Re: [dpdk-dev] [PATCH v3 25/26] event/dlb: remove version from device name

["McDaniel, Timothy" <timothy.mcdaniel@intel.com>]

> -----Original Message-----
> From: Jerin Jacob <jerinjacobk@gmail.com>
> Sent: Wednesday, April 14, 2021 2:32 PM
> To: McDaniel, Timothy <timothy.mcdaniel@intel.com>; David Marchand
> <david.marchand@redhat.com>; Ray Kinsella <mdr@ashroe.eu>
> Cc: dpdk-dev <dev@dpdk.org>; Carrillo, Erik G <erik.g.carrillo@intel.com>; Gage
> Eads <gage.eads@intel.com>; Van Haaren, Harry
> <harry.van.haaren@intel.com>; Jerin Jacob <jerinj@marvell.com>; Thomas
> Monjalon <thomas@monjalon.net>
> Subject: Re: [dpdk-dev] [PATCH v3 25/26] event/dlb: remove version from
> device name
> 
> On Wed, Apr 14, 2021 at 1:49 AM Timothy McDaniel
> <timothy.mcdaniel@intel.com> wrote:
> >
> > Updated eventdev device name to be dlb_event instead of
> > dlb2_event.  The new name will be used for all versions
> > of the DLB hardware. This change required corresponding changes
> > to the directory name that contains the PMD, as well
> > as the documentation files, build infrastructure, and PMD
> > specific APIs.
> >
> > Signed-off-by: Timothy McDaniel <timothy.mcdaniel@intel.com>
> 
> Please change the subject to "event/dlb: rename dlb2 driver", or so.
> 
> Also,See the below patch and change the abiignore to dlb2 now.
> 
> ------------------
> 
> commit 4113ddd45293d7b26ff4033bfd86cef03d29124f
> Author: Thomas Monjalon <thomas@monjalon.net>
> Date:   Tue Apr 13 10:29:37 2021 +0200
> 
>     devtools: skip removed DLB driver in ABI check
> 
>     The eventdev driver DLB was removed in DPDK 21.05,
>     breaking the ABI check.
>     The exception was agreed so we just need to skip this check.
> 
>     Note: complete removal of a driver cannot be ignored
>     in devtools/libabigail.abignore, so the script must be patched.
> 
>     Fixes: 698fa829415d ("event/dlb: remove driver")
> 
>     Reported-by: David Marchand <david.marchand@redhat.com>
>     Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>     Reviewed-by: David Marchand <david.marchand@redhat.com>
> 
> ---------------------
> 
> > ---
> >  MAINTAINERS                                   |  6 +-
> >  app/test/test_eventdev.c                      |  6 +-
> >  config/rte_config.h                           | 11 ++-
> >  doc/api/doxy-api-index.md                     |  2 +-
> >  doc/api/doxy-api.conf.in                      |  2 +-
> >  doc/guides/eventdevs/{dlb2.rst => dlb.rst}    | 88 +++++++++----------
> >  doc/guides/eventdevs/index.rst                |  2 +-
> >  doc/guides/rel_notes/release_21_05.rst        |  5 ++
> >  drivers/event/{dlb2 => dlb}/dlb2.c            | 25 +++---
> >  drivers/event/{dlb2 => dlb}/dlb2_iface.c      |  0
> >  drivers/event/{dlb2 => dlb}/dlb2_iface.h      |  0
> >  drivers/event/{dlb2 => dlb}/dlb2_inline_fns.h |  0
> >  drivers/event/{dlb2 => dlb}/dlb2_log.h        |  0
> >  drivers/event/{dlb2 => dlb}/dlb2_priv.h       |  7 +-
> >  drivers/event/{dlb2 => dlb}/dlb2_selftest.c   |  8 +-
> >  drivers/event/{dlb2 => dlb}/dlb2_user.h       |  0
> >  drivers/event/{dlb2 => dlb}/dlb2_xstats.c     |  0
> >  drivers/event/{dlb2 => dlb}/meson.build       |  4 +-
> >  .../{dlb2 => dlb}/pf/base/dlb2_hw_types.h     |  0
> >  .../event/{dlb2 => dlb}/pf/base/dlb2_osdep.h  |  0
> >  .../{dlb2 => dlb}/pf/base/dlb2_osdep_bitmap.h |  0
> >  .../{dlb2 => dlb}/pf/base/dlb2_osdep_list.h   |  0
> >  .../{dlb2 => dlb}/pf/base/dlb2_osdep_types.h  |  0
> >  .../event/{dlb2 => dlb}/pf/base/dlb2_regs.h   |  0
> >  .../{dlb2 => dlb}/pf/base/dlb2_resource.c     |  0
> >  .../{dlb2 => dlb}/pf/base/dlb2_resource.h     |  0
> >  drivers/event/{dlb2 => dlb}/pf/dlb2_main.c    |  0
> >  drivers/event/{dlb2 => dlb}/pf/dlb2_main.h    |  0
> >  drivers/event/{dlb2 => dlb}/pf/dlb2_pf.c      |  0
> >  .../rte_pmd_dlb2.c => dlb/rte_pmd_dlb.c}      |  6 +-
> >  .../rte_pmd_dlb2.h => dlb/rte_pmd_dlb.h}      | 12 +--
> >  drivers/event/{dlb2 => dlb}/version.map       |  2 +-
> >  drivers/event/meson.build                     |  2 +-
> >  33 files changed, 94 insertions(+), 94 deletions(-)
> >  rename doc/guides/eventdevs/{dlb2.rst => dlb.rst} (84%)
> >  rename drivers/event/{dlb2 => dlb}/dlb2.c (99%)
> >  rename drivers/event/{dlb2 => dlb}/dlb2_iface.c (100%)
> >  rename drivers/event/{dlb2 => dlb}/dlb2_iface.h (100%)
> >  rename drivers/event/{dlb2 => dlb}/dlb2_inline_fns.h (100%)
> >  rename drivers/event/{dlb2 => dlb}/dlb2_log.h (100%)
> >  rename drivers/event/{dlb2 => dlb}/dlb2_priv.h (99%)
> >  rename drivers/event/{dlb2 => dlb}/dlb2_selftest.c (99%)
> >  rename drivers/event/{dlb2 => dlb}/dlb2_user.h (100%)
> >  rename drivers/event/{dlb2 => dlb}/dlb2_xstats.c (100%)
> >  rename drivers/event/{dlb2 => dlb}/meson.build (89%)
> >  rename drivers/event/{dlb2 => dlb}/pf/base/dlb2_hw_types.h (100%)
> >  rename drivers/event/{dlb2 => dlb}/pf/base/dlb2_osdep.h (100%)
> >  rename drivers/event/{dlb2 => dlb}/pf/base/dlb2_osdep_bitmap.h (100%)
> >  rename drivers/event/{dlb2 => dlb}/pf/base/dlb2_osdep_list.h (100%)
> >  rename drivers/event/{dlb2 => dlb}/pf/base/dlb2_osdep_types.h (100%)
> >  rename drivers/event/{dlb2 => dlb}/pf/base/dlb2_regs.h (100%)
> >  rename drivers/event/{dlb2 => dlb}/pf/base/dlb2_resource.c (100%)
> >  rename drivers/event/{dlb2 => dlb}/pf/base/dlb2_resource.h (100%)
> >  rename drivers/event/{dlb2 => dlb}/pf/dlb2_main.c (100%)
> >  rename drivers/event/{dlb2 => dlb}/pf/dlb2_main.h (100%)
> >  rename drivers/event/{dlb2 => dlb}/pf/dlb2_pf.c (100%)
> >  rename drivers/event/{dlb2/rte_pmd_dlb2.c => dlb/rte_pmd_dlb.c} (88%)
> >  rename drivers/event/{dlb2/rte_pmd_dlb2.h => dlb/rte_pmd_dlb.h} (88%)
> >  rename drivers/event/{dlb2 => dlb}/version.map (60%)

Okay

Thanks,
Tim