From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DBA36A04C7; Mon, 14 Sep 2020 18:46:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 99CBFE07; Mon, 14 Sep 2020 18:46:10 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id E496E160 for ; Mon, 14 Sep 2020 18:46:08 +0200 (CEST) IronPort-SDR: J7BRp2bjQ9wO08GF4kXLv3Bn2gk7BAUK8ilagayaAnXzK3CSY2M46zGiTYUwg0OP9X/YzjaaWt PMf5DPv34Vhw== X-IronPort-AV: E=McAfee;i="6000,8403,9744"; a="138618404" X-IronPort-AV: E=Sophos;i="5.76,426,1592895600"; d="scan'208";a="138618404" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2020 09:46:05 -0700 IronPort-SDR: blBBdeFD7ycDDLC9W/yd2w3L+BZwkoN2AtHrrlGh1I9sywfN6xgGDlgW1gbWAa5bq85CdOdG9u nBILhy3DUjyw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,426,1592895600"; d="scan'208";a="506416006" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga006.fm.intel.com with ESMTP; 14 Sep 2020 09:46:04 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 14 Sep 2020 09:46:03 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 14 Sep 2020 09:46:03 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 14 Sep 2020 09:46:03 -0700 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (104.47.37.53) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Mon, 14 Sep 2020 09:46:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Xh39L+6NTIQ+gFRnNV2UBQqMU4vKuPB/yw+YtEnMBJvyiVnqRFfofU7To7bn3UPtu9fFyroJyFRg1oKAA8DGfMHJFyTT6knFXUrSQn+y4nb8XCstrvAPAHcGIhFNevPzcozCc8ACOsosOu4yfutoP9/LAvf1fhL3i54MqbCvMFhppTfBvYUl+owtmNYC3Yx8utfJuu/14dngPCERrZMTLuj5pFPRcDyiFOiukqp5sRRd/1YS6bl9Sa2dz77q0W9u0V54v7QcrTg1RWaUhdQyJ7K8ARJhRAP81dXuW6n8D+XZNRp6MefB+dIYczS5fsNAhDkDAdihZ/FXtH4coAZqJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cR9fKH6KH0nUABVXA3xfoHvC+48LipQW1ZjtIX0b3wM=; b=hdbgoU/1UdUdsIeKqj7igkedLFbJfcCU7W7xabQKrEtTaQN8zDpbvfJC6exji6D1IZYgxTnRC0IZnVeYsSXvkz+rp2LohqCuVpZf+wYcOiU6KPOz1GYAsT13QXMmwybHWy5IkRpqxmb2Gbtc4B6JOuwfxRfUZd9fT0RgT/la34mXVrmr1fGJlGjeLTyzLWAHnu9lUCEhXeYi1qhMgPKpqsWYBgrpGAzfUZ1YIvpAypUxGE4IqLEQe/RMtYxuMJsEUUaT3tdEWdTVzRyxvBh62Fs/QyUAb9GuPXMstM+8Tri0XAgtpRqXPEkykE2de/BQfOVtYRsIBFOc0FOeJhGZDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cR9fKH6KH0nUABVXA3xfoHvC+48LipQW1ZjtIX0b3wM=; b=V/lpbNmrqnsre+P7izBL+K0HO7G4IdU3Zffmkng6IjksFe0xSRhGM6TR0IkGr47s55tlp/nXIi0ZLzx6T10KdvRR35OypYJ8qy0090BgIVh6Hl7Qxwsr4H3PeZNbpSeU7OlpebbCN9LQkXeug/Bja5Sks+TYSO8n+7bagKYGVSk= Received: from SN6PR11MB3103.namprd11.prod.outlook.com (2603:10b6:805:d7::13) by SA0PR11MB4701.namprd11.prod.outlook.com (2603:10b6:806:9a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.16; Mon, 14 Sep 2020 16:45:56 +0000 Received: from SN6PR11MB3103.namprd11.prod.outlook.com ([fe80::dd10:fbd6:99e9:52f4]) by SN6PR11MB3103.namprd11.prod.outlook.com ([fe80::dd10:fbd6:99e9:52f4%4]) with mapi id 15.20.3370.019; Mon, 14 Sep 2020 16:45:56 +0000 From: "McDaniel, Timothy" To: "Ananyev, Konstantin" , "Richardson, Bruce" CC: "dev@dpdk.org" , "Carrillo, Erik G" , "Eads, Gage" , "Van Haaren, Harry" , "Ma, Liang J" , "Burakov, Anatoly" Thread-Topic: [PATCH] eal: add umonitor umwait to x86 cpuflags Thread-Index: AQHWiFjPYAN/tb1IKU6L3nVvuszz1aljonLAgAS3xfA= Date: Mon, 14 Sep 2020 16:45:56 +0000 Message-ID: References: <1599841589-9150-1-git-send-email-timothy.mcdaniel@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [162.251.9.49] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0dddf22b-8a06-4efd-c7d3-08d858cda6d9 x-ms-traffictypediagnostic: SA0PR11MB4701: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4502; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8RjwQwo2ZQj17+/K+fFmg2QgfR1xpu5P9WMjKN3y4vBmlVilHDESCywjg05FXo1JRUHnEWJP6kGQAbLD9Pcq+edVakuj+3lQUxThFEuAlfLB6OdyEL0wMO7TErafSc33DXHMSPvFOoiNiiVMDWMtvpL8t3pAdX8rS3ffukOffT7/up+AK9fl9RVGiJse+j4fA7HbgghFZJ+1gOW3d7pvA6P8GD12yaYh5Bc63xOp698SfSbsSgeEY0v5ncqhjg6pnBgCaLfljWBkpBsqWs+cG1imd8dO3dHe31PSAhgq7tdRcCwgthvFfvY7De0cuT3Fdd/33/8vY+m5v1wwBitAZ9npWYPkolEZgMfntejvsh7hTkNjSJvZxzdI4kz4CoM29H7VnqjceZWqZ0ey+6uSiQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3103.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(376002)(396003)(39860400002)(366004)(136003)(110136005)(6636002)(478600001)(86362001)(71200400001)(5660300002)(54906003)(66476007)(66946007)(83380400001)(66446008)(76116006)(66556008)(64756008)(33656002)(52536014)(7696005)(2906002)(26005)(53546011)(6506007)(316002)(186003)(55016002)(9686003)(8936002)(8676002)(4326008)(107886003)(966005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: JucsftBgjtQ7SdoLrQETyJWxIH5bsGrzsl3TxH74ae1ntRMTJeb7bvUs+/LPYsdBsrd+ckR0bfWncF2seoZaDEF6difPOLTCn1LvvNJLA++kKtBCv4gQKx2nLsAMVhYJ0tVXX8dBNTurin6byiecJ4mKEwzFiQIXdqh7BCmc76BaSZXB6AcMqutA2dFiLE1OM8g/2HmHT9ZE7r0DRcCwnTzOnIZD7+8HVnbdIp8t7tqrdQekR7eJ8MummZSsPszvOYjvZJZMMR501Thr+v1P8xVb34FP55q7ErM81cZwFOPKV0JRsm+yed3SoqcRJSVY8x6EcsJUAbXxRd4ZHDGChcM1CEG8PGM1QIo9d3C0ZMXxeVZreHNCVf3NT5sXOMPMyr8WtXf1eUnZ7nSYggfM0r+qG5lNYUZTqjGH3jNDTCGl8D2gNlZcZjgK67t9GRLtYHYoka36dpPUKDsx8psA2wARjwR4UzTrPJ6VMR1brcrB9TPkx7scN3jtBMIvzhyD5Ruashdxn0LwKGo+9tyBTCKwutkT/OQI16Qk9yN/xgiX1sHQ4WpFEG728u/EfZaUG7q/h6VHCa2dB3Eo0YVaxiRcAAWONUaufACUMhtPt5zBHBtgkrmgC7WQiV6GX7DfC1b83ygz7JPFpV/PXNoYsQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3103.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0dddf22b-8a06-4efd-c7d3-08d858cda6d9 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Sep 2020 16:45:56.1726 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eMRk5mO4o3dfYP3Vd4nv1V/wXj8Iclyu2IRRA+eEKJ6DxHZhX2/rWCN1+w6UISDx+xVjUp8FAbtVG/shO2OStuS7QiFIzsVFr0ZiJY2ASxo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4701 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] eal: add umonitor umwait to x86 cpuflags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Ananyev, Konstantin > Sent: Friday, September 11, 2020 11:37 AM > To: McDaniel, Timothy ; Richardson, Bruce > > Cc: dev@dpdk.org; Carrillo, Erik G ; Eads, Gag= e > ; Van Haaren, Harry ; > Ma, Liang J ; Burakov, Anatoly > > Subject: RE: [PATCH] eal: add umonitor umwait to x86 cpuflags >=20 >=20 > > > > umonitor/umwait are user-level versions of the monitor/mwait > > instructions. These allow the core to wait in a low-power state > > until a specified cache line is accessed, a timeout occurs, > > or the core is interrupted. >=20 > Isn't it a duplicate to: > https://patches.dpdk.org/patch/76554/ > ? Yes, the new rte_cpuflags.[ch] bit definitions for umonitor/umwait appear t= o be duplicates. I am not opposed to dropping my patch, so long as this new bit gets defined in some other patch= that makes it into 20.11. >=20 > > > > Signed-off-by: Timothy McDaniel > > --- > > lib/librte_eal/x86/include/rte_cpuflags.h | 1 + > > lib/librte_eal/x86/rte_cpuflags.c | 1 + > > 2 files changed, 2 insertions(+) > > > > diff --git a/lib/librte_eal/x86/include/rte_cpuflags.h > b/lib/librte_eal/x86/include/rte_cpuflags.h > > index c1d2036..ab2c3b3 100644 > > --- a/lib/librte_eal/x86/include/rte_cpuflags.h > > +++ b/lib/librte_eal/x86/include/rte_cpuflags.h > > @@ -130,6 +130,7 @@ enum rte_cpu_flag_t { > > RTE_CPUFLAG_CLDEMOTE, /**< Cache Line Demote */ > > RTE_CPUFLAG_MOVDIRI, /**< Direct Store Instructions */ > > RTE_CPUFLAG_MOVDIR64B, /**< Direct Store Instructions 64= B > */ > > + RTE_CPUFLAG_UMWAIT, /**< UMONITOR/UMWAIT */ > > RTE_CPUFLAG_AVX512VP2INTERSECT, /**< AVX512 Two Register > Intersection */ > > > > /* The last item */ > > diff --git a/lib/librte_eal/x86/rte_cpuflags.c b/lib/librte_eal/x86/rte= _cpuflags.c > > index 30439e7..6bed3eb 100644 > > --- a/lib/librte_eal/x86/rte_cpuflags.c > > +++ b/lib/librte_eal/x86/rte_cpuflags.c > > @@ -137,6 +137,7 @@ const struct feature_entry rte_cpu_feature_table[] = =3D { > > FEAT_DEF(CLDEMOTE, 0x00000007, 0, RTE_REG_ECX, 25) > > FEAT_DEF(MOVDIRI, 0x00000007, 0, RTE_REG_ECX, 27) > > FEAT_DEF(MOVDIR64B, 0x00000007, 0, RTE_REG_ECX, 28) > > + FEAT_DEF(UMWAIT, 0x00000007, 0, RTE_REG_ECX, 5) > > FEAT_DEF(AVX512VP2INTERSECT, 0x00000007, 0, RTE_REG_EDX, 8) > > }; > > > > -- > > 2.6.4