From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8DAA4A0C40; Fri, 26 Mar 2021 17:38:01 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 75BDB140D9C; Fri, 26 Mar 2021 17:38:01 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 6919F140D56 for ; Fri, 26 Mar 2021 17:37:59 +0100 (CET) IronPort-SDR: btkKaetvOCDa4g6vQmEL04j/q3Rs+357yE1MAyEQ/7UDUTEPK+c1DTRTa6GWS+5jjG/7IdRI0K vS/yt+Hy+zVQ== X-IronPort-AV: E=McAfee;i="6000,8403,9935"; a="187895658" X-IronPort-AV: E=Sophos;i="5.81,281,1610438400"; d="scan'208";a="187895658" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2021 09:37:58 -0700 IronPort-SDR: vXbBj+eN/sdsi5uRspy/Alk9GGvHnGzadpGX6H1sK2rW0omiu46VUbzSUJaEj+fgeDPdoRhpiv HFt/UOXBxTmw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,281,1610438400"; d="scan'208";a="443873584" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by FMSMGA003.fm.intel.com with ESMTP; 26 Mar 2021 09:37:58 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Fri, 26 Mar 2021 09:37:57 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Fri, 26 Mar 2021 09:37:57 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Fri, 26 Mar 2021 09:37:57 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.43) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Fri, 26 Mar 2021 09:37:57 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YbBLDQViPDNA4snOys4SOuK7Y4g3V2tl43/aqUuWP2xp8v4GHxQslMha1dta24PLrCMWZ3tmrsPTRAFwe3PjvYHSaE2UNc8LDz3NrDbeVzC2oZcb9EmXXqUpTxP9L38WLf+VObVpjzrdSM4VrzN+cWqFX+eIjqUW5Kgcn66BBrzcQHi3S1j84hWwFHK3uDABHTxUUREcFnmG/ahbWIN83grBX4/fTQPhJNvkIrAk1fHm9Z4d5RnguAw6UkJ1b3tVoHsXuNct5kGARqHhM7/GZSSfL6fx24EbO22RWE8p2/P82LGNCTR5fpez2p1KztTcfFgBRHHa210iPq7kCR+uHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yxBLokhtwNQn3+HhVik9GhfhVikUuInGVcbplePqc0E=; b=R2rb7qLtiGRMS5wGkpJMnluKTTRlkEXoEuOlH5W2QzGE7Ybbi/DPSscsQnVVqGLnYwAFzSMkXXFL+4tR3RWweGOgDjZa40ZDGf45YOI9m5M4iPD5BtKFW8rKF2bFVEj4t0UuB6FRwVzsLubmZw5Wx83ThUVaV3OoGjhhpTpVQ5wekMtEtrjcypRbwWxohPtYr/u3UibzQe9ZXjSVROFi7GShNvHrDnyoeJgtwbTsb+OFbPIXQPIxatHaZdvJzbweSIC+trdQyCpa+0Lpsf2PWK56sC28Tz+mLpGTz8uB+0x++1mJIK3Qxb5+4Pb8ORIcHRQFxKk1jH0aQ/L+BsPyIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yxBLokhtwNQn3+HhVik9GhfhVikUuInGVcbplePqc0E=; b=PMsqVYFA8ACcL0PdtpmaX00eGK8wa+DtONGM2AO57ECBxGpXAVV2ZWmPQD52xSGKmFaik9ibwi3wB9bAfOV3Pn4VNoiksqJl7eh7MTW8Cuw10Vd45lUPS4JHCfQrBDvQkNjsFZQzZhinO74n00HJ92kXgYYSd4zPd5lOBsEyhMQ= Received: from SN6PR11MB3103.namprd11.prod.outlook.com (2603:10b6:805:d7::13) by SN6PR11MB3488.namprd11.prod.outlook.com (2603:10b6:805:b8::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18; Fri, 26 Mar 2021 16:37:56 +0000 Received: from SN6PR11MB3103.namprd11.prod.outlook.com ([fe80::c9c2:8157:5bef:9b2]) by SN6PR11MB3103.namprd11.prod.outlook.com ([fe80::c9c2:8157:5bef:9b2%6]) with mapi id 15.20.3977.030; Fri, 26 Mar 2021 16:37:56 +0000 From: "McDaniel, Timothy" To: Jerin Jacob Kollanukkaran , "dev@dpdk.org" CC: "Van Haaren, Harry" , "mdr@ashroe.eu" , "nhorman@tuxdriver.com" , "Rao, Nikhil" , "Carrillo, Erik G" , "Gujjar, Abhinandan S" , Pavan Nikhilesh Bhagavatula , "hemant.agrawal@nxp.com" , mattias.ronnblom , "Mccarthy, Peter" Thread-Topic: [EXT] [PATCH 02/25] event/dlb2: add DLB v2.5 probe-time hardware init Thread-Index: AQHXGrKDVa+o/7Lr4E2bu4Hj9S22rKqOQhpQgAhE95A= Date: Fri, 26 Mar 2021 16:37:55 +0000 Message-ID: References: <20210316221857.2254-1-timothy.mcdaniel@intel.com> <20210316221857.2254-3-timothy.mcdaniel@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [162.251.9.49] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 672a96e3-aa0e-49c1-9acc-08d8f0758244 x-ms-traffictypediagnostic: SN6PR11MB3488: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:854; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: FZ+GqZZO0OznuK9WuQeDRvX09g21k2ulHm5IhEQS2kVl77K6FNVSAqUU84X+AejZ36zQb7Ad4YxaY0soklW5eG3opo1718J6lGQ8UyQPW7EDtCXNBDBTrVQVEDLNGeECMuvVvweO/Yad2FNUPtuXioQaRXlFOK7CVHwK2ti0C5eSe9+JJDt5xCC1sOpOVTpg0rTCkprIrJiQ3Y3qiUWDj7Nogh7/2HhGH7y97NkhRwqkNpP1MY+jfWdQkvAkhw9xONGNQBc0daFoOTSPo9BMWL9tmB9tVIAGmRl8KRdkPqDSysKxUC1qARU9cfP4ODIYNb3e6exD2FTd1DSwfPl0x3UMzivrROt0rd5MGjIE8UGcLpngRX8b+RTUtBVtH/YXXpSyXbR6oRam76Nybnfen1mvPVdsVL+0iO2bbuwQF5Yek3UzscZgb3adg2u9KSKbtooST+a2Km/0c/yhV40gAQ1aysD8Kkj2xVfNbxCAN/0pdONZIMCJGvVNIr38hOkiKrqITaX8RIBTpA6SvD0zH2AysA++SYGCPVZhY44FXTcwOVC1pGnVffRlyhVA1CRhH9DCHANwWZTXEzx7RhPrNe1XiENNNypnINbWbNZ4Pb3OkR5NdvQKr2wWSdv4MWF8sxf4Swp69vkhnU0fAf0DQTJFyrtIJV8KjATT9Vmt2XQ= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3103.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(376002)(366004)(136003)(396003)(39860400002)(346002)(83380400001)(53546011)(6506007)(110136005)(8936002)(54906003)(38100700001)(186003)(33656002)(55016002)(52536014)(316002)(7696005)(66946007)(107886003)(76116006)(64756008)(9686003)(5660300002)(71200400001)(26005)(66476007)(66556008)(2906002)(86362001)(8676002)(4326008)(66446008)(478600001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?seFTVrD2gIWumg7IknRQmT1MS/iF53kwNIq6j9FAUJ/rxYACOfWi9t/x+PJi?= =?us-ascii?Q?/SprJc+/wgUWg1ZbiCtEXKp6NuW6Xy+tFUjh+vFIrJePmEYnecOoPyVotvFm?= =?us-ascii?Q?FIBgMY7xRVV3eov1DIAjjsjvG2ZwIKD5axQ++dz00MAQ5hG2Ap76pg1y25aA?= =?us-ascii?Q?D/w/p9ECsur9qKSLIsFlN6s81suLfP5HHJcRU4ruDeeLvd5KPU9DcoHEmc0x?= =?us-ascii?Q?3KPBB4VvivuGsgt43Z+nH13ChWy8tV+p5GSWeNhCgdOqV67v1rGhvSkNubGN?= =?us-ascii?Q?hX44p4rhHs+ee4yWERh4jV715/M6lBaw5yW0pdyxlc0FTQabfJvZO9QFGyFa?= =?us-ascii?Q?kFPb7vakE18n5fJ41FdeUC0QqCFOgM7NJa5xyXXDC/Lj/s9hVEnZT81IdZUK?= =?us-ascii?Q?0A4RreHkwEsXWooNBYIT6zEcU286DecC57fPSTSINkGCk52HYyjCzAPVRa8b?= =?us-ascii?Q?OO+BRzpHlOM95mRszkiKiHFjWoOn1xcMY7fOOeJSGt/L4QM+/BOYOjdGe/KA?= =?us-ascii?Q?84Hkrz0WFyUDI7+MY3rXcPJSpeYqBza5O82YIzIKk81wO3iP7Ehj4DywZ4zj?= =?us-ascii?Q?3QvLnovDxENVEmj70+eas5BC4ri6k5M2JbEIJKSsS2aERT4iEdi4Vh+3fp5j?= =?us-ascii?Q?m59wON5YqUxSgr7yzVwXLg+91p/+xkFrb1GZjqBOV7g2cLKmN2r5/TB95rp9?= =?us-ascii?Q?QOCMnHaE5vqohnFYQfqLOSn1f+Y15yhylPKnNU4Cks1IA8VWR9k2kMajRASI?= =?us-ascii?Q?hKLwGTpYw/k0qSRiF99rixtxHpZYuFwrpJXFAdSAvS4aDxV3aIBeaGi2sOVX?= =?us-ascii?Q?CcK3xeQdrauKPd8yKXycXoRS+BKXrYUIc4288GZ0BDuUMfayU/QAWeCnPA4K?= =?us-ascii?Q?GRmr8iCJfFCwoowgUndd8V8aZIDvrp3jIXhwM+raqzLWHgEfNfmw6rpn9/3d?= =?us-ascii?Q?lr9yFYohDmzfWeeUEyVLFDjV0VFlLjOWidIyY0H4Hhe0itB+JDYI+Rw7NGu6?= =?us-ascii?Q?U6Zzfi3/VMF8unWJ6iTs2do7eOiU80HNFPamVBwf7UxDKUAIOQk5S28AX+Ii?= =?us-ascii?Q?ZGy/NzKSwACAdm4ECP0Fec2ifsy2B66VtYDQCxci+MjeC0BVE1zpgZV+kSYm?= =?us-ascii?Q?yDZgOHMi/WRdtjIAvWqUiyn/0hqUGDil4Zz4F5PPcjuf2n/VFVRu5BrWrQfc?= =?us-ascii?Q?i2B4pbx+LUNPOFfpAzNw+uIKHgZEfnqez5BXBLEguuN63e+YIQbA/bHEB6NJ?= =?us-ascii?Q?O17V5zdimt0VixS1QjVqnHe4E9Id7OxyypqGAeTtOj015qnJCD2NzPzVSBHP?= =?us-ascii?Q?UiP10mXiQm/f6SMay/YgkrrI?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3103.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 672a96e3-aa0e-49c1-9acc-08d8f0758244 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Mar 2021 16:37:55.9279 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: N39cewHlhPtUvshpMA5dSLiCTS7e4ZVxbZGLRM338sSvu87bZzO/gZ0hLAl25TSsbdQMblrBExmOcYWTIBbGmPVIXhny4IbZS8mA8Kr6fF4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3488 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [EXT] [PATCH 02/25] event/dlb2: add DLB v2.5 probe-time hardware init X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Jerin Jacob Kollanukkaran > Sent: Sunday, March 21, 2021 5:30 AM > To: McDaniel, Timothy ; dev@dpdk.org > Cc: Van Haaren, Harry ; mdr@ashroe.eu; > nhorman@tuxdriver.com; Rao, Nikhil ; Carrillo, Erik= G > ; Gujjar, Abhinandan S > ; Pavan Nikhilesh Bhagavatula > ; hemant.agrawal@nxp.com; mattias.ronnblom > ; Mccarthy, Peter > > Subject: RE: [EXT] [PATCH 02/25] event/dlb2: add DLB v2.5 probe-time hard= ware > init >=20 > > -----Original Message----- > > From: Timothy McDaniel > > Sent: Wednesday, March 17, 2021 3:49 AM > > To: dev@dpdk.org > > Cc: Jerin Jacob Kollanukkaran ; > > harry.van.haaren@intel.com; mdr@ashroe.eu; nhorman@tuxdriver.com; > > nikhil.rao@intel.com; erik.g.carrillo@intel.com; abhinandan.gujjar@inte= l.com; > > Pavan Nikhilesh Bhagavatula ; > > hemant.agrawal@nxp.com; mattias.ronnblom@ericsson.com; > > peter.mccarthy@intel.com > > Subject: [EXT] [PATCH 02/25] event/dlb2: add DLB v2.5 probe-time hardwa= re > > init >=20 >=20 > Please simplify subject in all the patches like > event/dlb2: add v2.5 HW init >=20 Will do >=20 > > ---------------------------------------------------------------------- > > This commit adds support for DLB v2.5 probe-time hardware init, > > and sets up a framework for incorporating the remaining > > changes required to support DLB v2.5. > > > > DLB v2.0 and DLB v2.5 are similar in many respects, but their > > register offsets and definitions are different. As a result of these, > > differences, the low level hardware functions must take the devicei >=20 >=20 > s/devicei/device >=20 fixed=20 > > version into consideration. This requires that the hardware version be > > passed to many of the low level functions, so that the PMD can > > take the appropriate action based on the device version. > > > > To ease the transition and keep the individual patches small, three > > temporary files are added in this commit. These files have "new" > > in their names. The files with "new" contain changes specific to a > > consolidated PMD that supports both DLB v2.0 and DLB 2.5. Their sister > > files of the same name (minus "new") contain the old DLB v2.0 specific > > code. The intent is to remove code from the original files as that code > > is ported to the combined DLB 2.0/2.5 PMD model and added to the "new" > > files in a series of commits. At end of the patch series, the old files > > will be empty and the "new" files will have the logic needed > > to implement a single PMD that supports both DLB v2.0 and DLB v2.5. > > At that time, the original DLB v2.0 specific files will be deleted, > > and the "new" files will be renamed and replace them. > > > > Signed-off-by: Timothy McDaniel > > --- > > drivers/event/dlb2/dlb2_priv.h | 5 + > > drivers/event/dlb2/meson.build | 1 + > > .../event/dlb2/pf/base/dlb2_hw_types_new.h | 362 ++ > > drivers/event/dlb2/pf/base/dlb2_mbox.h | 1 - > > drivers/event/dlb2/pf/base/dlb2_osdep.h | 4 + > > drivers/event/dlb2/pf/base/dlb2_regs_new.h | 4412 +++++++++++++++++ > > drivers/event/dlb2/pf/base/dlb2_resource.c | 180 +- > > drivers/event/dlb2/pf/base/dlb2_resource.h | 36 - > > .../event/dlb2/pf/base/dlb2_resource_new.c | 271 + > > .../event/dlb2/pf/base/dlb2_resource_new.h | 73 + > > drivers/event/dlb2/pf/dlb2_main.c | 41 +- > > drivers/event/dlb2/pf/dlb2_main.h | 4 + > > drivers/event/dlb2/pf/dlb2_pf.c | 6 +- > > 13 files changed, 5165 insertions(+), 231 deletions(-) > > create mode 100644 drivers/event/dlb2/pf/base/dlb2_hw_types_new.h > > create mode 100644 drivers/event/dlb2/pf/base/dlb2_regs_new.h > > create mode 100644 drivers/event/dlb2/pf/base/dlb2_resource_new.c > > create mode 100644 drivers/event/dlb2/pf/base/dlb2_resource_new.h > > > > +#ifdef FPGA >=20 > Don't do this. Either detect the FPGA presence or make it devargs >=20 > > +#define DLB2_HZ 2000000 > > +#else > > +#define DLB2_HZ 800000000 > > +#endif > > + > > + > > +/* TEMPORARY inclusion of both headers for merge */ >=20 fixed >=20 > Please make sure to remove this comments in sub sequent patches. >=20 will do > > b/drivers/event/dlb2/pf/dlb2_main.h > > index f3bee71fb..01a24e8a4 100644 > > --- a/drivers/event/dlb2/pf/dlb2_main.h > > +++ b/drivers/event/dlb2/pf/dlb2_main.h > > @@ -15,7 +15,11 @@ > > #define PAGE_SIZE (sysconf(_SC_PAGESIZE)) >=20 > Please use DPDK APIs for this. >=20 done > > #endif