From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B351AA04E7; Sun, 1 Nov 2020 21:52:12 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 646362B9D; Sun, 1 Nov 2020 21:52:11 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id D45C12986 for ; Sun, 1 Nov 2020 21:52:07 +0100 (CET) IronPort-SDR: uT1Kby81t+3rwg+9JXYZ7L2wvUkHmGunSqK5ahmBAyP7VsadfxoNZ0r46gsM8L7E1q6zseYyKi 7b3qHCfwTzRA== X-IronPort-AV: E=McAfee;i="6000,8403,9792"; a="148091920" X-IronPort-AV: E=Sophos;i="5.77,442,1596524400"; d="scan'208";a="148091920" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2020 12:52:05 -0800 IronPort-SDR: um6wIWnvA9fkEfpsgi6SCcenRDB8SLoHHPWiWA5wD/77TCC+MEC9vfMk/mP6WvycRoHCykKauB NUOLdJwmAKBQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,442,1596524400"; d="scan'208";a="324656852" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga006.jf.intel.com with ESMTP; 01 Nov 2020 12:52:05 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sun, 1 Nov 2020 12:52:05 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sun, 1 Nov 2020 12:52:04 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Sun, 1 Nov 2020 12:52:04 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.105) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Sun, 1 Nov 2020 12:52:04 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q111zI/RIRWSpJHTvo7auz2+F4hJl5ruci8wp/JvmXrY7ugcsIu2hkTwrq9Q563D1CpUJ05kUMAHQzpq3nNAqPK/NfckW0FsxDW1X6mwuqU85+CemKeAXVmUyQlj9V/Zqy8bx00LKm/zK9kquGI3t07rnLCD/8eU7y6JzwKP7i3RgTYcpRnUXNQoLkPPY0BMPUgAmDC1w0KeL2Hl6SGMdexHj4QqsbZ97e3RKorsRyOSOva9St/k495ed7R6eZ1FD8N6nt+iLiKw0W2i2OHCnvQRcInsx6M//nuShPuIv+jEE+R9UJnHy9QQf6nLOHe3iF+4A6n+mxmhEplGmV8AKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=adK2D9tFKDhqugh+gdOUXXQB5xV0xQRIxCgF/mi5jDg=; b=SSVt4uPPEhtYE2MnF4FMLepqSCo1Ui+diJoXT46/MuswG1gUFEZLqqFNaHFKK8YitWt3Nj21KZqQpNmQHeS2Jewl9DvhuySO3nqwtfsyDMfs3KeacBHotAkrppF6Cm7VSfY/qy6XOt1jD0GJFL4yjgK8w8KQw7WX3LjLQt1a78zdWOJtBR5gS/JbSw8YkCnzX6L+haxDbuci2UzBe5I2+sO9ogwkFtvDqU+dT2nqd5YjWVgPb0KTH61A9wtH1SSj54Zi+qdevC/wF1C8VtVfiq0ioJKrAGbCAg0y7nzGw6X8HaIGPHRPXxldMdIDGKQTzYHAFQuGfhMobDMUa42Fig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=adK2D9tFKDhqugh+gdOUXXQB5xV0xQRIxCgF/mi5jDg=; b=zggV4fEEKrvwq5oFilMS3S8S4P3kHa0DhJADRhFUtULwKmuHHQuj6Wq2jKOt/gW/B4kBDh+1kC9gXbxoGZ63yU9kQKCdudGw/TW0AenIxk4BQonzIOtqUyzzj6DUamXJTRlXXyeYtvZR3GQhWGjWvSM9FxMK+pM+fk+b0Gnu4nQ= Received: from SN6PR11MB3103.namprd11.prod.outlook.com (2603:10b6:805:d7::13) by SA2PR11MB4874.namprd11.prod.outlook.com (2603:10b6:806:f9::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.27; Sun, 1 Nov 2020 20:52:03 +0000 Received: from SN6PR11MB3103.namprd11.prod.outlook.com ([fe80::e43b:59bb:161:8349]) by SN6PR11MB3103.namprd11.prod.outlook.com ([fe80::e43b:59bb:161:8349%3]) with mapi id 15.20.3499.029; Sun, 1 Nov 2020 20:52:03 +0000 From: "McDaniel, Timothy" To: David Marchand , "dev@dpdk.org" CC: Jerin Jacob Thread-Topic: [PATCH] eventdev: check input parameter for dump op Thread-Index: AQHWsI7tPUa+gwDgUEOJWNdl7O+5S6mzwEzw Date: Sun, 1 Nov 2020 20:52:03 +0000 Message-ID: References: <20201101203644.1697-1-david.marchand@redhat.com> In-Reply-To: <20201101203644.1697-1-david.marchand@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [162.251.9.49] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a4add203-b439-4eb0-121c-08d87ea7fcd1 x-ms-traffictypediagnostic: SA2PR11MB4874: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3826; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: goOnuhK+HdxtTnHsXiUcN6zwDdXM+vzzetD1hXCw85go/P3JQlwlO9Ge5gy/xLCceuP0LVSm/sZSjWCL7WS3DLGSJB1YUgbo5Ufo/wAcUnvBfTUPvB2cxl44BZ2YSTxACskLk/2ALHqll+RHlT8PYfJ/glmNL8WUeUOOkAO6aGpSI/6eChCxy1H/LY5wmhKrNqOaIqRI4BtHIokEsit9plMyj9Nc5ukbz6MFycgyLZH119ykiD7+twZFxp1OzJ31AIBZiJV8Ym7KJBlaA9Ws0688xON9Yy1l1+srNzrM3kTb9O2rjOcxV9HGKwTqYF51XeUUhS/UFLPPKOJluXrrng== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3103.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(366004)(346002)(136003)(376002)(39860400002)(9686003)(186003)(8936002)(5660300002)(83380400001)(26005)(55016002)(8676002)(4326008)(86362001)(53546011)(76116006)(316002)(2906002)(6506007)(52536014)(66946007)(110136005)(33656002)(64756008)(66556008)(66476007)(66446008)(478600001)(7696005)(71200400001)(4744005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: sorEo3mixVk9C4l7zMKe62omHp0hZvhS78M0Kj9spObBnyTcjOsQC/nUrsReBjvwuZFr7lZ5CH8FU07lrU4jK2cq6CNCnjE1H2Mw0yCjkzO4A7AQ5nraFK/3Qj0mwmxC99lJWwyhh6rWk/O90MtXqxtpuBAAh4TW40IkXCJiGX/EmGdHLAwBceJ64lqCjo7SpIw0RAh/uWGQXLmykcY2r8oyW+mEeRemPxmN3jwrSR8djCc+XCOHn6oyP0YAI6ASrOBYndPeptXGk7FEcD9fxGsx4o7WZqU6U/rI+g5c1A7QlQ/atqFOhDCVoyfbwMtXT4HNyxXyRi+mo5r1M1kRh6Oc2Cpg8a8hESp7ZJS98/EW9klzKnprHx34AUeVYF4ciHG+7lrAZRwKmwYUi6o3wq7ijZgyul8h/wgF+ANlcyfaT4yHrDj1zQ88RpWp/7NTfiXYCnY922eScoWf8wwC+C/GY95h6yEBZsMlO3lF0Ot+Hq7zWMIIFPFkPaJYdo30voE/Y/Pi3+XrRXaYsyMoNUgWaoeiJcImcwPGsa1gDFz9SeKUKap2dXzfcZ6W8hH6abJ45jO/AsgQHnD7Y1N80G+kULH96tCH53wlPjKgEXeeUJcB97i5od86UINXnwvReY2ANGIdKJPuPIv2pIWOIw== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3103.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a4add203-b439-4eb0-121c-08d87ea7fcd1 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Nov 2020 20:52:03.7704 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: UmWB2Ep8eNcB6bYUwLGoo2N48WTVXQnMEdIzNarFQFdfjfhcvYc356MFlwK6Vr+fCAp7cHGwLfrBam8zs9MZMQC9XVuRnMOm1Il606eYZ9c= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4874 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] eventdev: check input parameter for dump op X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: David Marchand > Sent: Sunday, November 1, 2020 2:37 PM > To: dev@dpdk.org > Cc: McDaniel, Timothy ; Jerin Jacob > > Subject: [PATCH] eventdev: check input parameter for dump op >=20 > Rather than have drivers check for this, let's ensure the passed FILE * > is not NULL. >=20 > Signed-off-by: David Marchand > --- > lib/librte_eventdev/rte_eventdev.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/lib/librte_eventdev/rte_eventdev.c > b/lib/librte_eventdev/rte_eventdev.c > index 994bd1eaa9..afbadc535b 100644 > --- a/lib/librte_eventdev/rte_eventdev.c > +++ b/lib/librte_eventdev/rte_eventdev.c > @@ -1153,6 +1153,8 @@ rte_event_dev_dump(uint8_t dev_id, FILE *f) > RTE_EVENTDEV_VALID_DEVID_OR_ERR_RET(dev_id, -EINVAL); > dev =3D &rte_eventdevs[dev_id]; > RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dump, -ENOTSUP); > + if (f =3D=3D NULL) > + return -EINVAL; >=20 > (*dev->dev_ops->dump)(dev, f); > return 0; > -- > 2.23.0 Looks good to me. Reviewed-by: Timothy McDaniel