From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C7884A04DD; Wed, 21 Oct 2020 18:33:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3DCA2A9A2; Wed, 21 Oct 2020 18:33:39 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 37A63A9A1 for ; Wed, 21 Oct 2020 18:33:38 +0200 (CEST) IronPort-SDR: laEKSPq7SaoOAH60BBfmYtvHBBKPhIMUJU56YSVpsuMtr72kKBj36iYmZaDKnoKFZ+/qn6aptb 3ZsCdgBbhMog== X-IronPort-AV: E=McAfee;i="6000,8403,9780"; a="167487969" X-IronPort-AV: E=Sophos;i="5.77,401,1596524400"; d="scan'208";a="167487969" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Oct 2020 09:33:36 -0700 IronPort-SDR: RCg7a02OkU16YlMfCMmpa0T/JfF9CslYbt9VUgBd7U2n00iTRro5x6AUwnhE5DEHZ8bdrha83j O8zN44kln88Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,401,1596524400"; d="scan'208";a="466356196" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga004.jf.intel.com with ESMTP; 21 Oct 2020 09:33:36 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 21 Oct 2020 09:33:35 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 21 Oct 2020 09:33:35 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 21 Oct 2020 09:33:35 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.105) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Wed, 21 Oct 2020 09:33:34 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V5luuVx7YzhIWwI3WmmRl5LIhfUzUzQmPwsfIr3HilIvOtYojxo3XFw8STRbCNExRJLJHpTQy8EMMb7RpvTQxxEcHYh8XSgEC72MaRiA4B4cCyVlPCgUyFS1S9kaTT+6C9LZc18kD/zmSpQHc+xbQNLyHna0KqsSOIwYpgzA2WFNKpSprEBl5r512HonUjMndBhe/m7NUpuuaLsKoXwXgQVA4qqdDKU4eG3RYsT54LRE7x/fQuolr+Wj0SWJy/K3FWYkGqDInrA9gqwZ3fcMMDDsVjGoF33B0G3PMHi7s6BU+j3KjRkdqVUtXlfGqIIfhtwg2YY1jK4Tnr8xfiF3vA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BcJ1G2fGAjOeha7mwv2X7lKB9nvRVZ7DhJmEWDhLgKY=; b=P3AAWo1mxY5fBu+x6DJg6AftUbnbm8kFltdjkENoB2jXd/RcVZ//E5y+BMW5mzqGrFNy6vvTCKqBDwBIHGS0R0A9SYth0dgYtreuT8v8rrkPS4814sCvhEMnunAq2InHjXs+JXQl21IQKX71oMk/jeX0mRc/7ICs0+eogms9hmeYPVGtJBb4NJC28vp3Sh/iaIGcyUcOUqFvX4r8vb59OLDC6fK609DNzvAxjnT+nS+/fA/iXYpN3pyLBSTJZvp6brPliYRNyULacwf3Q1rW0XS+9A7ANGmNOB0e2RTNB1/8oc47atQf6plFVwR1e9+pNumrFcXDFJpJhTd+PhnMYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BcJ1G2fGAjOeha7mwv2X7lKB9nvRVZ7DhJmEWDhLgKY=; b=ouRuweGujqP4o+BQvs2sS3b66s6dDuOIJkkqoQteg4KXaFURcfcNXRWCmxAWkxgZX0P4XnfVXIa6cCko2E4H2ZiDO7ZjbDCor02JrfhJOOKzXx3hIZGt18Ar6IjP/oFUMOccDSvFPnOcFQxHVjZilMc+zTgiXe5w8iMqvuhW1SQ= Received: from SN6PR11MB3103.namprd11.prod.outlook.com (2603:10b6:805:d7::13) by SA2PR11MB4924.namprd11.prod.outlook.com (2603:10b6:806:113::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18; Wed, 21 Oct 2020 16:33:30 +0000 Received: from SN6PR11MB3103.namprd11.prod.outlook.com ([fe80::41fb:70e6:6102:a616]) by SN6PR11MB3103.namprd11.prod.outlook.com ([fe80::41fb:70e6:6102:a616%7]) with mapi id 15.20.3477.028; Wed, 21 Oct 2020 16:33:30 +0000 From: "McDaniel, Timothy" To: "Richardson, Bruce" , Jerin Jacob CC: "Mcnamara, John" , "Kovacevic, Marko" , Ray Kinsella , Neil Horman , dpdk-dev , "Carrillo, Erik G" , "Eads, Gage" , "Van Haaren, Harry" , Jerin Jacob , "Thomas Monjalon" Thread-Topic: [dpdk-dev] [PATCH v2 01/22] event/dlb2: add documentation and meson build infrastructure Thread-Index: AQHWpSuei/E6j1Yiyk6N717ECjYmz6memryAgAOqeVA= Date: Wed, 21 Oct 2020 16:33:30 +0000 Message-ID: References: <1599855987-25976-2-git-send-email-timothy.mcdaniel@intel.com> <1602958879-8558-1-git-send-email-timothy.mcdaniel@intel.com> <1602958879-8558-2-git-send-email-timothy.mcdaniel@intel.com> <20201019083337.GA649@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20201019083337.GA649@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [162.251.9.49] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e7239443-8410-4aa0-7985-08d875df0bb4 x-ms-traffictypediagnostic: SA2PR11MB4924: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: h0I5BgLE+Z/GQ4VbPLI1pYkNLDDs1TsY1l6LTox2MyIcuWCxgmxq0WpcAv6uG/zTQXCrWwnOO3XgGs3wS7DvfGqvFEZBIhme26+8WilhrnB4zj80zUGxIKv8uYuDiXIt2CiXRmkyBLY9BIRlV0v5S41kU3rdWSypYk6tV/IfHSuvbWOt4Nv49m3S/Qn2JkRREsaEAXnukLtPb3PWdyRHRXLJ//GFvO19Eu3qBPQLgZTeuSTLUZhjJb6atFEOYWNR36sHYV3DiT7YstrK/I1TNj94jiEuAAImLaRnI7ONoLhXb2WE9BieDoWslWwAYO5L x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3103.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(396003)(366004)(136003)(39860400002)(376002)(4326008)(53546011)(2906002)(86362001)(64756008)(66556008)(66446008)(55016002)(66946007)(7696005)(66476007)(6506007)(76116006)(110136005)(5660300002)(26005)(83380400001)(9686003)(316002)(54906003)(478600001)(8936002)(8676002)(52536014)(71200400001)(33656002)(186003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: TV/v4skNHYKmiy9BzqCHZAvpRsheMga5KIp5pZY2y1ZuDtLqiTYaapkpX1Q+Qx1vOddo3C6FhPWQoWICeqOQ0fiWlHU5U6uUrsg34Bv9w4q8a+Ms7TUnrx1kQhvAud5oRc9cUcy/UoKRtlRzYQ1h+fsLzgvsDwPm9ZyZzEnWnGTjNuOvJl5RF9cdLCf2dpqfoWlOdh6hIV2Et1Zg+AIN0+1n+oBahGWbXmFVr5en/YRhKfLzMoQg+bp9JJY8pp7s6vxiJ/S8iUpQpldA6Ito3hqX1xtPyg4bQNlxqcFL/slaEp99mh+K/iBZkl13/e6lkyZFCfoPGfR8Wvc4VrDFJlUHL3qnchMMAJTlmpRsMJzivUmQr6CYiB+MLLX7Ej52x86qH8vyoeEWNc1YcSsVN+HRVJuUCR34hL7ej1htii10wFGa326+WVeSkgzX3h9U8j04OZjSisD6ipChYTnXkbT1YXe6RvXkLKN4bZnrgHw55jusnYh/eeW+I0uBfvuMaqCbTepcp5mZqXrS3I8UC63tI18T/OcY+6Tzw4/t8g5ZsoJVpAljSxiOth1OSgWaU9BZnefNYR9JiaUFdqCRFy4+Pa4ZmUBH0geb6/FY4bj6xBMNinIsXv2vHchEhpCsE+vTPJxOB9uV7vh294Owbw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3103.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e7239443-8410-4aa0-7985-08d875df0bb4 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Oct 2020 16:33:30.5590 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2Z6nWrTNF9QHyCnwZwBIt1zC4/VzVwKvrQqDKAUL+l976TDxkgYIZe0V2dRZSuVkTWUoAATgjROMd2DQW5vddl0R1oVXxfgPyEbNTnQXh7I= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4924 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 01/22] event/dlb2: add documentation and meson build infrastructure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Bruce Richardson > Sent: Monday, October 19, 2020 3:34 AM > To: Jerin Jacob > Cc: McDaniel, Timothy ; Mcnamara, John > ; Kovacevic, Marko > ; Ray Kinsella ; Neil Horman > ; dpdk-dev ; Carrillo, Erik G > ; Eads, Gage ; Van Haaren= , > Harry ; Jerin Jacob ; > Thomas Monjalon > Subject: Re: [dpdk-dev] [PATCH v2 01/22] event/dlb2: add documentation an= d > meson build infrastructure >=20 > On Sun, Oct 18, 2020 at 02:18:32PM +0530, Jerin Jacob wrote: > > On Sat, Oct 17, 2020 at 11:50 PM Timothy McDaniel > > wrote: > > > > > > Adds the meson build infrastructure, which includes > > > compile-time constants in rte_config.h. DLB2 is > > > only supported on Linux X86 platforms at this time. > > > > > > Signed-off-by: Timothy McDaniel > > > Reviewed-by: Gage Eads > > > --- > > > config/rte_config.h | 7 + > > > doc/guides/eventdevs/dlb2.rst | 330 ++++++++++++= ++++++++++ > > > doc/guides/eventdevs/index.rst | 1 + > > > drivers/event/dlb2/meson.build | 7 + > > > drivers/event/dlb2/rte_pmd_dlb2_event_version.map | 3 + > > > drivers/event/meson.build | 3 + > > > 6 files changed, 351 insertions(+) > > > create mode 100644 doc/guides/eventdevs/dlb2.rst > > > create mode 100644 drivers/event/dlb2/meson.build > > > create mode 100644 drivers/event/dlb2/rte_pmd_dlb2_event_version.map > > > > > > diff --git a/config/rte_config.h b/config/rte_config.h > > > index 0bae630..fd1b3c3 100644 > > > --- a/config/rte_config.h > > > +++ b/config/rte_config.h > > > @@ -131,4 +131,11 @@ > > > /* QEDE PMD defines */ > > > #define RTE_LIBRTE_QEDE_FW "" > > > > > > +/* DLB2 defines */ > > > +#define RTE_LIBRTE_PMD_DLB2_POLL_INTERVAL 1000 > > > +#define RTE_LIBRTE_PMD_DLB2_UMWAIT_CTL_STATE 0 > > > +#undef RTE_LIBRTE_PMD_DLB2_QUELL_STATS > > > +#define RTE_LIBRTE_PMD_DLB2_SW_CREDIT_QUANTA 32 > > > +#define RTE_PMD_DLB2_DEFAULT_DEPTH_THRESH 256 > > > > We are going way with GLOBAL compile time options for drivers. > > I think, we should move to driver-specific folder not pollute top > > level config file. > > @Richardson, Bruce @Thomas Monjalon Thoughts? > > > Yes, we do need a better way to pass driver-specific build config options= . > How likely is it that the user may want to tweak these values? If it's no= t > likely having them just as regular defines in the driver folder may be > better, though they are not particularly problematic in rte_config.h give= n > the number of other values already there. >=20 We were careful to only place those options that were likely to be modified= by the end user here. > > > > > + > > > > --- a/drivers/event/meson.build > > > +++ b/drivers/event/meson.build > > > @@ -10,6 +10,9 @@ if not (toolchain =3D=3D 'gcc' and > cc.version().version_compare('<4.8.6') and > > > dpdk_conf.has('RTE_ARCH_ARM64')) > > > drivers +=3D 'octeontx' > > > endif > > > +if (dpdk_conf.has('RTE_ARCH_X86_64') and is_linux) > > > + drivers +=3D 'dlb2' > > > +endif > > > > Please add the message in "Content Skipped" section, > > Reference: grep "reason" in drivers/vdpa/mlx5/meson.build > > >=20 > The octeontx case is also wrong in this file, IMHO. Rather than checking > things in the event level and adding things to the list, the list should > just be static. If something should be optionally compiled, then check th= e > conditions in the driver meson.build file itself and add "build=3Dfalse" = to > disable, setting "reason" to the cause of it being disabled. This keeps a= ll > the logic about a driver in the other file, rather than someone having to > look in multiple places for why something is or isn't getting built > properly. >=20 > Regards, > /Bruce