From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4DE7EA04DC; Tue, 20 Oct 2020 17:17:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 21AB9BBA6; Tue, 20 Oct 2020 17:17:34 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id B2D1DA9F3 for ; Tue, 20 Oct 2020 17:17:30 +0200 (CEST) IronPort-SDR: tbT+95dH+e1NK4TY9AZBlewcXKxUNNgJK3jrqlvgLmQmq8N71BSeRh2f4ebHC1uKyp1fdNF7yr REtCV2e94iEw== X-IronPort-AV: E=McAfee;i="6000,8403,9779"; a="155010278" X-IronPort-AV: E=Sophos;i="5.77,397,1596524400"; d="scan'208";a="155010278" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2020 08:17:26 -0700 IronPort-SDR: q5QDczOij2ys8jz8hXFeKwap526ytQbWJF4M7FJz/QwWwLu9DZkbV35PMg3OjqPjgXgAf6ZJ4L 7ByGEOjIOj6w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,397,1596524400"; d="scan'208";a="347905682" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga004.fm.intel.com with ESMTP; 20 Oct 2020 08:17:26 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 20 Oct 2020 08:17:26 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 20 Oct 2020 08:17:25 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 20 Oct 2020 08:17:25 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.49) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 20 Oct 2020 08:17:22 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T5Dw+b3oxDwYxVwlU+WQ8zGRENAFje64sBsZYpFckzFoD6d156IZ6aBqTX62ZA6/K9t6g0LXUgVRVIWjQmoj9Dcq4gwvAcViukjMIyLAO6WI9U8+1N8gYHr312PdlcGs+Xdd9L7OQ2LIAF16NjlaoOc31E7EKgQOW29AGqawdjnxrommCe5tXnB2ayznhgoZFmhn8P3GulNIEAvCqXUoYYNNyOHYjOODPdrkfD0b/IONsvYn0fWUp2Hzcsnw+mmkQ+/hG0P7zOb8kGMeprWLFmwd+rSaM5WAEiip7kLrRJfzVVT1MGw01KYRGD/gF+8DST583kQeko2+woeJJuSksQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=08yx0/oH4bgPUVHu84CRGTyfGIRhrRxcautiYi3OQUs=; b=ILyDe6bEqkW9cSIPdrpmgOzJoGgFmEWdODngyMWcrKycOIiVLUh2WSNHHtGw6htgD3l0AxUpZGUrWHtD2Z4TS7ziIezia5b1XPokasB6YcGZDw2DnbYE8u0C4KhR/cIellZjhFX6OufT+8XpIF+3sZ8pr6pZ+qvYiUqeJTxG1eFXF5ogzRbWfZjSNtmpG8jdj+HYF7sqvIP7sDteyjukzrsT3wQwT5kLfE2M9efHU16b4iLLzC1rMWhaTYKqaZ/C8OkWrmFDZx8VRCF65U8nfxZFDWe+3hpJwtnRqJ5RJcBL0C9A2TFAmV0La4eo8PyqKbxtZboI+9qFkRokmb7GXg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=08yx0/oH4bgPUVHu84CRGTyfGIRhrRxcautiYi3OQUs=; b=DT0yblEqWKyNObTHrQBQhZnJKVC2x5tljZkPu5HQGjRH9nSpYQEtri5Gd/lSrgK9QlCcgI9Bw72oulR7dCaEtlEepG9u7T11JaMWlQTcqxZlDAZt4AKeiKQKdk90jM18p7eATFsVjKJVcKJbldArPrxvyplY+XgeibBQpUFKgxE= Received: from SN6PR11MB3103.namprd11.prod.outlook.com (2603:10b6:805:d7::13) by SA0PR11MB4767.namprd11.prod.outlook.com (2603:10b6:806:97::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.24; Tue, 20 Oct 2020 15:17:13 +0000 Received: from SN6PR11MB3103.namprd11.prod.outlook.com ([fe80::41fb:70e6:6102:a616]) by SN6PR11MB3103.namprd11.prod.outlook.com ([fe80::41fb:70e6:6102:a616%7]) with mapi id 15.20.3477.028; Tue, 20 Oct 2020 15:17:13 +0000 From: "McDaniel, Timothy" To: "Richardson, Bruce" , Jerin Jacob CC: "Mcnamara, John" , "Kovacevic, Marko" , Ray Kinsella , Neil Horman , dpdk-dev , "Carrillo, Erik G" , "Eads, Gage" , "Van Haaren, Harry" , Jerin Jacob , "Thomas Monjalon" Thread-Topic: [dpdk-dev] [PATCH v2 01/22] event/dlb2: add documentation and meson build infrastructure Thread-Index: AQHWpSuei/E6j1Yiyk6N717ECjYmz6memryAgAICegA= Date: Tue, 20 Oct 2020 15:17:13 +0000 Message-ID: References: <1599855987-25976-2-git-send-email-timothy.mcdaniel@intel.com> <1602958879-8558-1-git-send-email-timothy.mcdaniel@intel.com> <1602958879-8558-2-git-send-email-timothy.mcdaniel@intel.com> <20201019083337.GA649@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20201019083337.GA649@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [162.251.9.49] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7e7d5563-b56f-48b9-f938-08d8750b3909 x-ms-traffictypediagnostic: SA0PR11MB4767: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: g9k0ai8SCmZvFqY/2SBFEeKMsN4T4EnU55K4/ZkewHVop9jGADt9zWdTrxG8I8G9o+k4ZJN4dtmBfOPLuTzxhzelwqc2D3HB5pFNSmT/Wv5bQbX3J64LNC8tPAX5QluzobX+wnrtLyRpE40VyWb8lOpZaijs1cmRUKpY9o74bsR4uPy9vSSF+Ww+kILVBpR7rXSBJvNZ1WT6j/sBWRpebAt0GYlef+/lgonvMpEHn9svZFfLbJg+M3ESoz5p8VhfvEpJVeREofhsfLQqq24uDs0oBZgkz41RJ1He7PCG3kA+RGmH2rVRJQWp1tLWrWxu x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3103.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(136003)(366004)(376002)(346002)(39860400002)(64756008)(86362001)(478600001)(66446008)(66556008)(5660300002)(186003)(66476007)(9686003)(26005)(8936002)(33656002)(83380400001)(52536014)(76116006)(66946007)(4326008)(7696005)(2906002)(53546011)(6506007)(55016002)(8676002)(71200400001)(54906003)(316002)(110136005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: LIdGXJw7YKHDxSWOVZ+aWzhZt+NwOIpzyG/z5PwCKZflJyK0tmk10mb6N9HCa7bmsUO8el7mk+PkkQfIzAZ115ZrNUzk1cC1HTI/zKqAyfKAjT5jF/ml/uAlqSoz2EKEfKR8Y8lJ3Vl6VXcjzd4mxmJEI2d0qfP6GE5WRhAjmYWNCH1w9DewwE2Gd05RP5j2nB3oaqlT/XHrOA+mpuk8xQnxc2Y+W1PXFl8PEgaLeObjSwIpXeqCOjCcHf+gMWLcMtyeAhTfBZdkFUQu+YolCicFApFpjYueRvcfxDDWTvhD3W3F+IUJ5BTbxzzWe+heqPZA3Ign/glt/WkLhtkbU3N5MFoSOOaP7I3Udj5qZH5WNMyk2IJ9l381t9bL3bJf4auN6cuQzPkKPK52uYED5ACm1IfAAqbpIDZ1BbjPNIP30I1EQwTi7w+lKv30HAOfarnXwH6e2ydtdTpapBIiZNXQqVzSE9eiAXMlH9kx/Vn8wp1B/kT8HLSwNMlrO2n6UEZ7fCFcnO+OwGxv6V/H4jbbzzTqBSOwz+DSXeLr8pptgUm0oooLCJ6n12LvgQNoTDzejSs9VB5ibCgRxg0wetpQB3phMwsTrC0lfwf3lWIFcL9iorV7ZxN4TZ+WBCSHPiEGnFzZqTow1xoISolUcw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3103.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7e7d5563-b56f-48b9-f938-08d8750b3909 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Oct 2020 15:17:13.3850 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: RXmREesYElOWD+02ITkn3MUyp+BxnlNLC3UfJNf1pb93+IZWNhLJZcSElI97ADJy2aS5kblHUuUegU8rH21vQgUwqu2IxKQIYgH4RhvsDUk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4767 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 01/22] event/dlb2: add documentation and meson build infrastructure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Bruce Richardson > Sent: Monday, October 19, 2020 3:34 AM > To: Jerin Jacob > Cc: McDaniel, Timothy ; Mcnamara, John > ; Kovacevic, Marko > ; Ray Kinsella ; Neil Horman > ; dpdk-dev ; Carrillo, Erik G > ; Eads, Gage ; Van Haaren= , > Harry ; Jerin Jacob ; > Thomas Monjalon > Subject: Re: [dpdk-dev] [PATCH v2 01/22] event/dlb2: add documentation an= d > meson build infrastructure >=20 > On Sun, Oct 18, 2020 at 02:18:32PM +0530, Jerin Jacob wrote: > > On Sat, Oct 17, 2020 at 11:50 PM Timothy McDaniel > > wrote: > > > > > > Adds the meson build infrastructure, which includes > > > compile-time constants in rte_config.h. DLB2 is > > > only supported on Linux X86 platforms at this time. > > > > > > Signed-off-by: Timothy McDaniel > > > Reviewed-by: Gage Eads > > > --- > > > config/rte_config.h | 7 + > > > doc/guides/eventdevs/dlb2.rst | 330 ++++++++++++= ++++++++++ > > > doc/guides/eventdevs/index.rst | 1 + > > > drivers/event/dlb2/meson.build | 7 + > > > drivers/event/dlb2/rte_pmd_dlb2_event_version.map | 3 + > > > drivers/event/meson.build | 3 + > > > 6 files changed, 351 insertions(+) > > > create mode 100644 doc/guides/eventdevs/dlb2.rst > > > create mode 100644 drivers/event/dlb2/meson.build > > > create mode 100644 drivers/event/dlb2/rte_pmd_dlb2_event_version.map > > > > > > diff --git a/config/rte_config.h b/config/rte_config.h > > > index 0bae630..fd1b3c3 100644 > > > --- a/config/rte_config.h > > > +++ b/config/rte_config.h > > > @@ -131,4 +131,11 @@ > > > /* QEDE PMD defines */ > > > #define RTE_LIBRTE_QEDE_FW "" > > > > > > +/* DLB2 defines */ > > > +#define RTE_LIBRTE_PMD_DLB2_POLL_INTERVAL 1000 > > > +#define RTE_LIBRTE_PMD_DLB2_UMWAIT_CTL_STATE 0 > > > +#undef RTE_LIBRTE_PMD_DLB2_QUELL_STATS > > > +#define RTE_LIBRTE_PMD_DLB2_SW_CREDIT_QUANTA 32 > > > +#define RTE_PMD_DLB2_DEFAULT_DEPTH_THRESH 256 > > > > We are going way with GLOBAL compile time options for drivers. > > I think, we should move to driver-specific folder not pollute top > > level config file. > > @Richardson, Bruce @Thomas Monjalon Thoughts? > > > Yes, we do need a better way to pass driver-specific build config options= . > How likely is it that the user may want to tweak these values? If it's no= t > likely having them just as regular defines in the driver folder may be > better, though they are not particularly problematic in rte_config.h give= n > the number of other values already there. >=20 > > > > > + > > > > --- a/drivers/event/meson.build > > > +++ b/drivers/event/meson.build > > > @@ -10,6 +10,9 @@ if not (toolchain =3D=3D 'gcc' and > cc.version().version_compare('<4.8.6') and > > > dpdk_conf.has('RTE_ARCH_ARM64')) > > > drivers +=3D 'octeontx' > > > endif > > > +if (dpdk_conf.has('RTE_ARCH_X86_64') and is_linux) > > > + drivers +=3D 'dlb2' > > > +endif > > > > Please add the message in "Content Skipped" section, > > Reference: grep "reason" in drivers/vdpa/mlx5/meson.build > > >=20 > The octeontx case is also wrong in this file, IMHO. Rather than checking > things in the event level and adding things to the list, the list should > just be static. If something should be optionally compiled, then check th= e > conditions in the driver meson.build file itself and add "build=3Dfalse" = to > disable, setting "reason" to the cause of it being disabled. This keeps a= ll > the logic about a driver in the other file, rather than someone having to > look in multiple places for why something is or isn't getting built > properly. >=20 > Regards, > /Bruce Due to time constraints, I would prefer to take these issues up in a future= release.