From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 44C60A034F; Mon, 30 Aug 2021 16:47:39 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2866741136; Mon, 30 Aug 2021 16:47:39 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 13EEB41135 for ; Mon, 30 Aug 2021 16:47:37 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10092"; a="218004232" X-IronPort-AV: E=Sophos;i="5.84,363,1620716400"; d="scan'208";a="218004232" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Aug 2021 07:47:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,363,1620716400"; d="scan'208";a="540491365" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga002.fm.intel.com with ESMTP; 30 Aug 2021 07:47:36 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Mon, 30 Aug 2021 07:47:36 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Mon, 30 Aug 2021 07:47:36 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.175) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Mon, 30 Aug 2021 07:47:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EYLHBoamn6szPuh/5nXdInTEwrl2FwQdkopNgSi4n/hvx19Nl2D90YC8vdvjFywIAHcGL2XGh1/sVM0wGF4KELJZIdyzv2YEeukOVBRaEytbrzkstFrxn/2UJoy0fJlJIruolpFJIcqJ/VSpMsykVfmwnJ/Gq7/9si7e5N1WTcGwS4klhlACA/NYaGha1qvlP19lCVXRiZTxrraQHLNhqke5hrWVKNgLHcWTrnMmcLeTHeANWHc0mWdPbAMSh2P/wfuNjYaq52ddfrUtbuLOhfhkAMCOTs+z0PzNmc+cAcOcQ7UWL8IHsfBsmll9nI96L0fVb8B4rO1OO5IfdYyAww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Fr5F8eKE3gPCfMQtcp82DnTl7XHgY/XG7f56DkabqE0=; b=DJBKpPChVYK4ugefOOl59Jj3dEoPWaJsaLTUBbaRs3nwT9EZxnkMckfSZaM6iWxwWoUwciclmXicq+WlHWiI2uz7lU9C/oJhLEIh0eMSpxJtcTFbwjRfx6jYJ8ipo2c6ccQjmMsi7qmBiSr4rXFvSsJjGu3oPFdjaBR6gx/SSip5lHKLJtEGvlFH1n1DoQ77FqXVAAAtqinbpwEzYjIBEgsgptVDDFUmrhL8wzbsoGKGt/dcCGzs9yTzdxMyxXQnxy3zCKnAyPw4nLR4kQR9FDN48Y1g4BXlN5Z2ezUxakYuD08qYKZl5F86qSvso3qZxGEyeyWceFn0xeYq4wykDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Fr5F8eKE3gPCfMQtcp82DnTl7XHgY/XG7f56DkabqE0=; b=P+/HqcsUYHQQlLyCvbaiGxHAaiel2n75Vj55t3d5bPrL1MEs7R3NXPdMsYupkM/X/zSv/UPygluhhP/dWEi+7jLUHzQIJYG4JMgNFmhEBsbVOsT0PJgXjudD2hJGiWn1kHypKecTIrXC9C9vquobi+JJnd/CeFj5Nh13gqR3l+o= Received: from SN6PR11MB3117.namprd11.prod.outlook.com (2603:10b6:805:d7::32) by SA0PR11MB4592.namprd11.prod.outlook.com (2603:10b6:806:98::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.23; Mon, 30 Aug 2021 14:47:35 +0000 Received: from SN6PR11MB3117.namprd11.prod.outlook.com ([fe80::a140:8726:8fcb:6809]) by SN6PR11MB3117.namprd11.prod.outlook.com ([fe80::a140:8726:8fcb:6809%7]) with mapi id 15.20.4457.024; Mon, 30 Aug 2021 14:47:35 +0000 From: "Jayatheerthan, Jay" To: "pbhagavatula@marvell.com" , "jerinj@marvell.com" , "Gujjar, Abhinandan S" , "Carrillo, Erik G" CC: "Ananyev, Konstantin" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [RFC 14/15] eventdev: make trace APIs internal Thread-Index: AQHXmFbaxeJfgXIcv06mmSMLxMwtN6uMKrzg Date: Mon, 30 Aug 2021 14:47:34 +0000 Message-ID: References: <20210823194020.1229-1-pbhagavatula@marvell.com> <20210823194020.1229-14-pbhagavatula@marvell.com> In-Reply-To: <20210823194020.1229-14-pbhagavatula@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f1e8adeb-dee0-41fa-f1ba-08d96bc51aae x-ms-traffictypediagnostic: SA0PR11MB4592: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:392; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SUDB6hMktgzI/sgrzHRyAGWXivV2WVfJF2LnQf44RlQtYxwb7gITTpahbj6xPsIMRs1yEeRn382HaIcnDtAUUYFbYKNuyXNIrY/79PtzM8YRqYW3/Mwcz9hhtxKRsDf0Kg2sSgrLX1BrOzNPsFP3bX+X4oJp+C6RqQ/7/l/eMA6eatL6Nulu8sp/eHojtazGOkxjBmeNXQi3NoRmpqIGHwZDTefZSQpKAInudbdaB/PxUgb06Ddw+lQBsjB1MnmWJnNi89dDp4VFWe+d3+Ax/BS+kWaEMwJ5zE3seP5zvDk+0eTkSE+LnOQKEAv0w1QhG5mX58xXMQMmzo4gBwEooUnxZ7U1mnp+VW3IPuB18Jpfw//EpROl+Z99Cip6ibxFpdkAgQ5De9w1/0A2nbPTIHQ4xYqefM1/4SXcj0YfERl+GclrDlF6Wn6BFF6eBYw982JIi31ZhZ5dSdo5UJfH9B7zjfz9w43sENDnx7Q5DTAmchVgZS8VsI6a8aGvnZtRvF5dQR8+rUTm9JkitOM6ctDA67fCCMhNpjipYfR8QVExQCBtL7rqvlZQRJPlAyEOm8EdOqRBhP5NaoLRGu0duMECqTy4wO0xMyqg4GBORFRjQrHK7cp75OfSlmjyiHvrSRtWynjAQDgLZivmK/uf6Y61XYl0n4GDufHRxoHiGjr8gKR1w1TSRrZJRYe2cDYcoaJsF/4qYt4KDpAZoHpKFA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3117.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(83380400001)(110136005)(54906003)(6636002)(508600001)(7696005)(186003)(66446008)(66556008)(66476007)(38070700005)(5660300002)(33656002)(52536014)(316002)(66946007)(55016002)(86362001)(6506007)(4326008)(55236004)(8936002)(122000001)(76116006)(26005)(8676002)(64756008)(38100700002)(53546011)(9686003)(2906002)(71200400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vn+Vm2dHBZ154KcWeS0i8ujCckqAkArrVA5jCJSycWLnXoHKcJwwD6b6eLmU?= =?us-ascii?Q?/RFSFkh0iUL9SyCu4qPOq66+ZbumHE+AirCkjtE6vX8aOVxoo9gQSLpv6tmo?= =?us-ascii?Q?UbpsDBT6f9vb+TJKzj5LgqEaTNWqoSotgvaizFXdjUUsAbXZyPPUyrLjsrZg?= =?us-ascii?Q?LOFORDGjJe9Riad4CiHh3SBdHJ+TkfECRCIRAEgCx5KEoU1Jb/0NNBxXeqnu?= =?us-ascii?Q?9Ifl2BJW+57zOl9MPlVzGUSZN2frNVCL9cnMlJ32vALx534HAb7/f/9D3IEj?= =?us-ascii?Q?UOmgVXlUlYYTmFrwoTerCRUHF+TU9ZK3m8awp/rOQqGED33wZ75JuekI72x0?= =?us-ascii?Q?ZZDqRUrRL+1KSYwtCUfYeR+708SIrfpgnIQQmhDHdxdnAFdPi737iWG08vad?= =?us-ascii?Q?4sAgcvM2pwLU+Y2JyfkK5pXBgSv+hsBY4xKjqO9SI+hssq63raya9TTGVopl?= =?us-ascii?Q?DtUqzKM/kZ6sjGkJzJkGRSgbHJiuLL+TY5m8tr8aC9tXKuA+MA9hvVZVUsIY?= =?us-ascii?Q?JBcdZzmBiyrUCLncF+kcHs8Wo/JbOTNrDnB3EjoZNaoZaNsM45Tlt77oPYjO?= =?us-ascii?Q?b9s8iDPUjtbA4OR8Wzkj6ewbno1JNEUXbsfBZySpgVw3McXbHb2yR5u8VYiA?= =?us-ascii?Q?vnFpLbVDBr1k7U5Cb83WmvU6aD1gkQ4G5ZdpQcwdVZhYKD2vqvmnBvTob8Wr?= =?us-ascii?Q?A756Ikl6GmpRtvYiRBEIHsc99F9JYqtWGRG8r4gcPfGOVA0yF5iTANGVjrbZ?= =?us-ascii?Q?rFGIDEZT2gIwRlYv//inpq6tqdnoFt6yNmZ9IgRNVpotDJg2pAOsZ/EZbrJ8?= =?us-ascii?Q?fsdofNhxDl4Qsgr9xmM7p3HBoo/QdTEcNU/aPPFnvqanS/ZB73d142+3f5v4?= =?us-ascii?Q?dapd7BiV5PF1eHvAfpDxxlPa5A4sAsRzvaUxOxd3sHCIv61+oSCbmSG17j5t?= =?us-ascii?Q?m/B61z1vD0+W3WDp+vG7pXd7QHXcci0MrbjsWmrZFBZv41JxYH3fqyFddwP2?= =?us-ascii?Q?vqSgoXHJ1vlWsFhN4d06JJ8CSNMGppa716xp6q/qoi6S6F1IS055BsKC2cd2?= =?us-ascii?Q?2rKQrmE1RddEN0Rn0U1vCpcyiKoNU5EJoFudWdnyzKjp3WGr15MEqM8prSqr?= =?us-ascii?Q?zPcrdz56Krp9oGdbLH9fdhbiS4y7Ud/qetvo+qcicsYQ/qO5+EagaAQ+Rdct?= =?us-ascii?Q?3OouhXqbWkL4LkhwXNdHcNShlKDQJ7rlwcWc5gRJF2NA+FYrlLRw9sDhGVIg?= =?us-ascii?Q?J9/dT05f+7CCJb/fVtR90aNEx2gAtkHhWbrrK7RcIC1x8SI9sWQmlv4Nq0En?= =?us-ascii?Q?mzCM5XBrUTrtE2GqymLNIHxO?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3117.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f1e8adeb-dee0-41fa-f1ba-08d96bc51aae X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Aug 2021 14:47:34.8465 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: oVks7IHo6hZyF+GkNmX2bOCkrZHkOK8AJv9MDWnZYYdaLGWA1gLwBte2pCfK0+/crKBIr877vB49nCNf03Rc/pyq4OMU0slKhcUaiYt18CI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4592 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [RFC 14/15] eventdev: make trace APIs internal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: pbhagavatula@marvell.com > Sent: Tuesday, August 24, 2021 1:10 AM > To: jerinj@marvell.com; Gujjar, Abhinandan S ; Jayatheerthan, Jay ; > Carrillo, Erik G > Cc: Ananyev, Konstantin ; dev@dpdk.org; Pav= an Nikhilesh > Subject: [dpdk-dev] [RFC 14/15] eventdev: make trace APIs internal >=20 > From: Pavan Nikhilesh >=20 > Slowpath trace APIs are only used in rte_eventdev.c so make them > as internal. >=20 > Signed-off-by: Pavan Nikhilesh > --- > lib/eventdev/{rte_eventdev_trace.h =3D> eventdev_trace.h} | 0 > lib/eventdev/eventdev_trace_points.c | 2 +- > lib/eventdev/meson.build | 2 +- > lib/eventdev/rte_event_crypto_adapter.c | 2 +- > lib/eventdev/rte_event_eth_rx_adapter.c | 2 +- > lib/eventdev/rte_event_eth_tx_adapter.c | 2 +- > lib/eventdev/rte_event_timer_adapter.c | 2 +- > lib/eventdev/rte_eventdev.c | 2 +- > 8 files changed, 7 insertions(+), 7 deletions(-) > rename lib/eventdev/{rte_eventdev_trace.h =3D> eventdev_trace.h} (100%) >=20 > diff --git a/lib/eventdev/rte_eventdev_trace.h b/lib/eventdev/eventdev_tr= ace.h > similarity index 100% > rename from lib/eventdev/rte_eventdev_trace.h > rename to lib/eventdev/eventdev_trace.h > diff --git a/lib/eventdev/eventdev_trace_points.c b/lib/eventdev/eventdev= _trace_points.c > index 3867ec8008..237d9383fd 100644 > --- a/lib/eventdev/eventdev_trace_points.c > +++ b/lib/eventdev/eventdev_trace_points.c > @@ -4,7 +4,7 @@ >=20 > #include >=20 > -#include "rte_eventdev_trace.h" > +#include "eventdev_trace.h" >=20 > /* Eventdev trace points */ > RTE_TRACE_POINT_REGISTER(rte_eventdev_trace_configure, > diff --git a/lib/eventdev/meson.build b/lib/eventdev/meson.build > index f19b831edd..c750e0214f 100644 > --- a/lib/eventdev/meson.build > +++ b/lib/eventdev/meson.build > @@ -19,7 +19,6 @@ sources =3D files( > ) > headers =3D files( > 'rte_eventdev.h', > - 'rte_eventdev_trace.h', > 'rte_eventdev_trace_fp.h', > 'rte_event_ring.h', > 'rte_event_eth_rx_adapter.h', > @@ -34,6 +33,7 @@ driver_sdk_headers +=3D files( > 'eventdev_pmd.h', > 'eventdev_pmd_pci.h', > 'eventdev_pmd_vdev.h', > + 'eventdev_trace.h', > 'event_timer_adapter_pmd.h', > ) >=20 > diff --git a/lib/eventdev/rte_event_crypto_adapter.c b/lib/eventdev/rte_e= vent_crypto_adapter.c > index 8a2a25c02e..93e7352c6e 100644 > --- a/lib/eventdev/rte_event_crypto_adapter.c > +++ b/lib/eventdev/rte_event_crypto_adapter.c > @@ -16,7 +16,7 @@ >=20 > #include "rte_eventdev.h" > #include "eventdev_pmd.h" > -#include "rte_eventdev_trace.h" > +#include "eventdev_trace.h" > #include "rte_event_crypto_adapter.h" >=20 > #define BATCH_SIZE 32 > diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_e= vent_eth_rx_adapter.c > index f8225ebd3d..7e97fbd21d 100644 > --- a/lib/eventdev/rte_event_eth_rx_adapter.c > +++ b/lib/eventdev/rte_event_eth_rx_adapter.c > @@ -20,7 +20,7 @@ >=20 > #include "rte_eventdev.h" > #include "eventdev_pmd.h" > -#include "rte_eventdev_trace.h" > +#include "eventdev_trace.h" > #include "rte_event_eth_rx_adapter.h" >=20 > #define BATCH_SIZE 32 Looks good to me. Acked-by: Jay Jayatheerthan > diff --git a/lib/eventdev/rte_event_eth_tx_adapter.c b/lib/eventdev/rte_e= vent_eth_tx_adapter.c > index 18c0359db7..ee3631bced 100644 > --- a/lib/eventdev/rte_event_eth_tx_adapter.c > +++ b/lib/eventdev/rte_event_eth_tx_adapter.c > @@ -6,7 +6,7 @@ > #include >=20 > #include "eventdev_pmd.h" > -#include "rte_eventdev_trace.h" > +#include "eventdev_trace.h" > #include "rte_event_eth_tx_adapter.h" >=20 > #define TXA_BATCH_SIZE 32 Looks good to me. Acked-by: Jay Jayatheerthan > diff --git a/lib/eventdev/rte_event_timer_adapter.c b/lib/eventdev/rte_ev= ent_timer_adapter.c > index c4dc7a5fd4..7404b0cbb2 100644 > --- a/lib/eventdev/rte_event_timer_adapter.c > +++ b/lib/eventdev/rte_event_timer_adapter.c > @@ -24,7 +24,7 @@ > #include "eventdev_pmd.h" > #include "rte_event_timer_adapter.h" > #include "rte_eventdev.h" > -#include "rte_eventdev_trace.h" > +#include "eventdev_trace.h" >=20 > #define DATA_MZ_NAME_MAX_LEN 64 > #define DATA_MZ_NAME_FORMAT "rte_event_timer_adapter_data_%d" > diff --git a/lib/eventdev/rte_eventdev.c b/lib/eventdev/rte_eventdev.c > index b9b029edc4..3a393bd120 100644 > --- a/lib/eventdev/rte_eventdev.c > +++ b/lib/eventdev/rte_eventdev.c > @@ -36,7 +36,7 @@ >=20 > #include "rte_eventdev.h" > #include "eventdev_pmd.h" > -#include "rte_eventdev_trace.h" > +#include "eventdev_trace.h" >=20 > struct rte_eventdev *rte_eventdevs; >=20 > -- > 2.17.1