From: "Jayatheerthan, Jay" <jay.jayatheerthan@intel.com>
To: "Naga Harish K, S V" <s.v.naga.harish.k@intel.com>,
"jerinjacobk@gmail.com" <jerinjacobk@gmail.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] eventdev: remove event port config override in tx adapter
Date: Fri, 23 Jul 2021 11:27:32 +0000 [thread overview]
Message-ID: <SN6PR11MB31177D82E08B0348A35EDE57FDE59@SN6PR11MB3117.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210723081222.4176279-1-s.v.naga.harish.k@intel.com>
> -----Original Message-----
> From: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> Sent: Friday, July 23, 2021 1:42 PM
> To: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>; jerinjacobk@gmail.com
> Cc: dev@dpdk.org
> Subject: [PATCH] eventdev: remove event port config override in tx adapter
>
> The event port config set by application is modified in
> default configuration callback function. This patch removes
> this override and use application configured event port
> config value.
>
> Signed-off-by: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> ---
> lib/eventdev/rte_event_eth_tx_adapter.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/lib/eventdev/rte_event_eth_tx_adapter.c b/lib/eventdev/rte_event_eth_tx_adapter.c
> index db260bfb68..18c0359db7 100644
> --- a/lib/eventdev/rte_event_eth_tx_adapter.c
> +++ b/lib/eventdev/rte_event_eth_tx_adapter.c
> @@ -286,7 +286,6 @@ txa_service_conf_cb(uint8_t __rte_unused id, uint8_t dev_id,
> return ret;
> }
>
> - pc->event_port_cfg = 0;
> ret = rte_event_port_setup(dev_id, port_id, pc);
> if (ret) {
> RTE_EDEV_LOG_ERR("failed to setup event port %u\n",
> --
> 2.25.1
Looks good to me.
Acked-by: Jay Jayatheerthan <jay.jayatheerthan@intel.com>
next prev parent reply other threads:[~2021-07-23 11:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-23 8:12 Naga Harish K, S V
2021-07-23 11:27 ` Jayatheerthan, Jay [this message]
2021-07-23 11:36 ` Jerin Jacob
2021-07-24 14:10 ` [dpdk-dev] [PATCH v2] eventdev: fix event port setup " Naga Harish K, S V
2021-07-28 6:44 ` Jayatheerthan, Jay
2021-07-28 9:30 ` Jerin Jacob
2021-07-28 10:57 ` Jayatheerthan, Jay
2021-07-30 10:24 ` Jerin Jacob
2021-07-30 10:31 ` Thomas Monjalon
2021-07-30 10:36 ` Jerin Jacob
2021-07-30 10:59 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR11MB31177D82E08B0348A35EDE57FDE59@SN6PR11MB3117.namprd11.prod.outlook.com \
--to=jay.jayatheerthan@intel.com \
--cc=dev@dpdk.org \
--cc=jerinjacobk@gmail.com \
--cc=s.v.naga.harish.k@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).