From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 721BFA0C41; Thu, 16 Sep 2021 09:37:31 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F39924003E; Thu, 16 Sep 2021 09:37:30 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 172644003C for ; Thu, 16 Sep 2021 09:37:28 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10108"; a="244882494" X-IronPort-AV: E=Sophos;i="5.85,297,1624345200"; d="scan'208";a="244882494" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Sep 2021 00:37:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,297,1624345200"; d="scan'208";a="452841467" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga002.jf.intel.com with ESMTP; 16 Sep 2021 00:37:26 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 16 Sep 2021 00:37:26 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 16 Sep 2021 00:37:25 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 16 Sep 2021 00:37:25 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.173) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 16 Sep 2021 00:37:25 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Xutr49vy1oTMJHpF8klmlfD8+sd9WTiJ7TDudMnRV8SIcTS6kjbLAxa0PjML1kpyWlJq+OIAUEbecDZBxwkZSYei73Q5gSNRUCiuwsP6HihqjzHLvEsSDDklMEC2CwOPBhSJPXrjOHH/OIIwimxn4Mg5xNu57iAQ2PFwzUb6pusuSIF7H+IcHKXfoGmkBWTjQQAaKmRvMoosC2kUpJM0W2Z939Ru2J3O6wGY3Z5svn1HJNtsEtkvtqWgyFQZlnddnSSZzU9cXY4pjxNnenBa+oP7pVzb0yCtQm8yCh4nllEMK8yP35zv+a1OwpWt8/GyvHPIiCv/IBcW4Ed/fHXvsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=EM5BN8THnCLaU5dRVrTa3twrlQnxZTrwvVYY+bY7cK0=; b=kYQ7UOT6Of/tJADT3WGrT4CKAw7479pGhiWM22C5ZXuCOGxPbdh90zTT8rTjCu/PopVAi5fjwtSUJBGsSmqdhwxPLNySgi/cMZRIDxtM22u52seQvYIUjLx2PvtmSIaEwPue5hfq10Tz9i0J24glGtUqOf4l5QQVEQVl+TFnnfyknZIQKD+XjfqbEjw1wXi0FGZ5arUrYdw6MajoMVytooPQXPbww2V88UwRPWnA65Bj+Rhhmz/PTQEGnVFl80/PH7YKWDQt53BtuAOSDLlyQabbmC9ncrvozDcX7NJVO5plpVY4PK3PLX7ck/5E4KNP9LkqgyFBzEG+zcFTlK7R2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EM5BN8THnCLaU5dRVrTa3twrlQnxZTrwvVYY+bY7cK0=; b=H3gDRhpdntHlHmabRjURuD7v0vxAdG38gT5fUR8LG2XxgQoX24/EcKEyGvS3cXYVlsIqerrpIGqKntQSA4e+i5txBBnYEev2mEjGbjDoKFBOEVWqlyFICM+36felrRoA/z1hmFTdMVcewDCQt+0g0B8/RWXd0/7N74YYQR8/63Q= Received: from SN6PR11MB3117.namprd11.prod.outlook.com (2603:10b6:805:d7::32) by SA0PR11MB4749.namprd11.prod.outlook.com (2603:10b6:806:9a::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14; Thu, 16 Sep 2021 07:37:23 +0000 Received: from SN6PR11MB3117.namprd11.prod.outlook.com ([fe80::a140:8726:8fcb:6809]) by SN6PR11MB3117.namprd11.prod.outlook.com ([fe80::a140:8726:8fcb:6809%7]) with mapi id 15.20.4523.016; Thu, 16 Sep 2021 07:37:23 +0000 From: "Jayatheerthan, Jay" To: "Kundapura, Ganapati" , "jerinjacobk@gmail.com" CC: "dev@dpdk.org" , "Yigit, Ferruh" Thread-Topic: [PATCH v2] eventdev: update rx timestamp in mbuf using mbuf dynamic field Thread-Index: AQHXqsuJgWPEaS+sPEyH862KU2HSYqumRZiA Date: Thu, 16 Sep 2021 07:37:23 +0000 Message-ID: References: <20210914071451.3130703-1-ganapati.kundapura@intel.com> <20210916072143.1475159-1-ganapati.kundapura@intel.com> In-Reply-To: <20210916072143.1475159-1-ganapati.kundapura@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 76434e7b-3063-48eb-0345-08d978e4d2eb x-ms-traffictypediagnostic: SA0PR11MB4749: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yNx7BJMVewHN1H+HNb9YwdXHFPe4sSrKJSIgE/Tr150AX4/krzEvz15TpsyZFx7gFvEyzAdKFQTsgxL5FP8ZoI8PxxOpBGd5E6Sxm3B5jEI2kDbcViW0iM6juQi76F/uMhpWqdgpTbaRyeIzAm1Qu0C+2usdFraYfXFpxOjS4Qyq4AR240ZYbZmzq/lVFdkfg5K6AO8hklxuXrD9TlI7I6OhgYI4xnS6N4G4XcVpk4jKaT2a658SNJkQw0RMuN+l2tuhPsslzSyTfIqcBHKvEcIqD6KkDdhnB4p3O4FMM0YHYaCG6Z6NzEZlByOt71aMa8EIuHulYaMUosPfZZbj+8lJ3VFN7ixKzjxRP4JXD3HkEIJuUZQlTBH23fWuZgibhJ2bIOp/eRE0gjw1tJeHTM83GJCMpEHIrxUleLjgH70jr5rq7OUq1uZDCXGBNczAVQl25ZWbFpWDsBAmthG0RIG+BgS5GjjAdmc9Grm8BQnP+PPYts/ZUCiCd0UckhwtzyyZJ8m9jDA5XtHDDqAWoZt+rFpPpU5X+kksWB1QGpGM0gGfOdOp3dRuts5XQRp++9sarAUHjWPj9KAKhnhCbt1+yhTJ4/Qi7X7qc9BTXylIADEG49ogesgppIamJMMNITOnqrm8zPEd1QtfDn7fP/hCKxROSA7IIb6CLldaMz7dKOccyijE/olLQWzX6YbV8ZYgw4jfiV1wzBNIMsekCg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3117.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(136003)(39860400002)(366004)(346002)(396003)(186003)(86362001)(122000001)(55016002)(316002)(478600001)(66446008)(26005)(5660300002)(33656002)(64756008)(66476007)(107886003)(66556008)(66946007)(2906002)(38100700002)(9686003)(52536014)(83380400001)(15650500001)(76116006)(71200400001)(110136005)(54906003)(6506007)(53546011)(8936002)(38070700005)(7696005)(55236004)(4326008)(8676002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?r5GWjsdJb2MFDZof+bAKdm4ssW9Z2vTJdxXPTpmJz/RhcTymrSa+CXZvMTeN?= =?us-ascii?Q?awF6SbUX09KV3PuLweaGxA77l2sFNqTyrRK8hTTiDFMYwwfmqxBYsj1PsiyD?= =?us-ascii?Q?GUyLXLeZ/fSdQNfogjdQarefxgJ26MLIJXudkJcBZo3TKeIQ1sHihq0VHPxh?= =?us-ascii?Q?9yx5Xe0nCuTfRVAWIULBAhYvb+dJEsLDjc5hCudL37HZcaCQQmFZ3JVs8byc?= =?us-ascii?Q?2bAsFsVD9VhHEs/SJHT4Utl0OsWHhyesO9VM1B73VtsSq2w5+r3Abprvmf3Q?= =?us-ascii?Q?a1wbY0hw7mHUY7/q7Y1VYwuVPBJNFp1P6tqNo4xUgA23zOAUBbldDjBBae21?= =?us-ascii?Q?WEhnBTjnkrWvo50ezPI6DX9W7yBMyIQveSeUj/rnrIC/DdB5FLqm79IKqiva?= =?us-ascii?Q?RRPWlCWDFOk34Qblc/f0ueShAiIUq5RI5JN4LcAm+I8RgelBsvmtq3eThtu0?= =?us-ascii?Q?RWyKLwfLG4Xj6wxFxMqvuzUjOCpj/nGpVi3j1cnzYonz1Ypyi+AmIlSJon1C?= =?us-ascii?Q?aFhyYlFF56EgwHddFXy2ujhzit3kOH6yZgUyBhCsoTKb7x4sFQnhcMrMvff1?= =?us-ascii?Q?QwQI30zryQFnJalXmWuEpc8GuCi1yvlOOMyeY5nAMGNMQbdyZhyap1nTbTIB?= =?us-ascii?Q?F995zvoYFtCwKf2eUAnt3BhKE370kABaJUNN0i5XchckymOi8acwy9f0Q/YP?= =?us-ascii?Q?CINa7yhzjo5EKyvko778c+AQCiwVr7WBqzvgSq5dM33QsTTVK1Jp0qOs56Ez?= =?us-ascii?Q?v9DZhGvyQTyTKZ5cHsBvq/ntqmPRaFoDyQlFKSmeCmWsgNeIYUIPQqOprmhR?= =?us-ascii?Q?juNJhSXs5Qkla44SEwcxUxaT1dTEewttVtcJIW8VXNq8P+b1NjXxbROYmx1W?= =?us-ascii?Q?+Hk+14//UaX+2Jw5uGFkyFxjiVN5PYc8dHzj68R660Kk+7NDXIUFS3jG2zJZ?= =?us-ascii?Q?dIS/IWN1rCMvbKJ+CZfgGeUDUPy6kKU0/Z7qSTTUNHwjU40q9zF8d0j1r618?= =?us-ascii?Q?ToERbiIMnq7dau/2y9U9tm+NnKufgWIOJWonoIMf2Tp4+DO3MzCcoyLWut/9?= =?us-ascii?Q?Ng/knmvfXDrmiWM+tlHYd8GBwOSzmzNU2XDJvVQw803JYCAST/vGIBcLz3B2?= =?us-ascii?Q?GrxwhNSn5sY3nLpbxk6gyd5Q80SsdQrjWrEc8r0CqBECmzkERxCRBSniveM4?= =?us-ascii?Q?5Vk2q/ECckpRe50yGIiHr6G8eyJaHTr+9BcYP6GTSP2VGIBI+pVcekdkuei7?= =?us-ascii?Q?veQt7oLmCtukP0yP2qnCsV8GVg7r3nB/iQpC78AtAJEHv1zUr6shWky1uO1F?= =?us-ascii?Q?2Yo7hlZOIVW/OLdKOt4CmShz?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3117.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 76434e7b-3063-48eb-0345-08d978e4d2eb X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Sep 2021 07:37:23.4880 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wPTNEPynuaY7+e/prAX2s4XAaI8+WgXTodEv91F/K8XdT3gxdVn/Mm3hY2NzNpdFfINJ8PZ35Lrk814la4FBzYyqmorpmCXXrR2ee2pabVo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4749 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] eventdev: update rx timestamp in mbuf using mbuf dynamic field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Kundapura, Ganapati > Sent: Thursday, September 16, 2021 12:52 PM > To: Jayatheerthan, Jay ; jerinjacobk@gmail.c= om > Cc: dev@dpdk.org; Yigit, Ferruh > Subject: [PATCH v2] eventdev: update rx timestamp in mbuf using mbuf dyna= mic field >=20 > Add support to register timestamp dynamic field in mbuf. >=20 > Update the timestamp in mbuf for each packet before enqueuing > to event device if the timestamp is not already set. >=20 > Adding the timestamp in Rx adapter avoids additional latency > due to the event device. >=20 > Signed-off-by: Ganapati Kundapura >=20 > --- > v2: > * Removed rte_ prefix from the internal function >=20 > v1: > * Add support to register timestamp dynamic field in mbuf > --- > --- > lib/eventdev/rte_event_eth_rx_adapter.c | 33 +++++++++++++++++++++++++++= ++++++ > 1 file changed, 33 insertions(+) >=20 > diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_e= vent_eth_rx_adapter.c > index f2dc695..fd79b28 100644 > --- a/lib/eventdev/rte_event_eth_rx_adapter.c > +++ b/lib/eventdev/rte_event_eth_rx_adapter.c > @@ -17,6 +17,7 @@ > #include > #include > #include > +#include >=20 > #include "rte_eventdev.h" > #include "eventdev_pmd.h" > @@ -240,6 +241,17 @@ struct eth_rx_queue_info { >=20 > static struct rte_event_eth_rx_adapter **event_eth_rx_adapter; >=20 > +/* Enable dynamic timestamp field in mbuf */ > +uint64_t event_eth_rx_timestamp_dynflag; > +int event_eth_rx_timestamp_dynfield_offset =3D -1; > + > +static inline rte_mbuf_timestamp_t * > +rxa_timestamp_dynfield(struct rte_mbuf *mbuf) > +{ > + return RTE_MBUF_DYNFIELD(mbuf, > + event_eth_rx_timestamp_dynfield_offset, rte_mbuf_timestamp_t *); > +} > + > static inline int > rxa_validate_id(uint8_t id) > { > @@ -890,8 +902,18 @@ rxa_buffer_mbufs(struct rte_event_eth_rx_adapter *rx= _adapter, > int do_rss; > uint16_t nb_cb; > uint16_t dropped; > + uint64_t ts, ts_mask; >=20 > if (!eth_rx_queue_info->ena_vector) { > + ts =3D m->ol_flags & event_eth_rx_timestamp_dynflag ? > + 0 : rte_get_tsc_cycles(); > + > + /* 0xffff ffff ffff ffff if PKT_RX_TIMESTAMP is set, > + * otherwise 0 > + */ > + ts_mask =3D (uint64_t)(!(m->ol_flags & > + event_eth_rx_timestamp_dynflag)) - 1ULL; > + > /* 0xffff ffff if PKT_RX_RSS_HASH is set, otherwise 0 */ > rss_mask =3D ~(((m->ol_flags & PKT_RX_RSS_HASH) !=3D 0) - 1); > do_rss =3D !rss_mask && !eth_rx_queue_info->flow_id_mask; > @@ -899,6 +921,9 @@ rxa_buffer_mbufs(struct rte_event_eth_rx_adapter *rx_= adapter, > struct rte_event *ev; >=20 > m =3D mbufs[i]; > + *rxa_timestamp_dynfield(m) =3D ts | > + (*rxa_timestamp_dynfield(m) & ts_mask); > + > ev =3D &buf->events[new_tail]; >=20 > rss =3D do_rss ? rxa_do_softrss(m, rx_adapter->rss_key_be) > @@ -2238,6 +2263,14 @@ rte_event_eth_rx_adapter_create_ext(uint8_t id, ui= nt8_t dev_id, > event_eth_rx_adapter[id] =3D rx_adapter; > if (conf_cb =3D=3D rxa_default_conf_cb) > rx_adapter->default_cb_arg =3D 1; > + > + if (rte_mbuf_dyn_rx_timestamp_register( > + &event_eth_rx_timestamp_dynfield_offset, > + &event_eth_rx_timestamp_dynflag) !=3D 0) { > + RTE_EDEV_LOG_ERR("Error registering timestamp field in mbuf\n"); > + return -rte_errno; > + } > + > rte_eventdev_trace_eth_rx_adapter_create(id, dev_id, conf_cb, > conf_arg); > return 0; > -- > 2.6.4 Acked-by: Jay Jayatheerthan