From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8BAE542D60; Wed, 5 Jul 2023 00:30:48 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 783CC410F2; Wed, 5 Jul 2023 00:30:48 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 1F59C406BC for ; Wed, 5 Jul 2023 00:30:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688509846; x=1720045846; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=zOrBxEDb5HNj553efepIMHYVFCmLqBqaQugR97V3iHE=; b=mvSahLaN1RwIjFJAq7L3qwHNJdheeblKRb2hcvvBlQ6FE0fXP7PtbhDc 21JJDjqdZWs57S5OaqVLM6zST9JAgn6NdCJ9ztgzNZr1xCtdk6TAgsUxx mjR+rmyWTULAhlAbAQnSlPRgSwdKX/JcgoKdw8FYviCoNrrVf+ASxNgve uoSlLAdieoKWGbzLNb3O3PNzbcWOkqlJBB74rnASPFqI9g6cnyx1dzvf6 g4PtF7Sx6okbKEjC5D6Ms7hohz+r4ekgqR7ZMPwE5YB/tZNG/Zeuf5PSk raFNIuva2AgfhgzuqOH0IfP2wtYJxZeNGGzRfY/khsjTRYlSArlclqvFG A==; X-IronPort-AV: E=McAfee;i="6600,9927,10761"; a="353030852" X-IronPort-AV: E=Sophos;i="6.01,181,1684825200"; d="scan'208,217";a="353030852" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jul 2023 15:30:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10761"; a="843085811" X-IronPort-AV: E=Sophos;i="6.01,181,1684825200"; d="scan'208,217";a="843085811" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga004.jf.intel.com with ESMTP; 04 Jul 2023 15:30:45 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 4 Jul 2023 15:30:44 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 4 Jul 2023 15:30:43 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Tue, 4 Jul 2023 15:30:43 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.177) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Tue, 4 Jul 2023 15:30:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PgDmvECsCzAvSFECB0KDB8r9cg9b7N152kLBECPMRUFsvNYcoP6r46Nk2AiIC3WVr8JqLoWVDyb27+QGpEspQMcdrDPtH8hmQZuPqn2Lcf4fyX+Spvx9oolPQCDVuDSl73S6Mq4hNQH3Bpk8mrqaI/EHOXhaLYiHkWXpxyORZSxKT5TUdq808vPs+iBPQLoJpOLocLUyDkgymPek84HqLkV099ISubrCupxCZ3guPUurPTcCeXtc46eYV/vBbjvUhpPQhWdEaYEnGor5ScNhbriHNFUl7h5f16DRMD9nXFJ4VYJ2MLxuuqaKRJiaoAVQkdL8QCKBvTle+IZHx3ZfXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uFlvGjKo+GKcUfYLpUr2YUX+sxfgifP6NWU6SUX/AUU=; b=Xd0UYUJfVnKqoEjmHiXW9B27BF8sYZaxrreSg5RTLERKniObX3zU8UmqxYqieQBEjFRo8nikhcB9lHqVB09gB3CjTRakQRMFx7XuujcLAAxLksfpGhBUs0dHlPxgFvSHkcSXheFdctdLWDyMnp+CtgM6cNWEW0o19lVCg5CoQVJ2+duhwYnEUP9q3XSseWEFOp3SRKPBt3gm17TfKQVPCRVHO4qYmuyxvxAzCc2FVz+6DKg6P+mMzl0T7VcDSVf02/1MSWV1Fa9afdDrvjm/xeE2sZGjp+aHZCL1UfUNE5hW0BqU2YpISWbMs8iUaPL/pIbVJTrIagUBb08T3nip7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3408.namprd11.prod.outlook.com (2603:10b6:805:bc::22) by BL1PR11MB6004.namprd11.prod.outlook.com (2603:10b6:208:390::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.17; Tue, 4 Jul 2023 22:30:41 +0000 Received: from SN6PR11MB3408.namprd11.prod.outlook.com ([fe80::121a:92cb:2f78:e53d]) by SN6PR11MB3408.namprd11.prod.outlook.com ([fe80::121a:92cb:2f78:e53d%5]) with mapi id 15.20.6544.024; Tue, 4 Jul 2023 22:30:41 +0000 From: "Ji, Kai" To: "Power, Ciara" , "dev@dpdk.org" CC: "Matz, Olivier" , Akhil Goyal , Fan Zhang Subject: Re: [PATCH] cryptodev: fix device socket ID type Thread-Topic: [PATCH] cryptodev: fix device socket ID type Thread-Index: AQHZqoyzIcXN8De6g0qDK1WwkMIGAa+qOSv3 Date: Tue, 4 Jul 2023 22:30:41 +0000 Message-ID: References: <20230629132155.75075-1-ciara.power@intel.com> In-Reply-To: <20230629132155.75075-1-ciara.power@intel.com> Accept-Language: en-GB, en-US, en-IE Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB3408:EE_|BL1PR11MB6004:EE_ x-ms-office365-filtering-correlation-id: bbca94bf-ee17-4a4a-ca26-08db7cde4c79 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Rl4Vpp5cGHrgG69QHn143fHwhDLBdpg3RjUNHvh2pr1VaM71E2q1gzi5UnwPlK1eBsbnN82bgaK5aJB6+/OJtdOkfUjAcciBfNSeY8SxbAcQu1KPU1o2bqFfA5vtrVdNA+sm/rovAyecqHqawUMbWtUHcq+rJDIU1umNSJR0fpWy3uUWlOPrLZ2I2/r6WiDKxntyNL0UUE0kFLGSsY5weY7J4ISfViAejSg/+GwrBRihDW0kEl9UYojgx8HsiRnihn/XDK5B+yCHEGONuJz48ifntM3/AfxI7Dg6qC3vnDE/mTSzgmgygpqVto0gyUWvsmxYfgFa09e3b9LpSpQbG3KZo0pS5+offy3av7hOwALTTxDPt+fYVN85YfuEcDrr+5r+GH4frsOyWhAPM4soTaUILd96RJ+ixrSnZ3KaazG0lksumvL2sum8k/HbZF3uWp81i97m1SU7JNO6rTuda4CQcQp8ApXvh0YqUTz6CTMuXtUfh4SJHNvJqXgMtQPtCL8DTUVd3+KXOJCMsuMJPXw9UbwUa9ZMEo+jInG4+apB7d5e2r7CEVJLl0DDf8Unzoxoj3FCOaqYubcDhSQ4pQYZ1BJGZnjRDUlCxmTUAw5YpLDS5xzOT9EuhQX3vPFJ x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3408.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(376002)(346002)(366004)(396003)(136003)(39860400002)(451199021)(9686003)(7696005)(478600001)(54906003)(110136005)(53546011)(6506007)(71200400001)(186003)(26005)(2906002)(66446008)(91956017)(64756008)(66476007)(33656002)(76116006)(4326008)(66946007)(41300700001)(8936002)(52536014)(8676002)(5660300002)(66556008)(82960400001)(316002)(38100700002)(122000001)(86362001)(55016003)(38070700005)(83380400001)(19627405001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wrkxVdWbPJqL/r6k3BaJQta6EbaEX3sjcmFSekEEDyHQE9fMu0P1EqMRQQkY?= =?us-ascii?Q?d1c4KYC/l+un3cJSp+5TE58wfU87GDJ/ghQZJ9WkgO3LYcutUorGNCWxO+PX?= =?us-ascii?Q?hsVTOCO4dyCWNfo8+dFd3qKkSaNdGRChbuIfYtoiMkwRdq2YfdnogWHRl5nA?= =?us-ascii?Q?17+ce8DhwFU0n5ZRnhY+uKaTr8AxBEr7n8gIESVW/kz7O/V/ZG8xvsB32Vam?= =?us-ascii?Q?q19EcjuOypXId0cAjxRR6pvwRihoAVSTcp7YNHAzo1RoPZztAg5oyUW/wiS8?= =?us-ascii?Q?fS7egtKtrC+VIdCWesgNRAuT+o7hCVlKTGYKGXb+bP/gKrOr/28tLsGyu5VF?= =?us-ascii?Q?U6Hj6PKOn1NFLBfsbJByL4snuHvCpeU+9fzpUd4S6sR/hHGXLxZXPQJHPIpl?= =?us-ascii?Q?ab2zPovuhPDjwZNwhe64lHdygLyHKW44z4EiiSMjQj7JZZRLxZG433Iz4xVY?= =?us-ascii?Q?hwePkBdbjBHdosf93TU05Ikfuy8S2hIKOuDEffK/sst37QMdxSEGZhjKwAzy?= =?us-ascii?Q?QPGAg1tQRw0nQ+l1Woyn9zH/nqzBwrX7W/fOT8IxE1N9pibai+r0CO+i0L+l?= =?us-ascii?Q?YmIlvDPBP6j74IKJTtgz3g9/Eqm2sxEvPxzKm27NExtnzb+1M4YwEW7zCG7V?= =?us-ascii?Q?mnhXmZlTpE/BGR/ML0yO0bre0UA2xKw9Qkv/m5rm8pM4aPu5aCRDK1KC8HvM?= =?us-ascii?Q?bHL3j0b4CFFYHttUPGaX4FhFHPkcF6KN/bj1ujGkG5l1SFGNdsvmLXTRMvfn?= =?us-ascii?Q?PFzuKI9aE2BmNxwVZ9RuC55Coh4fuS6LMfDqiYE/gP1I7zxFYm4ihlwTW+/V?= =?us-ascii?Q?QD3qVumPFu5umKuceybtNrpZ9VtshjBRoP4qDYAYUwTE4efuG2Zt3RB1/dX/?= =?us-ascii?Q?y9YTczYXj6gOSFo7Wtlp2oECUI551i1rrpnBDpi0LW4TZuqND9E9tMU/31wA?= =?us-ascii?Q?PZErhUJcHb5qOreDcqMGZL9eVrJecEopaUUbB6TRZOzFMOYMM5hEdWnlatvJ?= =?us-ascii?Q?HfKkZXzigr3uiq4zVslFjDHB5myXh9NO3wloBTXEvsH5Mx0tSFawRdjZMr4j?= =?us-ascii?Q?xh+gSP+Ap1Ug6Yb1v5oCnFuJZpdU7b42qd7tBeXj04TyTxNdvtsYbwyjx+2J?= =?us-ascii?Q?UJD0uq4zZ3uXHLLYFnmufzRk8Mj20Zk6qLTnETATV4RUR1bBl6sgivHRID/A?= =?us-ascii?Q?4b0Q4deUixy8LpADxY70Z3YqmLpeEkuOn+QZgXgSPV//3V3SMojCvMgp9Kij?= =?us-ascii?Q?mIjNUaXZpr/PdS6sLdj/NtZCsFuOtNbro4pCnYWkxRkSZuBkN2PEjU/R08qv?= =?us-ascii?Q?H9Lay2rH1N5UVdBn3F27W2rwlQrnIVwzYF1Tc2GLdRs7fdUqwGUVej0z8+Iz?= =?us-ascii?Q?0FlZSd78bv7Kk9n2/2wHumMA3L5lK55/CK5H5CdadlhETsg7UKFG5MESblQv?= =?us-ascii?Q?zgFo5Pt4GANHcLPNF8OvzCkhIekOE6t3HFNIVGi/U6sD/calnu+SdaN1ACbi?= =?us-ascii?Q?c53s8lcMTzR1LzNiLKKe/J+fGtghX1Iez7V4lRR5y/2lSRrLPj+eHEdElLJV?= =?us-ascii?Q?OGlmxZFg3dkX8blMJV8=3D?= Content-Type: multipart/alternative; boundary="_000_SN6PR11MB34082127B1ABA0DD95C2E5CC812EASN6PR11MB3408namp_" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3408.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bbca94bf-ee17-4a4a-ca26-08db7cde4c79 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jul 2023 22:30:41.0441 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2MnLZqos92vy7wdK+/P+Vgrr1T9+C4z2Fe/i5Kvfig/t6HrQHGq5yuJX+xhtay1xNZlHjm7YFY6Q1KQyozPS2Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB6004 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --_000_SN6PR11MB34082127B1ABA0DD95C2E5CC812EASN6PR11MB3408namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Acked-by: Kai Ji > ________________________________ From: Power, Ciara Sent: 29 June 2023 14:21 To: dev@dpdk.org Cc: Ji, Kai ; Power, Ciara ; Matz,= Olivier ; Akhil Goyal ; Fan Zh= ang Subject: [PATCH] cryptodev: fix device socket ID type The socket ID field for a cryptodev device data was unsigned int. Due to recent changes to the default device socket ID, this caused an issue when the socket ID was unknown and set to -1. The device socket ID wrapped around to 255, and caused errors when allocating memory. Changing this field type to int fixes the issue, as it now takes the correct -1 value. Fixes: 7dcd73e37965 ("drivers/bus: set device NUMA node to unknown by defau= lt") Cc: olivier.matz@6wind.com Signed-off-by: Ciara Power --- lib/cryptodev/cryptodev_pmd.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/cryptodev/cryptodev_pmd.h b/lib/cryptodev/cryptodev_pmd.h index 8710ed7558..4c98cedca6 100644 --- a/lib/cryptodev/cryptodev_pmd.h +++ b/lib/cryptodev/cryptodev_pmd.h @@ -65,7 +65,7 @@ struct rte_cryptodev_data { /** Device ID for this instance */ uint8_t dev_id; /** Socket ID where memory is allocated */ - uint8_t socket_id; + int socket_id; /** Unique identifier name */ char name[RTE_CRYPTODEV_NAME_MAX_LEN]; -- 2.25.1 --_000_SN6PR11MB34082127B1ABA0DD95C2E5CC812EASN6PR11MB3408namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Acked-by: Kai Ji <kai.ji@intel.com>
From: Power, Ciara <ciar= a.power@intel.com>
Sent: 29 June 2023 14:21
To: dev@dpdk.org <dev@dpdk.org>
Cc: Ji, Kai <kai.ji@intel.com>; Power, Ciara <ciara.power@i= ntel.com>; Matz, Olivier <olivier.matz@6wind.com>; Akhil Goyal <= ;gakhil@marvell.com>; Fan Zhang <fanzhang.oss@gmail.com>
Subject: [PATCH] cryptodev: fix device socket ID type
 
The socket ID field for a cryptodev device data wa= s unsigned int.
Due to recent changes to the default device socket ID,
this caused an issue when the socket ID was unknown and set to -1.
The device socket ID wrapped around to 255,
and caused errors when allocating memory.

Changing this field type to int fixes the issue, as it now takes the
correct -1 value.

Fixes: 7dcd73e37965 ("drivers/bus: set device NUMA node to unknown by = default")
Cc: olivier.matz@6wind.com

Signed-off-by: Ciara Power <ciara.power@intel.com>
---
 lib/cryptodev/cryptodev_pmd.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/cryptodev/cryptodev_pmd.h b/lib/cryptodev/cryptodev_pmd.h<= br> index 8710ed7558..4c98cedca6 100644
--- a/lib/cryptodev/cryptodev_pmd.h
+++ b/lib/cryptodev/cryptodev_pmd.h
@@ -65,7 +65,7 @@ struct rte_cryptodev_data {
         /** Device ID for this ins= tance */
         uint8_t dev_id;
         /** Socket ID where memory= is allocated */
-       uint8_t socket_id;
+       int socket_id;
         /** Unique identifier name= */
         char name[RTE_CRYPTODEV_NA= ME_MAX_LEN];
 
--
2.25.1

--_000_SN6PR11MB34082127B1ABA0DD95C2E5CC812EASN6PR11MB3408namp_--