From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 79BD342D60; Wed, 5 Jul 2023 00:30:09 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 04ED040A8B; Wed, 5 Jul 2023 00:30:09 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 04662406BC for ; Wed, 5 Jul 2023 00:30:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688509807; x=1720045807; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=CsyGUbiEBzDp38hp8ezeDZhcBd589rLXMaCacujJrYo=; b=e4hXFWRXsWMBvhyWf5zN4Sgp7HwaCr2eF1KkHMXTIKdr+HgNBY4iY3fA rA8wn6gT503BaZKO/s+9MD3zcXPMGp3LtNY0tHCyt8k22/sJmRjjb7qf2 PiaFvZJE9NVTrMXF9n8FZz3ajE3dy1yoEEdALwhMalW6Db5lhdnazlqVT rEyPvQz+aL519Oyw+4hkGGq7G2cPx5QnfxYGk23sz0bbx81bx4ZmubWas frnIbB1LBNdHTZRBDVh30ix9q9khazf/5Pof/1KmoT4Za2FPNju8M5rbM DKMlxlob7vzOwkyJBMdDKXw5k+jI9V1My873iDeakJdJo7RxTyYx7ekie Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10761"; a="449570786" X-IronPort-AV: E=Sophos;i="6.01,181,1684825200"; d="scan'208,217";a="449570786" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jul 2023 15:30:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10761"; a="712975294" X-IronPort-AV: E=Sophos;i="6.01,181,1684825200"; d="scan'208,217";a="712975294" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga007.jf.intel.com with ESMTP; 04 Jul 2023 15:30:05 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 4 Jul 2023 15:30:05 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 4 Jul 2023 15:30:04 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Tue, 4 Jul 2023 15:30:04 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Tue, 4 Jul 2023 15:30:04 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cFGRVd4fy2LglMfcPiBDm4mDd2sEtLWI4kQcg1xMx5j92JhwhdwoSxncyw//QRsOqjVjLw5Uqnp2ynOMMpba9boNQZdyiqEYncEspMtczDOy3nwNAFpT6FdbrAaLpMhJwwqhYJLcUslAI/0eVphwZSZmjgNTGvX+F5ked7jsQKW2ZPOsUvZQoS3NxPCpD2z56+AXVsAUGWht915te+8yU8Myl3AeNqiF7UipCD6f0GAZpdicTL+hTwcOlicX/W3ZW7TV78pTLiuupC3COJyENoaqzV8vSm/J5L4XHRX0kZLAshGKEd9y8GfSpx++NRpzHxjZqhAtYw6/hCTYaATAqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zK3VdnVHKUi/8pxy7er2I75lyv8F2CQnQnKEoUeH+U8=; b=ZQG4ltfl8RZKiJfhpq5t7l/CIicIjdyZwJ+gB33EU6yq5x86yxhcPraB6lB0nijAccPiuPTBp5KdIO8eib8J0nW9nGY4KxAPbmtr5KPBGqZvR/RRk6EIS+MViPSvlru5AKX51i4HXEFGD5Un3xSVPmnHC5xtTltqEUlq9tiOYaeaRaNfgBA8qh1ruIWgUgg8DPvS8ms4cEWSwHkoSVuOegQR7BaVOwxC+VR1dkLZxu/YUYQjEZ6BibwfKuJASARxTY9fSSdagd+g7hx7gQ7pKyeCWMmybhH9VfLJXpL1QVJ8cpRmqCx9ZlKTCCcqEI4Z2LCdG6lrWMBS2/tb3RNOyw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3408.namprd11.prod.outlook.com (2603:10b6:805:bc::22) by BL1PR11MB6004.namprd11.prod.outlook.com (2603:10b6:208:390::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.17; Tue, 4 Jul 2023 22:30:02 +0000 Received: from SN6PR11MB3408.namprd11.prod.outlook.com ([fe80::121a:92cb:2f78:e53d]) by SN6PR11MB3408.namprd11.prod.outlook.com ([fe80::121a:92cb:2f78:e53d%5]) with mapi id 15.20.6544.024; Tue, 4 Jul 2023 22:30:02 +0000 From: "Ji, Kai" To: "Power, Ciara" , "dev@dpdk.org" CC: "De Lara Guarch, Pablo" Subject: Re: [PATCH] drivers/ipsec_mb: fix aesni_mb set session ID Thread-Topic: [PATCH] drivers/ipsec_mb: fix aesni_mb set session ID Thread-Index: AQHZqy3LOegrzuviUkiOzpehX3n8dK+qN6cd Date: Tue, 4 Jul 2023 22:30:01 +0000 Message-ID: References: <20230630083441.429989-1-ciara.power@intel.com> In-Reply-To: <20230630083441.429989-1-ciara.power@intel.com> Accept-Language: en-GB, en-US, en-IE Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB3408:EE_|BL1PR11MB6004:EE_ x-ms-office365-filtering-correlation-id: 47870822-6c5a-4e2a-ad9f-08db7cde34ff x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: bc6mYFvnrqG+lE/jB5hvWoMrqO95KU9Pg7CwayqU2SQ/m1thQyRCSAhnouXuxtgkcdi61kYz9wlTi4wuzrBMpQt+RJKHjKND4ajizjcWVTlH+5uqfbqFnCqMKUgalsUQthTOvDfnZfccD35OOmjQ4wCWp/IWozi1DZHee3s7SIql2z/xp9saKKldnmKzZwkiSx/J8L1pgsXGhnISYdRT9ltFI6FTP62b+1Hx96ksWKAQnLFRFEGiFk3SUP4p47y1cgzWvmaVKHzjfpDjRIEj5rQZUiOreBdJf5NlpFRLkw3TXrVS4nYoQTs4z2AfDqiih6KzfBICr3w6NcyKyahFShNoxzqN6Ee2PUue8bmAXN0My19mbYUq7Sfq5xr4yVNl+LHwnSkBKYOFb+tHHC6tC7UbRUHIVmc7QTzcxKbUv01ofbcc/PL8fHQwZaIYiBBIETqSlpgdCRbM1wEOeyF1sIV3nfKBTCRX8l5QsNjMeTBrZxgtVfXRZ66bI5lMWR55iv4EbOtliAW/gJzJGqaxQO2ptRei/n2lKpVz5hMT9QfN/dVSPzDRqVGHLum5mtZVUeKu0zfW/AufZgWrpfCc+QVSBBLVu6wLHH6MgvH+VItmoRszRcX6OVOYzA0eMAxL x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3408.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(376002)(346002)(366004)(396003)(136003)(39860400002)(451199021)(9686003)(7696005)(478600001)(110136005)(53546011)(107886003)(6506007)(71200400001)(186003)(26005)(2906002)(66446008)(91956017)(64756008)(66476007)(33656002)(76116006)(4326008)(66946007)(41300700001)(8936002)(52536014)(8676002)(5660300002)(66556008)(82960400001)(316002)(38100700002)(122000001)(86362001)(55016003)(38070700005)(83380400001)(19627405001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?kO9ec3ls8sgczL3PMlpRYacbRlOiryiVEEP0iLdzHPE4hjyAki65uFeWM683?= =?us-ascii?Q?t+RObdE910qwBPCeVg4WzGG/Y7+rfQxllqyUtb56S06XRTO4+egAIxzX0Z8l?= =?us-ascii?Q?3N+iiNec8AyJDGFXMItC5XxSzvrc1YFIXS+zcF46YiBU/rYQR6gZdJfU0f7v?= =?us-ascii?Q?TxXaKa8A/wptblIIUA9OyOUWcVMgZbuRpnJF4aDK57VvdfNvUtUwl/PuMCzd?= =?us-ascii?Q?cm+V0McXWJwY7B+o3FvL8hvWsZ1QpAuMNGqdj8ydXeD3orUhExZOQcuk4yDB?= =?us-ascii?Q?CAkYqRb3zNPkxFHlxap26Hv0EfWaJ9AyzLuMJsG+N3k3vo3m2NV/+KBRdgEo?= =?us-ascii?Q?g+czmWGLH4THI9hFkgJhhB5WuqmY0iFj8eg3WA0Ay/SFFzoGibPe9BHITwQq?= =?us-ascii?Q?MYBtx95hZzU8LizfNJLmxyrD3fiK6XH+DzuBDM9DA7GQaBPXaUyWQfOFHr3V?= =?us-ascii?Q?i+PUKKzjrHP/bj/EoCIi/Se4WhAkf8JqnaZ9jS0UJ3eRcaZ/hcBYwQ0NfVLA?= =?us-ascii?Q?JTwfMBmwL9np/nwerrjNm4wybIsUifWOtSAPiHyZfzPdqIe1WVZxQdh6UuRY?= =?us-ascii?Q?0dgVgkJZKHcxL5jHJ/rVKQnI31ocNL0AT5U2H/ZrP5Yq3kC/5Y8WKXHP6DA/?= =?us-ascii?Q?piylpYEH3wXViRUBfkwIu4Oh/Q5Zqx0qtuBtL7iaTET6BlHkxhAdHmebuH+D?= =?us-ascii?Q?uocyEbtBDPMkxWHWwZotfGqwqom+9e4u1jLtPn6+E+v4bjvmyM7v2qlvKfT4?= =?us-ascii?Q?Hd+H1NwOXq780SADqEEH8TirpM5QxbG4kWL7Q9N7Z+COyjLtC02Zeyl0Z/Wk?= =?us-ascii?Q?KqwP7kIjTa4qGCXmWYUAiOUbCj1ki3HDEK5jOrVbH8JH2RJROQrVRKuvz6e5?= =?us-ascii?Q?2eHJPPOhpRjQ3QwVYigZDA/Yjhd2xwyTrtepiNhPsHWWT7631g+fI78n26eo?= =?us-ascii?Q?NnF+S0eSg67PNwg9iN9jaGCCxlxyUa0fNxeRj0NFCpSOdc9XqfSY9/8CPlOV?= =?us-ascii?Q?gczQ1pCKeb6TpyVYGMJ/UCM+yE4h32BijzKfT/ecJIgv8URXmbPiGS4M0cJf?= =?us-ascii?Q?vbqovYMcOMxMDNzFy6qCzYJ+Hgo2ncQpEXxbURj2EbuL8jzhfv7IXUqLwp0e?= =?us-ascii?Q?nhHPwXWiPvsuVHgK7IkbkF1VZM/Pe+3a09bSM2iPSI2lpwe7OoRYgMzd9hyx?= =?us-ascii?Q?aeVR0dWgqVIVGziq3qCtKCwE4tNLgtITDvxjO0f6xswZ8HmqdhMz3bu9h/rz?= =?us-ascii?Q?nmktwJtM3lhnq4PUWxXXgD1B4OG/iR2awebfY1sZgRwZHVe1jHcCSmQIdwHf?= =?us-ascii?Q?eJm0ctuqjRZKM6LT/6ccQkPQEC6CCTsaqsJB19uwsONBSfr6NyoqdTiGsROl?= =?us-ascii?Q?7mTpz94xkqui34iOE8y3dWBazVlNAfeDpmR7lWBxeGHgf4du3v123Xeg6nev?= =?us-ascii?Q?9FFIr+Knuy9UjhaCfpkHP1bYzJ1gjmlNOpAO9u+IyzOHz9HA/zMIz5U0XP2W?= =?us-ascii?Q?Fc/n4e7PrY3PcxwWdqwg8ZqY+isV5dGzSRSxTbeTOqZeXsI31SkTCGB5WSha?= =?us-ascii?Q?Bxa8gv4DHozh92L54oY=3D?= Content-Type: multipart/alternative; boundary="_000_SN6PR11MB340846B31B14DFE21E4FAEA7812EASN6PR11MB3408namp_" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3408.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 47870822-6c5a-4e2a-ad9f-08db7cde34ff X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jul 2023 22:30:01.6194 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fkhOXNQTKzS6TJuFHJyOZ7QkgtOuhUF7ioHP6YcgTqlL9wZ/EDka5FgFTTlN3wDk463C80hNQelVnwZQLYSg6g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB6004 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --_000_SN6PR11MB340846B31B14DFE21E4FAEA7812EASN6PR11MB3408namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Acked-by: Kai Ji > ________________________________ From: Power, Ciara Sent: 30 June 2023 09:34 To: dev@dpdk.org Cc: Ji, Kai ; Power, Ciara ; De La= ra Guarch, Pablo Subject: [PATCH] drivers/ipsec_mb: fix aesni_mb set session ID In the case of multiprocess, when the same session is being used for both primary and secondary processes, the session ID will be the same. However the pointers are not available to the secondary process, so in this case when the session was created by a different process ID, then copy the template session to the job again. Fixes: 0fb4834e00af ("crypto/ipsec_mb: set and use session ID") Cc: pablo.de.lara.guarch@intel.com Signed-off-by: Ciara Power --- drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 8 +++++++- drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h | 2 ++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c b/drivers/crypto/ipsec_= mb/pmd_aesni_mb.c index f4322d9af4..555b59621d 100644 --- a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c +++ b/drivers/crypto/ipsec_mb/pmd_aesni_mb.c @@ -2,6 +2,8 @@ * Copyright(c) 2015-2021 Intel Corporation */ +#include + #include "pmd_aesni_mb_priv.h" struct aesni_mb_op_buf_data { @@ -847,6 +849,7 @@ aesni_mb_session_configure(IMB_MGR *mb_mgr, #if IMB_VERSION(1, 3, 0) < IMB_VERSION_NUM sess->session_id =3D imb_set_session(mb_mgr, &sess->template_job); + sess->pid =3D getpid(); #endif return 0; @@ -1482,7 +1485,10 @@ set_mb_job_params(IMB_JOB *job, struct ipsec_mb_qp *= qp, session->template_job.cipher_mode; #if IMB_VERSION(1, 3, 0) < IMB_VERSION_NUM - if (job->session_id !=3D session->session_id) + if (session->pid !=3D getpid()) { + memcpy(job, &session->template_job, sizeof(IMB_JOB)); + imb_set_session(mb_mgr, job); + } else if (job->session_id !=3D session->session_id) #endif memcpy(job, &session->template_job, sizeof(IMB_JOB)); diff --git a/drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h b/drivers/crypto/i= psec_mb/pmd_aesni_mb_priv.h index 4ffbe4b282..3f6cf30c39 100644 --- a/drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h +++ b/drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h @@ -854,6 +854,8 @@ struct aesni_mb_session { /*< Template job structure */ uint32_t session_id; /*< IPSec MB session ID */ + pid_t pid; + /*< Process ID that created session */ struct { uint16_t offset; } iv; -- 2.25.1 --_000_SN6PR11MB340846B31B14DFE21E4FAEA7812EASN6PR11MB3408namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Acked-by: Kai Ji <kai.ji@intel.com>
From: Power, Ciara <ciar= a.power@intel.com>
Sent: 30 June 2023 09:34
To: dev@dpdk.org <dev@dpdk.org>
Cc: Ji, Kai <kai.ji@intel.com>; Power, Ciara <ciara.power@i= ntel.com>; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com><= br> Subject: [PATCH] drivers/ipsec_mb: fix aesni_mb set session ID
 
In the case of multiprocess, when the same session= is being used for both
primary and secondary processes, the session ID will be the same.
However the pointers are not available to the secondary process, so in this=
case when the session was created by a different process ID, then copy
the template session to the job again.

Fixes: 0fb4834e00af ("crypto/ipsec_mb: set and use session ID") Cc: pablo.de.lara.guarch@intel.com

Signed-off-by: Ciara Power <ciara.power@intel.com>
---
 drivers/crypto/ipsec_mb/pmd_aesni_mb.c      = | 8 +++++++-
 drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h | 2 ++
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c b/drivers/crypto/ipsec_= mb/pmd_aesni_mb.c
index f4322d9af4..555b59621d 100644
--- a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c
+++ b/drivers/crypto/ipsec_mb/pmd_aesni_mb.c
@@ -2,6 +2,8 @@
  * Copyright(c) 2015-2021 Intel Corporation
  */
 
+#include <unistd.h>
+
 #include "pmd_aesni_mb_priv.h"
 
 struct aesni_mb_op_buf_data {
@@ -847,6 +849,7 @@ aesni_mb_session_configure(IMB_MGR *mb_mgr,
 
 #if IMB_VERSION(1, 3, 0) < IMB_VERSION_NUM
         sess->session_id =3D im= b_set_session(mb_mgr, &sess->template_job);
+       sess->pid =3D getpid();
 #endif
 
         return 0;
@@ -1482,7 +1485,10 @@ set_mb_job_params(IMB_JOB *job, struct ipsec_mb_qp *= qp,
            &nb= sp;            sessi= on->template_job.cipher_mode;
 
 #if IMB_VERSION(1, 3, 0) < IMB_VERSION_NUM
-       if (job->session_id !=3D session-&= gt;session_id)
+       if (session->pid !=3D getpid()) {<= br> +            &n= bsp;  memcpy(job, &session->template_job, sizeof(IMB_JOB));
+            &n= bsp;  imb_set_session(mb_mgr, job);
+       } else if (job->session_id !=3D se= ssion->session_id)
 #endif
            &nb= sp;    memcpy(job, &session->template_job, sizeof(IMB= _JOB));
 
diff --git a/drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h b/drivers/crypto/i= psec_mb/pmd_aesni_mb_priv.h
index 4ffbe4b282..3f6cf30c39 100644
--- a/drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h
+++ b/drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h
@@ -854,6 +854,8 @@ struct aesni_mb_session {
         /*< Template job struct= ure */
         uint32_t session_id;
         /*< IPSec MB session ID= */
+       pid_t pid;
+       /*< Process ID that created sessio= n */
         struct {
            &nb= sp;    uint16_t offset;
         } iv;
--
2.25.1

--_000_SN6PR11MB340846B31B14DFE21E4FAEA7812EASN6PR11MB3408namp_--