From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 343D442D07; Tue, 20 Jun 2023 12:02:03 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B75E34068E; Tue, 20 Jun 2023 12:02:02 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 6D6F5400D6; Tue, 20 Jun 2023 12:02:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687255320; x=1718791320; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=el++btqG/gu2Z6FxN1yYKPhrAT0auVWzAC+Q6vvsR8M=; b=Ub1C93v9OhPRIfDw1noNnCMojCcLHmjB6ibgOcEXk4NncLKM7O7ebwqq sA8RGiE88nFdX69iOo5bC4npY3Wbu4FC65Tnuc3m3efHxEXSGB+JEROoB UtnzjvK2loUV9piyKFAfXcbNqhG1JuVDY5afL+Yjc5V0LFO67HaY0F1+I c8WmItLrlal0do6D/aQiRDPjQ24+khhGOA9ThwWhM6ytl5/tsBqw9eYug n6YEj7H5Y5aCx1DjkI/MLilU1bECBEKU54GMevNZzf57jlJkGYkLo5ok4 +f4lrcyndZyL2W45ZTNAg7K8ITUi8vVcTt8GW5FLIhRXYAxqLYMZSEeel Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10746"; a="446194037" X-IronPort-AV: E=Sophos;i="6.00,256,1681196400"; d="scan'208,217";a="446194037" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jun 2023 03:01:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10746"; a="784013100" X-IronPort-AV: E=Sophos;i="6.00,256,1681196400"; d="scan'208,217";a="784013100" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga004.fm.intel.com with ESMTP; 20 Jun 2023 03:01:59 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 20 Jun 2023 03:01:58 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Tue, 20 Jun 2023 03:01:58 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.173) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Tue, 20 Jun 2023 03:01:56 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bVYfveWvGIPc7EerMZMetE18b9xBPIFzPbCgFZkTXPopxqaY4NCZ6MHqNMxdvd/4KaMoi2JrYS8jI+Zr7vssMhbaKSxQQm5ThAYbGuNEG5GbqpOx4frLkkz0l167ZuXeTE17qe6vvus6wJPzZzc+s3T3NtsfheJEH5D4YJGH/lcPhqJw6Nn+CXUD79dzR1hZyi1ySTsM40rx2SMT8RKnOBfOsh3J/CYrFBw+JyfA5beJPSDCU42GIcWrU61gRNOC96Pen5O46kq4hBXyW3azMN7yLzNfD2oT3mmV+fKGaGp9RdgvoNepdpYG2At+hcWgQAfOGbGI+qUjxJvRtT8f5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=el++btqG/gu2Z6FxN1yYKPhrAT0auVWzAC+Q6vvsR8M=; b=aBXu+WDMb2YlE7BAXJHtTvBYVmHPNMa0OwPLrXWrIbS2nKZMgL5zh8wDWu2wyPducafUUO8r1bPYv/D3/AAM1NcWhYiyex96fUh/qxZgevWM4ZoMkGbmp+3mo7pZj+4QqfXA3v5OLvLhfTQW4xNsun1PeOmDmgr7Pd7D5l/uk9vANacIafcf+J0L5zOY50iF09+jLartXo9qQFPdpAqs8MC/WUI+piPQSJAKUaxF20n/jg3vLLf6s3fX+bwOG+YRv5P9mX9S4qAVxf9nkxV6LLlsc9d5Y0/huME+OavZvTuwNgDVJtGPUToUsxlLmRI1rsi7xHUGLjKzEHWg0QquaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3408.namprd11.prod.outlook.com (2603:10b6:805:bc::22) by CY8PR11MB7873.namprd11.prod.outlook.com (2603:10b6:930:79::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.21; Tue, 20 Jun 2023 10:01:51 +0000 Received: from SN6PR11MB3408.namprd11.prod.outlook.com ([fe80::121a:92cb:2f78:e53d]) by SN6PR11MB3408.namprd11.prod.outlook.com ([fe80::121a:92cb:2f78:e53d%5]) with mapi id 15.20.6500.036; Tue, 20 Jun 2023 10:01:51 +0000 From: "Ji, Kai" To: "dev@dpdk.org" , "pallard, didier" CC: dpdk stable , Akhil Goyal , Fan Zhang , "asekhar@marvell.com" Subject: Re: [PATCH] crypto/openssl: fix memory leak in auth processing function Thread-Topic: [PATCH] crypto/openssl: fix memory leak in auth processing function Thread-Index: AQHZcgHe+NzJjesjyUOa5fhhafbx7q+T1zowgAAAJzs= Date: Tue, 20 Jun 2023 10:01:51 +0000 Message-ID: References: <20230418142619.2643428-1-didier.pallard@6wind.com> In-Reply-To: Accept-Language: en-GB, en-US, en-IE Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB3408:EE_|CY8PR11MB7873:EE_ x-ms-office365-filtering-correlation-id: b487e869-aaeb-4eda-cd1c-08db71755e64 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: D+ff83wJ3kI1fO3vroqpqgt61txbyrGVJM9G9CJ138P+j55ABLrujgEodME54gDsGTP9fuK58bHvipvz6DSdnEhfGXZCL2tpPY6ifQpGZ1HvHYNzkq3U86w+2AOl3+wLb9SLdwkuVQBjl3QZ1sAhW8nzpDzc/p1idUx37mA5y1BCExYtJ+xISVrttN/ti6pKDuBZeOpK7ZMd2tCe4K2IMY1SZO4O/+7O2OTGYWj74krAzl/kWJZ3M3+STg81IabRM7C8gMdIbnWY2QyNBUL/3MAmpU7m78E+TJTgNfyHt81OSrS2dd1GtsbtkDheg+e6CpVAKO2oSuSTi4mRXMRB9a0evj5vKXYQMDcc9bKRoE7Bm3XJWxpimhALPb1Oy+qCKbfWTTScuFdnEItliSY4VeiK+S5BnecfsoKmBeSg2VTz5fbbEEuZ7hlM3w14lQ1SqUYn4vIp886HxFqfHllkm7qSVDddW1czxmGo8KOrFZeikyESYFaEG6M2k5UjIe2wuqSV52BcNW+wy1E5W4PNMk6pLkqbZ+YCZjZEnKF+C6YwfCnpWxiZmakTXfzgwCPlXbZL75iP7atAfRc9N0OeozPwI2f+Qd67rWseGMszF3goIqRCYC1gONXfZOHs3+BP x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3408.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(396003)(136003)(376002)(346002)(39860400002)(366004)(451199021)(71200400001)(7696005)(478600001)(33656002)(186003)(53546011)(6506007)(26005)(9686003)(83380400001)(38070700005)(86362001)(38100700002)(122000001)(82960400001)(55016003)(4326008)(91956017)(66556008)(66446008)(64756008)(66946007)(76116006)(66476007)(316002)(19627405001)(8936002)(8676002)(52536014)(5660300002)(41300700001)(2906002)(4744005)(54906003)(110136005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?c9xVaFOgz+7Po4haGg8oza+8e+x2Ma6WITubTk8NVEIm6JFZg1EvecPYpu?= =?iso-8859-1?Q?VWYUMVNRUeXi/eZQKFL/S+mDf2lM8v3vaQcB6PNoumrnvaMIhk2FYF59g7?= =?iso-8859-1?Q?MgxAwbSDZ68OR2lnPr5xPVsbBnjyE9MwCMj7Y0QJdSwv1pdG9l6cuCQz1O?= =?iso-8859-1?Q?Pvd8JWl1IHQaGccVx1zzCfGOgcfZW6N11t6vWPhb05EJzUHAOhDM8T62/e?= =?iso-8859-1?Q?VfqjdLhpBKKAtd+xIDM9dwx5xn7GaqkZ1TlTUrWtfprvOj9AqdFD+RYTXW?= =?iso-8859-1?Q?KRRTBCF0Aw1df6uqhDfyXi79oxdZCXqkpB8zTIPbDL02eFWwrkbJvZquku?= =?iso-8859-1?Q?yrcjDxNaHYI7bkR41oZFL5hED2IhAxgL4o6KXyr+KBtCu5D8uUwwuzSF1g?= =?iso-8859-1?Q?RUcjrHbQyciyxBQYFpe3XSy62uG02uF3grckd5W0HE/Gli7JEmLXRXxUu+?= =?iso-8859-1?Q?sVxCm3gC6nIfXr2siZWm9czTEWXhK9zwe6ALOEpwhkACg+cbw7cC7PfE6x?= =?iso-8859-1?Q?tRl5tLsxbhta00OScZywdaRiD9umo+HR6lvQCK60aYT8tJn56fWp6YtEIn?= =?iso-8859-1?Q?PIcx5T4WgTOCaXX7eQ0h2MIru5nfretK+2PSWdzQWNKSR5X9f/NWi9RNBa?= =?iso-8859-1?Q?nW4v9oMmfFxNVfptNiWVcP25ffksHJeKe99SfF+Zyh8UcnO2/c6CGHegwp?= =?iso-8859-1?Q?UFshr5P7BITxjqsw3+fNnh+rhxKJxz+X3oXhQcl+4Rx+ixbYDylsViLAuc?= =?iso-8859-1?Q?/mVacLKDlk6VITZAPYbjT4pQao5R/aJXcw+u0DksNOiWsQyDQ596B5kS4r?= =?iso-8859-1?Q?cPkj7xZlNLGGiycYzB8vL2eFTgWhGac0WC1XjNdj/96VqPMzCatbJKMwpM?= =?iso-8859-1?Q?kqCKrEIXaqhvno6mDE79DrL271nhOHYgXTxxcqraXTXHHwB1TiOHuGGRrE?= =?iso-8859-1?Q?nHm24/OwGrfb6E9C7rT1oUtrhgUzNvJ8w8fobNgckdr0rJHIKcyCEOK4rs?= =?iso-8859-1?Q?TO2ThJ927Swx5tRuYEcwJaZQruypCAghv6RS3w2/nU97MNcf4/MtnxDlPu?= =?iso-8859-1?Q?BM7j9vMhzP/1O6LlHxjQf6DPdQsHz7vwYwMe0HYTYRusi5FcPRpSVRQfbH?= =?iso-8859-1?Q?7RR2CxuBh+xVnCPy0sEJOAPBjYXdGZGsg0OZzUaDFfT1f1lQUt4zql3vMi?= =?iso-8859-1?Q?V4IS4laNrlP4UtqmnFFQ8SZydxoh8sc0ekAIjYPUStYbd1sLUmjGblbZvK?= =?iso-8859-1?Q?wX7p1AK4z7sz8mV0aSHIHmU06O07alKgdcjXgs5OwjlLJh2rPTl7y5fl30?= =?iso-8859-1?Q?ctVt+K6msMqxC0bQ97/RlfSYiHRsGW7XMxB/4NjPrCz7DXr89/O2PtTg1d?= =?iso-8859-1?Q?xcxGOcccmcABcelC/ZIqQZTui1Yxf/QTZD2HEm45cNppQN8/OU8iwlnCMY?= =?iso-8859-1?Q?iEy9LRODnQvP5+h2pU3gkO+Si+ghVBqNnUmVCrDngDItTGI03J0nnHpuG/?= =?iso-8859-1?Q?B3wlYCww6ZgHWfM6BisLuWqGOyVHrzlyDsbvSEAsyjaFrBHffAMMBHPXn2?= =?iso-8859-1?Q?H8GFtjQFTdMUr0s9eOpJx0K0G+GzsbXFvg5HZacyioP0i72GZlpRzDcKxG?= =?iso-8859-1?Q?5e6eCcEj6JAQc=3D?= Content-Type: multipart/alternative; boundary="_000_SN6PR11MB34086C12F50B0ED92AB90687815CASN6PR11MB3408namp_" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3408.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b487e869-aaeb-4eda-cd1c-08db71755e64 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jun 2023 10:01:51.1361 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: uz7A3QZlg9zNeM4X2ICWWUfW6nGPG8l4Ne/qZvlI4qJRFtOwgw7CdyYKfpVUPJUUoHKZx2mkyboeECLkqmrQ1g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7873 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --_000_SN6PR11MB34086C12F50B0ED92AB90687815CASN6PR11MB3408namp_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Acked-by: Kai Ji > > -----Original Message----- > From: Didier Pallard > Sent: Tuesday 18 April 2023 15:26 > To: dev@dpdk.org > Cc: stable@dpdk.org; Ji, Kai ; Akhil Goyal > ; Fan Zhang ; Ashwin > Sekhar T K > Subject: [PATCH] crypto/openssl: fix memory leak in auth processing > function > > Contexts allocated with EVP_MAC_CTX_new calls are leaking, they are > created then overwritten by the return value of EVP_MAC_CTX_dup call. > > Fixes: 75adf1eae44f ("crypto/openssl: update HMAC routine with 3.0 EVP > API") > Fixes: 2b9c693f6ef5 ("crypto/openssl: support AES-CMAC operations") > Signed-off-by: Didier Pallard > Cc: stable@dpdk.org > --- > -- > 2.30.2 --_000_SN6PR11MB34086C12F50B0ED92AB90687815CASN6PR11MB3408namp_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable
Acked-by: Kai Ji <kai.ji@intel.com>


> -----Original Message-----
> From: Didier Pallard <didier.pallard@6wind.com>
> Sent: Tuesday 18 April 2023 15:26
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Ji, Kai <kai.ji@intel.com>; Akhil Goyal
> <gakhil@marvell.com>; Fan Zhang <fanzhang.oss@gmail.com>; = Ashwin
> Sekhar T K <asekhar@marvell.com>
> Subject: [PATCH] crypto/openssl: fix memory leak in auth processing > function
>
> Contexts allocated with EVP_MAC_CTX_new calls are leaking, they are > created then overwritten by the return value of EVP_MAC_CTX_dup call.<= br> >
> Fixes: 75adf1eae44f ("crypto/openssl: update HMAC routine with 3.= 0 EVP
> API")
> Fixes: 2b9c693f6ef5 ("crypto/openssl: support AES-CMAC operations= ")
> Signed-off-by: Didier Pallard <didier.pallard@6wind.com>
> Cc: stable@dpdk.org
> ---
> --
> 2.30.2

--_000_SN6PR11MB34086C12F50B0ED92AB90687815CASN6PR11MB3408namp_--