From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3EC0842B2C; Wed, 17 May 2023 18:51:35 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1230240EE1; Wed, 17 May 2023 18:51:35 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 4D141406B7 for ; Wed, 17 May 2023 18:51:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684342293; x=1715878293; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=LT0AU6fyhVWc9mZG3hoyJT350qa1MKL7IkAFo7qs/E4=; b=mkoFC+CrX+0xnxgUAQAmtjqCndWbC/DDY4Q7JNN06dyIN0kiysvg+SKn BdTMaXbEpocJd56mafgEuNjqiijwZSfQ7uzElZ07e5Eg3FQhauUAGzwAH mXOc8r+c3FZrp9IJbNvHGbEJKJ/T5axbzXGGZYV+SloITxdXkX3w6bQZq utOlOrRJHU/DQ85bNt8I6ew8uVww5wSy0AmJ3axMn7PyNVZHiyRJcfQ4X LDSWA2JxMlHbi6qosjeRlHxFyFYkmqlteKtgU1GkEl4vfVEt2NolwIY/E I43UWq0UUIIfOYIDRgDjSEJHuahLTZIedJJJYdNjA8WCzkvzAH1XJf9pI g==; X-IronPort-AV: E=McAfee;i="6600,9927,10713"; a="349322019" X-IronPort-AV: E=Sophos;i="5.99,282,1677571200"; d="scan'208";a="349322019" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2023 09:49:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10713"; a="701820278" X-IronPort-AV: E=Sophos;i="5.99,282,1677571200"; d="scan'208";a="701820278" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga002.jf.intel.com with ESMTP; 17 May 2023 09:49:25 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 17 May 2023 09:49:25 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 17 May 2023 09:49:25 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Wed, 17 May 2023 09:49:24 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.43) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Wed, 17 May 2023 09:49:24 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=auuw9cC+kbDl+z+55N1+OzW2DZhdhhivIbCzjhaMKoFpn13Q2pnizXxCliA9DBVS4I3Hkxt0UdW+v2yu9knP69W7/xPH+SdRQguGr68hM21TJkFg4X54d/3MREg3UoQ8JyLs3tsEP0jcnuamU9e7NMvzuFGcy3QkhTpWcvOjpRc4y9is0FG1hVeVybhnksBVY1K0uthFPa/WJd4YYDcSkJAcu8xrp0OKw4JjaldBOFP7LPETVl1BWOl5jroENjK1FbvKZXjZyiV73GHBsPy3i/dCOpOjuTo62fzIiPzaBzeOlbKrMwITNjRA6m3UdyerrHOBiOSlzmqX5Q9QnmCzMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XP9KlzEuhlCfcB/lDzR82kNVBln3Y8bvnrBQ4NyRVXU=; b=Yo2yJ+W+SOZlHM/+eEA6KqPGUIX7UaNtpbgjYKHuosP4KESyOndzmAlnCYQr/kB35Xam++2NYNXX3Q2kT8lidP7kLjKnHcZTCcGckmUX8FSKhno4OQMLt7f+o7vhZSy8wjz5mzAwWVviK6C103o9mSuXYsBN7MSaQ8qQs4I1GchP9aYBN2ykGHdduJRR/Q9ptdb0mui3j8bJBTpDKUcBWi6aEY+uSoVKV6Y5ZIK3RC9bETBpJ+gFK84TXgYwdFPYUcob/USPMMReVmEHexoxyxKWDRY+NOPQL7iiQh3CsJLnPS/T6lxuHXUfdiF4r0hQCxxI1fkpib5ubsFnXNGSlg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3408.namprd11.prod.outlook.com (2603:10b6:805:bc::22) by CO6PR11MB5635.namprd11.prod.outlook.com (2603:10b6:5:35f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.17; Wed, 17 May 2023 16:49:23 +0000 Received: from SN6PR11MB3408.namprd11.prod.outlook.com ([fe80::7bfe:acda:6bdb:84c2]) by SN6PR11MB3408.namprd11.prod.outlook.com ([fe80::7bfe:acda:6bdb:84c2%5]) with mapi id 15.20.6387.030; Wed, 17 May 2023 16:49:22 +0000 From: "Ji, Kai" To: Gowrishankar Muthukrishnan , "dev@dpdk.org" CC: "anoobj@marvell.com" , Akhil Goyal Subject: RE: [PATCH] crypto/openssl: fix memory leak Thread-Topic: [PATCH] crypto/openssl: fix memory leak Thread-Index: AQHZiN8ETH5D/6RQs0aHrZ6Z+deAba9erRvg Date: Wed, 17 May 2023 16:49:22 +0000 Message-ID: References: <96b2fd6a6341603426ad79f71c4bcf1342460e71.1684341281.git.gmuthukrishn@marvell.com> In-Reply-To: <96b2fd6a6341603426ad79f71c4bcf1342460e71.1684341281.git.gmuthukrishn@marvell.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB3408:EE_|CO6PR11MB5635:EE_ x-ms-office365-filtering-correlation-id: cc1e9828-929a-4a04-3ccc-08db56f6aab1 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: psN5aYIBpBHVo5ssFfmPFV0gsZAWkOOpy2L4qr6dqrkjJEqFKZ/7SPnYXjZaj3Y6QeKszbh8TNATCCL4A7iXSylj23EWXcr7rcJodEAzbOIu9W2fjpe82Sz4S1G2kdWxWu2yCTqxcuT5UTgkTaKgA0P86kX0A6K+ADkYxj2eeSaZ6QDvk714H+f1Zcw5aONW7gNffgnyjoTZDrhYL4ixdoCNaZF0QUJ+QZSWRktP97iX9m6m2bMnl49dSZZBX4GYwq0WL6qgCV6uG8VSGImCzdWC7G55tukfhfVmQXLT9OC/oEtCs7aBArZ4pRxCU+pjiA0rrlpGGdu/ERSrAFeLe31lFGdkmhNMLi8mjlnHwVHrhu9FlszGU3FDh0EUZw7O8XvhvwTFAmWja4cJwNReGlepc/KJh1jJ4Ycj7TBBDuiIYia2ML2YvW+rTqWtgd4wCGmDu8xibyBPxT6xtRpbqyJX76e3MF3m7SiKMJiH7PasS2C/UjZPfksJrljM+BHJiLLSVVwKH18iFt/t6aq5ioe2VAye7GoVEmGYOtL+wdow0+VbH7xXOKpOP2tupq3Bc2fmvTAC//D1bFQemsXTxTwnCXzBpj216pQA9VRSpIs= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3408.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(136003)(396003)(366004)(376002)(346002)(39860400002)(451199021)(966005)(316002)(66946007)(66556008)(66446008)(64756008)(4326008)(66476007)(76116006)(478600001)(54906003)(110136005)(33656002)(38070700005)(86362001)(83380400001)(6506007)(26005)(53546011)(71200400001)(186003)(9686003)(7696005)(5660300002)(41300700001)(8676002)(8936002)(2906002)(55016003)(122000001)(38100700002)(82960400001)(52536014); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xhSLO1msKHPrr3Qf/Gdxo6BUYbPs8qDNGC2mlBTJ/o42YbTD9E4W6tAvIEw3?= =?us-ascii?Q?yjlH5Nqe1BPfIcMrMCiMn/DNzZFb5Hf4qbd1t5YZP84luqQiCN8LAU/QhGSU?= =?us-ascii?Q?Ggpx+EV2G8mPd/yR8IFuDia807FpYBJW+5VAUOEQz1+h/bB0nohJImailgJP?= =?us-ascii?Q?XZb8VT54a1CI6nzZH3q01I+q6AEoqMFezyJFMy3dD+LRBUSlv2HHrCm6wLNo?= =?us-ascii?Q?ZUxMPK/fGSmAFXS3CaMcpw838tRcJqt/Uc53EhwOx4cVTKDD+M2DrrYUamY/?= =?us-ascii?Q?NTHoXLtXIugFW3ZrHjo4sE6IQ6nn2hSsRSkWszvSOogEBHZNIJ9YHu2/1Q9W?= =?us-ascii?Q?BLl+O2+ICE0j6gM8zxjaBBrTVykjfv6E3r9vmXa+csHYmo48GLRk2p6I7gAb?= =?us-ascii?Q?vdCfa3OpvpLKjEFkxGj/M27rVRXGJS1Vv6CYXQ0wwzGb6i0ydRXcX7zlzTjG?= =?us-ascii?Q?ptQsHC3acG7oPbpfzIiG6sEzINdsWz2bmAosIHoTBnzYfI+pOevhKXqVbSNv?= =?us-ascii?Q?DzKet0ubZOvvHck8moWv9463lrBUsCKvyoNZ0bzTVBXq+Li3LuYBPgZY18Gu?= =?us-ascii?Q?ph07WtuNVLUC3UCzGhdAZ7mTpwWehL8Bt4dYPyUSm7vJ+cUDFsFSxkxxSUJb?= =?us-ascii?Q?cHYjizTaMvw7HoSXIDvcJli/RTL5J52d/prTjj1eN73n2qO4zEb2ZMw42arK?= =?us-ascii?Q?uF2wFS6XLNmte4HuKSTMLNWhpgg5qwoPx2viLv4IHq81IibHrwXDYaE3A23I?= =?us-ascii?Q?kzn0qDH6IQQE5GMJGf1EHK/eqhEST8NucVYrw3VCNYt2l7ll+rZeBV86XzQL?= =?us-ascii?Q?Jm+KXnwll33DTExHK/fdsuGTjPvDJeJgNWRuMas+7A872TjkESI050vX/xR+?= =?us-ascii?Q?5+cn1mHaGUWhXbRGCF/TCrYG4odiKpoYPstn2w1uvQdL0EQWcuzoAZ9Pn8Cg?= =?us-ascii?Q?rCinW1zk1SqZTjfDSS+8xGm9tk3WJmn1BhOyy3rdIQ41nGkooHDlF8YgkZo6?= =?us-ascii?Q?KtclLTxP4myDTqCJUdXGNsHdTXEHnwIPCvJTRzr7WzXhEY6DYjLrL556Lk8P?= =?us-ascii?Q?VBPRMpv0cyXj+duzC5tjEppcn/QEIKyleAFnTiLgVx6UItpQSKpyRfivxOZu?= =?us-ascii?Q?Vhf19lks7tU/O6QGIZ5MwWOWmoWU2tI72GpqEb+Qqzz7gtDgNbmkNrL+Q/rd?= =?us-ascii?Q?whgA3yJvEIJVfJgTN8qNV7vciBnB9FZ6FlkTgGnlNaCJp9+qOJBjUT/hgsE4?= =?us-ascii?Q?1N0Mbcs/jtirbOxZzQIr83tLG9aInDm1pFmYzRcfAlMDZwZmfDt33e/KTahV?= =?us-ascii?Q?cWV3UWPICWvnxt10vC164iakY7BNl6gWT2FXN5afRttT8vNuFTgAX9FZdXH6?= =?us-ascii?Q?N9x8Sfm3Y6Xp86b4C39PTPKK0gz/n8c1WCw5g4/4rRNSUvpmBXH9Vei74g8P?= =?us-ascii?Q?lPfFGP6/1OieECG9smuD7Or5DEj0DFQntx+SOvKgzjqjIMkJiPWnazGTdwmS?= =?us-ascii?Q?k8v6vX8cx7tOmreIYI9jzumjUxFSk6HxmZtJnC5BEvFijWlH4MACyIrY4DUk?= =?us-ascii?Q?zM6eqXxbOM5HWaTkYMY=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3408.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cc1e9828-929a-4a04-3ccc-08db56f6aab1 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 May 2023 16:49:22.8487 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: L7FZZQTDQtsqlNxo6VInMxNmw6KpLW16Y3M8frKZbvVWQ89uNKxZZlZ0vYjGxMhfbSSVstYpwxnuFMZqcXLvsg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR11MB5635 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi gowrishankar, Is that the same fix ?=20 https://patches.dpdk.org/project/dpdk/patch/20230511135944.142416-1-ciara.p= ower@intel.com/ regards Kai=20 > -----Original Message----- > From: Gowrishankar Muthukrishnan > Sent: Wednesday, May 17, 2023 5:45 PM > To: dev@dpdk.org > Cc: anoobj@marvell.com; Akhil Goyal ; Ji, Kai > ; Gowrishankar Muthukrishnan > Subject: [PATCH] crypto/openssl: fix memory leak >=20 > Memory allocated through OPENSSL_malloc should be freed only through > OPENSSL_free. >=20 > Signed-off-by: Gowrishankar Muthukrishnan > --- > drivers/crypto/openssl/rte_openssl_pmd.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c > b/drivers/crypto/openssl/rte_openssl_pmd.c > index 384d262621..f65fbca300 100644 > --- a/drivers/crypto/openssl/rte_openssl_pmd.c > +++ b/drivers/crypto/openssl/rte_openssl_pmd.c > @@ -1927,7 +1927,7 @@ process_openssl_dsa_sign_op_evp(struct rte_crypto_o= p > *cop, >=20 > if (EVP_PKEY_sign(dsa_ctx, dsa_sign_data, &outlen, op->message.data, > op->message.length) <=3D 0) { > - free(dsa_sign_data); > + OPENSSL_free(dsa_sign_data); > goto err_dsa_sign; > } >=20 > @@ -1935,7 +1935,7 @@ process_openssl_dsa_sign_op_evp(struct rte_crypto_o= p > *cop, > DSA_SIG *sign =3D d2i_DSA_SIG(NULL, &dsa_sign_data_p, outlen); > if (!sign) { > OPENSSL_LOG(ERR, "%s:%d\n", __func__, __LINE__); > - free(dsa_sign_data); > + OPENSSL_free(dsa_sign_data); > goto err_dsa_sign; > } else { > const BIGNUM *r =3D NULL, *s =3D NULL; > @@ -1947,7 +1947,7 @@ process_openssl_dsa_sign_op_evp(struct rte_crypto_o= p > *cop, > } >=20 > DSA_SIG_free(sign); > - free(dsa_sign_data); > + OPENSSL_free(dsa_sign_data); > return 0; >=20 > err_dsa_sign: > -- > 2.25.1