From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CA82A42DCC; Wed, 5 Jul 2023 12:23:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A32FF4021F; Wed, 5 Jul 2023 12:23:15 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 4095640150 for ; Wed, 5 Jul 2023 12:23:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688552593; x=1720088593; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=NHnmDg25tZL9aF34B7bipBPHaxBQ+Y+ghRTFlNpsl6E=; b=NGyFrWud5yzEwwVL8Kiw7bDU/ySECpAwFDCkmZZa2OFKKSOP7b5WnjYE a1KUX5c3l59L1fRwPUgR6UYwR+ft9LADFHPkDnOLLm50CX473HvJfXjzV 1U8D3BIfmg9ijyd5nKaKTAhWcwUQwAvw84zltQcyvEnupY58+50qKpMWk pv55w5hV5MLzuSeuA1QB9Xc9itougYgz6KB5W7T40gLYwKkPtwc3oZzB4 Ye7MDUPKAn4/z6xM05nnlqJ/dQqfBfrmmiO88WJhD5hMeARXuOG1D9Nxf 3rJhEd0dKih80YB3oE6yzkBQhslLj+wZCAzaS2rsHJxksPxXfeuYIdyBe g==; X-IronPort-AV: E=McAfee;i="6600,9927,10761"; a="449672646" X-IronPort-AV: E=Sophos;i="6.01,182,1684825200"; d="scan'208,217";a="449672646" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jul 2023 03:23:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10761"; a="832485785" X-IronPort-AV: E=Sophos;i="6.01,182,1684825200"; d="scan'208,217";a="832485785" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga002.fm.intel.com with ESMTP; 05 Jul 2023 03:23:11 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 5 Jul 2023 03:23:10 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Wed, 5 Jul 2023 03:23:10 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.106) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Wed, 5 Jul 2023 03:23:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MtmvSQRJbEfsqQ25gxlExshiznQi7KzQ841eeaY7W9B5BECbX6NGYffc/AzGqP1t/PI8S77PKtlTZ8Uq8KB+416LH6GLEtMlcJILbpeNa90O7FZNDoZhawB+nIWOSVarenfugB35/d7CY5G/6KYFn7RyC6UttZFhDmwQ6B1FxMgbyFZWajBkeN6MhTAYErc6T5OqzlNpzAWacTE8bH2Or9pvxya3/LULX+tzj6A0pby4QEj+E+bHe0QJlBjmC21iwz3wss8Ht+wA1fkpb+DIBTrbhg0RIUtYTAIhiT5vvDzmJ1flXd/f6Ie6rR5UuVq+us/zfTJYcYEU23zHDpfVNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X5mc8AFFsvlkInrkozxuQHZ7N0LROE6fAdX/5qqehVk=; b=JQJfDFsg2TpZg/U7uzIII2F6shHNV/JbJVIB5DuV/Cge6Tb65oc8Fal6qPAbQ2/YoDTslKCeusxfBNI4BwAKkYGkInvihRx8VEk4Os83ATilcpo/Od+Yvj4s3JssTk52dVflM6q2lq1ZdjxuIt/qx6g72Gie9SfhGK+csX5fBbspaXfgEnEvCUn0fM5SJc2LBtNP/AtAk1vjYUgClXxbkbIqalmSmp5U6SW+N6bmnbyjVEgePidiXc4dOcHIazU521ZH2Vx3XejGSTdiWNzLISfe7SsiKuufpzVjfUaYGELcTMkvVyPMRCv+Iqt1wOz/kK+tEaT/Q/4IP2qCuEikyw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3408.namprd11.prod.outlook.com (2603:10b6:805:bc::22) by DS7PR11MB6102.namprd11.prod.outlook.com (2603:10b6:8:85::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.17; Wed, 5 Jul 2023 10:23:04 +0000 Received: from SN6PR11MB3408.namprd11.prod.outlook.com ([fe80::121a:92cb:2f78:e53d]) by SN6PR11MB3408.namprd11.prod.outlook.com ([fe80::121a:92cb:2f78:e53d%5]) with mapi id 15.20.6544.024; Wed, 5 Jul 2023 10:23:03 +0000 From: "Ji, Kai" To: "Power, Ciara" , "dev@dpdk.org" CC: "gakhil@marvell.com" , "De Lara Guarch, Pablo" , "Cornu, Marcel D" Subject: Re: [PATCH] crypto/ipsec_mb: fix jobs array used for burst Thread-Topic: [PATCH] crypto/ipsec_mb: fix jobs array used for burst Thread-Index: AQHZrymnYpCNXl90mUiVxf+1YwB4ba+q9vBo Date: Wed, 5 Jul 2023 10:23:03 +0000 Message-ID: References: <20230705101521.1126253-1-ciara.power@intel.com> In-Reply-To: <20230705101521.1126253-1-ciara.power@intel.com> Accept-Language: en-GB, en-US, en-IE Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB3408:EE_|DS7PR11MB6102:EE_ x-ms-office365-filtering-correlation-id: cda562e1-0970-4216-53b0-08db7d41d0eb x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: HAFpNO6LAcEWyT69+eCTXzmV97dFHl8ll08aCw37BAGOP8FHtl9FQJ9RE3IQ1QvgVC6brah/PDufCxaoeQZoqVshPGMPETT2ZXgSXZCzf1wYS07QhTfyT0TVYmwssxH3JSGJ6jFyagPApd0NYoY6v1z5TA0nQlftYYwBLbw+FFHIM5u532iqvkdusgkklxlaDhp7K6GZWglTx4UjjuaWn7JL9PVglZSdaAS6y4asJV1GM4uKCAoGNzIcbmxqJqG2vwnBUpnjUF685LfYnEKTyIovYJw/FawBGJL96Smc86+8xlYErgKspLS88P0auj3m2Pymt9F5hApIhK1JBd4tXJdrtlt7WbjNWSczAb2fdJKQIzXaDUhkIxW5rAypD3dgi3UeCnTbiPVWdHjoYNiwYYegcIbpda46vtnjmxN8LwcYStqbqWZWX8jSeVjLaBhsGwo3KwAnYRXFKHqzoIftA4Ii9ZGvAwD4/yomqlFo23ks/iDw8FsCjvW5Uv6JmGXQFu2jUL3z+0KNLGvTVcZGU7CdhFNrUuZdHr3B8dXw9UK2H6ZndpPx6rO/q+E297+I3ct15VlvMR6D5+0EFw7fcbUtLzp4c+3uAm/HSwuexO7zhBcGZcMi5nvsjOe06As4 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3408.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(136003)(366004)(376002)(39860400002)(396003)(346002)(451199021)(19627405001)(8936002)(8676002)(2906002)(55016003)(76116006)(52536014)(5660300002)(6506007)(53546011)(26005)(186003)(41300700001)(107886003)(122000001)(7696005)(71200400001)(82960400001)(66946007)(4326008)(91956017)(33656002)(66556008)(66476007)(66446008)(64756008)(316002)(83380400001)(54906003)(110136005)(38070700005)(478600001)(9686003)(38100700002)(86362001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6v69Sp3jiBszz1P2+ncybpScy+Hljc10E10q4BLT4NxYnIMBf1GC+oajF01R?= =?us-ascii?Q?UHCPOykXFUXvtktxNlq+rBfFg8dNc/PQUbdDnToQJIX6km5TaXG/8ernndyg?= =?us-ascii?Q?keY5x2HRAEUNgx/lxNTh+BeTfp6diORcCtmRFMtP9rWtlmYcmucuAipR6EP3?= =?us-ascii?Q?rHgrCd5JUrh7gWf3ys2pbf4PhuKs8KHVq4JQVJEZlbtDjQE2+Bxix8ewkODx?= =?us-ascii?Q?StbcL6pAafFmk3kujbe/0j4rprfstDI49hLq2TgSXIB8FshLIFOWYO5dRAAs?= =?us-ascii?Q?ak3XHpHOZsOBY8vWTJT4BS5lDvxHLZf4wRPe8g7Ad8ZPqA1uBhjcIc5fQrXz?= =?us-ascii?Q?XsSWkbV0cF8xeYRyRDwP59BsvIzdo44rSRffOLh1KIxqMj/ucthS4Y64afrO?= =?us-ascii?Q?E+Qo716S4QQ/7dWe1ZYy57t8eagbq0mkr4V/Cy5eL0NEyuXeEUYG5Mwwe0yL?= =?us-ascii?Q?Fnhj4LXg1kiGsE2OCiA1A5ssw2Jn46nifFE67tUqtTsscFPsbjjQT8sSlED5?= =?us-ascii?Q?Y06x0NSFOUKC1djfGcSDzxIOgvLgKXnHE/p0G3CVdYSuAcqOXGb/uZv/QamO?= =?us-ascii?Q?y3qN4ujsrjtJ9OBmlaum59vQ7NceVvwdzgRh0r6F+NBlmaguV6WG4SpTgdAI?= =?us-ascii?Q?WNOWXUAQmWH7CM2N/mXjU8nYxEGm9AmStWZmkwpvdV1xEJ+IcIrETn3w7Z6a?= =?us-ascii?Q?MzjLzuR1zy719AyyDSUv7BAM5MpMX6TKGbTlf82iRVcu0Fq5S0NbIxT6Njqo?= =?us-ascii?Q?t+1pjy0B6sHtzlRx5jJVIktOQweL24l79tyEJeqXpAdh7fCJ+OX/fF8/lzyh?= =?us-ascii?Q?3CdDr2MR5wldQJtr8gpuv1zDmsuXwJIdzwq02epoAQDnYUHhebGrAiqdbC1E?= =?us-ascii?Q?Cb9GAXk3nykHqFzy8Tq1jhbRb+NnGzEsewaojZSxU89siCFqMDIuhmH1aoFj?= =?us-ascii?Q?JFmrtGeVNN78cJcf6uJOg5SsnsrPZMLeKQk9SpQTxwyQNAnPI/B1Iyzm488y?= =?us-ascii?Q?kTzCctreQuNodhAze09V6dMnUNilsNiEu24khq2/mfXb3dBy5at1gjYCvsj2?= =?us-ascii?Q?di3OqRFkMzYYpimrl0om+WDUNlanw1KfDKKpIBceqUefUCAjp0l0sHFYRoY2?= =?us-ascii?Q?zHcpd1+MvYFOA0/zUfE+t3CHLTJEmN9oxo3ItG7rQ0kQJ/btYGZ/MCys2VQL?= =?us-ascii?Q?Fd6QWLmynNsGuiC2DfO9KTgvxXKqWEFV2SA/Mu/9f6k51PIpohUVW8cVy+x3?= =?us-ascii?Q?8fkUAQUk3YdgjcBP9+J//G1/8iv3AW0FOzJFGUqath2gLdzN4ArBshu3gfFU?= =?us-ascii?Q?h5N4cHkDVFDE6/qVYfkUYO8Qd1Q6ijUVppEq4cknZTP3YGh2vLKeowyW2YCX?= =?us-ascii?Q?J+MwG4RA2Wnsc7xE8VTHwV2p15/LLcjLYl/iAaV0ILNVnS8W5nZKOsngNamI?= =?us-ascii?Q?P00BEIydAWa2Ircl7CKKAN+lKEfhYUau83lHjW+LMSeUeQmY89XOCx7pZ8QN?= =?us-ascii?Q?7Z0vFVSVXaWOPIJzg3vd4bsxopV34YsiGXR4JAE6vIsqxIxCg16ss1Xh+NVW?= =?us-ascii?Q?86G1GaCua52XmgYAxrI=3D?= Content-Type: multipart/alternative; boundary="_000_SN6PR11MB3408B816103A2EC2594ED233812FASN6PR11MB3408namp_" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3408.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cda562e1-0970-4216-53b0-08db7d41d0eb X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jul 2023 10:23:03.4056 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1tYt4v0tOEI1jO4LzZn47KHHPp7Z/k8H7/5TabUXhxgKbzTDiOAzjUT5uXdgDGmmQsKAdIe9QQdvmj2R9yjfNA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6102 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --_000_SN6PR11MB3408B816103A2EC2594ED233812FASN6PR11MB3408namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Acked-by: Kai Ji > ________________________________ From: Power, Ciara Sent: 05 July 2023 11:15 To: dev@dpdk.org Cc: gakhil@marvell.com ; De Lara Guarch, Pablo ; Power, Ciara ; Cornu, Marc= el D ; Ji, Kai Subject: [PATCH] crypto/ipsec_mb: fix jobs array used for burst The jobs variable was global, which meant it was not thread safe. This casued a segmentation fault when running the crypto performance app, using more than one lcore for crypto processing. Moving this to the dequeue function where it is used fixes the issue. Fixes: b50b8b5b38f8 ("crypto/ipsec_mb: use burst API in AESNI") Cc: marcel.d.cornu@intel.com Signed-off-by: Ciara Power --- drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c b/drivers/crypto/ipsec_= mb/pmd_aesni_mb.c index f4322d9af4..f702127f7f 100644 --- a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c +++ b/drivers/crypto/ipsec_mb/pmd_aesni_mb.c @@ -9,10 +9,6 @@ struct aesni_mb_op_buf_data { uint32_t offset; }; -#if IMB_VERSION(1, 2, 0) < IMB_VERSION_NUM -static IMB_JOB *jobs[IMB_MAX_BURST_SIZE] =3D {NULL}; -#endif - /** * Calculate the authentication pre-computes * @@ -2044,6 +2040,7 @@ aesni_mb_dequeue_burst(void *queue_pair, struct rte_c= rypto_op **ops, IMB_JOB *job; int retval, processed_jobs =3D 0; uint16_t i, nb_jobs; + IMB_JOB *jobs[IMB_MAX_BURST_SIZE] =3D {NULL}; if (unlikely(nb_ops =3D=3D 0 || mb_mgr =3D=3D NULL)) return 0; -- 2.25.1 --_000_SN6PR11MB3408B816103A2EC2594ED233812FASN6PR11MB3408namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Acked-by: Kai Ji <kai.ji@intel.com>
From: Power, Ciara <ciar= a.power@intel.com>
Sent: 05 July 2023 11:15
To: dev@dpdk.org <dev@dpdk.org>
Cc: gakhil@marvell.com <gakhil@marvell.com>; De Lara Guarch, P= ablo <pablo.de.lara.guarch@intel.com>; Power, Ciara <ciara.power@i= ntel.com>; Cornu, Marcel D <marcel.d.cornu@intel.com>; Ji, Kai <= ;kai.ji@intel.com>
Subject: [PATCH] crypto/ipsec_mb: fix jobs array used for burst
 
The jobs variable was global, which meant it was n= ot thread safe.
This casued a segmentation fault when running the crypto performance
app, using more than one lcore for crypto processing.

Moving this to the dequeue function where it is used fixes the issue.

Fixes: b50b8b5b38f8 ("crypto/ipsec_mb: use burst API in AESNI") Cc: marcel.d.cornu@intel.com

Signed-off-by: Ciara Power <ciara.power@intel.com>
---
 drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c b/drivers/crypto/ipsec_= mb/pmd_aesni_mb.c
index f4322d9af4..f702127f7f 100644
--- a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c
+++ b/drivers/crypto/ipsec_mb/pmd_aesni_mb.c
@@ -9,10 +9,6 @@ struct aesni_mb_op_buf_data {
         uint32_t offset;
 };
 
-#if IMB_VERSION(1, 2, 0) < IMB_VERSION_NUM
-static IMB_JOB *jobs[IMB_MAX_BURST_SIZE] =3D {NULL};
-#endif
-
 /**
  * Calculate the authentication pre-computes
  *
@@ -2044,6 +2040,7 @@ aesni_mb_dequeue_burst(void *queue_pair, struct rte_c= rypto_op **ops,
         IMB_JOB *job;
         int retval, processed_jobs= =3D 0;
         uint16_t i, nb_jobs;
+       IMB_JOB *jobs[IMB_MAX_BURST_SIZE] =3D= {NULL};
 
         if (unlikely(nb_ops =3D=3D= 0 || mb_mgr =3D=3D NULL))
            &nb= sp;    return 0;
--
2.25.1

--_000_SN6PR11MB3408B816103A2EC2594ED233812FASN6PR11MB3408namp_--