DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Ji, Kai" <kai.ji@intel.com>
To: Akhil Goyal <gakhil@marvell.com>,
	"Karas, Krzysztof" <krzysztof.karas@intel.com>,
	Thomas Monjalon <thomas@monjalon.net>,
	"De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [EXT] [PATCH] ipsec_mb: expect ENOTSUP in ipsec_mb_create()
Date: Tue, 28 Feb 2023 23:24:35 +0000	[thread overview]
Message-ID: <SN6PR11MB3408DF77C125AC44023C18CB81AC9@SN6PR11MB3408.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CO6PR18MB4484D794422DCED32840C17AD8AF9@CO6PR18MB4484.namprd18.prod.outlook.com>


Is there any validation to this changes ? I Can't remember the exact reason why EEXIST
 returned, somehow we need to handle that case. 

Regards

Kai 

> -----Original Message-----
> From: Akhil Goyal <gakhil@marvell.com>
> Sent: Monday, February 27, 2023 6:27 PM
> To: Karas, Krzysztof <krzysztof.karas@intel.com>; Thomas Monjalon
> <thomas@monjalon.net>; Ji, Kai <kai.ji@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>
> Cc: dev@dpdk.org
> Subject: RE: [EXT] [PATCH] ipsec_mb: expect ENOTSUP in ipsec_mb_create()
> 
> > Subject: [EXT] [PATCH] ipsec_mb: expect ENOTSUP in ipsec_mb_create()
> 
> Title should start with crypto/ipsec_mb:
> Avoid using function names in patch titles.
> 
> >
> > Commit b35848bc01f6 ("crypto/ipsec_mb: add multi-process IPC request
> > handler") is part of DPDK 22.11 release and it enforces usage of
> > shared config and multiprocess mode.
> >
> > DPDK is not required to be run with more than one process in general,
> > so instead of erroring out, catch the error and proceed with ipsec_mb
> > device creation normally.
> 
> This seems to be a fix, kindly adhere to the guidelines for fixes patches.
> >
> > Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
> 
> 
> Kai/Pablo,
> Acks please?
> 

  reply	other threads:[~2023-02-28 23:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-20 17:13 Krzysztof Karas
2023-02-27 18:26 ` [EXT] " Akhil Goyal
2023-02-28 23:24   ` Ji, Kai [this message]
2023-03-13 12:01 ` [PATCH v2] crypto/ipsec_mb: expect ENOTSUP Krzysztof Karas
2023-03-14 17:25   ` Ji, Kai
2023-03-16 18:46     ` Akhil Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN6PR11MB3408DF77C125AC44023C18CB81AC9@SN6PR11MB3408.namprd11.prod.outlook.com \
    --to=kai.ji@intel.com \
    --cc=dev@dpdk.org \
    --cc=gakhil@marvell.com \
    --cc=krzysztof.karas@intel.com \
    --cc=pablo.de.lara.guarch@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).