From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EAB64A0556; Mon, 17 Oct 2022 10:19:07 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C441940143; Mon, 17 Oct 2022 10:19:07 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 62C1E400D7 for ; Mon, 17 Oct 2022 10:19:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665994746; x=1697530746; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=R5Evn4Zr3aS46Ggo4RvTMFY1H76aXk9yrcdLzZ/Aiv4=; b=KM7ScdMXSw5ptApl+ay/dd8DMVoJ7F5ckb3lbDlaHlwr7mw4tsvqQ7r9 IOFeSkWM4oUUKmRkozt4JbWtH6Pxd1gfo4ZZ4t8fVS34M4TyseC5KHRlR OwQuaTJljNovubpel4V2BTQAeSAZul4kbwB5XwYfVoDvlxvkgT7P/8yAp undWskaglbHS+kB60+zcRE16FRZpdlMKvGF1rvZmCnzmpbyegc0UIm5Ya xOBjXqSkccK8Iw8V33F5BbwKBYsBovmoXZq6wAZz1pMu43B4GbYN4d+j+ QM0NYhjFq9NxghorTvQvDcGgJ4JTnWJ1aGAx3Jlv9VXbjF46EMYJmkb/1 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10502"; a="285464534" X-IronPort-AV: E=Sophos;i="5.95,191,1661842800"; d="scan'208";a="285464534" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Oct 2022 01:19:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10502"; a="579292244" X-IronPort-AV: E=Sophos;i="5.95,191,1661842800"; d="scan'208";a="579292244" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga003.jf.intel.com with ESMTP; 17 Oct 2022 01:19:05 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 17 Oct 2022 01:19:04 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 17 Oct 2022 01:19:04 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Mon, 17 Oct 2022 01:19:04 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.106) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Mon, 17 Oct 2022 01:19:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ADAWbgI9AVuHBHn3Sl9maoVoNYj7TnyHWbPKuGF1Kg8KIvHM/RDMIoRmHFxdwrQ7R5JLt/NFYbY2vhOIah2DYID8kgMvTMR5rQnpgM0cxH8ehv+Hc9o/ParKnVuGbX2weBaA1e14JwORQmm2CEZbekSVtwSNNj3zw3Fmke9gPQVJAojAeZFeeV6ssW7rIV0detV7Fei4bxVrC7xMLn9J+8tVKnDfwSlxQt5RIGWUkvg98Dc2LX/FQNyGmdHZcSE24HT2F6WxfLYDwTm28m3gsTe8jcud0e1Y+tW/rPYZ7R/7+vobzFC05PUyFxjCI3mmBMU68pPtXKaz5OU4EfRRoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iKwOSA6qsCj7ZYjilPxBLKgdsqAZY3LP6O22fgUSLAM=; b=S07S5zJBo/ArNeyQ8TojP736sI10uhlHlbBW459fhKExa09tsQp/FxeM0SEGZh60hFA1RuggJMJFHNqwxSy5ED7V9lP0uFkRWLjBNAyCoz9aPVLhyQJybFh54TkIjwsF+EJoKaHyctbuOagNXYQITjLrJtbRzfKm3Fg9KKarpU2TplRbEKz7WCi6j2raPoKsLhNN2gxRNNQOUb1gPdedYRUZgNonANl39PeYeNpvOpOHsIUA6hFFSECXA4kb7MhAN3cZss96i+4K1cX8BAFwSjaE6aZw9qZzZYQZD4Xta0yVxSC7HMp6DsgvcM+QfLadr4EwTBQ+y7xE4KoEBihICg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by IA1PR11MB7293.namprd11.prod.outlook.com (2603:10b6:208:42a::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.32; Mon, 17 Oct 2022 08:19:02 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::39bf:57b1:4824:d40d]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::39bf:57b1:4824:d40d%6]) with mapi id 15.20.5723.030; Mon, 17 Oct 2022 08:19:02 +0000 From: "Xia, Chenbo" To: "Matz, Olivier" , "dev@dpdk.org" CC: Maxime Coquelin Subject: RE: [PATCH v2] net/virtio: add queue and port ID in some logs Thread-Topic: [PATCH v2] net/virtio: add queue and port ID in some logs Thread-Index: AQHY4f6dfnVSO4T3PkeqFVl7QkZ//a4SPi6A Date: Mon, 17 Oct 2022 08:19:02 +0000 Message-ID: References: <20220929122228.1170-1-olivier.matz@6wind.com> <20221017080037.28634-1-olivier.matz@6wind.com> In-Reply-To: <20221017080037.28634-1-olivier.matz@6wind.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB3504:EE_|IA1PR11MB7293:EE_ x-ms-office365-filtering-correlation-id: 0b8bd4b8-5266-4754-7592-08dab0183fda x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0onMh6kfJOXKBnphQ1m8krYHY+eVms7XcT/qA1IOgf+xFI/VDn2lxsLMWTj8ImOQoboLgyj3YlTfkV7WWNfCmDpbix1ITBf3INyRQqrE3x/vXpJqOzFCatrURPXmjHnAkQDxLqjleePm8b3SYo4pcKEgRL36UtP0gxKOiyDs2nx2Iz1HOBQTtRsLi6jl4KV1DjDsTzma9V6j8D6tCA5Ffft2hlBe+Bikgq0JFOkNMRtxTNkGtDyjfEG7TW/PrZKJS8uufiIkAr6StV6CqLeESX8de/Hb3alpQn8QaPf/G8LGEf1vqqfayW0SBqrH34Qw9O3AE6XDUcpXmh1cA9T27hZoJdXtisnm7I4XeVSuX/rf2tALRJSjMkCL759QuNKqGPJpsqzkRw8WCYhqzQ1+GAULV/eI/0I/tDk/JmIGVWTijOBz3ofBRyrhun/FvMDIfCAvmlv2d0z5SEKuh5KSuqOReO+66r2NYH21WyIittvvUr5pMpE25eN696zcao9aNaYpaSsySAtglHXQYHedC8dg74sFH+wNh5rw4L5YcipS7SnwcGjR2Byx+evIr7jYqS7WJFZfGu+eV65KBbw3udQ+80qif77Azwj9prq4+djd6M1bXg6aV4BeOFvv1iE/6mWvb4/2itIIPb8z+MvkYIPynlf+ShjwY7w1SuO3rcHalpAwvV9vv+on4lSKHFYqxwsaViCsiPlpK1ZqRicax40JDqZw+sFdK+l2voSVUL0SxjumhFj43d0gkUjCo6hL3DtjQ0GK1tKW+fy7fpOuSQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(376002)(136003)(346002)(366004)(39860400002)(396003)(451199015)(71200400001)(33656002)(86362001)(122000001)(5660300002)(2906002)(38100700002)(82960400001)(186003)(83380400001)(38070700005)(53546011)(7696005)(6506007)(316002)(478600001)(9686003)(26005)(76116006)(66946007)(66556008)(66476007)(66446008)(8936002)(41300700001)(110136005)(52536014)(4326008)(55016003)(64756008)(8676002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?IvwN4wSO1w0acYtzrIHNquyd7ZOce2D0HyIiLJ9Fsskq5S6Th2lB8QpMVGMt?= =?us-ascii?Q?uofN5vCMXOaCs8lqNQc/tMgnpkSA/yWodadreAkpSGC8Op9Qg2iNj93nS9Ow?= =?us-ascii?Q?nL1USHY6yh9iBpCedQ1w+fFHOeQieyXdcYXmf8fWt9AxcCPmuSEiQduou22W?= =?us-ascii?Q?rAcXAowAPNjHtXcV2+Pq5oRkZz6Cl4a9Fx11ajyIBbGjakZfRB2O1zijb5W7?= =?us-ascii?Q?tp5cNBsFGqSYOUNO8uXCxqN9yiznIw/L6h4gM+PSlSgHEsN66yhEWYFfIqlJ?= =?us-ascii?Q?TSe+m0WAsD1Cnwbhs561BTTKdaIxvmT0Zv16PxHbhWy+2bXFdfJLJyeOcJFb?= =?us-ascii?Q?vq9Q8j3gXo6G+Ht4BcwvBX/+r3MZsdSyEXAJBEwMf3Ak92wz8fiSHo2u2DVs?= =?us-ascii?Q?yLQhzRH2b7XV38nDC/G0jxz7tJXOdVqJQrm+PN24I7YyLpDW+JpHFl6IjrJV?= =?us-ascii?Q?Xv7DoawbXBJ/ki8MHf87SXVqW+4FYLbw3IF1KfZNUsqFgCz6VqtPQ6BYe4ZL?= =?us-ascii?Q?g+1MDGmbXu4s5P2hF8bIwMEFkaXnTrQlEFfnVHvP2XxJqnGFNuplq/qOh1QP?= =?us-ascii?Q?QnpR6NRAOvnUFn7igWiNFS46S5prUkfU4W+nffkEf7AJX1IDGcML6gUBwVA2?= =?us-ascii?Q?UZPlXuGdwaWh8+Psg0LaG5c8NI93srH/B1yf9FxRej6j1u6k91yB4a0x3y5U?= =?us-ascii?Q?sWAPTIdEqWeHFl5pVKHY2G6hyyneRPLnGPP7E8FLrhW82oZcK/cfZimvCHbw?= =?us-ascii?Q?bZ3p1aqqf1DqMV4byaBFR4fsTiGI/mIm1xz9MKJCDnw4ON/B3po87hEj6GQP?= =?us-ascii?Q?AfaIyjqyBOy0WTPVxei+JZFX1k5NnnbvcqJiJhLoEyKFb6vxJ3IQn0d7AvzM?= =?us-ascii?Q?xLvqJGOGPEYRS5IRqt1eKCe04+27tQmz032eEmQr+wUKGSkynkAtNbp+0Ysz?= =?us-ascii?Q?1oCnrmG3kMW7pbQXFUfTlDTZ8adDb69ZF4yS4HIOD5Xv4I29vyORzSKBG3zx?= =?us-ascii?Q?4CXW1S+JG6d6Z8KIlffGdJXzj3h7Z2vjnQeZHhT/OUDkyLx0W4PdeCS6aJAz?= =?us-ascii?Q?1iR1Qm96hH5nuNgrczRIybDb0tfjqv+jmECGpkLDj4VaF10uzNVSmY8YUz/k?= =?us-ascii?Q?Ub8oY+KRk3z8ILNawToZnpejitSQLgJwyj1T2OT5nB4rBd/CAxFmXtSDpRbh?= =?us-ascii?Q?HHsop1CxRNW0F1/PRBGowA1MA0DKCrAn7t4aah258axpn8vJwqBf5ZOFKvyk?= =?us-ascii?Q?i7TXoushlbXNfyUdcUvegfVV17m52Hw6gQsHQU5TqlkSZGgNBybMmWTQ4R6p?= =?us-ascii?Q?L1is4pYR2W21K7UarFVIaZatLs5sNTsEF23mD9elZO1HXaODvrFoWsa8LoWs?= =?us-ascii?Q?DuIC2X3mhWWlP8qDUfScK/JO/Q6rq7iSd5olBdvZSFkh+1huABmBhPc1Vvoo?= =?us-ascii?Q?l3UpYIKV6JXhJYB1eAHj02IFlLFmpqHCoqplWymk7FU/SQgxfrZIRD93o942?= =?us-ascii?Q?HmzH2t0T1xAYfSFQfya8fGgIxccNVI4Rx0aKDdGKhixyPFDfMJzE2547P/Mq?= =?us-ascii?Q?z8Utud8lBcqkKptFsJHDuqOE+6JmcJHD91Il6TBX?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0b8bd4b8-5266-4754-7592-08dab0183fda X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Oct 2022 08:19:02.3175 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mveZz/LzjDvN6kANEIsG6ED0EgND0KDyLEe+3Ucpsz60vzwMvZnvDhRuYpRHxtfpBVyja8p/Ag2HIB781bdqxQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7293 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Olivier Matz > Sent: Monday, October 17, 2022 4:01 PM > To: dev@dpdk.org > Cc: Maxime Coquelin ; Xia, Chenbo > > Subject: [PATCH v2] net/virtio: add queue and port ID in some logs >=20 > Add the queue id and/or the port id in some logs, so it is easier to > understand what happens. >=20 > Signed-off-by: Olivier Matz > Reviewed-by: Maxime Coquelin > --- >=20 > v2 > * use %u instead of %d for unsigned types >=20 > drivers/net/virtio/virtio_ethdev.c | 6 ++++-- > drivers/net/virtio/virtio_rxtx.c | 3 ++- > 2 files changed, 6 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/net/virtio/virtio_ethdev.c > b/drivers/net/virtio/virtio_ethdev.c > index 574f671158..760ba4e368 100644 > --- a/drivers/net/virtio/virtio_ethdev.c > +++ b/drivers/net/virtio/virtio_ethdev.c > @@ -2814,7 +2814,8 @@ virtio_dev_start(struct rte_eth_dev *dev) > return -EINVAL; > } >=20 > - PMD_INIT_LOG(DEBUG, "nb_queues=3D%d", nb_queues); > + PMD_INIT_LOG(DEBUG, "nb_queues=3D%u (port=3D%u)", nb_queues, > + dev->data->port_id); >=20 > for (i =3D 0; i < dev->data->nb_rx_queues; i++) { > vq =3D virtnet_rxq_to_vq(dev->data->rx_queues[i]); > @@ -2828,7 +2829,8 @@ virtio_dev_start(struct rte_eth_dev *dev) > virtqueue_notify(vq); > } >=20 > - PMD_INIT_LOG(DEBUG, "Notified backend at initialization"); > + PMD_INIT_LOG(DEBUG, "Notified backend at initialization (port=3D%u)", > + dev->data->port_id); >=20 > for (i =3D 0; i < dev->data->nb_rx_queues; i++) { > vq =3D virtnet_rxq_to_vq(dev->data->rx_queues[i]); > diff --git a/drivers/net/virtio/virtio_rxtx.c > b/drivers/net/virtio/virtio_rxtx.c > index 4795893ec7..d9d40832e0 100644 > --- a/drivers/net/virtio/virtio_rxtx.c > +++ b/drivers/net/virtio/virtio_rxtx.c > @@ -793,7 +793,8 @@ virtio_dev_rx_queue_setup_finish(struct rte_eth_dev > *dev, uint16_t queue_idx) > vq_update_avail_idx(vq); > } >=20 > - PMD_INIT_LOG(DEBUG, "Allocated %d bufs", nbufs); > + PMD_INIT_LOG(DEBUG, "Allocated %d bufs (port=3D%u queue=3D%u)", nbufs, > + dev->data->port_id, queue_idx); >=20 > VIRTQUEUE_DUMP(vq); >=20 > -- > 2.30.2 Reviewed-by: Chenbo Xia