From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 03F7641E37; Thu, 9 Mar 2023 04:04:01 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 085C842B8E; Thu, 9 Mar 2023 04:03:54 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 0E2A94113D for ; Thu, 9 Mar 2023 04:03:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678331032; x=1709867032; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=efiyWjngfBNTuA/Er3SwWnPE63toUAm+2330Uh93cPY=; b=ND4Nr9HNUIZ540p10AeQHuGhhZ6HDIXZ33EnAh5A/ej3UnL6JAHy9Gie Vwou3PojlhTvN/DvNZdGt8wQSEyVlzDqEf4PHZG4H75PspL7Ps9RK6Km1 T5ewfGQJl4ezKvhhSTv6xN7kUvoZ07gVhDIl0SWgRIYLMLQm1BX0qPZJ2 vGixIy2o4QiW+XeNaJU57mWddelopKRo3sYsf+BvuLZ7YUyCnpVhgN9Oq keBURFU7NyFvUeJKyO/mwZL/vqI8N+Wb0zij7FAaYJ6ikwrNVS5cQ6O8Z /DjLD7yLpz2l0V/4dRTkve0MqQ5uReIY59k2FioX9yYyJw930uvGtMQyh w==; X-IronPort-AV: E=McAfee;i="6500,9779,10643"; a="336356034" X-IronPort-AV: E=Sophos;i="5.98,245,1673942400"; d="scan'208";a="336356034" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2023 19:03:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10643"; a="741378833" X-IronPort-AV: E=Sophos;i="5.98,245,1673942400"; d="scan'208";a="741378833" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga008.fm.intel.com with ESMTP; 08 Mar 2023 19:03:49 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Wed, 8 Mar 2023 19:03:46 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Wed, 8 Mar 2023 19:03:46 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.171) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Wed, 8 Mar 2023 19:03:43 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LFlQPkNp/m+DTfDcFqXKl8yHLAjd4SNA1kUNNIn8lhxayoJXzs5+3Bsp2leUATrJgj9Ra3kMbhlptDZB6WiEazf1bvgzki3ZfA+bUFfBaQ0PPVuUtZ+f9hYEWcW8NoLqLNAID7NVdnT60KiB1MnmRFEGXwy/B/FQ3FOslOWCWRdgt6kkoZXXAOFQdA0bkfs5S0XEBLxdj10ulyzp4wRzuC2h5wGuPdqtJZt7I24Ixwt15uVBOr8AFkTFAj3n4YKhHKE+4/s3QFo/QQqg22JfwoRjFGFexpKwZAEtPxUfDq3AR1t7D6w99QLLEYUhlJ5EWwyhoVj5l0u1y+XMWXqL0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DFW5unBxySXsdZoDt/BwXbAXfwpm5ZfnnoKG2PGq3lk=; b=KjZvnbvoazgnybQ2R1pRYOyGfnTzRnFt8/iYCCpfED9PVSyy4/4clfX5fHrugS4cLJg2oq6tKafe6d0nw1OGKUQ+wxrpdzL6DVD3VS8YrUWfn/Mowrio4lUB4nR4jyiFOxuSTMOI4COcvnjx1xt63WVF8gQSSQo0+EbO2JeyaGPFKQdpVJnXntGgN3OAj8w4VlWcrUglViQu8xnio5S49YFmYi8rsoNdVxmYj4PlesAGsnrBPbPxkg7WQ2s8d/H8/66jGcQYsC+diUDUMYlQ2oJIPbOmRUogWDKnEPFJ7wQzdaxPAR8nC3WFhVwQkSCp4rmg94OqhiDmH6nNtmPRHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by MN0PR11MB6277.namprd11.prod.outlook.com (2603:10b6:208:3c3::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.29; Thu, 9 Mar 2023 03:03:41 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::930b:6671:e4f0:4ebc]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::930b:6671:e4f0:4ebc%3]) with mapi id 15.20.6156.029; Thu, 9 Mar 2023 03:03:41 +0000 From: "Xia, Chenbo" To: Nobuhiro MIKI , "maxime.coquelin@redhat.com" CC: "dev@dpdk.org" Subject: RE: [PATCH 2/2] vhost: refactor to follow new naming convention Thread-Topic: [PATCH 2/2] vhost: refactor to follow new naming convention Thread-Index: AQHZUiv7V85mNqhPCE2zlyc7kWR4Tq7xwY2Q Date: Thu, 9 Mar 2023 03:03:41 +0000 Message-ID: References: <20230309020721.22164-1-nmiki@yahoo-corp.jp> <20230309020721.22164-3-nmiki@yahoo-corp.jp> In-Reply-To: <20230309020721.22164-3-nmiki@yahoo-corp.jp> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB3504:EE_|MN0PR11MB6277:EE_ x-ms-office365-filtering-correlation-id: d91c6f34-3daa-4f51-0e44-08db204ae35e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jM2kEDUTEqfr5AVsw/xRGZXy2pbNxyeeE515s+4hTEr8GsgNm/9yr3/GETdlRhsK1fBD6K1ZplyYrHqnrtWG08UEXjPo15+zXt++H2ijLfAuZbw5Z2mY47Q2pOntAeJwAS+/epTogkaBS9RG1zAvK+34WJa/Wc9bL80tNQs65J8I/NriVjEuwKnE0rR6wzH+iPLb0cIJO9SPKNgj3lHsPXx9/wXjcHzTHe/nAF/6NTRJ7W5zD6xMGcsSSn5YE3UMVf6jip/bCLSuJ5B6OqN7NtoLNpU2C7B6lmSaxPcK+YF8KL8ww7VrgBNmEDCwwN/N5Jk/yick9CXa9Aj66cbk4AE/UW+HS6Agp6yMkuNZSWI52iUe66vFkF/WkVDmcjWJhkuGveR7ZSm4FvH6HcMVgHuBeHtMVKTCAO+aVcGxhLCmXegbUB+lwAVAZKrjnlkyecHUevXcFP8zHgveCWNM3Sx5+0CNZvB6vsjigJe1eUm7LYnpmIXrX7q6aPHNzk7X+8Fekn20z50cm1VX4Qgz3vh6DHzFIeWzCBzJ9jJv4UaDe/cR5JwTDjhkfX+T5yR/EBrSMD2XjHYOref/M9koIueZZKvvUNRvNMBRO6N4J0Fw2pmR7XrmoRVvrOQ61BoFAzGmXiPsMXMNCf230YxX/sqpFDPNTytk21/9qFQQD0X24vffN8a8G4Rnod9Ah7ms1Nj/Tp4oHNVKCLxd8GOAfw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(136003)(396003)(39860400002)(346002)(376002)(366004)(451199018)(5660300002)(478600001)(9686003)(186003)(53546011)(83380400001)(26005)(38070700005)(86362001)(55016003)(2906002)(6506007)(33656002)(7696005)(71200400001)(316002)(41300700001)(64756008)(66476007)(66556008)(66446008)(4326008)(8676002)(122000001)(66946007)(76116006)(82960400001)(8936002)(38100700002)(52536014)(110136005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?blTS19H2bkfWn3mrPT8SxfJ6tOGCim77Ehk6SCiIPeqDns+ESlSF+uqJpVrI?= =?us-ascii?Q?XzogTxaAQ+nM+kKc9jOmVNElI8b3WcwEj0GUcqmNvSLVymOvYCe8qDwiKLlK?= =?us-ascii?Q?qspmwILCyFAGmrxgdRXs9Vh4yLEC91I6BvYBaizIZTzp58wHgOPkBvwyrCvf?= =?us-ascii?Q?7bucuwtLkNjNmVIx7oYZMBeSyI4ZzG5mwXHROUyai+IZJyW/1qy4LQD1hT6F?= =?us-ascii?Q?sIWYPXMrjSNOzHpSizTRG9rOe4dra7smOJ/gOSeKWfif6WHFMxHcRP4tRTRB?= =?us-ascii?Q?8rOxBWiIg9rd6xZx4Qy2yx1xuw/gZ4Y/yQbbaU09nidkD07A8pZfwyC0qQ32?= =?us-ascii?Q?0l1et2G1VlwAti5DHF76cK4IB4JLi50gP72f1H9trNOww1cH2kOl0HrIbI9X?= =?us-ascii?Q?4Yhk6W4fFVJkm0zqqddXDsczOccsf11rsfvPgti7agSUVLOeBsVR4VBDY8Mn?= =?us-ascii?Q?XbgqYXsCh7O42JUSA0IL0EpJyBOApYpr80O+sPfvLAbOXQ0EU5si0w0PZ3WP?= =?us-ascii?Q?Q+NQCwAqrqlDApWqbenTcf7thlZDVtBg8OBANxrJ9JIJdwcOwwIKWwJ5ukQF?= =?us-ascii?Q?+MPVhS625lMtFLdQwMWoxJVQPI/66mTet2HpObWgJvQLW2t5xopi9HV4juc5?= =?us-ascii?Q?JwZy480W94LS4kjNdcJCKYKxDtK5j4ek69uvAHuLJMgGZyS3G6vQIfdMEPtZ?= =?us-ascii?Q?NTHiO4dJ9voDtwG1nOw0EUeqI6+vv5eioNG2bY7XiF2yTRIzHiKpgHJLVKsw?= =?us-ascii?Q?3tApiXK/wj6mvv128phPfp7jeqHgFjrRh2pUoEzfo1vMvFIt1BiXEtc7ho19?= =?us-ascii?Q?a2g6//cBtlpq2x3st8IP0wJbLrfdJ5ayVqTzKP1wccwf5jFuE+9XW/u2+U+E?= =?us-ascii?Q?4C5vf9acApjD28fGfE9v7noIq6p1TgjLjOwaNthA2nWfJooLRKrzlmhAZI16?= =?us-ascii?Q?0ZI8kcJHB6Bwb0p6hst8FYISMoEGfRSqSuLMWuOQ3nShHbqIrPXKVIzwyRys?= =?us-ascii?Q?Lq9RZYOWsF0XDsAXTPMuRxw22cjkj2Hbxxwk8FFYsghH/pHVJAst61gvDpSl?= =?us-ascii?Q?s3PuYM8dp/gVAeh2nH+/8fvqjpmxEkMin8Zbi1MzXGxBeOOlHzjrw6YkPFA4?= =?us-ascii?Q?6f9tbPE/7W6B0/GUBBuhQ4ZKzJdRxGbTRqXTJdZ7fdLwuNVUqGmSaQdbngkS?= =?us-ascii?Q?dUFl4XQVoNSIqco/qTrOkI3qLWX5coN4MGoiddI1P4MmZBu8/IA4fd9sYt4J?= =?us-ascii?Q?7gqRqoVanpR2ogpAxcw2SMOrp3XMZDjplf2tcEb5fZ9Z/VrmKeMIuXwLkPlj?= =?us-ascii?Q?c22VjN0Jf1ChW2JI9CJaEEX0ChRurRjOOMYey1e3aB2JadYW75rS2vBUt3xP?= =?us-ascii?Q?yxMP90ZMi1omUwVPvcGh3YOw/pZa51p+gM1maf+sfj2DPe9sltUegXQavBP0?= =?us-ascii?Q?d9dnyeAX3w334xdvLXAk5aLJJqrvWgrjY1A+EFgNCwTWg9P5XYvEh03mwe8l?= =?us-ascii?Q?RWfW8M0hMga7QmNv817YnYIPTEPmtbGFqr1IXFInWI5p0cE7ibLpCyBxT/Hd?= =?us-ascii?Q?3czf4JBMNXE1DIgNJwmp7ekh+Z88xbEO+oh3T33y?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d91c6f34-3daa-4f51-0e44-08db204ae35e X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Mar 2023 03:03:41.6693 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IBPhSSMdIx6L6ZxnEJA7ZA2ntNXRcvPK6+F5HPA2GaByFRpeuCGeuJ8ye9upizNtUM1wdOlWZeoNfPdcaxlzUw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6277 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Nobuhiro, Thanks for the work, check comments inline. > -----Original Message----- > From: Nobuhiro MIKI > Sent: Thursday, March 9, 2023 10:07 AM > To: maxime.coquelin@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; Nobuhiro MIKI > Subject: [PATCH 2/2] vhost: refactor to follow new naming convention >=20 > Simply replace '_slave_' with '_backend_'. >=20 > Signed-off-by: Nobuhiro MIKI > --- > drivers/vdpa/ifc/ifcvf_vdpa.c | 2 +- > lib/vhost/rte_vhost.h | 2 +- > lib/vhost/version.map | 2 +- > lib/vhost/vhost.c | 4 +-- > lib/vhost/vhost.h | 4 +-- > lib/vhost/vhost_user.c | 62 +++++++++++++++++------------------ > lib/vhost/vhost_user.h | 6 ++-- > 7 files changed, 41 insertions(+), 41 deletions(-) >=20 > diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.= c > index fe4d278c5380..e4133568c1aa 100644 > --- a/drivers/vdpa/ifc/ifcvf_vdpa.c > +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c > @@ -605,7 +605,7 @@ virtio_interrupt_handler(struct ifcvf_internal > *internal) ... >=20 > typedef struct VhostUserMemoryRegion { > uint64_t guest_phys_addr; > @@ -137,7 +137,7 @@ struct vhost_user_config { > typedef struct VhostUserMsg { > union { > uint32_t master; /* a VhostUserRequest value */ > - uint32_t slave; /* a VhostUserSlaveRequest value*/ > + uint32_t backend; /* a VhostUserBackendRequest value*/ I think we should rename the master to front-end too (as QEMU spec says) If you can also replace all the 'masters' with front-end too, we will appre= ciate that much.. BTW, I guess this is your first patch, you need to update .mailmap file wit= h your name and email address. Thanks, Chenbo > } request; >=20 > #define VHOST_USER_VERSION_MASK 0x3 > -- > 2.31.1