From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7AA6EA0556; Mon, 17 Oct 2022 08:59:05 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 128C340143; Mon, 17 Oct 2022 08:59:05 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 2861B400D7 for ; Mon, 17 Oct 2022 08:59:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665989943; x=1697525943; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=FvZgImbvYelEYYo9it7zd7PoPMNGRnfS5ndYnbRF+ng=; b=E8bPEyB2gp9G59HuTKyy+onjWfbNSUX736b/W2eT9bmjR1HEjxxg2eAu bZoJSj1TsIRB13Iis5IKWxuw7xUf3M9bTXQj7tVTtOLowdta6E4icQ3SK 5KT6mtAE12Ye3jCiBEKb6M+vnzwYiDASq+2MqmjioK0juH42m0z+Qsh+e nbkxwZgTIx4DCXskPnlgyAtZUqpaWP4+EG7vJSXRcvf4fiTCxQz6SmFyg qapXq9Gcj09ARa7w5bf9ymayYdtcJVMfuQ0rqSBmbq7ZLzhHvYUPw5XIA CEsMK4w74xGdxHW3wxhUc1EA9vLWhgD2T2zQxypAKlGTmUiH5b77ZR+Op g==; X-IronPort-AV: E=McAfee;i="6500,9779,10502"; a="293090333" X-IronPort-AV: E=Sophos;i="5.95,190,1661842800"; d="scan'208";a="293090333" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Oct 2022 23:59:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10502"; a="873361408" X-IronPort-AV: E=Sophos;i="5.95,190,1661842800"; d="scan'208";a="873361408" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga006.fm.intel.com with ESMTP; 16 Oct 2022 23:59:02 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sun, 16 Oct 2022 23:59:01 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sun, 16 Oct 2022 23:59:01 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Sun, 16 Oct 2022 23:59:01 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.101) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Sun, 16 Oct 2022 23:59:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X9aGbOd20uNI2dz3eb6aWnzErf7AFghhHzIarJqVYi4JwGut47svs50mc13ySkwsZlM9EFBJND6kpuDJ0CG4e++abDlscOZr6EL7YLbHtG9y7LE81DLh2EwTRAGAheMmz5mCxu8xGB5xu7SvdKPYx3n/POpqq6AO3cnn5/yecqzd3ERDp8BHiqEy9vR/7i/GXsQEyJqMZqLmCYVBAIWfZu6D1xaaSjj5Ks9mfU+RZ+ITd4nASx+U/9Kca1k2YFQuENho9tahwR+PkSqzEL1ayAErt83olhGY5P41tyNs7yXGpsIq74n6kyVapLBHBKjY5yHAcLILr6h5WzJ6kvv1jQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ng8tTOSCH/tVruT4GTPXWOz96KH1r1goPMwBuvLoFH0=; b=jeXGGKeeB1kzwtujGo8hyrDlwnfgxodq7NEhIUfwkBBr0f6kc1f+hLGtfIE+zzg40k3jfJmac11w9pvGLLc8X0K2+pp6FIKCASfw862qPdikzV0Bg/A8uBcUQDUPeRfNLil6ILXSL/48wXDHXuC+pd9PyaQ5Q1ttxmDVOM91i+aJ5cyntvn6CVpx8XZlleee8O5H0QIF6Nirq85wW4euXYhp8bpAPV7Ti22YDwcvuvzWce9y7HnX6LhRuhN8tE1nuxEedXHkoMjMd74bzo2F99lPd1NuPHJVU605FmjAsPdOi5pVtVyCIZeuC+7/zEHFk1NEBBCq1vclUjzh1+FoqQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by SJ0PR11MB6741.namprd11.prod.outlook.com (2603:10b6:a03:47a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Mon, 17 Oct 2022 06:58:59 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::39bf:57b1:4824:d40d]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::39bf:57b1:4824:d40d%6]) with mapi id 15.20.5723.030; Mon, 17 Oct 2022 06:58:59 +0000 From: "Xia, Chenbo" To: "Matz, Olivier" , "dev@dpdk.org" CC: Maxime Coquelin Subject: RE: [PATCH] net/virtio: add queue and port ID in some logs Thread-Topic: [PATCH] net/virtio: add queue and port ID in some logs Thread-Index: AQHY0/4wV+5qR7vTBEufYJYtpuqgf64SQ21A Date: Mon, 17 Oct 2022 06:58:59 +0000 Message-ID: References: <20220929122228.1170-1-olivier.matz@6wind.com> In-Reply-To: <20220929122228.1170-1-olivier.matz@6wind.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB3504:EE_|SJ0PR11MB6741:EE_ x-ms-office365-filtering-correlation-id: 5f8cf2f9-f9ad-430e-2a77-08dab00d1122 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cgKkHcPB0jSJkoD1seXm66AXAZQBNpJl+cU+HeLKyv/VRCS4Fw4Ox9wUAITsyMlEB/ooovKWL2eP6zZCYj9QyVfKtDjF2WHwFPJPe406y5Tqzz6TtHR4YgKzWZeKxwRgeMCV20N/o9TGGaUZuBKCJCn8biAFPFKK7RMCEmNhKe9KbXjeXXfZxrPu10fKaQYxCySksHEQ8ZDJXKMy9SH8NVp2APCgydMPspBjSf6KFb+nayfqWkdtXNpI5Ffh6vxjuGNDWzwGHEzNQy5H6UikkCfAdsLcY6LiSwqhphPDDagKU3Pei2dbLnAqqpmFtrSefE26sxd7597DWK45F2MvzBcYjcPa/uorAldpQ/AZfHCt1n0GlocP1DpzD0SH8NKCwToW6hDSc0ABe70tFizTC+Vg6kp/enVh6waVLhTVaodH//rr2szIbPgo1itul6d00cJp81xPqi6z60hHHDY0tJfk5vmSdkGTUdXx9Oa6GkikhCImdNM7B4QRg+PHxZDNg7F+mZKNUkyhE3VahOWEwqNnGXYNfk4ceOuH0IyWUD84LdxI9n5dCSnfTbdJYKmwXV7kOmUtn5IW/JlScS+ymOsi9IS76MBRakp9NSqfB6WOJodhNcqmMDGEGOirpp5MzghqGhX+BrqVSwl8kyzXDu1wPbitIMQocCrpLtSplqWX9sjUNsG0L1c4g4sFffdTacdpBM/sWqKodCVpEWn9wjZlnRdPjzF97W6GyC6RiO/c+sGd6oAUE3aWmOY97j0bcD0OycOXW1mFfEZFJkwg/Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(136003)(366004)(396003)(39860400002)(346002)(376002)(451199015)(2906002)(5660300002)(4326008)(8676002)(64756008)(66446008)(66556008)(66476007)(8936002)(52536014)(316002)(66946007)(76116006)(122000001)(478600001)(33656002)(41300700001)(71200400001)(110136005)(7696005)(6506007)(26005)(83380400001)(38070700005)(9686003)(38100700002)(55016003)(86362001)(53546011)(186003)(82960400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?KSLvtEvg7zeZpskK0IdzmxwLtn8tbKz6dSkGlmnzctk3VBgCxfKlJ17ccu9w?= =?us-ascii?Q?Nx0pzZJgcw40AsVUkQdeBheAE8g4RZMYUSn/FeyRKbZ+UrBvxQY9rYhbG0Tj?= =?us-ascii?Q?AunhmJu/SpsVngWd7oiMcI1tEEd1R9l2z7VjjLI+3SlNVO2ZCxHUYbSJcw3j?= =?us-ascii?Q?8fBt+V9+5fuAvWTwOOE5F53rpSq+0ByaVi2/eS3hLExSCr/SDr5lqxMi5bjT?= =?us-ascii?Q?XDlaiav/cbZpjZ1RvTbKjib1ASgWDEpvcxD0VF6C6hu57XOTXkVH+ng7AU/m?= =?us-ascii?Q?Fazz4v2xn9I2uomEDAHAKEaJXZOiMg6CXUVtfyAYGIIRTTB+wXoDRsWLy5hA?= =?us-ascii?Q?rr151gyfHoUkfPRmyfphIkvhcdXWMnBtgR6mBu/qLkAx63ywk+h8KiYghxZo?= =?us-ascii?Q?BLCEWcv/zXLC5DXCC8y2bZk8CKxeoEG2CFS8scWagyf6q0AhuXEpc95OhrFH?= =?us-ascii?Q?VatDc7g8CEC6VaVFxdwxG+4rVLda8SBDPaNcpC5NFe69bTmlUHJNnY089yq1?= =?us-ascii?Q?WbRwZKzlVuJ7Du5a8NfQf2jQ0m5tkqbicDzNU24oDPcV/dXGN1hHAccTrr2z?= =?us-ascii?Q?CtTzAvu1doJxE7uT1hfY3gS4h8ms1jgbvTa+YhZQy5+fUA7DUuTyFNRtv7hL?= =?us-ascii?Q?Vv25xPo5sl9LJorG9PwZ2RFxTd817KZJi1sGd/yspKdCyKg7mqBRYRR6E+JN?= =?us-ascii?Q?MKCXrvIZRu/H6iCPNfYXO0oqj3Sv5DeblSlz04lOMgfZuxAhAEoK/MSO0ZpL?= =?us-ascii?Q?yr7pNidgqy9TmNp5ZuUNfv/qDVCSPRfVdMQqQ5v9zQO70HWNdny+mLOsu1MA?= =?us-ascii?Q?CvVrrJL7wu9uZJaJ5VDbgQOH2zPUNZdu3iOD5T7ljUTD65A02pxbAlXQ+PkF?= =?us-ascii?Q?P/bWviaeizT74Mrz8YvD+lOvjsrSQIL+SnqkQ1wW6sc9vWLhXLjCFDums5cS?= =?us-ascii?Q?+x1vif5XwzWZ1TbL0Kk2cpXoa6hLhhkq2K7n24rAMg1djiRE6DUOCE7kb9Us?= =?us-ascii?Q?t8mYRw6fciVjzPQWmfsewPAC9hPmBvuWk7Dc2bRNVIv6b3nNWZz1587AY2ne?= =?us-ascii?Q?FVBARiFU4zMSXhMoTBosviJuGImCLtS7UqR/lq4ZkP2PfguvmdVhjimUBRRW?= =?us-ascii?Q?CvlRTyCVjy05rFofPgUXzbeHFgX215mwzhOjRXDUHblZhBt2kxEeMMgiIUBh?= =?us-ascii?Q?QipP9KUouYez7cQ04Q7XXkh0GpAWkEtg7Qf5+6kl2qqDWhLbw2n20UkXi2YV?= =?us-ascii?Q?p9ycD4mIvXemENXOiz3H8AJKMJ/AJsnQQntrvNT5RnIoaABsEkme3yIv3mcN?= =?us-ascii?Q?L07FuEiZ4HpquFZ5CCKlyLlyUv93OMTbNxBFGfCeiw09lxV1ZaxPHYZeful9?= =?us-ascii?Q?e+gS985hOxuWbtQI0dSpgKHc5AG9+V68uoQUnaJcHUu0VGXJeJGAKSqZOW8j?= =?us-ascii?Q?AxGYgVq7SCpE+kd/vVMA5YpIxaMdwyy0u9HfD7fLKlFpjcd3cIYkF7glS8N0?= =?us-ascii?Q?Qx/rn2WJK2phSZlxXRtY+8bKTnIMpVOdLR7QRX4G5jeiqlAboy9rQBNCm8On?= =?us-ascii?Q?HAkSMbhfT7akcIThaM+Bv041HS5XI5HJ6Ga5n6b8?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5f8cf2f9-f9ad-430e-2a77-08dab00d1122 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Oct 2022 06:58:59.4392 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3L1c9RmIy9tZlniJMwUK7u9varPqWXmkukawB6REpnrk7a81i5ghPL2V3ot7ikdgDvNaOkvoWt3z4zPm41byaA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB6741 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Olivier, > -----Original Message----- > From: Olivier Matz > Sent: Thursday, September 29, 2022 8:22 PM > To: dev@dpdk.org > Cc: Maxime Coquelin ; Xia, Chenbo > > Subject: [PATCH] net/virtio: add queue and port ID in some logs >=20 > Add the queue id and/or the port id in some logs, so it is easier to > understand what happens. >=20 > Signed-off-by: Olivier Matz > --- > drivers/net/virtio/virtio_ethdev.c | 6 ++++-- > drivers/net/virtio/virtio_rxtx.c | 3 ++- > 2 files changed, 6 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/net/virtio/virtio_ethdev.c > b/drivers/net/virtio/virtio_ethdev.c > index 7e07270a8b..44811c299b 100644 > --- a/drivers/net/virtio/virtio_ethdev.c > +++ b/drivers/net/virtio/virtio_ethdev.c > @@ -2807,7 +2807,8 @@ virtio_dev_start(struct rte_eth_dev *dev) > return -EINVAL; > } >=20 > - PMD_INIT_LOG(DEBUG, "nb_queues=3D%d", nb_queues); > + PMD_INIT_LOG(DEBUG, "nb_queues=3D%d (port=3D%d)", nb_queues, > + dev->data->port_id); Better to use %u for all port_id since it's uint16_t Thanks, Chenbo >=20 > for (i =3D 0; i < dev->data->nb_rx_queues; i++) { > vq =3D virtnet_rxq_to_vq(dev->data->rx_queues[i]); > @@ -2821,7 +2822,8 @@ virtio_dev_start(struct rte_eth_dev *dev) > virtqueue_notify(vq); > } >=20 > - PMD_INIT_LOG(DEBUG, "Notified backend at initialization"); > + PMD_INIT_LOG(DEBUG, "Notified backend at initialization (port=3D%d)", > + dev->data->port_id); >=20 > for (i =3D 0; i < dev->data->nb_rx_queues; i++) { > vq =3D virtnet_rxq_to_vq(dev->data->rx_queues[i]); > diff --git a/drivers/net/virtio/virtio_rxtx.c > b/drivers/net/virtio/virtio_rxtx.c > index 4795893ec7..f8a9ee5cdb 100644 > --- a/drivers/net/virtio/virtio_rxtx.c > +++ b/drivers/net/virtio/virtio_rxtx.c > @@ -793,7 +793,8 @@ virtio_dev_rx_queue_setup_finish(struct rte_eth_dev > *dev, uint16_t queue_idx) > vq_update_avail_idx(vq); > } >=20 > - PMD_INIT_LOG(DEBUG, "Allocated %d bufs", nbufs); > + PMD_INIT_LOG(DEBUG, "Allocated %d bufs (port=3D%d queue=3D%d)", nbufs, > + dev->data->port_id, queue_idx); >=20 > VIRTQUEUE_DUMP(vq); >=20 > -- > 2.30.2