[PATCH] vhost: promote per-queue stats API to stable

[PATCH] vhost: promote per-queue stats API to stable

[Maxime Coquelin]

This patch promotes the per-queue stats API to stable.
The API has been used by the Vhost PMD since v22.07, and
David Marchand posted a patch to make use of it in next
OVS release[0].

[0]: http://patchwork.ozlabs.org/project/openvswitch/patch/20221007111613.1695524-4-david.marchand@redhat.com/

Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
---
 doc/guides/rel_notes/release_22_11.rst | 4 ++++
 lib/vhost/rte_vhost.h                  | 3 ---
 lib/vhost/version.map                  | 6 +++---
 3 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/doc/guides/rel_notes/release_22_11.rst b/doc/guides/rel_notes/release_22_11.rst
index 37bd392f34..d5d3eeae24 100644
--- a/doc/guides/rel_notes/release_22_11.rst
+++ b/doc/guides/rel_notes/release_22_11.rst
@@ -443,6 +443,10 @@ API Changes
 
 * raw/ifgpa: The function ``rte_pmd_ifpga_get_pci_bus`` has been removed.
 
+* vhost: Promoted ``rte_vhost_vring_stats_get()``,
+  ``rte_vhost_vring_stats_get_names()`` and ``rte_vhost_vring_stats_reset()``
+  from experimental to stable.
+
 
 ABI Changes
 -----------
diff --git a/lib/vhost/rte_vhost.h b/lib/vhost/rte_vhost.h
index bb7d86a432..59c98a0afb 100644
--- a/lib/vhost/rte_vhost.h
+++ b/lib/vhost/rte_vhost.h
@@ -1075,7 +1075,6 @@ rte_vhost_slave_config_change(int vid, bool need_reply);
  *  - Failure if lower than 0. The device ID or queue ID is invalid or
  +    statistics collection is not enabled.
  */
-__rte_experimental
 int
 rte_vhost_vring_stats_get_names(int vid, uint16_t queue_id,
 		struct rte_vhost_stat_name *name, unsigned int size);
@@ -1103,7 +1102,6 @@ rte_vhost_vring_stats_get_names(int vid, uint16_t queue_id,
  *  - Failure if lower than 0. The device ID or queue ID is invalid, or
  *    statistics collection is not enabled.
  */
-__rte_experimental
 int
 rte_vhost_vring_stats_get(int vid, uint16_t queue_id,
 		struct rte_vhost_stat *stats, unsigned int n);
@@ -1120,7 +1118,6 @@ rte_vhost_vring_stats_get(int vid, uint16_t queue_id,
  *  - Failure if lower than 0. The device ID or queue ID is invalid, or
  *    statistics collection is not enabled.
  */
-__rte_experimental
 int
 rte_vhost_vring_stats_reset(int vid, uint16_t queue_id);
 
diff --git a/lib/vhost/version.map b/lib/vhost/version.map
index 7a00b65740..8c5e8aa8d3 100644
--- a/lib/vhost/version.map
+++ b/lib/vhost/version.map
@@ -57,6 +57,9 @@ DPDK_23 {
 	rte_vhost_set_vring_base;
 	rte_vhost_va_from_guest_pa;
 	rte_vhost_vring_call;
+	rte_vhost_vring_stats_get;
+	rte_vhost_vring_stats_get_names;
+	rte_vhost_vring_stats_reset;
 
 	local: *;
 };
@@ -88,9 +91,6 @@ EXPERIMENTAL {
 
 	# added in 22.07
 	rte_vhost_async_get_inflight_thread_unsafe;
-	rte_vhost_vring_stats_get_names;
-	rte_vhost_vring_stats_get;
-	rte_vhost_vring_stats_reset;
 	rte_vhost_async_try_dequeue_burst;
 	rte_vhost_driver_get_vdpa_dev_type;
 	rte_vhost_clear_queue;
-- 
2.37.3

Re: [PATCH] vhost: promote per-queue stats API to stable

[David Marchand]

On Mon, Oct 10, 2022 at 5:37 PM Maxime Coquelin
<maxime.coquelin@redhat.com> wrote:
>
> This patch promotes the per-queue stats API to stable.
> The API has been used by the Vhost PMD since v22.07, and
> David Marchand posted a patch to make use of it in next
> OVS release[0].
>
> [0]: http://patchwork.ozlabs.org/project/openvswitch/patch/20221007111613.1695524-4-david.marchand@redhat.com/
>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
>  doc/guides/rel_notes/release_22_11.rst | 4 ++++
>  lib/vhost/rte_vhost.h                  | 3 ---
>  lib/vhost/version.map                  | 6 +++---
>  3 files changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/doc/guides/rel_notes/release_22_11.rst b/doc/guides/rel_notes/release_22_11.rst
> index 37bd392f34..d5d3eeae24 100644
> --- a/doc/guides/rel_notes/release_22_11.rst
> +++ b/doc/guides/rel_notes/release_22_11.rst
> @@ -443,6 +443,10 @@ API Changes
>
>  * raw/ifgpa: The function ``rte_pmd_ifpga_get_pci_bus`` has been removed.
>

Nit: in the RN, vhost library updates go earlier.


> +* vhost: Promoted ``rte_vhost_vring_stats_get()``,
> +  ``rte_vhost_vring_stats_get_names()`` and ``rte_vhost_vring_stats_reset()``
> +  from experimental to stable.
> +
>
>  ABI Changes
>  -----------
> diff --git a/lib/vhost/rte_vhost.h b/lib/vhost/rte_vhost.h
> index bb7d86a432..59c98a0afb 100644
> --- a/lib/vhost/rte_vhost.h
> +++ b/lib/vhost/rte_vhost.h
> @@ -1075,7 +1075,6 @@ rte_vhost_slave_config_change(int vid, bool need_reply);
>   *  - Failure if lower than 0. The device ID or queue ID is invalid or
>   +    statistics collection is not enabled.
>   */
> -__rte_experimental
>  int
>  rte_vhost_vring_stats_get_names(int vid, uint16_t queue_id,
>                 struct rte_vhost_stat_name *name, unsigned int size);
> @@ -1103,7 +1102,6 @@ rte_vhost_vring_stats_get_names(int vid, uint16_t queue_id,
>   *  - Failure if lower than 0. The device ID or queue ID is invalid, or
>   *    statistics collection is not enabled.
>   */
> -__rte_experimental
>  int
>  rte_vhost_vring_stats_get(int vid, uint16_t queue_id,
>                 struct rte_vhost_stat *stats, unsigned int n);
> @@ -1120,7 +1118,6 @@ rte_vhost_vring_stats_get(int vid, uint16_t queue_id,
>   *  - Failure if lower than 0. The device ID or queue ID is invalid, or
>   *    statistics collection is not enabled.
>   */
> -__rte_experimental
>  int
>  rte_vhost_vring_stats_reset(int vid, uint16_t queue_id);
>
> diff --git a/lib/vhost/version.map b/lib/vhost/version.map
> index 7a00b65740..8c5e8aa8d3 100644
> --- a/lib/vhost/version.map
> +++ b/lib/vhost/version.map
> @@ -57,6 +57,9 @@ DPDK_23 {
>         rte_vhost_set_vring_base;
>         rte_vhost_va_from_guest_pa;
>         rte_vhost_vring_call;
> +       rte_vhost_vring_stats_get;
> +       rte_vhost_vring_stats_get_names;
> +       rte_vhost_vring_stats_reset;
>
>         local: *;
>  };
> @@ -88,9 +91,6 @@ EXPERIMENTAL {
>
>         # added in 22.07
>         rte_vhost_async_get_inflight_thread_unsafe;
> -       rte_vhost_vring_stats_get_names;
> -       rte_vhost_vring_stats_get;
> -       rte_vhost_vring_stats_reset;
>         rte_vhost_async_try_dequeue_burst;
>         rte_vhost_driver_get_vdpa_dev_type;
>         rte_vhost_clear_queue;
> --
> 2.37.3
>

Acked-by: David Marchand <david.marchand@redhat.com>


-- 
David Marchand

RE: [PATCH] vhost: promote per-queue stats API to stable

[Xia, Chenbo]

> -----Original Message-----
> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> Sent: Monday, October 10, 2022 11:38 PM
> To: dev@dpdk.org; Xia, Chenbo <chenbo.xia@intel.com>;
> david.marchand@redhat.com
> Cc: Maxime Coquelin <maxime.coquelin@redhat.com>
> Subject: [PATCH] vhost: promote per-queue stats API to stable
> 
> This patch promotes the per-queue stats API to stable.
> The API has been used by the Vhost PMD since v22.07, and
> David Marchand posted a patch to make use of it in next
> OVS release[0].
> 
> [0]:
> http://patchwork.ozlabs.org/project/openvswitch/patch/20221007111613.16955
> 24-4-david.marchand@redhat.com/
> 
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
>  doc/guides/rel_notes/release_22_11.rst | 4 ++++
>  lib/vhost/rte_vhost.h                  | 3 ---
>  lib/vhost/version.map                  | 6 +++---
>  3 files changed, 7 insertions(+), 6 deletions(-)
> 
> diff --git a/doc/guides/rel_notes/release_22_11.rst
> b/doc/guides/rel_notes/release_22_11.rst
> index 37bd392f34..d5d3eeae24 100644
> --- a/doc/guides/rel_notes/release_22_11.rst
> +++ b/doc/guides/rel_notes/release_22_11.rst
> @@ -443,6 +443,10 @@ API Changes
> 
>  * raw/ifgpa: The function ``rte_pmd_ifpga_get_pci_bus`` has been removed.
> 
> +* vhost: Promoted ``rte_vhost_vring_stats_get()``,
> +  ``rte_vhost_vring_stats_get_names()`` and
> ``rte_vhost_vring_stats_reset()``
> +  from experimental to stable.
> +
> 
>  ABI Changes
>  -----------
> diff --git a/lib/vhost/rte_vhost.h b/lib/vhost/rte_vhost.h
> index bb7d86a432..59c98a0afb 100644
> --- a/lib/vhost/rte_vhost.h
> +++ b/lib/vhost/rte_vhost.h
> @@ -1075,7 +1075,6 @@ rte_vhost_slave_config_change(int vid, bool
> need_reply);
>   *  - Failure if lower than 0. The device ID or queue ID is invalid or
>   +    statistics collection is not enabled.
>   */
> -__rte_experimental
>  int
>  rte_vhost_vring_stats_get_names(int vid, uint16_t queue_id,
>  		struct rte_vhost_stat_name *name, unsigned int size);
> @@ -1103,7 +1102,6 @@ rte_vhost_vring_stats_get_names(int vid, uint16_t
> queue_id,
>   *  - Failure if lower than 0. The device ID or queue ID is invalid, or
>   *    statistics collection is not enabled.
>   */
> -__rte_experimental
>  int
>  rte_vhost_vring_stats_get(int vid, uint16_t queue_id,
>  		struct rte_vhost_stat *stats, unsigned int n);
> @@ -1120,7 +1118,6 @@ rte_vhost_vring_stats_get(int vid, uint16_t queue_id,
>   *  - Failure if lower than 0. The device ID or queue ID is invalid, or
>   *    statistics collection is not enabled.
>   */
> -__rte_experimental
>  int
>  rte_vhost_vring_stats_reset(int vid, uint16_t queue_id);
> 
> diff --git a/lib/vhost/version.map b/lib/vhost/version.map
> index 7a00b65740..8c5e8aa8d3 100644
> --- a/lib/vhost/version.map
> +++ b/lib/vhost/version.map
> @@ -57,6 +57,9 @@ DPDK_23 {
>  	rte_vhost_set_vring_base;
>  	rte_vhost_va_from_guest_pa;
>  	rte_vhost_vring_call;
> +	rte_vhost_vring_stats_get;
> +	rte_vhost_vring_stats_get_names;
> +	rte_vhost_vring_stats_reset;
> 
>  	local: *;
>  };
> @@ -88,9 +91,6 @@ EXPERIMENTAL {
> 
>  	# added in 22.07
>  	rte_vhost_async_get_inflight_thread_unsafe;
> -	rte_vhost_vring_stats_get_names;
> -	rte_vhost_vring_stats_get;
> -	rte_vhost_vring_stats_reset;
>  	rte_vhost_async_try_dequeue_burst;
>  	rte_vhost_driver_get_vdpa_dev_type;
>  	rte_vhost_clear_queue;
> --
> 2.37.3

Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>

RE: [PATCH] vhost: promote per-queue stats API to stable

[Xia, Chenbo]

> -----Original Message-----
> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> Sent: Monday, October 10, 2022 11:38 PM
> To: dev@dpdk.org; Xia, Chenbo <chenbo.xia@intel.com>;
> david.marchand@redhat.com
> Cc: Maxime Coquelin <maxime.coquelin@redhat.com>
> Subject: [PATCH] vhost: promote per-queue stats API to stable
> 
> This patch promotes the per-queue stats API to stable.
> The API has been used by the Vhost PMD since v22.07, and
> David Marchand posted a patch to make use of it in next
> OVS release[0].
> 
> [0]:
> http://patchwork.ozlabs.org/project/openvswitch/patch/20221007111613.16955
> 24-4-david.marchand@redhat.com/
> 
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
>  doc/guides/rel_notes/release_22_11.rst | 4 ++++
>  lib/vhost/rte_vhost.h                  | 3 ---
>  lib/vhost/version.map                  | 6 +++---
>  3 files changed, 7 insertions(+), 6 deletions(-)
> 
> diff --git a/doc/guides/rel_notes/release_22_11.rst
> b/doc/guides/rel_notes/release_22_11.rst
> index 37bd392f34..d5d3eeae24 100644
> --- a/doc/guides/rel_notes/release_22_11.rst
> +++ b/doc/guides/rel_notes/release_22_11.rst
> @@ -443,6 +443,10 @@ API Changes
> 
>  * raw/ifgpa: The function ``rte_pmd_ifpga_get_pci_bus`` has been removed.
> 
> +* vhost: Promoted ``rte_vhost_vring_stats_get()``,
> +  ``rte_vhost_vring_stats_get_names()`` and
> ``rte_vhost_vring_stats_reset()``
> +  from experimental to stable.
> +
> 
>  ABI Changes
>  -----------
> diff --git a/lib/vhost/rte_vhost.h b/lib/vhost/rte_vhost.h
> index bb7d86a432..59c98a0afb 100644
> --- a/lib/vhost/rte_vhost.h
> +++ b/lib/vhost/rte_vhost.h
> @@ -1075,7 +1075,6 @@ rte_vhost_slave_config_change(int vid, bool
> need_reply);
>   *  - Failure if lower than 0. The device ID or queue ID is invalid or
>   +    statistics collection is not enabled.
>   */
> -__rte_experimental
>  int
>  rte_vhost_vring_stats_get_names(int vid, uint16_t queue_id,
>  		struct rte_vhost_stat_name *name, unsigned int size);
> @@ -1103,7 +1102,6 @@ rte_vhost_vring_stats_get_names(int vid, uint16_t
> queue_id,
>   *  - Failure if lower than 0. The device ID or queue ID is invalid, or
>   *    statistics collection is not enabled.
>   */
> -__rte_experimental
>  int
>  rte_vhost_vring_stats_get(int vid, uint16_t queue_id,
>  		struct rte_vhost_stat *stats, unsigned int n);
> @@ -1120,7 +1118,6 @@ rte_vhost_vring_stats_get(int vid, uint16_t queue_id,
>   *  - Failure if lower than 0. The device ID or queue ID is invalid, or
>   *    statistics collection is not enabled.
>   */
> -__rte_experimental
>  int
>  rte_vhost_vring_stats_reset(int vid, uint16_t queue_id);
> 
> diff --git a/lib/vhost/version.map b/lib/vhost/version.map
> index 7a00b65740..8c5e8aa8d3 100644
> --- a/lib/vhost/version.map
> +++ b/lib/vhost/version.map
> @@ -57,6 +57,9 @@ DPDK_23 {
>  	rte_vhost_set_vring_base;
>  	rte_vhost_va_from_guest_pa;
>  	rte_vhost_vring_call;
> +	rte_vhost_vring_stats_get;
> +	rte_vhost_vring_stats_get_names;
> +	rte_vhost_vring_stats_reset;
> 
>  	local: *;
>  };
> @@ -88,9 +91,6 @@ EXPERIMENTAL {
> 
>  	# added in 22.07
>  	rte_vhost_async_get_inflight_thread_unsafe;
> -	rte_vhost_vring_stats_get_names;
> -	rte_vhost_vring_stats_get;
> -	rte_vhost_vring_stats_reset;
>  	rte_vhost_async_try_dequeue_burst;
>  	rte_vhost_driver_get_vdpa_dev_type;
>  	rte_vhost_clear_queue;
> --
> 2.37.3

Applied to next-virtio/main, thanks