From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 77BCAA0542; Wed, 26 Oct 2022 11:31:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3A0D240E28; Wed, 26 Oct 2022 11:31:29 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 4875F40041 for ; Wed, 26 Oct 2022 11:31:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666776687; x=1698312687; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=h4DkDTUnkOomEyjXbU8acKLAmQEUoCoekdJxF9/VlwM=; b=LYfHgbegsAUA+d6UGWeFqK+uffI8+bHYQ9b7qCvGdNU5vS+Goib+qJ9I oXiLNG7yLQMuhIoEBdle9/E+Dm3IE1xkdOJ0SX8xqZYkR59gGzAe8LB0r xqskrjnkRc2yBRmvHQJlOyOLkW+iH/W6yHxLOzsSr7R6ESjpwjZYwuCBq WR684SgmTF36mXSa3+qYJ5oW+cDpenZaz1GMSkYwYS9LkOHJPlW3y/tdZ h5gTpM8n0BiQ4Fs30cxVJl8+DIC9XufgqcW2y3DG9kWO1NNcZnd0YBqTA f+6Q+JYtvYdZl5LZdAw/nuakppiG4nOC14dcxZyKPn8LHGkRAThJYQUJn Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10511"; a="306632595" X-IronPort-AV: E=Sophos;i="5.95,214,1661842800"; d="scan'208";a="306632595" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2022 02:31:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10511"; a="757240773" X-IronPort-AV: E=Sophos;i="5.95,214,1661842800"; d="scan'208";a="757240773" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga004.jf.intel.com with ESMTP; 26 Oct 2022 02:31:25 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 26 Oct 2022 02:31:25 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 26 Oct 2022 02:31:25 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.46) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 26 Oct 2022 02:31:25 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BtIgs4lRtyxImmcwoyvXRiP+xMnL/6QFkkHltGOBvuZm0RGnUMaDkBEZjzhcx7kYUAyePDftr41C9CzzX/6IRLFq4C0gj6jD9EaO38gwIZNMEoRlMnRVFTORwMdyZLyZmIPRr301azupwGBragiffTj4ty2sjOReBNZqnBPnD0c9xONOemoTTssVpjgaOVwkievB9DiVk8M396JfZf7XJ3Kg1TDVoID3hsqbASbG1aO8M0c5dm78RKGWWgA8yTsHUpEdAO4UO3z5meUXOAjC6s5fDBQrmtJkB37HYGf8UDZP5eoqyL/mqs08PmG1F8tKRbPbhqMBTkK5WXpZe07rfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=C4+0y+O6/cZpXbwqeUNqjF2nZ4rnbrkB66+dt4t0Rls=; b=DGi5QfzmeWAaYvQ9Jv/j1P4ApKP80HbpfQl4xFYam9Dpb8cwzrKfQTr9PlqRmXGdlE1UwRX3oBoaCqBegY4Yz3E5mi2OdMQbwlg/Q9mIFNPcNhXBodf5IQksHnG0cBUPua2sRX2nHTNB64lLyimMBgzMMhsiR7E5kXYTY1pfeBBWp9ptn4Mk/EVUBnGR5fxpSadHZ/uopuRxG2moYjdN16K6f59WJA7VR0F3TbyPn1/SUfTy8cfaG6yqOtG1KzOXPhbw17E6tEWjF9e8Q4EpdTtflPmJ8H3sH5yNKJQDO5unxJfPnRLYkCNy1M0VEJEJrDE63U78D7lnhkYoilSYjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by PH7PR11MB5794.namprd11.prod.outlook.com (2603:10b6:510:131::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28; Wed, 26 Oct 2022 09:31:23 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::1a91:6a56:1250:ef0e]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::1a91:6a56:1250:ef0e%7]) with mapi id 15.20.5746.023; Wed, 26 Oct 2022 09:31:23 +0000 From: "Xia, Chenbo" To: Maxime Coquelin , "dev@dpdk.org" , "david.marchand@redhat.com" Subject: RE: [PATCH] vhost: promote per-queue stats API to stable Thread-Topic: [PATCH] vhost: promote per-queue stats API to stable Thread-Index: AQHY3L5UU6IF9f2vIEmw4ahm0pD8W64ggdrQ Date: Wed, 26 Oct 2022 09:31:23 +0000 Message-ID: References: <20221010153751.58951-1-maxime.coquelin@redhat.com> In-Reply-To: <20221010153751.58951-1-maxime.coquelin@redhat.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB3504:EE_|PH7PR11MB5794:EE_ x-ms-office365-filtering-correlation-id: 93c1b5b9-9f12-467e-cd6a-08dab734d949 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: LzDichNNv38jfH5JEEpraxbxrjaIJHY/qvmnCTqvwEzR9XykkSU+Loo4Na7g8k7NZdE3rHzN7fxaDSHaZ4sa3rhGDFU44VkQtG0sjL1ACHyjrwTraaXr3WlhkVD2u6iKnS33GmtBSDyY3Zcca+dIlI5P4Ms6SUqGquGu+vJW9OqSbTMCyj71iQi2ZDmi0VNOYd/xTg/E6mc+tmAac4X/7CpqEJMAqAj31+G+Q2Dw1h1ia1WxTg8New/+b+hE3G2jJwTacwV5Mwg/bAo1bh2xRqF8lPKwoOvBNS3aCZMSnU/HmsXW+O4aBvpqp3oiB6pKPgXKBPmvMeAwMYDyUnQOq5adyJuj9zuxooHmDA1EsLevAO4qIc1TEBQfqmgmNyb/JHjkBjyjzCtGwrrl8XyxNXkFwHGaBnEbd/XnpF2UzGTd7DGS1nlO5gfsJVxorxWXWF1Cd7610bBjMHGRFoBAdAfG6JghcDHHvYBCgTvfBp90TDGPZfKVa5oiOznCnkK4LDRMsUsmt1jsssHyttDrbMDh2GYGkpNZY7hfwXTXErQACIu+n/QKBUoSmpvIXWCcSLVZPTgRxh584vDNwj2YX7vcUY20J5WKtc/9YKefSAlmSFg0qY/EuTcS4gNlPvJ+aKli6BI+agZJLfwjJyPIkhZo/FM8P6FEMIfwywCUqb8ayvFsApUdihoeNyyQJi8z3qZsZLoryyXIiTsW+2v5wd9p/SxJH9da5hDVNuB/hwLA61pDpPpEAI2QhLCXya4NMLX+ooFmpr0V9kO0hhfLc0m0mEgQ1pRZSQRdxtH1OZ4= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(366004)(346002)(39860400002)(136003)(396003)(376002)(451199015)(38100700002)(64756008)(53546011)(82960400001)(86362001)(38070700005)(122000001)(966005)(8936002)(478600001)(71200400001)(5660300002)(2906002)(8676002)(316002)(66446008)(66476007)(66556008)(76116006)(110136005)(52536014)(66946007)(83380400001)(26005)(41300700001)(9686003)(186003)(6506007)(7696005)(33656002)(55016003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?z47lpcEhpY/1y3flwLVq8QT8ljKNKgXaiyvDejFM+vqWA/GzTdnYSHvziNx6?= =?us-ascii?Q?Xw3AwAGSbbMFzgpyrZWm8jSB6T4dVmpdb0/3IHMqdmudiMFSTJxcgEG4b9fa?= =?us-ascii?Q?W6d5FEVDi32JzhoxvCvdITV2ucrueYuFJrQgKPysj59bdi8gsSN2EcrwUW5s?= =?us-ascii?Q?q/UF/grWpCBbfp9HJSujQITzoRr+emtWMbby22J0N8Il3wmibvMd8OmeS+Wa?= =?us-ascii?Q?2hihIookRYglbDR+C4Ak1Yxpl+Sb3MMgJYM7YEKy87GmRW60rUD0OIkqCTWx?= =?us-ascii?Q?NNU3w/FfC7he5gOeGn0aS67YnggtBeUpkHTSoVEougbfxrJOhVphGNzb0UKr?= =?us-ascii?Q?uvZb9C5EIKCPZ+QkLzMtmmi62ZRsdF1w7ggoZlQnkYIxdplkIzcUbbg3AUst?= =?us-ascii?Q?gLzZFz6S4V5dn4R8wZWumzlda9PHa5EvpDKq4z78D/RxwUnv8I4/VYToz/TP?= =?us-ascii?Q?HTDWucxKozeedOQIzWLTot2fq5x49YcNkB/0c/O0dSFvCTffIa1Sv56wkVAG?= =?us-ascii?Q?w493WgrBgr9BSqNrG56FCJZLefOB4Mo1Qyjp7JXCEPEEW9aMn28TqSkZWGwt?= =?us-ascii?Q?o8f3G9R5a06BHUqs470rUGtgQXNuLNmqShyt4yuzoiNPPe9urrIrn+l8nqmY?= =?us-ascii?Q?DHTvgfIzZIzYsWk8s7fvz82EBomue7ia9EdkxkSqYZ197jozZcyG9q3c0z1G?= =?us-ascii?Q?StVxHIrIyCb8wHaCN6tuoN5KY7PudUSDoXNmlChZfeEMbp/tRlE1LuozUj0q?= =?us-ascii?Q?0UU+dtP6d7PolplLqNoYkoxCxq5lwAbz7Lpo/Thm/qBhCZaG5sh+2dAS5mwq?= =?us-ascii?Q?T6RaS/43iUqDKSrI179O2L+aepD8e+sNJS3bFHzRNdwx8T3k4N/puTGa+wEa?= =?us-ascii?Q?Rxpswe4LM+Oi0TKirCQRZhB8m2sZlY6PK0vFO9GN27sf2Zts6KbDYuA4h0K2?= =?us-ascii?Q?DqdC7l3Rcwq/FGQknkKvVrPnTNMehXBpPiQjKVn+vT9dvTM20FMR1+1UT478?= =?us-ascii?Q?7SHlMiF1YFJIe724KMjOqQyWxtzD4YbQxfULHJjhrhi8f5EvlZZTW0HjyE0O?= =?us-ascii?Q?gjLYxCNdb6WYeDBxpMf3nRQO30e1picOv2mjqITXQ8m0lMjV13GCKHeui/tr?= =?us-ascii?Q?Upbwdi5GLIDP1xFxOtgkPMaQVmEhFrNY+hHwwELHSoJLUVf8y4dHNZuPmkE/?= =?us-ascii?Q?nksS/KpuVaVgT5dRwLFDCnl/CK3jhBbj7wnk4q5iDUPvXjdbVo+Jliox7AY1?= =?us-ascii?Q?CKG4tk+vlrHq76dX2UfqJ7kAnDMs6zAxYMsw9QSRHwTVSjTWsLLev+ag5jie?= =?us-ascii?Q?Mw1A9ubQNI/pDkZjwinwtFJkoZtIobPNhRZnJbfYFdjGc5n8IxmXTvonBFVE?= =?us-ascii?Q?Ul4KQYYttE3ofn1TMcwNQGYgWWCdQKIJkfQQz6Wv6KH7cSfoU4sc0KrGhi8W?= =?us-ascii?Q?P/TVqrJYt2wdubwvTVYF19aI0987UBjOB/frqu4O0jeiAHNdD7Ozv6/WjhEy?= =?us-ascii?Q?dQ6XB8OZrl2hlriqH2dQhzR9qT3PeRUvimepLNbNSLSrX45lFZ7fVRVNvnef?= =?us-ascii?Q?daXeANB1xqUGZOzpLxckEJkorWh0RuAWdGv1jI1H?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 93c1b5b9-9f12-467e-cd6a-08dab734d949 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Oct 2022 09:31:23.7552 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lYh03Zf7jva3f0qGy2XvlORdmkxfHEogBd2/C2l8cwyub17gb/BwVwV8ebPc1O60Ig/qBaMAqy5xAttVVZCWSg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5794 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Maxime Coquelin > Sent: Monday, October 10, 2022 11:38 PM > To: dev@dpdk.org; Xia, Chenbo ; > david.marchand@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH] vhost: promote per-queue stats API to stable >=20 > This patch promotes the per-queue stats API to stable. > The API has been used by the Vhost PMD since v22.07, and > David Marchand posted a patch to make use of it in next > OVS release[0]. >=20 > [0]: > http://patchwork.ozlabs.org/project/openvswitch/patch/20221007111613.1695= 5 > 24-4-david.marchand@redhat.com/ >=20 > Signed-off-by: Maxime Coquelin > --- > doc/guides/rel_notes/release_22_11.rst | 4 ++++ > lib/vhost/rte_vhost.h | 3 --- > lib/vhost/version.map | 6 +++--- > 3 files changed, 7 insertions(+), 6 deletions(-) >=20 > diff --git a/doc/guides/rel_notes/release_22_11.rst > b/doc/guides/rel_notes/release_22_11.rst > index 37bd392f34..d5d3eeae24 100644 > --- a/doc/guides/rel_notes/release_22_11.rst > +++ b/doc/guides/rel_notes/release_22_11.rst > @@ -443,6 +443,10 @@ API Changes >=20 > * raw/ifgpa: The function ``rte_pmd_ifpga_get_pci_bus`` has been removed= . >=20 > +* vhost: Promoted ``rte_vhost_vring_stats_get()``, > + ``rte_vhost_vring_stats_get_names()`` and > ``rte_vhost_vring_stats_reset()`` > + from experimental to stable. > + >=20 > ABI Changes > ----------- > diff --git a/lib/vhost/rte_vhost.h b/lib/vhost/rte_vhost.h > index bb7d86a432..59c98a0afb 100644 > --- a/lib/vhost/rte_vhost.h > +++ b/lib/vhost/rte_vhost.h > @@ -1075,7 +1075,6 @@ rte_vhost_slave_config_change(int vid, bool > need_reply); > * - Failure if lower than 0. The device ID or queue ID is invalid or > + statistics collection is not enabled. > */ > -__rte_experimental > int > rte_vhost_vring_stats_get_names(int vid, uint16_t queue_id, > struct rte_vhost_stat_name *name, unsigned int size); > @@ -1103,7 +1102,6 @@ rte_vhost_vring_stats_get_names(int vid, uint16_t > queue_id, > * - Failure if lower than 0. The device ID or queue ID is invalid, or > * statistics collection is not enabled. > */ > -__rte_experimental > int > rte_vhost_vring_stats_get(int vid, uint16_t queue_id, > struct rte_vhost_stat *stats, unsigned int n); > @@ -1120,7 +1118,6 @@ rte_vhost_vring_stats_get(int vid, uint16_t queue_i= d, > * - Failure if lower than 0. The device ID or queue ID is invalid, or > * statistics collection is not enabled. > */ > -__rte_experimental > int > rte_vhost_vring_stats_reset(int vid, uint16_t queue_id); >=20 > diff --git a/lib/vhost/version.map b/lib/vhost/version.map > index 7a00b65740..8c5e8aa8d3 100644 > --- a/lib/vhost/version.map > +++ b/lib/vhost/version.map > @@ -57,6 +57,9 @@ DPDK_23 { > rte_vhost_set_vring_base; > rte_vhost_va_from_guest_pa; > rte_vhost_vring_call; > + rte_vhost_vring_stats_get; > + rte_vhost_vring_stats_get_names; > + rte_vhost_vring_stats_reset; >=20 > local: *; > }; > @@ -88,9 +91,6 @@ EXPERIMENTAL { >=20 > # added in 22.07 > rte_vhost_async_get_inflight_thread_unsafe; > - rte_vhost_vring_stats_get_names; > - rte_vhost_vring_stats_get; > - rte_vhost_vring_stats_reset; > rte_vhost_async_try_dequeue_burst; > rte_vhost_driver_get_vdpa_dev_type; > rte_vhost_clear_queue; > -- > 2.37.3 Applied to next-virtio/main, thanks