RE: [PATCH] vdpa/mlx5: fix return value check of mkey create

["Xia, Chenbo" <chenbo.xia@intel.com>]

> -----Original Message-----
> From: Bing Zhao <bingz@nvidia.com>
> Sent: Tuesday, November 16, 2021 4:01 PM
> To: Xia, Chenbo <chenbo.xia@intel.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Matan Azrad <matan@nvidia.com>;
> maxime.coquelin@redhat.com
> Cc: dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>
> Subject: RE: [PATCH] vdpa/mlx5: fix return value check of mkey create
> 
> Hi Chenbo,
> 
> 
> > -----Original Message-----
> > From: Xia, Chenbo <chenbo.xia@intel.com>
> > Sent: Tuesday, November 16, 2021 3:54 PM
> > To: Bing Zhao <bingz@nvidia.com>; Slava Ovsiienko
> > <viacheslavo@nvidia.com>; Matan Azrad <matan@nvidia.com>
> > Cc: dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>
> > Subject: RE: [PATCH] vdpa/mlx5: fix return value check of mkey
> > create
> >
> > External email: Use caution opening links or attachments
> >
> >
> > > -----Original Message-----
> > > From: Bing Zhao <bingz@nvidia.com>
> > > Sent: Friday, November 12, 2021 10:43 PM
> > > To: viacheslavo@nvidia.com; matan@nvidia.com
> > > Cc: dev@dpdk.org; rasland@nvidia.com
> > > Subject: [PATCH] vdpa/mlx5: fix return value check of mkey create
> > >
> > > The return value of "mlx5_os_wrapped_mkey_create" is checked in
> > the
> > > caller. A zero means success without any error.
> > >
> > > The typo in the if-condition should be fixed in case there is a
> > > misjudgment.
> > >
> > > Fixes: f26e06d97d57 ("vdpa/mlx5: workaround dirty bitmap MR
> > creation")
> >
> > Wrong commit id, should be the one in main tree:
> >
> > Fixes: 398ea8450c53 ("vdpa/mlx5: workaround dirty bitmap MR
> > creation")
> >
> > With this fixed:
> >
> > Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>
> 
> Thanks for the comments.
> Is there any need to send a v2 or Maxime will help on this?

I think it can be fixed when applying.

Thanks,
Chenbo