From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2D96042A69; Fri, 5 May 2023 07:07:38 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 08DA4410EA; Fri, 5 May 2023 07:07:38 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 1BB1D40ED7 for ; Fri, 5 May 2023 07:07:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1683263256; x=1714799256; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=uGwcjntKAvB35FrvFUXeANWdYXaJE0D3HLXiu62IuG0=; b=DNktfIw1I2JdpnIBGVqTHLYcMDSlQdQFPhwlFGR4n/iIjvV5sK5KO5QM nqEz8Bm41/XpRNAqcpfCeC4HlS7nPQYm1f5Xj2GZEp8PByPy4agNF+Ow+ 4aFizBn0f+IUAk6FxEJc6jHtwpXAEI9C2XZlATG4eXqWa+ZMGuX60Q7bm JoHtw9d+4bCna9ZNeWM2Ml0EJ1A25RCvoLec5FWhEM83bVxFtSfD+86xw M8g6Z8a5dqqeQUxFSN+hnqdqBuApptvsOeo5NlnGNeVrz45W1mpqUlxJx TOdRg+c1eoRGAQsIyjsplJj43OPY4+/daiWgzhdcy05iz2n9YCQfR1wdg w==; X-IronPort-AV: E=McAfee;i="6600,9927,10700"; a="377205442" X-IronPort-AV: E=Sophos;i="5.99,250,1677571200"; d="scan'208";a="377205442" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 May 2023 22:07:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10700"; a="697375331" X-IronPort-AV: E=Sophos;i="5.99,250,1677571200"; d="scan'208";a="697375331" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga002.jf.intel.com with ESMTP; 04 May 2023 22:07:34 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 4 May 2023 22:07:34 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Thu, 4 May 2023 22:07:34 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Thu, 4 May 2023 22:07:31 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hhfdO/CDBD6nLHedhg/rYfomLkVUJuVTOanGCUY68WdcER1dFSQqQsctVQ3bhN8o+ErGX+Fp/vURhq8dY0Dop7rvg+dJwYzI0NdmLgKkz89260rXPNMEz4DLJE+4gQeZq2pc06JZHdTj78/LDlsM7jt0tkIKLvkXpF0hM/IaJXXPPIvUMZZZpsxOeRz9pZQG78NUNyJ3X5fWiAN0HFgTtDwcQELcUjEM5CULIaKN7NA88w7wFGSrTfxRlDuT6zolxN4AgFOO0sqdkJp1H7R5V5p66f6qsBOciSTrzGLD2kI7DsWZ5DHzK1f7tRu/hx/hZ6XoBqGUKx3TjYQR5oRDYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vePXqQViBoEKdLCQIeH70S4LQnilgTI78pEb0vQsEdA=; b=KjpvSerRhw+5OSD7H/PuiTnoLyeuGb+Aa74gGj9bF9z0n8MBoe2V9glIRptcleCGFC6F0PcSWJbN4HQl2Axq1XlBJ8Ar1SC97xSwdrPC5PktSQwGWeOqvXLAA/fJqmNEMUFALbWC3yyEs1IulMgfDYt6H7n2RZyOcY+CSBpDUWZNbEyQSla76dIEZU6Ef7reoXY9GWv2C0tVYlXXgs3Ic3FGeykqmNlby8fS6+Y2QX2Js/xjVc+nmuxs5mTNmmUuuvZGQ+zfLRcg/swVCXxmVg3UWojymC7Qo97oWEJMmszwi7+RHFmcSaClKZCVd/xgp09KWBsxi6kQJ1eGD1bdow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by IA1PR11MB6444.namprd11.prod.outlook.com (2603:10b6:208:3a7::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.22; Fri, 5 May 2023 05:07:29 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::5797:849:7a10:560d]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::5797:849:7a10:560d%6]) with mapi id 15.20.6363.022; Fri, 5 May 2023 05:07:28 +0000 From: "Xia, Chenbo" To: Maxime Coquelin , "dev@dpdk.org" , "david.marchand@redhat.com" , "mkp@redhat.com" , "fbl@redhat.com" , "jasowang@redhat.com" , "Liang, Cunming" , "Xie, Yongji" , "echaudro@redhat.com" , "eperezma@redhat.com" , "amorenoz@redhat.com" Subject: RE: [RFC 10/27] vhost: retry translating IOVA after IOTLB miss Thread-Topic: [RFC 10/27] vhost: retry translating IOVA after IOTLB miss Thread-Index: AQHZY+eaTxruHA4by0q7WarOrQGRLa9LKrdg Date: Fri, 5 May 2023 05:07:28 +0000 Message-ID: References: <20230331154259.1447831-1-maxime.coquelin@redhat.com> <20230331154259.1447831-11-maxime.coquelin@redhat.com> In-Reply-To: <20230331154259.1447831-11-maxime.coquelin@redhat.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB3504:EE_|IA1PR11MB6444:EE_ x-ms-office365-filtering-correlation-id: 896b2abf-7bf9-4528-e0bc-08db4d269f69 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: zEXiPMkrxYPoQORU5CUGgi4NGsNRUNZCIqQfHkNGR6ZtrrcpohF3aDMi+zRz6ggq0Xjb/48IxNKLtcTeTtrDAJug2jlUP201ShHVAO1mLGEbRaT2GNlH0Zpe8GGvomIp3DKF7hYClPM12OoaGXRR4MNZ9HN/OvPdWW0nkebvdJA42NbKjtjBikO7lSAzud6jTfMrCzX460TU6dWtiCVTqK4if0rylgyTdx/gJbGn7BwwQQKVJ8XzeA8ryAhujlkrzBh/dcyCLmWF61j+ksR857LccfHuW3AlA/lP+jHBc+Lurqe9yMEjqM5/Aaq7ZwXt2RETZnOuZsKqs58xjrWPapdgj8uL0wkAhJPidGd16Qka4yvdhAGGKL/mid0pzjaXjKUeu2/UshHtGMRVAVM3Vmur73mc3pbaK1w/27f5+RAlYeVoX3lW4nLsnopIsFTFvFw7t7S8arfvwtOs04Ou1gQZGwVG/Sp+yqj1yj0sRMhH0UHydAsY8qmf+s+irHD20IoNITcGK7HkSSa/yLu0sruzxQyunc72c2pgX8CS7ZES5N6tTDPknUh/pZqwkOYjOVxoIL2HzBvcZ8e7p3wbBDVjYvW7fQZg+k2nBhd7TGCf0aB23+ypyGW+o1QGp1xIFhjDvxUjXTNQiYZsWFrUkA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(136003)(39860400002)(396003)(376002)(366004)(346002)(451199021)(921005)(55016003)(8676002)(26005)(6506007)(9686003)(8936002)(7416002)(53546011)(52536014)(76116006)(316002)(66556008)(110136005)(66476007)(66946007)(64756008)(66446008)(71200400001)(41300700001)(478600001)(5660300002)(7696005)(122000001)(33656002)(38100700002)(82960400001)(86362001)(38070700005)(186003)(2906002)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?sMtcrNljJuWIQ+ZoGd8axqhBZeyT/MYghsjwHxRK6jngQEAjieuBX9QZB5EC?= =?us-ascii?Q?cE0BbMmDNphMXnW59M0nVYC6A7freo7n8dd/CjuVY4UtrnuTcvFOFSQeR26f?= =?us-ascii?Q?ld57JNxz2BMvbl4YaMa/VteMFoBxKTBVueNjOb6lC9BQFbxGtZ8gPUg6F4NQ?= =?us-ascii?Q?LwqTts0SjTkgjlC8HfyzNeLE7fkoUj+rv2e+fWtlJqHgCKKX3FXAar3EVdQ0?= =?us-ascii?Q?mxi/Z1Xf2oYg3z/nV53i2zN2jYGauOHjTplW78scTcjTE9bY4fGnX8j9jC6u?= =?us-ascii?Q?XYI/MPZ/7vKC/GvRWgzGNr8MHJD1VTytpbe1YwNJI47kSy1opD91y/yfaWQU?= =?us-ascii?Q?RGsCC1pY8cuqHGcppOc+OPiLghgbvRw1FAkGQHO7ixfMaWCDlkK09GbAuYQm?= =?us-ascii?Q?gc+K4XnRDTPbZVT0XN1t8jhzhUcAWahx4z+lPAbZ6Tvx3xJGNyGn8pRTlS1N?= =?us-ascii?Q?oHUGYmwQmqWmdbm7a5LfNYlkPgjjgev1dIKxxMkf+SMBhlLi1fD6mXAdL1ye?= =?us-ascii?Q?jNOD92a4HFzEnpj0tIJmlmxwe+a/l1ePtk+vKVfbBgicLknkHL6POrbyyPHL?= =?us-ascii?Q?X3aHyOLzNteXfZe+kh7jLdhSyyD9FISLNMLEoCclM88zwOob93HYCcpvETGI?= =?us-ascii?Q?lYklblyiov/om5lHI7XeZoqYN/axCjCDZndVLEleXDVOmZhlgAhyz4J35hRq?= =?us-ascii?Q?U7GIkI9vzKHkKQEAOJRh/+LQIUqloQfECSqQdeNF88H1cfoOWOlLfw4m23Sy?= =?us-ascii?Q?1S8X+f/lmhZ7HEOzjyfbY38xX3b77ELqsWbjhcFv4zdrb8EYg4C54N5Hca6o?= =?us-ascii?Q?fLgOY0wkAC4HHzSBN8VQoLC8EOsLFzrULl/3J0kdtIg5LJg5TThVdv8JukY0?= =?us-ascii?Q?11eAoOnQCK8XDihDkbUaYWJMmF36OwfKgjtn3QKGnPE/fkaKXBqnfCWjF+Wx?= =?us-ascii?Q?iwHl9/Jh3nFDqG9BdGSCYb0cNUucfBJn7/avMCNPpnPdULU5CER6fmiHuTPO?= =?us-ascii?Q?lUTXF/ZdowcuzXEaSuFrxmpoyGSe78QSvGAkphV1foXlFn17imVL18ulzovw?= =?us-ascii?Q?JM8Of920BOUQcUk9Qh06Lospl2T4+/k2Ss9yGGsCS/cTOVfpr380cO+mDayc?= =?us-ascii?Q?r9qpGTsdGjP9M6gdTWUOZ3gBGwOwHMZiN62qGrZNcbLN4nPZUg9GDyvaW2Q8?= =?us-ascii?Q?FLdoeuxp6xGelFj8hbSQA8d9n4WVJW5Mi7/CWqYO8C+B3W8VjDDbrucXuyx9?= =?us-ascii?Q?EJZGGkxgkYvS/mmhajZW7h6Q0NQKvCcCO2+5Sx9snc9uZDY6zEn0ZLHwn1Hq?= =?us-ascii?Q?9Hm6tmuIpVsg/Dh+j96c2mLGth73+FgujGhuqvwoc/jk/puMkTmQWHjKaO92?= =?us-ascii?Q?qoFO3EHue+kWkJaCB9DlQYpb6k59mA+Oi8U51c2FaFERpzphynt3BRAnBc+O?= =?us-ascii?Q?lPoVNejq1yI3Z0zVj+ogAP1SxMokhsq+G7G+NS15MUH1BU4s97TZ36xHzAYd?= =?us-ascii?Q?fw8MCEB1exutPOCqauMgl6B0HVadjzkyrYobn+p8uI9iqESTlup5KSFN4Jep?= =?us-ascii?Q?VbuKdYXHME2IkNDQjSUA95Pk3jd4bXE+76a5w8tm?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 896b2abf-7bf9-4528-e0bc-08db4d269f69 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 May 2023 05:07:28.1174 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tpfiwlPYPh8Bw7kbSRgeIeaRlQ33YPiqA0/7BBQxmakorXxeaJ/r9ECQ/vt5j9rvjsbq/wUXx+8N4/eTm9ngdA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6444 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Maxime Coquelin > Sent: Friday, March 31, 2023 11:43 PM > To: dev@dpdk.org; david.marchand@redhat.com; Xia, Chenbo > ; mkp@redhat.com; fbl@redhat.com; > jasowang@redhat.com; Liang, Cunming ; Xie, Yongj= i > ; echaudro@redhat.com; eperezma@redhat.com; > amorenoz@redhat.com > Cc: Maxime Coquelin > Subject: [RFC 10/27] vhost: retry translating IOVA after IOTLB miss >=20 > Vhost-user backend IOTLB misses and updates are > asynchronous, so IOVA address translation function > just fails after having sent an IOTLB miss update if needed > entry was not in the IOTLB cache. >=20 > This is not the case for VDUSE, for which the needed IOTLB > update is returned directly when sending an IOTLB miss. >=20 > This patch retry again finding the needed entry in the > IOTLB cache after having sent an IOTLB miss. >=20 > Signed-off-by: Maxime Coquelin > --- > lib/vhost/vhost.c | 6 ++++++ > 1 file changed, 6 insertions(+) >=20 > diff --git a/lib/vhost/vhost.c b/lib/vhost/vhost.c > index d35075b96c..4f16307e4d 100644 > --- a/lib/vhost/vhost.c > +++ b/lib/vhost/vhost.c > @@ -96,6 +96,12 @@ __vhost_iova_to_vva(struct virtio_net *dev, struct > vhost_virtqueue *vq, > vhost_user_iotlb_rd_lock(vq); > } >=20 > + tmp_size =3D *size; > + /* Retry in case of VDUSE, as it is synchronous */ > + vva =3D vhost_user_iotlb_cache_find(dev, iova, &tmp_size, perm); > + if (tmp_size =3D=3D *size) > + return vva; > + > return 0; > } >=20 > -- > 2.39.2 Reviewed-by: Chenbo Xia =20