From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A715842A9D; Tue, 9 May 2023 07:32:33 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8E53F410FA; Tue, 9 May 2023 07:32:33 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 9E3D6410D7 for ; Tue, 9 May 2023 07:32:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1683610351; x=1715146351; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=5KvRqMnFjMxydqtEZeSSImmZe13333bNTyL2ZoYms4U=; b=HUqxVmK4sRRR188f4Tjc8su1oU+77wGcZt/yIrX0RTifCltHJbwKrQ8a 1Gj5roRyGwHMo/9fA3DYTiA18RdfwuU263ujvI+XlXMI2rL43vqMNc+gk YK1u1n4ZBt/yl9s3sSxghgnTtvP/sRV9rSnJhWcMUByOcwQ/uNKFhnFbD 8jKIy+Tpoig+OZtdSMIZvo1gURCSXsdXSpGPTuZ+qZIlpIFrIimakQ4h6 DXX3tY924srrV5yhjsiJbM7fmwAPAoY9VCgR2+SIpMcJAob1ukcYcpnKJ Yn5s4M2WNtyfC1vTNU9hNCvnwP7pL+H36edBRylKufqQZDdZh+yj/MT4c w==; X-IronPort-AV: E=McAfee;i="6600,9927,10704"; a="330172356" X-IronPort-AV: E=Sophos;i="5.99,261,1677571200"; d="scan'208";a="330172356" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 May 2023 22:32:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10704"; a="810518278" X-IronPort-AV: E=Sophos;i="5.99,261,1677571200"; d="scan'208";a="810518278" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga002.fm.intel.com with ESMTP; 08 May 2023 22:32:30 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 8 May 2023 22:32:30 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Mon, 8 May 2023 22:32:30 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.173) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Mon, 8 May 2023 22:32:30 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I/09IGsKCkYfBriFNnc+zXdojvh5Al/qWZjTpcoPF3JIX0Zkipns8cphszey9GBE1B6e43kjIQ7nVM1o/czUpQCxDApyt/2C8Uf6i0ynv5EQv1FyC7sujsup9o3lQRs98IiixJBzEvJ45Wy8u+wFNSJ+l7qIrrIXSq7F9bNkNeW1nPogEvDyxgwE2sh4tOuOuBes2N/5T1N+YY89skH5TMDzrwmUMp2Ps2OvcqWNAwtXnCNXWmG/uIE+m/cSGNxZ4XWBEvjgJXjaoLQBZvd9jBavQ4YGxNfdvFatDXO/S9ycP4RP+8nd9kBppnKoH0XWSBqsJNp9rFr/6hwiXw7oAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tIxY5neN6lgKvUFMaIgVStbVGz/JLFqtC78CW6xNcRk=; b=E7WFBZg5N7qoIvSAenuqlP/MujzngPXYaAe7ByU/fr7/zvs16DnyG/iu7tke5w3iK1GeqyE+jEo6DLdtsfalS7u72s4vo0JrTmnt0HBI08vcK+tg9MMOsE8ip/HCX6jqm0NvaOXIgU6seRmsgekogOiHZbmAiF3k4rVTtSoXiHOKVo6WLaZgTHR/8RzT4MsJSzoX2Ikt0gr9wSvtXuvrHruX64/DdC+9a9zg39Tdp3TWVJC8QZDTek4dStSaOa6bEY5Zea57i+iVIQq2d1KZGpcwCFqL4xb9YEERHYGwiMbGu2UvyrXXTIsfJ2Hj6Dx//z36IpucJAVAx1TJ/hw9eg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by DM4PR11MB7352.namprd11.prod.outlook.com (2603:10b6:8:103::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.33; Tue, 9 May 2023 05:32:23 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::5797:849:7a10:560d]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::5797:849:7a10:560d%6]) with mapi id 15.20.6363.032; Tue, 9 May 2023 05:32:23 +0000 From: "Xia, Chenbo" To: Maxime Coquelin , "dev@dpdk.org" , "david.marchand@redhat.com" , "mkp@redhat.com" , "fbl@redhat.com" , "jasowang@redhat.com" , "Liang, Cunming" , "Xie, Yongji" , "echaudro@redhat.com" , "eperezma@redhat.com" , "amorenoz@redhat.com" Subject: RE: [RFC 20/27] vhost: add VDUSE callback for IOTLB entry removal Thread-Topic: [RFC 20/27] vhost: add VDUSE callback for IOTLB entry removal Thread-Index: AQHZY+eokGJO345WcUuo0a7bXe2Q9q9Rehjg Date: Tue, 9 May 2023 05:32:23 +0000 Message-ID: References: <20230331154259.1447831-1-maxime.coquelin@redhat.com> <20230331154259.1447831-21-maxime.coquelin@redhat.com> In-Reply-To: <20230331154259.1447831-21-maxime.coquelin@redhat.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB3504:EE_|DM4PR11MB7352:EE_ x-ms-office365-filtering-correlation-id: 4afbff8e-ad4c-4432-ce07-08db504ec421 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: FajLxw9f73aI7QQd85Zap4RCY/+I00VzSOAy5B65QhTrv0DVYVuW7vPq6rRwX/UyR3a0aNAFuHWtWJH3Dl4Fw1vMNge89bOzOJsQJuaAKu/hYr8XLwxxNcgA7SSSsbQt1EcSZjXFX+75vf1DjQq6vv8XkmFkZxnwPSWLPQRRMUq0Hu8YTYYYx1ueUHcutMyUm2j6OiH3lvH7EMmJeC19QzZR7IMHS+STiNjmX6lOv+G2rPg1yuNUp+AS2kvrR1EeTypYT/cKQHRX7IHDJSnTd1yx3KNbPi8vsHgGgB/d6mqiaGEbexsr9BjqjpD93lzHe6oDJwXMmqUQZWmrF7cRxAPuL46Kv+gRUQNNbwpbf+d8JSrP4+6km+2tleBaBLNTayy2BRnnSDnrOAHR7y/6rBbmVZtls/gs2xTXwBgol2OdBOmtAMTPvrn07oZrx6UszQYKRVKpGgxmZTW1VTMVF49r4GdY56kpRcarspVjwJGR21muDx1tsnSsp4WDJixct0ITW1wOMxt8YI6C766635PMeIutMbjxyY/UB1T9O2GYbBRI+7csH/uVzJJHFlfq7KbV6L5eSLERS0PhLzB6cwPe9Yu1LM+bP9ZHAoz2GQIMoKzOvMY3csz3alJj5PFlm7vHjAHqEkBpSk6wCgT8ZA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(136003)(346002)(396003)(39860400002)(366004)(376002)(451199021)(38070700005)(52536014)(316002)(5660300002)(41300700001)(38100700002)(82960400001)(921005)(26005)(64756008)(86362001)(66946007)(71200400001)(122000001)(53546011)(9686003)(66446008)(66476007)(66556008)(110136005)(6506007)(2906002)(76116006)(8936002)(8676002)(33656002)(7416002)(186003)(7696005)(478600001)(83380400001)(55016003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?F4TJxNikru2hNW4R36yrc8yt560MRE5YfkZZ+OCNSCgW5FyrpD3JPeJIOh9I?= =?us-ascii?Q?3Pdr0gThkLLUZCTndlITQ+kKhc3lJV+5nkpgVsBBNZuJvHHcprcckwdaoK/l?= =?us-ascii?Q?2MO/UJIhJ44MzXyKTzrPcxe2s4aFRDSRBxOrBnNaZiGrp0AGarq0wi9qMA7M?= =?us-ascii?Q?Pn77jWz9GUIO45859w4g5SRXYaTTMxVsZFkwQ5M8qGY29JeQoSxSzpYNWbiE?= =?us-ascii?Q?Te3IqYJXLouURc7v7IAPDumjB2XV99s9EpGEGZlPGMhHrxQlnjSqIqqZcTSy?= =?us-ascii?Q?qBxujO5Vjs/grGpaJrJ7czFoHbjtDmosY/KIpR13kCNy6V1f2YkvyHzzhH5u?= =?us-ascii?Q?ijAcHnUN9Cftu8AhsIyKQMFfg3yzaid4PDkc44io3Mlqmc8X5yCoM7aOtaWP?= =?us-ascii?Q?ygwPUheOxXwF8dwaPo+I96cvk21EolM5WD6W9ghCZIHLMrJXWymdmM9hMuVM?= =?us-ascii?Q?eclVD5Zlwyfp1cioWkhUl++gH+8sRF4kh/lr+0bjtaIveJbjEQ21zePhCRHp?= =?us-ascii?Q?vFw51iWQ9SOg06s54VqpaOmb06QDX0zGobJG2zrs+mu0g9vwxR3fNoOCdJ7U?= =?us-ascii?Q?XiJ/OEItIZq8hD6TGaZroO2n8z9eLixIcLacclHJTNf+xtKptBSIAh8Wp6YZ?= =?us-ascii?Q?2vdv4gActbTBbpyNVCjfnNm2+TYHPvOahq6ONkyFcoaFGNDd5aMvfr6adAIl?= =?us-ascii?Q?7MbelAdODEgj6I3JapjiFmkDJB6cBcl9qcW/lcurNpZgJ8NvopXaI4zxg3+W?= =?us-ascii?Q?nYM7vx3AaL+Dp+ISNa49us8bDw2+qWaDQ7UNBiw9ZVeeQcisJG2raENEU3Dj?= =?us-ascii?Q?XF1vlqFVO26ijCklKUWZO6ZfoctwhArY0QTe579KrPTJMnPz8IPS+HCtTUcL?= =?us-ascii?Q?Q19LEa16AVM0qv55ipIfjVeiR7Km8vbTQntef31U3Cy7kzU6nbim3obAz0Sr?= =?us-ascii?Q?58eiBkoeD4EoXEojHqJysegTuUT98sVc0striMnn8Nc6a0+zmdoImfc+Cb/g?= =?us-ascii?Q?mNlviB4I/VczXdVFOO1O5QiysNDiVzZ2ivmqdKiGU14O+9G+jP99tvYnijSZ?= =?us-ascii?Q?L2Az0Rs1FSHienZQ4qF6hZvPH1AsryBh2qB5i1VcsbXgGSub67HSe7u+bYX5?= =?us-ascii?Q?WkqJSjv2CQY2mWYZG6JYo1b2K1n+brKCZ1oBuFpc6I+bDp5HOXc+E8QWKJty?= =?us-ascii?Q?LFWvwdB0SFGM1xQq3Kc6BxRRM6doOuq/Rk9ZjhOlTH/UC3zM4dqiuKRckuUS?= =?us-ascii?Q?8Rg1UdEqV6Ptu0tyKo7nlbYROGbbr7rGDyZ7gakWUGn2JYgJhChY5xRHLDi1?= =?us-ascii?Q?gk8OKz7ps5baX9bFnc6pqq2PIDKcra1mNXrFi2jgMM3D0rOMcO+e8rvnfXT+?= =?us-ascii?Q?hwx3v0ZKUEY/JHZ4qFAkqHn2rbO8Yirrm+ZuZiRr2iMlt0OArbUHrzaKA2Ti?= =?us-ascii?Q?w1kJnEo9XUTPksyns7eq5CtYlx1st5fSeVk8vN1zpN6zMOKaat8kqHM2L5hB?= =?us-ascii?Q?baVoxffpKt7SKoJ2ArUHUcx7Nd4vVPo9/bwZqoOkpyxgKSgsbQvMLDSbg9Dx?= =?us-ascii?Q?rL8EokLxeNtUEgecZ91wfACoRp8xCqfTOmGWfeut?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4afbff8e-ad4c-4432-ce07-08db504ec421 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2023 05:32:23.0862 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SZYqKwOWvnkJP/5GSCbWYBzyZRDDuF+R3U1P2vFazX7lPEfjtWwO5QZMw2I6KKmArIiRg0vuKi//6gR+We8eKw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB7352 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Maxime, > -----Original Message----- > From: Maxime Coquelin > Sent: Friday, March 31, 2023 11:43 PM > To: dev@dpdk.org; david.marchand@redhat.com; Xia, Chenbo > ; mkp@redhat.com; fbl@redhat.com; > jasowang@redhat.com; Liang, Cunming ; Xie, Yongj= i > ; echaudro@redhat.com; eperezma@redhat.com; > amorenoz@redhat.com > Cc: Maxime Coquelin > Subject: [RFC 20/27] vhost: add VDUSE callback for IOTLB entry removal >=20 > This patch implements the VDUSE callback for IOTLB misses, for IOTLB entry removal? This commit messages seems the same as patch 19. You may want to change it :) Thanks, Chenbo > where it unmaps the pages from the invalidated IOTLB entry >=20 > Signed-off-by: Maxime Coquelin > --- > lib/vhost/vduse.c | 7 +++++++ > 1 file changed, 7 insertions(+) >=20 > diff --git a/lib/vhost/vduse.c b/lib/vhost/vduse.c > index f46823f589..ff4c9e72f1 100644 > --- a/lib/vhost/vduse.c > +++ b/lib/vhost/vduse.c > @@ -32,6 +32,12 @@ > (1ULL << VIRTIO_F_IN_ORDER) | \ > (1ULL << VIRTIO_F_IOMMU_PLATFORM)) >=20 > +static void > +vduse_iotlb_remove_notify(uint64_t addr, uint64_t offset, uint64_t size) > +{ > + munmap((void *)(uintptr_t)addr, offset + size); > +} > + > static int > vduse_iotlb_miss(struct virtio_net *dev, uint64_t iova, uint8_t perm > __rte_unused) > { > @@ -89,6 +95,7 @@ vduse_iotlb_miss(struct virtio_net *dev, uint64_t iova, > uint8_t perm __rte_unuse >=20 > static struct vhost_backend_ops vduse_backend_ops =3D { > .iotlb_miss =3D vduse_iotlb_miss, > + .iotlb_remove_notify =3D vduse_iotlb_remove_notify, > }; >=20 > int > -- > 2.39.2