From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 412DF429D0; Mon, 24 Apr 2023 04:58:02 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BFDDB410EC; Mon, 24 Apr 2023 04:58:01 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 7D0E8410DE; Mon, 24 Apr 2023 04:57:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682305079; x=1713841079; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=VxUppSW6GrBT+Vxt4VAzEX8S3FBEe/Fq/PBkYnp1Vhk=; b=AzOSJpMILw69oOXQVvBIB/0nravchCQ2AGaVIlirCMFmb93oatIxcyVl Wq1bWw5vsSA2Q8TzdZ5btkFK5K4eCGIO/tCfc1p8ia/KNs/yJHLGxBwIh QFb/X0rIaLBEAK/oLgXtzfxTdRfSaLmtlDHwUcWlkWl2VCYL5vDbM9fgv OdZVvGuIAkyhDwIw9ziCuzE7TVlK1Ru2wi4LZqosFiEVSLVswsODeokIK m7XqE2Fwj32hOjPGyinFyUZ+fupQ00zKV86FM51p4Oe/F0DeQMg4Q/mbJ SAgUDTTPiFbtXCWU408DFRI9hPK+9zw4rhVU/w12XuRTgVhctdKmj2DLD Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10689"; a="348255805" X-IronPort-AV: E=Sophos;i="5.99,221,1677571200"; d="scan'208";a="348255805" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2023 19:57:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10689"; a="782242152" X-IronPort-AV: E=Sophos;i="5.99,221,1677571200"; d="scan'208";a="782242152" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by FMSMGA003.fm.intel.com with ESMTP; 23 Apr 2023 19:57:58 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Sun, 23 Apr 2023 19:57:58 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Sun, 23 Apr 2023 19:57:58 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.43) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Sun, 23 Apr 2023 19:57:57 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=akvK2z042ojSi38S2TNUihYFm+hcRPZPjg8yp5XwydjB+lIxl23BJeHTx4LJapwzDSP6/PAJiYc1OiSDE+M7Guac84XpGR3PaIxdRRJ5OU/OrzYkocAJNMfNbWhf7mhMB4SQWnxXaWwpELzkW4/w+3MCegESGU0B0nxX4qNeK1Hp/RAs06v2e9Hb/ROdGL/1DiaIpGrfkCwjyJWKbaoVoCAuF7WWG251X6GJDDzecaaysPYdoHSN5U4FIKPP5t/ACyKhJtvaiMEqV/A9NUbdvDrIGSxxkfzU5MLgZFhJVxA+Ygk9VuYuS23Hn4xlJPX0M8NGD0bbqSatd4zUgxJhbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ozJWA/MytRMKJOI/+njEgj5R8kTsRwf6vP0Ta2DpUUw=; b=Yn2ug8NZh2yPS/46nXxfc0rsfVrTlz4WxFFvApZkoGh/pmmQBPn3D7u+m8k18RX5ySwLqYppzdSRY4fpydDD5jFGDNn8f84fdXq0ZiQ/eIvSFzGCe+YXiVr4Bb/S0d4sbDmx1nO/rVy+Pkz5wBQsG5XezQPSwJCnurMjCJleJ7PZtl7vGImpHS7ZcWcCy917vn4rBRCtuc9PtMqoJO+fgXIM3Oq4Js/apVKr2HTsbBaQTzGJa1GoXtVspNXwqGAkhn6Y3o5kmpABbBC7sT4fZtZYOiNQLecd9FNm6N6o4n/rtf6yibdNzz4oIBzEsyazQ3TPrpe4LHHG03hpSFxKVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by PH0PR11MB5143.namprd11.prod.outlook.com (2603:10b6:510:3f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.32; Mon, 24 Apr 2023 02:57:55 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::2d7a:a878:7bed:bb11]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::2d7a:a878:7bed:bb11%4]) with mapi id 15.20.6319.032; Mon, 24 Apr 2023 02:57:55 +0000 From: "Xia, Chenbo" To: Maxime Coquelin , "dev@dpdk.org" , "david.marchand@redhat.com" , "mkp@redhat.com" , "fbl@redhat.com" , "jasowang@redhat.com" , "Liang, Cunming" , "Xie, Yongji" , "echaudro@redhat.com" , "eperezma@redhat.com" , "amorenoz@redhat.com" CC: "stable@dpdk.org" Subject: RE: [RFC 01/27] vhost: fix missing guest notif stat increment Thread-Topic: [RFC 01/27] vhost: fix missing guest notif stat increment Thread-Index: AQHZY+eEtql4crIDLUa6LMyzccYf16856UFw Date: Mon, 24 Apr 2023 02:57:54 +0000 Message-ID: References: <20230331154259.1447831-1-maxime.coquelin@redhat.com> <20230331154259.1447831-2-maxime.coquelin@redhat.com> In-Reply-To: <20230331154259.1447831-2-maxime.coquelin@redhat.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB3504:EE_|PH0PR11MB5143:EE_ x-ms-office365-filtering-correlation-id: a5a87430-64db-42b0-177d-08db446fb394 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7u+UXcfIcDduqDQzDOa4zBoPjHkEI0Mhoi2MpPj3mu/2zF0KXiVLdTvUGzI3qBJivecTK6Jt1+mYJFoWEHIgnR5MOJHgEo7AssKUCIiEE1DHZaCISGGcm7uHYLyBs/a9u7L8DY1a4jwXHm2188dXxaDYVWowu01t/kCc5N1053K0bUct/H67GYN9VSdSFbm5W0URolhaLNohftoY7OEbNrfqDSZIT4e7VsyWGp8NgxtKAEXWVbSNWRddyS4OrsS4WGU8QzXbUAPr0a5dYZ1ZtW2UeXRijHORCEdcbw1EYuFtuxXj8GqXosFW+bDpxIyOaJVWip5H7At/OS8l6Eq1WGB8BVUzcdvgi2Z2eXD0TMygnH6WWYCzLyUT3ayOUOqjak6MeeO357NeRQVaSMKebpfN2y/i9xerv0BYWwkyGU6umjxLQTnIvTK+CiCGX5tHdiNl7J78ypq1HVo4463Hspn0+mTkWUGLJ5qMNpf8DzmF0WxoyeR++VfcIO8Qw9ThLYcMF3SLSgRMOPpEdplcxeUal1HcPyS/QIhTjefdu1jVqdGhApMWIWTWI2EIkRb1UCpKzVgqP78PCsUgjUrnxBs7XOnHpFFQKaG9hQBIs59JTECT8v8gDO332lH0nMSuVL6WbUoJaBCUHYfLLo8QJw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(376002)(346002)(366004)(39860400002)(136003)(396003)(451199021)(38100700002)(122000001)(921005)(82960400001)(9686003)(53546011)(83380400001)(6506007)(26005)(55016003)(186003)(33656002)(7416002)(2906002)(8676002)(8936002)(52536014)(5660300002)(7696005)(478600001)(71200400001)(38070700005)(110136005)(316002)(4326008)(66446008)(66556008)(76116006)(64756008)(41300700001)(66946007)(86362001)(66476007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?zPgy0HqRI5793d8GboJZvq3fudbQ5BiQT0yuPWhQQbrgMDFK28i9IAPhVzCh?= =?us-ascii?Q?1BoeuZoTRfkYjsfSwaAVVXjHcrjBFGTj/JfTREdeVwU9x6A/4bX7oTe8DdtM?= =?us-ascii?Q?8qArAxUOuTpcMOW22NikN7fWuYmYZ6nCIXaOinv1p5OXEDonXt+8+m1uJRL6?= =?us-ascii?Q?4BshlBRu9PBy3x8c100z+QzTjNm6VJ6o9tgk22f2pmnaa5r+HAP8v2CnlqGu?= =?us-ascii?Q?5dF7mqLiADzcTQVZWZJIaKUB8qzSsGixwmt2paw5W73u3GqDJIAaoSmXgaPk?= =?us-ascii?Q?pLUa/0AOh8a2j8ttonHIXP02DYhgi49D9ivQzGZFimkAofX+HshPiydIwzU9?= =?us-ascii?Q?n0NWUExT5Fy/DsZx7pvvt6WQRhMpqQUPznHKZp+IviRjIEnzX1Y+gyReCRu5?= =?us-ascii?Q?tCckHKDbx93tolqtCjnC9MKzmxzhRmszoFzlR+in6DUE+5uJCv1lY9KGWFU5?= =?us-ascii?Q?oZUxYzLuyXgDiq0Ta5xAFXVxDa3PQzA7v8wLojqym2pZLXTd5id2n6ZIjae1?= =?us-ascii?Q?/vU/urwtxyMmJh9FNKhqZKiJNqeacbejmrDoNgWU/jiQD0VxSJnfOt9Py5Ob?= =?us-ascii?Q?m9710yoi95Y5hFWhEVtzGktaWbobPhZITfNbln9RU/JDyLSC85UeJs3Rlgv8?= =?us-ascii?Q?6c4pHiQCBzckKN3MOd9gWChmEcuNSX0RPY6fJvoimgg9WxbL7nngEahmjeOM?= =?us-ascii?Q?zxQfqH4QTw5J3nlQyHrkHXMwIU8P5klXyetsulGgL28PJeyLfjtoZs5pA8As?= =?us-ascii?Q?Uy0gEnV7nrUiJCHGRMF3PvttAUHfqsNSNd+wDW34uYkDmtAgKJsGi914CpoJ?= =?us-ascii?Q?vSZE1C0tiFm+pWDxVRFafFsdgE8ziF5MYuqgrROhsNpPAsSq+HkrIaCWEfqW?= =?us-ascii?Q?VZ78jnVFRweCVonVmAsKsy4WdRxQh3n7EkJO4H0CwE43upLMuKH5fs/GFC/n?= =?us-ascii?Q?bIWiXJPhotJ55pvfZucaSK775Ma5PtG01SldlNA1zVUkH8uWzsJD54nozq0m?= =?us-ascii?Q?DkTmi7GhON8tMaMhR38otTFtf5tmUXEPD9DlkgJ3c0cUmrBdvpi8/En4s+R2?= =?us-ascii?Q?DVd3vzMCMotJ/dZ8AGeWb0fRaEKORwoAOPssO9/BmrarR/rotS9HHq1TvlCR?= =?us-ascii?Q?uaNQGjtwCLJz5IATJpTTxguUVEkckJs26bL4wTe15RQNfqGFrFiPMz3AxXiQ?= =?us-ascii?Q?GCMXV1+y6xfeTsQEmyqL6HEuKsY0dLzPMdtPHqymaLryeNgLPx0UGQhVvQwJ?= =?us-ascii?Q?nIIg0NMrGJSBsmwFk2IiDXhTAnehJsvlnEeaZoJofUgLXQ6osW+x5q9F+gmw?= =?us-ascii?Q?yu8aR2RG3BERIpXl0vlTbRlsR6wA9c2ZL+DJ+9WKGAYypiedsi2vF6AkLyeS?= =?us-ascii?Q?9tT3zRlCfp1WoEaHwUoWcTXNc3xjhlaJcC6fSjSt2DVRJzf+Tliu6zUR42Va?= =?us-ascii?Q?vQYaHCVdM1dRKCccnRyeUxlyIwvPuWbSyryfg8Pb6oA760qo+s+IzVBnhQch?= =?us-ascii?Q?QEdIzn1Ih7A2+BfgqfUUKvgsy03O0nDlGMsYuB7sS5BdKwkQCG+FKIs1nK+P?= =?us-ascii?Q?5+kbHofKgxGcCHKkTqqw7ot8ai8OI4xdUKdCcGog?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a5a87430-64db-42b0-177d-08db446fb394 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Apr 2023 02:57:54.7768 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7ySgnOL8rqeVnBhaEj62xPiuh/siHaht3eIyBtX3eYkG+wmaZwwIUmTqV5QlSkvB2/GFHJyqN+UGO/x8y0x4Lg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5143 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Maxime Coquelin > Sent: Friday, March 31, 2023 11:43 PM > To: dev@dpdk.org; david.marchand@redhat.com; Xia, Chenbo > ; mkp@redhat.com; fbl@redhat.com; > jasowang@redhat.com; Liang, Cunming ; Xie, Yongj= i > ; echaudro@redhat.com; eperezma@redhat.com; > amorenoz@redhat.com > Cc: Maxime Coquelin ; stable@dpdk.org > Subject: [RFC 01/27] vhost: fix missing guest notif stat increment >=20 > Guest notification counter was only incremented for split > ring, this patch adds it also for packed ring. >=20 > Fixes: 1ea74efd7fa4 ("vhost: add statistics for guest notification") > Cc: stable@dpdk.org >=20 > Signed-off-by: Maxime Coquelin > --- > lib/vhost/vhost.h | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/lib/vhost/vhost.h b/lib/vhost/vhost.h > index 8fdab13c70..8554ab4002 100644 > --- a/lib/vhost/vhost.h > +++ b/lib/vhost/vhost.h > @@ -973,6 +973,8 @@ vhost_vring_call_packed(struct virtio_net *dev, struc= t > vhost_virtqueue *vq) > kick: > if (kick) { > eventfd_write(vq->callfd, (eventfd_t)1); > + if (dev->flags & VIRTIO_DEV_STATS_ENABLED) > + vq->stats.guest_notifications++; > if (dev->notify_ops->guest_notified) > dev->notify_ops->guest_notified(dev->vid); > } > -- > 2.39.2 Reviewed-by: Chenbo Xia