From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 046E0429D0; Mon, 24 Apr 2023 04:59:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E847A42B8E; Mon, 24 Apr 2023 04:59:14 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 0C85D427EE for ; Mon, 24 Apr 2023 04:59:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682305153; x=1713841153; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=FjCji4j2xAFXvKyU3IDO/n+nSK/E3iEthklyKRQieaQ=; b=Ij8zR11Ss7HNKnMdxuLREX/1th1zgTlW7lURzZwmFBTlwrnECWXWu6rM gZZJBgu0xhBfftiOtEuiJmuU/MS+kKHpiBczpKuwdwnl3K5tQrUkyqKsN bGq6AtaOFm/tUtfDtGshvVgLD+N5iWDHt4hVo5wTQgbZGX8hhs8BeuI3+ Vja63C1Ppvpk7d2tG0mXmeXUfujqEx4qzSNp4g78KRkOohsC+795dPsHl MgkKPZsFP5cxdeVbCtCV2JhAdx3MtyqVVAXuwFhECp4/TNnBfaGId7xBv gdyRYoiu99eSthtcmFRgrBvUASAC7eStkPr55p9Yz+2UCAM7i1DbueXzm g==; X-IronPort-AV: E=McAfee;i="6600,9927,10689"; a="330549297" X-IronPort-AV: E=Sophos;i="5.99,221,1677571200"; d="scan'208";a="330549297" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2023 19:59:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10689"; a="686619309" X-IronPort-AV: E=Sophos;i="5.99,221,1677571200"; d="scan'208";a="686619309" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga007.jf.intel.com with ESMTP; 23 Apr 2023 19:59:10 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Sun, 23 Apr 2023 19:59:09 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Sun, 23 Apr 2023 19:59:09 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Sun, 23 Apr 2023 19:59:09 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.101) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Sun, 23 Apr 2023 19:59:09 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dYBoaAtyPAYBWGscDsp79lPtO0cuHNSI4jH8Sk0KK/NUAMfZX2qIr8IUP98SW648+G/0HYJrTVM4aEfT+jnzxCddzngfL8ZXb+T7c+Bt2g1inF2riyxvhNzTpAhT8b5V7o1HqkNNFt4JDn+hkFqF3JCl0mlUguoQgGGDa2UWY2uOx1Jafe/XtHe9fKfoU78iNmMYmgkigMEfHU7wtL7oSrDFzr3OCeBzuOsad0wwiwVoeIl8spJPMR0j3OaI9LWF40EKZ4UXTZYDgAK2GJScN18GXGiEcjjlUsCV2Hi70PleFE5n1t1OL2jxBdtn27XcvwFhKZgrrSUJZ+eaaMm9iQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=POi+u/fDyJpD7qZP0TdX4xsHFg2Bcqa142fM/7uckH0=; b=BT0+76LhdDJDFR7st52rPlpARacusoxFYbUcRUd2HlGYYJryDS0zr/pFgZJ1e90NpVtYMqZkv9kpAhJVvlc8z6D2vJay9y29lx0RHUwDw8SSl6fuAI2f3xZt4lczek9ZpFy1X72T0L/PpSVFH1oAi1zynHv+oJrxWWkbKzEHhUu9xuiE/l8Mt9yC6aOdsiEzPXse0/j+iaoPKtAXvEqX1Oach0854I9mJSS35/SfNC62S34N2FozmgxLB37UQ+N3bI61knGOsBM8IIQ1v5F3v9UvTcUaY5NjhaTiflgp0buInXPLbq9eqhfVG7a/klqiogl0nyqGGym2Csu6JgQU5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by PH0PR11MB5143.namprd11.prod.outlook.com (2603:10b6:510:3f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.32; Mon, 24 Apr 2023 02:59:06 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::2d7a:a878:7bed:bb11]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::2d7a:a878:7bed:bb11%4]) with mapi id 15.20.6319.032; Mon, 24 Apr 2023 02:59:06 +0000 From: "Xia, Chenbo" To: Maxime Coquelin , "dev@dpdk.org" , "david.marchand@redhat.com" , "mkp@redhat.com" , "fbl@redhat.com" , "jasowang@redhat.com" , "Liang, Cunming" , "Xie, Yongji" , "echaudro@redhat.com" , "eperezma@redhat.com" , "amorenoz@redhat.com" Subject: RE: [RFC 04/27] vhost: add helper of IOTLB entries coredump Thread-Topic: [RFC 04/27] vhost: add helper of IOTLB entries coredump Thread-Index: AQHZY+exUUvsUBxCu0q0htp3tI0JQK856Zqg Date: Mon, 24 Apr 2023 02:59:06 +0000 Message-ID: References: <20230331154259.1447831-1-maxime.coquelin@redhat.com> <20230331154259.1447831-5-maxime.coquelin@redhat.com> In-Reply-To: <20230331154259.1447831-5-maxime.coquelin@redhat.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB3504:EE_|PH0PR11MB5143:EE_ x-ms-office365-filtering-correlation-id: ad54028a-21b8-4e57-7524-08db446fde63 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Y+t2Ucf6293VLwyfaN5COLFaj8LACDVrVxbrUthsvdcs75lniLoOxiin8jZsd3NYuXikDapjZcMVY5lfWysuEINLZjFYf+xAS2/53Nb+/S9eESGXttO1ZVC4+il4RspFs0IraP3NZVN8FargWRR6GQDLFLhFXXc0jRB+wXJMW/6a7jBMyQ/RBysQUosUzVI+KXpWL3CKV16BRX1g0TRDhGBJrEMbTJDmVjZfPX+etsQWhI2zOzNWFL28W+5vNrzLkugNRoDTkVQKdLxJTN3xocJhO3rrF+V0VFJ9pX5ZO3VQxRh46mFGbGUz+VWEdj7nvT218xBvIFb3H33snFlwmr9WTDXWFVvfELcltLWZZZzxWtNgxEZzn3XYRlo1esrRz69J4VxoyjegQvDGJAtm/cFqjQc0YOY4ePBAhfZJ8B2mDzjQAVtXLU1C94L7ZVXjQecUMKfXPOg0jOrxAU697w1FFUL12USdKeBxbAzI3MzidtGBgi0WHRUopSuuaPY/fQXauLBL535LYrCm8bwJtcTZWNRTx18UU1DYF8sb9ZsOPD1FNjUjsgijKMom/QALSf1/RpM1UQZoml9BXJK97gyVjJU8H1gEyltxnKQbJZO6Nv4wVLQ/iJgJVMR+/1pR+OgFAlnnrD/62zjup2Qa5Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(376002)(346002)(366004)(39860400002)(136003)(396003)(451199021)(38100700002)(122000001)(921005)(82960400001)(9686003)(53546011)(83380400001)(6506007)(26005)(55016003)(186003)(33656002)(7416002)(2906002)(8676002)(8936002)(52536014)(5660300002)(7696005)(478600001)(71200400001)(38070700005)(110136005)(316002)(66446008)(66556008)(76116006)(64756008)(41300700001)(66946007)(86362001)(66476007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?FnStrCAfdoASE0K1tL1j2Uuct93GpcQObZtB+qaXIxOmY/NuTiSmS0b/ArVc?= =?us-ascii?Q?2eLdfS6liCbpzUPgGbxL0MoZZk1O7C/6YSfq/P6PuZF/9rJOGVrKeTwwUYkZ?= =?us-ascii?Q?TluEITY2zczDlZOvVQnfYZ+aR8jwdW6UbvF+9rzXjSgcQMw/D3t2H6LH/vyJ?= =?us-ascii?Q?iikCghC9mHQuCRLfmgWLDn3CIZZcvJTN2QIS+M5fD3UszC17ujTgWz58qjPj?= =?us-ascii?Q?R+kDEPjPCWGs6MSXRvJeHojFN+3EsJKWw4zb9Wr7hZtmX4X9MzedoCb8RJjf?= =?us-ascii?Q?dSMIReRdDEl48jM6nn4ye4V56b1niW16usDuD4ztemjWGYRibwJHKvdenL+w?= =?us-ascii?Q?FkMmnY9RwyejIWtR8sYxqA60syJbLAPtgUc2CVUQGbv4ynloMnT1cAOAhM7I?= =?us-ascii?Q?vumyR2FsvNWoKMtv3FL0eszvdGNCrCsAon4jM9FWWuzbywU1PmLPeQUK7miT?= =?us-ascii?Q?CyLPSdqPS34NSYvItMuxFLr2AP/5koDoUcw2QhkB1lbjHysYLOpRpoN/85Cq?= =?us-ascii?Q?nH+XxkrFdTE6jWCjJRU5+dsPcBnOVXTeTWnHd6sV/JDgKvAV8g9vIlMW2P+w?= =?us-ascii?Q?3EYguj4yHUm6Rt1YUAl8+QloVC0T4UbbfBTJbOqvnT0bux1IgplsCdV9/i2B?= =?us-ascii?Q?rptcccUXVg39gfY9yYAodyzlEBy+P+3mASHdnCE8F9s7FO5Xmee7mTlhWXB0?= =?us-ascii?Q?AuDy+BvmuDnno/75+iw1/8GcLS5UVeFyeG7JZu9zkloUVOcOevaoFFXp3X3c?= =?us-ascii?Q?T9xS0cg6DQpUwvvRWp/6d9UG1aFg+DThruUZYJb4NDaT21Ifjd4wtfl67smi?= =?us-ascii?Q?syTPDD9tC8AitfrU4Nyrk4Kz5RzZVw/sPZMFRlpNwKmMa10rGBn6MnPSWa+E?= =?us-ascii?Q?MOiWJTm0TTt/AB915xq2y6Ly+7b5czLJDFL5WEhBJy9on7KcmSQlODh1Ok5A?= =?us-ascii?Q?X0GHk2zc5Zk+ALTnNSWw53mJpgjbMenHr4rWQAxW1XihehQZUFcqukCqecMu?= =?us-ascii?Q?m5dXZJAwa0qYrJViMXNgHE0x+Sx60fwVaNvQ+DbBTz2dj/irludQR8V0yxOM?= =?us-ascii?Q?eh/Tp1NcRVt0gZyeHYyoctJ8/oZtUY4k46T46yG82cUNvKhhecCao/xTLZG8?= =?us-ascii?Q?juoVxW0N+RxW6Z9rm7QVSau+tkcxTi8nMVp6yO4FW52HkavHyQTQE/2q1MHc?= =?us-ascii?Q?l9n1/vtddQtxytKvTcUMV1zMbJDayCcH+MbMqnvq+/smUGYLbuIpSHEdkSYp?= =?us-ascii?Q?dhoU/po0CTn21IaRUk+PMxpTIJzk1vVuHLHWu14pC5U9iTU3tgk1/2KXiB9t?= =?us-ascii?Q?JwHfQAQI0mmt+MPjc75RVbGfv9DQfZmZGvS8iiPrwYri0i2JGPGXi8N3PCIc?= =?us-ascii?Q?mWv8DOsScBWFPVDJVII2xRzBIvli8c5C6os77EEGHkj7U7WX/rgAUpLl39Ka?= =?us-ascii?Q?RbWFjRvzdwhjcbv+RSNd6GfQZ0O49k1TsGgmK4mG7k6tr8CiVil41y/qOoQX?= =?us-ascii?Q?GQSmuekuNF6yb7DH8VO4ZNtzc2PYu8SuVoXDI3u+D28Dm0aDgUpArT7aH/sQ?= =?us-ascii?Q?Mc0EsZxlrQtmzOptOSPhpiTAQNcCzikS4L8wO415?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ad54028a-21b8-4e57-7524-08db446fde63 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Apr 2023 02:59:06.5940 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 52kWt/VpusTKiiXrCwW2ZBRBWyzvfbDVPazvHU7M/O4ZkCW8xw+2Lrin4Jr0xRhi43TSk+yZR7Jdg0y5Mtcm2g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5143 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Maxime Coquelin > Sent: Friday, March 31, 2023 11:43 PM > To: dev@dpdk.org; david.marchand@redhat.com; Xia, Chenbo > ; mkp@redhat.com; fbl@redhat.com; > jasowang@redhat.com; Liang, Cunming ; Xie, Yongj= i > ; echaudro@redhat.com; eperezma@redhat.com; > amorenoz@redhat.com > Cc: Maxime Coquelin > Subject: [RFC 04/27] vhost: add helper of IOTLB entries coredump >=20 > This patch reworks IOTLB code to extract madvise-related > bits into dedicated helper. This refactoring improves code > sharing. >=20 > Signed-off-by: Maxime Coquelin > --- > lib/vhost/iotlb.c | 77 +++++++++++++++++++++++++---------------------- > 1 file changed, 41 insertions(+), 36 deletions(-) >=20 > diff --git a/lib/vhost/iotlb.c b/lib/vhost/iotlb.c > index 870c8acb88..e8f1cb661e 100644 > --- a/lib/vhost/iotlb.c > +++ b/lib/vhost/iotlb.c > @@ -23,6 +23,34 @@ struct vhost_iotlb_entry { >=20 > #define IOTLB_CACHE_SIZE 2048 >=20 > +static void > +vhost_user_iotlb_set_dump(struct virtio_net *dev, struct > vhost_iotlb_entry *node) > +{ > + uint64_t align; > + > + align =3D hua_to_alignment(dev->mem, (void *)(uintptr_t)node->uaddr); > + > + mem_set_dump((void *)(uintptr_t)node->uaddr, node->size, false, > align); > +} > + > +static void > +vhost_user_iotlb_clear_dump(struct virtio_net *dev, struct > vhost_iotlb_entry *node, > + struct vhost_iotlb_entry *prev, struct vhost_iotlb_entry *next) > +{ > + uint64_t align, mask; > + > + align =3D hua_to_alignment(dev->mem, (void *)(uintptr_t)node->uaddr); > + mask =3D ~(align - 1); > + > + /* Don't disable coredump if the previous node is in the same page > */ > + if (prev =3D=3D NULL || (node->uaddr & mask) !=3D ((prev->uaddr + prev- > >size - 1) & mask)) { > + /* Don't disable coredump if the next node is in the same page > */ > + if (next =3D=3D NULL || > + ((node->uaddr + node->size - 1) & mask) !=3D (next- > >uaddr & mask)) > + mem_set_dump((void *)(uintptr_t)node->uaddr, node->size, > false, align); > + } > +} > + > static struct vhost_iotlb_entry * > vhost_user_iotlb_pool_get(struct vhost_virtqueue *vq) > { > @@ -149,8 +177,8 @@ vhost_user_iotlb_cache_remove_all(struct virtio_net > *dev, struct vhost_virtqueue > rte_rwlock_write_lock(&vq->iotlb_lock); >=20 > RTE_TAILQ_FOREACH_SAFE(node, &vq->iotlb_list, next, temp_node) { > - mem_set_dump((void *)(uintptr_t)node->uaddr, node->size, false, > - hua_to_alignment(dev->mem, (void *)(uintptr_t)node- > >uaddr)); > + vhost_user_iotlb_set_dump(dev, node); > + > TAILQ_REMOVE(&vq->iotlb_list, node, next); > vhost_user_iotlb_pool_put(vq, node); > } > @@ -164,7 +192,6 @@ static void > vhost_user_iotlb_cache_random_evict(struct virtio_net *dev, struct > vhost_virtqueue *vq) > { > struct vhost_iotlb_entry *node, *temp_node, *prev_node =3D NULL; > - uint64_t alignment, mask; > int entry_idx; >=20 > rte_rwlock_write_lock(&vq->iotlb_lock); > @@ -173,20 +200,10 @@ vhost_user_iotlb_cache_random_evict(struct > virtio_net *dev, struct vhost_virtque >=20 > RTE_TAILQ_FOREACH_SAFE(node, &vq->iotlb_list, next, temp_node) { > if (!entry_idx) { > - struct vhost_iotlb_entry *next_node; > - alignment =3D hua_to_alignment(dev->mem, (void > *)(uintptr_t)node->uaddr); > - mask =3D ~(alignment - 1); > - > - /* Don't disable coredump if the previous node is in the > same page */ > - if (prev_node =3D=3D NULL || (node->uaddr & mask) !=3D > - ((prev_node->uaddr + prev_node->size - 1) & > mask)) { > - next_node =3D RTE_TAILQ_NEXT(node, next); > - /* Don't disable coredump if the next node is in > the same page */ > - if (next_node =3D=3D NULL || ((node->uaddr + node- > >size - 1) & mask) !=3D > - (next_node->uaddr & mask)) > - mem_set_dump((void *)(uintptr_t)node->uaddr, > node->size, > - false, alignment); > - } > + struct vhost_iotlb_entry *next_node =3D > RTE_TAILQ_NEXT(node, next); > + > + vhost_user_iotlb_clear_dump(dev, node, prev_node, > next_node); > + > TAILQ_REMOVE(&vq->iotlb_list, node, next); > vhost_user_iotlb_pool_put(vq, node); > vq->iotlb_cache_nr--; > @@ -240,16 +257,16 @@ vhost_user_iotlb_cache_insert(struct virtio_net *de= v, > struct vhost_virtqueue *vq > vhost_user_iotlb_pool_put(vq, new_node); > goto unlock; > } else if (node->iova > new_node->iova) { > - mem_set_dump((void *)(uintptr_t)new_node->uaddr, > new_node->size, true, > - hua_to_alignment(dev->mem, (void > *)(uintptr_t)new_node->uaddr)); > + vhost_user_iotlb_set_dump(dev, new_node); > + > TAILQ_INSERT_BEFORE(node, new_node, next); > vq->iotlb_cache_nr++; > goto unlock; > } > } >=20 > - mem_set_dump((void *)(uintptr_t)new_node->uaddr, new_node->size, > true, > - hua_to_alignment(dev->mem, (void *)(uintptr_t)new_node- > >uaddr)); > + vhost_user_iotlb_set_dump(dev, new_node); > + > TAILQ_INSERT_TAIL(&vq->iotlb_list, new_node, next); > vq->iotlb_cache_nr++; >=20 > @@ -265,7 +282,6 @@ vhost_user_iotlb_cache_remove(struct virtio_net *dev, > struct vhost_virtqueue *vq > uint64_t iova, uint64_t size) > { > struct vhost_iotlb_entry *node, *temp_node, *prev_node =3D NULL; > - uint64_t alignment, mask; >=20 > if (unlikely(!size)) > return; > @@ -278,20 +294,9 @@ vhost_user_iotlb_cache_remove(struct virtio_net *dev= , > struct vhost_virtqueue *vq > break; >=20 > if (iova < node->iova + node->size) { > - struct vhost_iotlb_entry *next_node; > - alignment =3D hua_to_alignment(dev->mem, (void > *)(uintptr_t)node->uaddr); > - mask =3D ~(alignment-1); > - > - /* Don't disable coredump if the previous node is in the > same page */ > - if (prev_node =3D=3D NULL || (node->uaddr & mask) !=3D > - ((prev_node->uaddr + prev_node->size - 1) & > mask)) { > - next_node =3D RTE_TAILQ_NEXT(node, next); > - /* Don't disable coredump if the next node is in > the same page */ > - if (next_node =3D=3D NULL || ((node->uaddr + node- > >size - 1) & mask) !=3D > - (next_node->uaddr & mask)) > - mem_set_dump((void *)(uintptr_t)node->uaddr, > node->size, > - false, alignment); > - } > + struct vhost_iotlb_entry *next_node =3D > RTE_TAILQ_NEXT(node, next); > + > + vhost_user_iotlb_clear_dump(dev, node, prev_node, > next_node); >=20 > TAILQ_REMOVE(&vq->iotlb_list, node, next); > vhost_user_iotlb_pool_put(vq, node); > -- > 2.39.2 Reviewed-by: Chenbo Xia