From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4639C41C27; Tue, 7 Feb 2023 03:58:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DB371410DF; Tue, 7 Feb 2023 03:57:59 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id A8F6B406A2; Tue, 7 Feb 2023 03:57:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675738678; x=1707274678; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=tVoy3DCIHg5cI/TUUCkgXElNrPbtb8R76AE8LfLkwig=; b=ZghEjT1CqdQOXVzRGYJf4cp5PqUGjD7lRBMnLjjMEo/Ps5pBDZ2n5VjM 0ssGNuxeGFPDhyrbN9pLVTireXDJ9RYDFjhhxsYGVk13wL/7qXiDIOx/f I2/hd6oKgcb2u11qEXY+e7MWQ5YsV6zgB6e6BdhE8eDuHecB0saZlVNFc eOXBYmbHdg8CRp73rutgjmC+9c3nWgM8sVQJMCK93nmZboFYZG+ySPtP2 rgLYTjQS9xQZUvv0b4rDbWqKU/GTeCoKKieMprBWKaIR5mrkTjPhu6ivi 0qrbp9s2p42+7r9TRHUvkfMou8a6WFTdq1DgBZcbhDSAcKSpwh1UP++pX g==; X-IronPort-AV: E=McAfee;i="6500,9779,10613"; a="329405182" X-IronPort-AV: E=Sophos;i="5.97,278,1669104000"; d="scan'208";a="329405182" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Feb 2023 18:57:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10613"; a="660065551" X-IronPort-AV: E=Sophos;i="5.97,278,1669104000"; d="scan'208";a="660065551" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga007.jf.intel.com with ESMTP; 06 Feb 2023 18:57:56 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 6 Feb 2023 18:57:56 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 6 Feb 2023 18:57:56 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.170) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 6 Feb 2023 18:57:55 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ALVtfOpi6OBZVtieB2vYijr0Eh1IcpgInP0u/pdVmWfmNAU96Q5VcrMkEKw+yTTJT7C4dhP7UEBeO+HT0tzl+3oPNz1A1qU3M5JHknNfqWG2XXZXthReYV6keRXF6GHStGYFiXA22h9XET5/eDy2BH2yJhEtMZx55NTfTnWLgcuQgwrrQeVhfKnTMf+nboccnn1rEgIvb/PFusfQ0iFoZg5PnWNTdMXkw7WEjahvDRf5j2pzXvAPMvOSc7ufJUbyvi3faF2WO0UZE5g0sZcYdwBfz57VaXdUGgBmWk2R5flXXh0rqLbmqSyA1hMgK/A2ypFtkznxzOcpKC2vWbhhpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Smgm4gI41eO+HHBLCjqFRrJRhQ+HWiZNPmC1zhpTHLg=; b=DbAxEK/bOE8U58hQtJEhnlb4eWAK7uTknZ4SLNwRv8auogGlwf7lsZJS4qO1425euRR/EiBa5ReXUvTqlXRT6UCHhWluZ03tDSqsC9QgK7AmuRhJr2fHCbpEkHhCei4k81Un7MoUWqph6ESJj08Vuoega0BL+gcFXf3CbWHBVLD+SOa8GCDxW42VcTA6aomrxUUQ+fgXo7n7uT2ko33ZWEd4OxSBbVeuk2Lc35xPrkFjq9hfHrRymg0vkqDx5oaigY/Z62Z85fL+bPYC0InTaVULAss4KR4BQwgCm7+RoZ0RBS9JiIiEYIwOYEGWw0A7rA5Xr+Cg5dneoLQnDkwijA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by CY8PR11MB7009.namprd11.prod.outlook.com (2603:10b6:930:57::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Tue, 7 Feb 2023 02:57:54 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::c8f8:a3e1:5b23:a9c3]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::c8f8:a3e1:5b23:a9c3%5]) with mapi id 15.20.6064.032; Tue, 7 Feb 2023 02:57:54 +0000 From: "Xia, Chenbo" To: Maxime Coquelin , "dev@dpdk.org" , "ktraynor@redhat.com" , "david.marchand@redhat.com" CC: "stable@dpdk.org" Subject: RE: [PATCH v2] vhost: decrease log level for unimplemented requests Thread-Topic: [PATCH v2] vhost: decrease log level for unimplemented requests Thread-Index: AQHZOjz4BBqqr0d5R0u40IJBbxBwAK7Cy2zw Date: Tue, 7 Feb 2023 02:57:54 +0000 Message-ID: References: <20230206150733.108910-1-maxime.coquelin@redhat.com> In-Reply-To: <20230206150733.108910-1-maxime.coquelin@redhat.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB3504:EE_|CY8PR11MB7009:EE_ x-ms-office365-filtering-correlation-id: f240e7cb-b9e4-4218-2942-08db08b71bdc x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vJE7XKToPqYqA7UXsiHT9pqBsSBR5SX7Gdln5ijHEFQoyApDR9lnYBJ6Ge8NnVBFe+YqEm7Wl9CaAEeR91ttGO8lwN1Af8nLxxmnqWD2SKzh8bxxSfzkG18mgCHYQL48DLTXKe84EXPCBwogg831UjXzEZMly7UYuYt9N0K8aCqUG009r5BYEtB1Fj+bFa0lK/nPo0TTjUZYTf3sqBUYp+sIsSSjLOwn6V+ypMTvJRhGn48Njo95E3FIDfci+1ui4bWjHqTMlHvpwc+0CUgpDsboCNmAkS/IkijGQVZGz2eQuJQXLkM+5MyU7eX2COhi+qdfneWq39SEwPvh1zoTni2+xgg2Nr/1k2sX2qwgqmj6viW73/NOemrNaCcAyKF8bTmS6nwCjIb+jHnKsFq5kJvz14A26gOBC5gv3UaZ/3LYHiIpuCgcT/aWAjvu7GMljtSqo7Gcjou5/hU/Wwo0M7nE1mbbR1YXW1IvLdiEPsilyQj3+WTJeMjMHyZ1SJ3+v+TK0IXQZGYhE2oOJMQaCL79qiNy2zggN4HrLvNaLGGVlFUwsEmpp4uYPjjAEa/5nUUrVesIIdzHMMxDA5QEMvDQQN8kahCz/g3EA7O5xz+pl+KV0W0IEb9BIqtdTZ80SnKppXJYuI3ai0MoZq+G60MM+/UmgohJs1YzoGqXtaFhRFjSdM9rqR+VwW4SFLE3DnV09JrIFpCyCZwdfq3Exw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(346002)(376002)(39860400002)(396003)(366004)(136003)(451199018)(86362001)(33656002)(2906002)(82960400001)(122000001)(38100700002)(38070700005)(53546011)(7696005)(71200400001)(6506007)(186003)(26005)(9686003)(55016003)(83380400001)(66946007)(110136005)(316002)(4326008)(66446008)(66556008)(66476007)(41300700001)(8676002)(64756008)(76116006)(478600001)(5660300002)(8936002)(52536014); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?VcHggyzoS2VOz7SNfqsg3Qmlbz8kjmQL5LTmxct4LaOhJL42GEc1NZaaOESG?= =?us-ascii?Q?eWjZydAOgn7wt9YEPbzpi4EirXrZX6lfzoHVvniOULYvWEOJ5dKD1UxJC+Tb?= =?us-ascii?Q?n6voBVWqqUvFkqYsBwJpyHnrvzZy+fX45Sfkm56IekAXXpervVhI3rDlfRh6?= =?us-ascii?Q?mpMaScLMGEBSyrY6/1YtHJ/TG6yNee6eLeT5gwHM2qC9ycNBOsSiyrgHtzl7?= =?us-ascii?Q?vp1IUAVEoDHPXI3jHcHGRq692IQeanv1Rhyzw5eFzzzshMy8RA9eoigydLRQ?= =?us-ascii?Q?R134Zn1lruB2J7buRtB3Rcuj1oYKidF8VriX6d1uFAIDCRWuw8zWWY+Bi5rv?= =?us-ascii?Q?4Bkcx3fmjkmD02JmRlHS+CCiqznuMHqkUaC7EbGyrM2T5KKjVKng+Zz5WFAa?= =?us-ascii?Q?uoq/TLHU7z/ZrTZcwDVpHqjcP1isHNhidUSxAv5qYh6OINw3qwicdcgZVmfl?= =?us-ascii?Q?nDgFe2qCkQ4SZXTNG1eLXFjajdfkj/OaD3S/WrQLL9g9qlaRBksG2TZGzX4d?= =?us-ascii?Q?xWqSf2knfLHPRz259EyseeoVpVyg0OKgXHQdRAk8PIurRDP8Ygrkt51JP+70?= =?us-ascii?Q?AgNYO4ljumjLcFlfam69yMz6vcOuQhJHdiZRr/i6VVVZdZruoAhYMXP4ZaMa?= =?us-ascii?Q?4Irn2JmTZEwYVuEkj6E9clgZZXSWTzuA/xeu4FrD47o/2o0UAgamkLz+Rtag?= =?us-ascii?Q?JvH/bTejQoz7uOb0OnReY0KmO48n738kIcBT9KLJ9sjRSGMyAp6BRITRTHse?= =?us-ascii?Q?fRReHt0KEzpiWcVUECyQ2qioRTREIsf3rHovomuUvvSIOEkozN63XMHhu1/Y?= =?us-ascii?Q?H2K6QwKsrQ4udLGyVBnvYK9ifIGtnuEd4jcK1MjNazzxiNhUFzx+zljSMQGm?= =?us-ascii?Q?N+9ptUAxAEcqwnF4ZPRrKuoxxq39fJIBWMR7U2eGbcq6B+2JtpvPDH1EKinH?= =?us-ascii?Q?13gPwq8nRGmmyA1glI8uL3gz4JCLg/7yhxixnVyD4X6Kfdy0zmwWYpMpEhpd?= =?us-ascii?Q?ENzDoebwZnKVHewYCr8iWgAfcvW9rryHrhRMf/jH3i6nsq4eRAYtduJILRWh?= =?us-ascii?Q?iva70jZJL1BL8KqHs0m7se+OlFZKzgMyqFk/fnExulZ6XQjHacQUNcOl4STD?= =?us-ascii?Q?1iOgknR+2fa9/arb2/WzfdjN5odSSrhrthoi5T26xWbi4AAjq2HPg0qHT7hM?= =?us-ascii?Q?nc00J5pN3vPhWzXGybBenskxlpz7fu78QuGeC4XQo5r+CfbqK/F3PUYKodmO?= =?us-ascii?Q?mkJfuwuF+bREZzhey7/gOd6dzWxtd48Ii+TX3GggWt8PlHTJ5H0/UpNYuBPg?= =?us-ascii?Q?c/Mvwja2nJNyidsK5W0GLojVmo6MbYh7lEoY5F8IF/t3E/UpdB+m0TIl2q7Y?= =?us-ascii?Q?m7BAjjcETvzSQBpvpIUg0VKPbLRbV9TDbd7QfWeSmMt+uAzHePdOFSToX9Y3?= =?us-ascii?Q?X8rhSTTPL+VQvr8cb4Rsf5a0WWNFCRGkCAkERUshKG1VkV6xdqaNwhaVBSa7?= =?us-ascii?Q?RSTfj3ikZpT2+rnWFme/Ax13B4xZWGboDgsA2v1P1LPhbaPFePdxaXqmgDG3?= =?us-ascii?Q?eoeqMT52XnbdlI6Rdb+ep7I2b8I1X0Nc8XADNbvQ?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f240e7cb-b9e4-4218-2942-08db08b71bdc X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2023 02:57:54.2351 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lYTuF5tnxbsEt9lLxsngDUoF0ndng03FlOiCCvtdVaBXKC7B/kMqZHNH/0kOJnL5I/IAYAnQcNAOW+yb6z8hzg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7009 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Maxime Coquelin > Sent: Monday, February 6, 2023 11:08 PM > To: dev@dpdk.org; Xia, Chenbo ; ktraynor@redhat.com= ; > david.marchand@redhat.com > Cc: Maxime Coquelin ; stable@dpdk.org > Subject: [PATCH v2] vhost: decrease log level for unimplemented requests >=20 > This patch changes VHOST_USER_SET_VRING_ERR and > VHOST_USER_SET_LOG_FD "not implemented" log levels from > INFO to DEBUG, as implementing these requests is not > mandatory. Having them being displayed at INFO level > may induce some confusion to the end-user. >=20 > Fixes: fd29c33b651a ("vhost: handle unsupported message types in > functions") > Cc: stable@dpdk.org >=20 > Signed-off-by: Maxime Coquelin > --- > lib/vhost/vhost_user.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c > index 8f33d5f4d9..551908df8e 100644 > --- a/lib/vhost/vhost_user.c > +++ b/lib/vhost/vhost_user.c > @@ -1818,7 +1818,7 @@ static int vhost_user_set_vring_err(struct > virtio_net **pdev, >=20 > if (!(ctx->msg.payload.u64 & VHOST_USER_VRING_NOFD_MASK)) > close(ctx->fds[0]); > - VHOST_LOG_CONFIG(dev->ifname, INFO, "not implemented\n"); > + VHOST_LOG_CONFIG(dev->ifname, DEBUG, "not implemented\n"); >=20 > return RTE_VHOST_MSG_RESULT_OK; > } > @@ -2336,7 +2336,7 @@ static int vhost_user_set_log_fd(struct virtio_net > **pdev, > return RTE_VHOST_MSG_RESULT_ERR; >=20 > close(ctx->fds[0]); > - VHOST_LOG_CONFIG(dev->ifname, INFO, "not implemented.\n"); > + VHOST_LOG_CONFIG(dev->ifname, DEBUG, "not implemented.\n"); >=20 > return RTE_VHOST_MSG_RESULT_OK; > } > -- > 2.39.1 Reviewed-by: Chenbo Xia =20