From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 86D2BA0557; Fri, 10 Jun 2022 05:51:38 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 77B51406B4; Fri, 10 Jun 2022 05:51:38 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 66CAE40221 for ; Fri, 10 Jun 2022 05:51:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654833096; x=1686369096; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=DuL9jzEQoeXe8x0+t9ehI+Ykus+6BKlq1nNuDBb0M5A=; b=OFEpbmhRtiIJbUUjVn5Da/jK8repl33gCLH3T5lnXye3q1PlR0seI19u 3BzxSRVfE28fHbqliV6UJOhYrowybmC5ufGdZdH9OLzfkI9Tq/Ll5YJc5 vIA0rD/punLG0yM+aFrzR49YMwgWkU4ZLoHe/kOMmpydkmb2Neer6e6ax q0nvCrA0NaEukAHPCXfL/VQQk1Kw+w4BrSBDwfjdOYhsL25dGvjnsEPXO 1bKb7PGSkRWsIDtd621Tb6E0/o+2crBeJbinNrgidNrB3fgtAMcvxnCn1 fbAkhuHsFzCfs1RqblwT/kthySAiFd08rfdqq8SwL3/fnj6TxJNZ2DIkq g==; X-IronPort-AV: E=McAfee;i="6400,9594,10373"; a="363829254" X-IronPort-AV: E=Sophos;i="5.91,288,1647327600"; d="scan'208";a="363829254" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2022 20:49:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,288,1647327600"; d="scan'208";a="556194686" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga006.jf.intel.com with ESMTP; 09 Jun 2022 20:49:48 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 9 Jun 2022 20:49:48 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 9 Jun 2022 20:49:47 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Thu, 9 Jun 2022 20:49:47 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.172) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 9 Jun 2022 20:49:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Pz5ow3sGzpVx+I7/yJoDS2otvifHNCpoIrWamUnueOg+YviqCAPjs1juaAzHukJAnMPWMMpt7OvOkE5KsJ1UHpIYR+Phu4rIhf8Cx5EDfvFdXJompxiMV18iPsD04HbV2hcHgPaMjtXY8+oskX0UBIajDrXjGdUDHEzlIXy8FZDcfri4KO9RXXqAeS5lKjBOsNzFCwsMs6ZejIVd5RX12MYjkKJPA+Livqzu+BScA59QuA4AmacSpt+uHNA9Ywj4YeQbG+Lj7wdJ+chbi+MHzaor2aSkYSEcSC09wk7R7sDYBs2zNiZVChv4OOl+1AVvmkaGX0t3Son+I2QZK3QUVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=V9QbrcEURUUrcDHfpP2TJHDs6kmb78lHFIGVH74vxb0=; b=RbE0TIXbHBkCfv+J+lIvPoxZZ3g5otHwHXztb81q5dH1ps0I1pPV5PtJTqDDrmlJCg/DDUnadb9AWnl5VBDjD0Lr08EtQBJgIXsAL7FAYfdTXbAQkP63WbNL98MK4max6qjJoMNjtc2ij/Xx4Dz15mZBNYn40XBk4Pz8rAk7rb7F0tZS1/EsW2j1Xl2MBaTrLGNBZS9/BjEEmqQiSA2V86ebuthkkfj3xDUZi1woNfSnbN5p7Z/t1+5wHaa0ENi0duDhwqBirYVW8YZqcizE450CaThp4nY00oQjZN5K2rcYZSxDQd6mtkynbIOxtdihd6+aJ41QaDzAVkZjQaAwMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by MWHPR11MB2016.namprd11.prod.outlook.com (2603:10b6:300:26::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.13; Fri, 10 Jun 2022 03:49:45 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::d4ff:ac50:621a:60e7]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::d4ff:ac50:621a:60e7%7]) with mapi id 15.20.5314.019; Fri, 10 Jun 2022 03:49:45 +0000 From: "Xia, Chenbo" To: Maxime Coquelin , "dev@dpdk.org" , "jasowang@redhat.com" , "david.marchand@redhat.com" , "Matz, Olivier" , "Ma, WenwuX" , "Zhang, Yuying" , "Singh, Aman Deep" Subject: RE: [PATCH v2 6/6] net/vhost: perform SW checksum in Tx path Thread-Topic: [PATCH v2 6/6] net/vhost: perform SW checksum in Tx path Thread-Index: AQHYezZTW5vJMGYo1UypFmW2qXY6eK1IA8HA Date: Fri, 10 Jun 2022 03:49:45 +0000 Message-ID: References: <20220608124946.102623-1-maxime.coquelin@redhat.com> <20220608124946.102623-7-maxime.coquelin@redhat.com> In-Reply-To: <20220608124946.102623-7-maxime.coquelin@redhat.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6986e589-93ff-4b3b-bf4a-08da4a944226 x-ms-traffictypediagnostic: MWHPR11MB2016:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Zkv/5P8NMbMcHPRuldPGippw/Swze6WL0Y6BxRV+7o/gQYen5V0BLrd92aE9iUZtvi5sxQWb4vjfeczz9+Y9aRMwxVHbzrqTPs2podnb5nyVqyc/zyh5MKWjBOdTUlNq9MbC25M9LREyQ7gIcR7O8HnKMLzOGfoc1PTjxKKoNGqY7oYbqlJ6VFpmT2FSjHWYgjkKCBPu5leHvZrvY9kUMZfiEFDpIxJchmh1pnxreUQ83QBxCQslWYyCnKZKIbmyN7lNhQTllxGv77pH+G3umkH7YkIqjBSR65ZhegDIartqLxRXmYc0dliGXs/v/M8jUf0U9RauOYbOHABaAohaM6tnfUSdaItPxKBwGjPZs4et1Ci/852vjsFitqJvZ50EX8ziuRLIbbuqbMg3Uu07KhuRKkDtSxNaGTFOCy2aVw6JUTPBab0EVGiiO3y77f9nFfDT7g/dIn3YtcRdml4uS1Kv8tvTRSd2owBgQVMHRw+7kuzMAd6l3OQdyjkyL9QdwsSS4Aw35WLgrkVqTTxjmBoD9CMPhh3SbCILxopo24c4Cq1hk/4OmRf4xf6Vfqy7H7DnaJ9okg1pviHBDN4e0ctS47+0pbMgSbPA1y04InIM0oXJbEQh7RFqmExVCmjomhltNKF83u7AcE/NAPwtm0IwBCIIOwbMZ16i7SRz1ok1YqZ3SyO3HbYLgkNXyBVX0FnzXhq11y3YLSaTk6CIHlff8daIkdxBilW0w0VX1H8= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(122000001)(26005)(2906002)(38070700005)(316002)(110136005)(6636002)(86362001)(921005)(9686003)(55016003)(5660300002)(71200400001)(186003)(82960400001)(52536014)(76116006)(33656002)(38100700002)(8936002)(66946007)(7696005)(83380400001)(508600001)(53546011)(66446008)(66476007)(64756008)(66556008)(8676002)(6506007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?4kLVX0CCAEfPmVRZwIPRBXMAni83YabkATaoO2Gm1nNzz9YumxkjmvYFCtav?= =?us-ascii?Q?qNsWNupdr2nWU8Rf5qZ6GRbHhlf71hsdgr0HF3K3AEAc8H0/4k2bp+5B68kD?= =?us-ascii?Q?D+NwowGxwBd7XlMQYI3chgClEHCGmLlmsm0W2xaXL9Hx2Plhxmk54cIcjKTs?= =?us-ascii?Q?AKV/RA98FEO6B8HsA9MkJoGx79VMAwhuBMn7Lnyfs5/ZiQbqRfNjyw+9fJRr?= =?us-ascii?Q?5k0eqF7q0CIkO2ATOJWeqrXMevMoWxMryuYlaZge4QmYCI2wBV62aBCHbznY?= =?us-ascii?Q?nbEnnSCtNeYtdUjlFoUNIkS5T3ybzCMryAatGdmSdfXky96tLm6HasVW20LR?= =?us-ascii?Q?pipKKb/UNOqJhbwkJZ+MN9oYsXN4TA4go0UPH9kvdmU1zZFT3INe4XJXGmxs?= =?us-ascii?Q?6kIuv8dKrGWE09w2evGfwpDOdumauJVy2BLQawwzh1VTTkbLiStHWdOu/2HD?= =?us-ascii?Q?grlmPaevJUySTGMBBpdtD+XaG6CnOOmcR1+TTDKbU3XUfAEUFE8nhGoK3QJw?= =?us-ascii?Q?JaOBBjPAiREXx0oswj3wLHmY3onsKte+Ds9vIroJArKyeJjyl0ZUrM3yX0FW?= =?us-ascii?Q?A66YghG+gOirxMdz+xZrP7is7wy4vpLLU4iidtF3dfxBNe4ecBK0mVtX5QtW?= =?us-ascii?Q?aslHcyhLFuIf6tlnOhWmzzPOQLzFqKcjFYvwrxzb7JtGDF1g/JTnc6icDvaj?= =?us-ascii?Q?TAwveKYajzmct8i0dRXmm9NemffB4+K9uZN3F2ChH6Mym2PG3wkG4ex2m2h4?= =?us-ascii?Q?9jLw2W4K3jeddQ/uAOZQ0S2d0kMtCYRLLsp3n6a4DvI3mNqXh+T+mdwJE3IU?= =?us-ascii?Q?CyZFNelEYQOZ3vjEccvXiU7z2Fr2Zb7ysfaSr2ckzL+lzmVyNZ3dHwB3egQv?= =?us-ascii?Q?VI5ubxxRrgyKMiJ6GzNJd+e9j/UcVyuvYg3rPcn2wJXQEIPr9G354EaIMZgc?= =?us-ascii?Q?3DvKqiyCIDYngUcLq4NtYThmYH/XBZa0gX99OiwI1/hikY1iI789ZQwqu1QR?= =?us-ascii?Q?Oe3WPbrMGEG6bSNmhHZ3BpRrWAlumFflpZALLj+a41hXnPvgYBFZgb+n7PF6?= =?us-ascii?Q?6ny1hi1naTaJ1rD4cdI7RHBdLbfBsiLnnrbwgBtrhU7Vmp5+htiTui93jyOK?= =?us-ascii?Q?U+D1VRs+k9iasWHHUw1nYcaQMOU7oCTW9ovfYqZFy9oHQgDCWC3HrxozpFJq?= =?us-ascii?Q?E9Pq00MvXhMSzUWINJriWUzfeSHviWHzEmX6eQ8k3L06GkcLehSHpTR69FMN?= =?us-ascii?Q?eOFGQ8ibBqmPdQ0lpBnTDIZSzwcZU5/vYO2f1A9zsLX/iwM0L+rYVE1UEFyx?= =?us-ascii?Q?qYkkXUbU3algvkHeMP8tEzI7/DNFO6FEFmYWMocSqzKJ81oIbW8MlW9iZHUZ?= =?us-ascii?Q?Q+VpMmnt6Vp3MR7pV0qA8AHMthq18RoWFRNdbQhFdJDoWubKesH2JSzOFzjH?= =?us-ascii?Q?YnR4nF2koFQYWq4pzPe8DDl4r6FTlxcHUUbg0TOVX1mYH02wfVrgl40gTPP7?= =?us-ascii?Q?CU6TJa1uuWJ/mBnrDr8fR/QzMYd2m9KM8Y9OGwvbBBam8+qHl6I3kq4QzXqE?= =?us-ascii?Q?oMrfWfSNFLYiNeInXyabDQ6XYPf6k2ge45vTdjZDPYWrXtYvw8UQZfY5oFbv?= =?us-ascii?Q?NjjoO0PnPSR5rVqATGrVTqOMvWHlaljTs3z0D76pa+qcXavjjhwldcvFYpve?= =?us-ascii?Q?dfKXQ/ldxJyicEDfIuNSsUjZk3fcMwJVnebLUXnZ0Pmx9mAaMAqU7p8Sd723?= =?us-ascii?Q?eEAC5cm8Zw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6986e589-93ff-4b3b-bf4a-08da4a944226 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jun 2022 03:49:45.1484 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ViWEZYTnqQUBg+AUqyL9t7fVSXCR+VsC6s1K6jxER4LMgLhU3n4UABPreklaRe9tan85ndR1gl65NzSousjT/w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB2016 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org +Cheng for review > -----Original Message----- > From: Maxime Coquelin > Sent: Wednesday, June 8, 2022 8:50 PM > To: dev@dpdk.org; jasowang@redhat.com; Xia, Chenbo = ; > david.marchand@redhat.com; Matz, Olivier ; Ma, > WenwuX ; Zhang, Yuying ; > Singh, Aman Deep > Cc: Maxime Coquelin > Subject: [PATCH v2 6/6] net/vhost: perform SW checksum in Tx path >=20 > Virtio specification supports guest checksum offloading > for L4, which is enabled with VIRTIO_NET_F_GUEST_CSUM > feature negotiation. However, the Vhost PMD does not > advertise Tx checksum offload capabilities. >=20 > Advertising these offload capabilities at the ethdev level > is not enough, because we could still end-up with the > application enabling these offloads while the guest not > negotiating it. >=20 > This patch advertises the Tx checksum offload capabilities, > and introduces a compatibility layer to cover the case > VIRTIO_NET_F_GUEST_CSUM has not been negotiated but the > application does configure the Tx checksum offloads. This > function performs the L4 Tx checksum in SW for UDP and TCP. > Compared to Rx SW checksum, the Tx SW checksum function > needs to compute the pseudo-header checksum, as we cannot > know whether it was done before. >=20 > This patch does not advertise SCTP checksum offloading > capability for now, but it could be handled later if the > need arises. >=20 > Reported-by: Jason Wang > Signed-off-by: Maxime Coquelin > --- > drivers/net/vhost/rte_eth_vhost.c | 62 +++++++++++++++++++++++++++++++ > 1 file changed, 62 insertions(+) >=20 > diff --git a/drivers/net/vhost/rte_eth_vhost.c > b/drivers/net/vhost/rte_eth_vhost.c > index 42f0d52ebc..d75d256040 100644 > --- a/drivers/net/vhost/rte_eth_vhost.c > +++ b/drivers/net/vhost/rte_eth_vhost.c > @@ -92,6 +92,7 @@ struct pmd_internal { > rte_atomic32_t started; > bool vlan_strip; > bool rx_sw_csum; > + bool tx_sw_csum; > }; >=20 > struct internal_list { > @@ -283,8 +284,10 @@ vhost_dev_csum_configure(struct rte_eth_dev *eth_dev= ) > { > struct pmd_internal *internal =3D eth_dev->data->dev_private; > const struct rte_eth_rxmode *rxmode =3D ð_dev->data- > >dev_conf.rxmode; > + const struct rte_eth_txmode *txmode =3D ð_dev->data- > >dev_conf.txmode; >=20 > internal->rx_sw_csum =3D false; > + internal->tx_sw_csum =3D false; >=20 > /* SW checksum is not compatible with legacy mode */ > if (!(internal->flags & RTE_VHOST_USER_NET_COMPLIANT_OL_FLAGS)) > @@ -297,6 +300,56 @@ vhost_dev_csum_configure(struct rte_eth_dev *eth_dev= ) > internal->rx_sw_csum =3D true; > } > } > + > + if (!(internal->features & (1ULL << VIRTIO_NET_F_GUEST_CSUM))) { > + if (txmode->offloads & > + (RTE_ETH_TX_OFFLOAD_UDP_CKSUM | > RTE_ETH_TX_OFFLOAD_TCP_CKSUM)) { > + VHOST_LOG(NOTICE, "Tx csum will be done in SW, may > impact performance."); > + internal->tx_sw_csum =3D true; > + } > + } > +} > + > +static void > +vhost_dev_tx_sw_csum(struct rte_mbuf *mbuf) > +{ > + uint32_t hdr_len; > + uint16_t csum =3D 0, csum_offset; > + > + switch (mbuf->ol_flags & RTE_MBUF_F_TX_L4_MASK) { > + case RTE_MBUF_F_TX_L4_NO_CKSUM: > + return; > + case RTE_MBUF_F_TX_TCP_CKSUM: > + csum_offset =3D offsetof(struct rte_tcp_hdr, cksum); > + break; > + case RTE_MBUF_F_TX_UDP_CKSUM: > + csum_offset =3D offsetof(struct rte_udp_hdr, dgram_cksum); > + break; > + default: > + /* Unsupported packet type. */ > + return; > + } > + > + hdr_len =3D mbuf->l2_len + mbuf->l3_len; > + csum_offset +=3D hdr_len; > + > + /* Prepare the pseudo-header checksum */ > + if (rte_net_intel_cksum_prepare(mbuf) < 0) > + return; > + > + if (rte_raw_cksum_mbuf(mbuf, hdr_len, rte_pktmbuf_pkt_len(mbuf) - > hdr_len, &csum) < 0) > + return; > + > + csum =3D ~csum; > + /* See RFC768 */ > + if (unlikely((mbuf->packet_type & RTE_PTYPE_L4_UDP) && csum =3D=3D 0)) > + csum =3D 0xffff; > + > + if (rte_pktmbuf_data_len(mbuf) >=3D csum_offset + 1) > + *rte_pktmbuf_mtod_offset(mbuf, uint16_t *, csum_offset) =3D csum; > + > + mbuf->ol_flags &=3D ~RTE_MBUF_F_TX_L4_MASK; > + mbuf->ol_flags |=3D RTE_MBUF_F_TX_L4_NO_CKSUM; > } >=20 > static void > @@ -423,6 +476,10 @@ eth_vhost_tx(void *q, struct rte_mbuf **bufs, > uint16_t nb_bufs) > } > } >=20 > + if (r->internal->tx_sw_csum) > + vhost_dev_tx_sw_csum(m); > + > + > bufs[nb_send] =3D m; > ++nb_send; > } > @@ -1267,6 +1324,11 @@ eth_dev_info(struct rte_eth_dev *dev, >=20 > dev_info->tx_offload_capa =3D RTE_ETH_TX_OFFLOAD_MULTI_SEGS | > RTE_ETH_TX_OFFLOAD_VLAN_INSERT; > + if (internal->flags & RTE_VHOST_USER_NET_COMPLIANT_OL_FLAGS) { > + dev_info->tx_offload_capa |=3D RTE_ETH_TX_OFFLOAD_UDP_CKSUM | > + RTE_ETH_TX_OFFLOAD_TCP_CKSUM; > + } > + > dev_info->rx_offload_capa =3D RTE_ETH_RX_OFFLOAD_VLAN_STRIP; > if (internal->flags & RTE_VHOST_USER_NET_COMPLIANT_OL_FLAGS) { > dev_info->rx_offload_capa |=3D RTE_ETH_RX_OFFLOAD_UDP_CKSUM | > -- > 2.35.3