From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8697F424BD; Mon, 30 Jan 2023 08:52:19 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 74D7C40EF0; Mon, 30 Jan 2023 08:52:19 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 5DD6F40EF1 for ; Mon, 30 Jan 2023 08:52:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675065137; x=1706601137; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=RtYenMbzOd/9DxfdNvoINGNeXzie5KCzh8+s/qEruqo=; b=YwG6PMu5lkx4NeN5WIkc2BEAG6ghZkiOPdfzCKs5JfEZGSEOKurloB+1 iVjIHEyPgJB04UQFyd20YNp2JNOUUkSOoizcNFlMrOJKhumBhfNgpu3+x P7aehqZsLng+FFZA4TbloYK8feKARSqNNWL98lbTWrPCxVAfB7BqSoyPY gU6KuajG/YCDQsZKXryCBfNUbTIORFQnscpbZv+lgeXZi5mFhS7lV0ce5 +7GA4SVBDznoVz70Ep9Sea6zxYyPqpmVDS42J0F/TexZoXvQMs/rgYRwE ku3/tN7MAgWi6Y1mQm4QugK6pVCJV7cWzUAS68ZPrsOpE9QbHftWr73f8 g==; X-IronPort-AV: E=McAfee;i="6500,9779,10605"; a="325195887" X-IronPort-AV: E=Sophos;i="5.97,257,1669104000"; d="scan'208";a="325195887" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jan 2023 23:52:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10605"; a="696315510" X-IronPort-AV: E=Sophos;i="5.97,257,1669104000"; d="scan'208";a="696315510" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga001.jf.intel.com with ESMTP; 29 Jan 2023 23:52:15 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Sun, 29 Jan 2023 23:52:14 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Sun, 29 Jan 2023 23:52:14 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.44) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Sun, 29 Jan 2023 23:52:14 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NJ7tCnP8jeH3LRtBs5z8rV4dB88uYTpibj7+ZsLsLl37hBK7N/jK4ZtUa6JtqwuXRE//Km77g2xg11QFXVcYGTNuWTLWOuW7QZcVrqMnV5UYvytoe6hVGPQPNaVb7fPr2v6uqhjleR17lUqcTeO694Qdq8OA8TpiItCfjlWlPSD+0Qbhb3BsMNDKJHVB6A7T8d5TINZQTWo3d83DR0SwxHHSFU3NkQBoO8IG1wsFsjsZSEHzeIaUiim/Cam5YBE465rgd8m4HM3Vfzp/seszWZQf0N7+G6Lh5fRVY6//H1sYwLtfNh/J/2LPdJiBMn5SA41cUyLA3BWe4AhqDLbYpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bNKBhpSUVpBnA3/MZ8NSuRv3I5KWLBNLcVFKf+j2GzM=; b=HbLib43pBmHcWtDJcwYH/+SpEoyfAO76MXMtAJvgf4Ws067DX8LK3NwPKUaYGp9N5FqUvIMrOESynftK+RVJBAHyzFjtE3+qSRYxkOtob17oe+6ciZOmFD/dtKWeqqZL/rMjG1DSI9T87xBqUmGy1gyBytCty/oZ7KLpvWzEoY3xdGtwOP+C9ZvAxnawwnyX8vp0fLlB5qIv+JtFj8qb8LOt+d4TtE/K0oHHE776mmYHgVnAZSIBBfZH79ViyyhVcWDrHbR7MA7Lp7v+FmJvH2hDKMjX92UU4Slf3Ocux9117cV+GXelGuSmVtT+VACrkTZ6keQe0vG4g5ZQCHDUVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by SJ0PR11MB4990.namprd11.prod.outlook.com (2603:10b6:a03:2d8::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.36; Mon, 30 Jan 2023 07:52:12 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::c8f8:a3e1:5b23:a9c3]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::c8f8:a3e1:5b23:a9c3%5]) with mapi id 15.20.6043.033; Mon, 30 Jan 2023 07:52:12 +0000 From: "Xia, Chenbo" To: "Coquelin, Maxime" , "dev@dpdk.org" , "david.marchand@redhat.com" , "eperezma@redhat.com" Subject: RE: [PATCH v1 06/21] net/virtio: remove unused queue ID field in Rx queue Thread-Topic: [PATCH v1 06/21] net/virtio: remove unused queue ID field in Rx queue Thread-Index: AQHZBNRmFjQdQHe/W0aI+ZoiDWXp1q629dPw Date: Mon, 30 Jan 2023 07:52:12 +0000 Message-ID: References: <20221130155639.150553-1-maxime.coquelin@redhat.com> <20221130155639.150553-7-maxime.coquelin@redhat.com> In-Reply-To: <20221130155639.150553-7-maxime.coquelin@redhat.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB3504:EE_|SJ0PR11MB4990:EE_ x-ms-office365-filtering-correlation-id: 10939b17-558f-49ff-cccb-08db0296e578 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: T4UppnjgznIzYjhnyfRIaUnhEnX3AtwoirceKM0NxqHbwnyE6kX8FwpY3kojcpmpRSz+R5xyx4FS5Z4CVYreg/UbzKpp+Td2f2aKHnf5eUtOvhoFVGxuigQ1MkPCj4Sls65QvamsA7SiyNMrKgqgmzRmdO7/wr78jK55e3PQ6rTBLSSAL3i5GdYK726RXIvgnpC4E72UcPBN04ya3XXeNw0nmxLthR+MMzrYvxglFSYNL7CE4V/8qmHFfDCA8vgmOjZnI5IUeflXJ09dFnkErusr28ALWIgWSCyIbRA/ZQyqe2vlIfGZ3pyImI6+6wuBW71NE5UbeDnMntwiX5gYyBkKkXe4aIzz6ZPZUhbge/hwCF/XJCbBImW+oos7c2dhxI62gdxYbdg9kE+cI2zT54EaG7PWWfvevnOMIBGjhrjGu+jo1v9SOI6/5fzcIfB6rLD35WsEVbCCVz+IYXeWUUOmoUOlon/Muqs23Q5zZugmlDNENSDnmnWGrWGtcaeGEXhjpcu9DMfLMyC+keDxc4Wk+RwzzNdvluKGL+YKUzJOdmd8rat8ACNFTX98VsUBclIgHvAIYSmkQsU5BTMXpiWsza/EW6KfoIxXwXxAf84b0cSs668wikAO5Cjwmlx2SBX2zBh2plyJhJEHBxbrjWuk1f/fyhjCjRNBSIHIZmbhjytaMgrRHmpoGQGdAzGFvCltc3Hd9Ruivhaso4mZNg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(136003)(39860400002)(376002)(366004)(396003)(346002)(451199018)(110136005)(316002)(66946007)(66476007)(8676002)(66556008)(66446008)(76116006)(64756008)(8936002)(52536014)(5660300002)(122000001)(38100700002)(86362001)(38070700005)(33656002)(82960400001)(41300700001)(53546011)(71200400001)(9686003)(26005)(6506007)(186003)(55016003)(2906002)(478600001)(7696005)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xsurbAzftoRgBSIxt/3A+S1bBrlsmNPg7zyFlKesad6NOqm1f8kNJXml9Mpa?= =?us-ascii?Q?CialSIxVS4nGoBAlWszW2Tw3JcAueAEmD5f4v6+zni468WyyqHb7Do7rN+uy?= =?us-ascii?Q?f13UMCeUWM5+VZOCVnYSJBWkhRAv/DwYMZHYXXkuzpP7PMHGBt98dUsg/U02?= =?us-ascii?Q?CaoenF+ZIJHgh1dc+pS47wKjbVyG7PX9k80irk+t/kWc79VB2oxDew00USL2?= =?us-ascii?Q?zNDkpnO+pNB/yXQKwyXZz4DJO99NzoCxyDgSguAroshm5MQOzzvpWlH/TjXg?= =?us-ascii?Q?YNw6Cn1kLfgjvLImjb+FCBm+ms8GC5g1EiD0DQXHdf5kg0YnZt4UA8HG71QO?= =?us-ascii?Q?tVDDhKtVFrd9OnLB4QU8FvS3MMNgHGZHqqNTguXKrY+ZRgQsh01Kslz68L7h?= =?us-ascii?Q?sziDiei42k28uNY1uRXPbwm97MvOkOiYKXnaZi48cIhXq+lhoz3WtWkLUXoJ?= =?us-ascii?Q?JjGRZ9EaBBeP2MDBajB1S/U/lJnMBOiy7MiSYuHIJB0QZ7nPRYVQ4KAG2Zgw?= =?us-ascii?Q?kClMZQsARBHgEXALBCpkXfk3aNpk/MUsYoUgduhzSRIbg7znfdAtt62/KD11?= =?us-ascii?Q?u8EGZp9hfS4ZJDnaE8Qd8QMub4/qrjPqrfdlA3eKyWjtITM4iWFJWjyPF6ca?= =?us-ascii?Q?kDgLjL4/swQ7iN7FFVBzUT3BF+tyN8ZyWXZ/FEL3y9zL6BDE3fkimYQIAlME?= =?us-ascii?Q?Ro07VUZJHhLkJ8HdG9dv2YI9GGuc+HLEJ+6uTy/igNqVuAgCgYnLq6y00CRG?= =?us-ascii?Q?4P9zz3QCSz3V0EYTJgBsZwuCu+nWjWS7fr2Pzu2uQ5fZTMht6ejt9OW1NIUq?= =?us-ascii?Q?0BJuekeOap5Tgfl2aqv8D8gvQRGWEbhBywsB0/IgnkCKICKiFd7U8SjwcbWx?= =?us-ascii?Q?pzGXkdtRMHy1gGg1FFZL+WhH4n8IrUYdnnPzGNU9XfoRmHhVh6UFAct3/V3c?= =?us-ascii?Q?Ow8ZaQsEWbjkPhQlY6vNQ+j1KFmH40jxp+Y9AmYKnbLaoevTni1ZQrloGsdE?= =?us-ascii?Q?4CKtcHiWpZzlF/RcDm7sudqY4G+7NmAbE6rj2KIl+N5aw6g0U/iHIFTJBQf0?= =?us-ascii?Q?YB6BTVMkFJANhQ9YG+VtNkvKft9UDfpC5zkNWKShaPMUAj/3+DaJxFSr+Qe0?= =?us-ascii?Q?9yljuNw3wQz0aRKv+N3R0b1UHiGWvQUaRjzwRzyCOnyEcQo7pPaIfJox/20I?= =?us-ascii?Q?+rYCqDawMUGxkC56usr89FOR3FBPautGUSX9pSvW6gv9SWuhRj+2YbM52RwV?= =?us-ascii?Q?0dhZ5hOwCG9MDcxqj/23T1Joyj+SXJbg1m5cqQn3cr+58iT0GqNUn/lbENuU?= =?us-ascii?Q?H09RbLRB/f3OC9F2MDpx4aDTK1EoZjNqJgzG8zXRxR8MSk57bToaoFM58Ovn?= =?us-ascii?Q?eQj+YPBwQF4X9LQTj6Kwdk4aMvWb09gc4BjSoA4zTN327uIqVUeKy48HL7jC?= =?us-ascii?Q?UFRBPkw2LFNjspTtV6ndHJ/ecx+QQsXYtzgWCDsgc3yaWpq0AFDKRJdhOqdk?= =?us-ascii?Q?/qfj0SN9+0ro4LKU1JzNtCTaZiQQhmMEaaevFng2HoJKTHTGzPefOpcDWqBw?= =?us-ascii?Q?tpzAbGnewc9qS3NZqdugA0g/ewaeyxs+iGtMUQwE?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 10939b17-558f-49ff-cccb-08db0296e578 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jan 2023 07:52:12.0681 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: d5SZWNi01OPRePP6thPRZ4QlUuHY1bepDhQIANeXEcxSWUEeEpxwaV6K4FdAvIj15SViDcB9GQlBu6whC7YhAA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4990 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Maxime Coquelin > Sent: Wednesday, November 30, 2022 11:56 PM > To: dev@dpdk.org; Xia, Chenbo ; > david.marchand@redhat.com; eperezma@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH v1 06/21] net/virtio: remove unused queue ID field in Rx > queue >=20 > This patch removes the queue ID field in virtnet_rx struct. >=20 > Signed-off-by: Maxime Coquelin > --- > drivers/net/virtio/virtio_rxtx.c | 1 - > drivers/net/virtio/virtio_rxtx.h | 2 -- > 2 files changed, 3 deletions(-) >=20 > diff --git a/drivers/net/virtio/virtio_rxtx.c > b/drivers/net/virtio/virtio_rxtx.c > index 304403d46c..4f69b97f41 100644 > --- a/drivers/net/virtio/virtio_rxtx.c > +++ b/drivers/net/virtio/virtio_rxtx.c > @@ -703,7 +703,6 @@ virtio_dev_rx_queue_setup(struct rte_eth_dev *dev, > vq->vq_free_cnt =3D RTE_MIN(vq->vq_free_cnt, nb_desc); >=20 > rxvq =3D &vq->rxq; > - rxvq->queue_id =3D queue_idx; > rxvq->mpool =3D mp; > dev->data->rx_queues[queue_idx] =3D rxvq; >=20 > diff --git a/drivers/net/virtio/virtio_rxtx.h > b/drivers/net/virtio/virtio_rxtx.h > index 9bbcf32f66..a5fe3ea95c 100644 > --- a/drivers/net/virtio/virtio_rxtx.h > +++ b/drivers/net/virtio/virtio_rxtx.h > @@ -23,8 +23,6 @@ struct virtnet_rx { > uint64_t mbuf_initializer; /**< value to init mbufs. */ > struct rte_mempool *mpool; /**< mempool for mbuf allocation */ >=20 > - uint16_t queue_id; /**< DPDK queue index. */ > - > /* Statistics */ > struct virtnet_stats stats; >=20 > -- > 2.38.1 Reviewed-by: Chenbo Xia