From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 23133A0540; Tue, 8 Nov 2022 08:56:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 13755410EA; Tue, 8 Nov 2022 08:56:24 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 36A384003C; Tue, 8 Nov 2022 08:56:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667894182; x=1699430182; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=1B8ojkjKknFMiIGspFvn/0caOu/CpEWBO/PUqilmudc=; b=LZ32NgPgrNgvcVnLsHaz4rSvs6mpqvFZl1pwP4p0hu79SS7e/KvG6h0E YkxKDaDFitN5+rS5PiShswpKTV3LXtEsilUELb0VawI63V4FPNnSSqxF8 W2co13qobRQlMstgQAhOm9c9qTFV+qa2WJ6ThUTJaNIEX/ajV0C+1K5iD quVE54EdEiBpScG7DW2SiiL9GXommKOBD43zIvc804CzszFN4K9+j0drG ukhAYo3OHbR28//0UpuufZ0kW+gZv2GK0d6yhHIpE9izli3dyv5Eo/qp9 aGgR2AYrLl6aqdlk24y5Nw/ElcxS65mj+Ul2juW7r+WAWxJGYoCh2etwn w==; X-IronPort-AV: E=McAfee;i="6500,9779,10524"; a="290353134" X-IronPort-AV: E=Sophos;i="5.96,147,1665471600"; d="scan'208";a="290353134" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Nov 2022 23:56:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10524"; a="669463641" X-IronPort-AV: E=Sophos;i="5.96,147,1665471600"; d="scan'208";a="669463641" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga001.jf.intel.com with ESMTP; 07 Nov 2022 23:56:20 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 7 Nov 2022 23:56:20 -0800 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 7 Nov 2022 23:56:20 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Mon, 7 Nov 2022 23:56:20 -0800 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.40) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Mon, 7 Nov 2022 23:56:20 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FnxRniqjLUGk8jNaTs0nGL/gO2tXKHK9418nIOlvhM82ZxPWosNWVMZMojuF3q3cDg785BZX4Z2OxmaWfLb8exRYwyPbQbeWQ62UYZNUnyE9TPcFfjA5Hpq7G5/X4Fvj4q6DV1RBtTJt8TSMuFCJWFseieDziwF1b8R/MWqL3akWm+WoJZCRRkgYC6k/hQDjIZil3KzLmZH1Z5chdBU83FOvXIXliyclIMnrcha1JS/zAeC21GMSGkUOtpO+CgNrXY6AxCcFKyjCeU4+NlMf815wYEQCrQt2InfaykfhOjbdIeAQtFwrbqcSbR5SnemRMzHWp6WD4fSd2CMbtpFKqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=q3J/ZMGd4ApNwy/xgbMgxUIFoQ+fkus+/XKqPB7cuFU=; b=jKK3h6L4Yeu6NMDdiRyQHklgnZK7dSH9NxGWQqM9d1yfTMyHaIE/EnxDn5ZWxIeqQelS7ON8TlXTjKTktwU/X9dIftSfYN+vWu4vuA35oMsWHOSo16Lc6rs1cXiv79EqsuUfLOxvQjEIhi7CG1+v9fN5dzmxhGVk4O3JxU7VKxN/5D+x3yg2rtp8GlB/TdE2VIav6jzFU88RYAe0XyGkUg7xtUvmZyztRi/JG4hKRSaTXq8GTEbOq6exwCwz7f38hDWzj2inWMHokJtSXjeIOpBHHfQwuj6UADs6eEdArS8dK3ojj1v1gfW0Sh4IV8OwLsWU0AXKqHU1l/zJKHtlWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by DS0PR11MB6448.namprd11.prod.outlook.com (2603:10b6:8:c3::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27; Tue, 8 Nov 2022 07:56:18 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::3c6a:7a7c:129d:aecb]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::3c6a:7a7c:129d:aecb%4]) with mapi id 15.20.5791.026; Tue, 8 Nov 2022 07:56:18 +0000 From: "Xia, Chenbo" To: "Pei, Andy" , Taekyung Kim , "dev@dpdk.org" CC: "stable@dpdk.org" , "maxime.coquelin@redhat.com" , "Wang, Xiao W" Subject: RE: [PATCH v3] vdpa/ifc: fix update_datapath error handling Thread-Topic: [PATCH v3] vdpa/ifc: fix update_datapath error handling Thread-Index: AQHY8odmMbp1E9gIAk2goLguQTrE0640Qp2AgABiFdCAAAUAYA== Date: Tue, 8 Nov 2022 07:56:18 +0000 Message-ID: References: <20221107053411.98653-1-kim.tae.kyung@navercorp.com> <20221107085943.116357-1-kim.tae.kyung@navercorp.com> In-Reply-To: Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB3504:EE_|DS0PR11MB6448:EE_ x-ms-office365-filtering-correlation-id: 3e166938-2b0f-4223-8cca-08dac15eb7d8 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: t8FMijZL7BcWiJOP8Cbgr8TG/xNezMmPmeFf8EbQkuNzC6eubpwIwqomct2ZKoqZjj0PAzaOLeFwu3qPzyiotLaOdFPebW1F7ao3803UYgzZOT3eTQcDadbogxh0wVheHT0hqS25BJ8Ae3PKOA2UPbaLCtsnMsvOwjUiaN9refC6T/ijAi0ycabIL0QeaLA9p+txPa174Kv266LFv8X852aeT1IgBkXVsWCVOuS+NQh5G43q74GOhStvTirPP9crZR3yR9hxqgSftGPdoHUlAXdqr/EBNGit0hWocPVDBKk04IaFQ88ZW8fS3Bgf/anIvw298AefGuMr7Inr7hfZ9hF49WxPfp5S5tNz3ySqreYbQwPE0duNtO6dUXS7ZV5PeGp748PIJZJw3GPxpCPRd9XM7uUPyzev1F8SQrly0Cdyk1JwFJv57j6RPIb+83KJaYSFYah2yCgymvH+fqnyQgOOQdTuMKzIp8d8tXUqvI+odMUe1XvJe5l5OEbF4usZ71EN5hQfMEJte5aFh3gz0CYwz/GGCSaZOAPaXCbeQZhSQpAB6abxwOuRrlizrZwUVIRB2/MkQklc/y+jAWglgDLfQL2O0KPOo4xV53jSELSPDBhqNgieFBg4eQFFy10LUBOVmBJh2nfaRC2GmAsNyD136UfYRecEpDNaedUvOmHWKbRL0cAbhQj54XNK4XTMB19GUNRQKMH6FbzkWMjk4sq/kv6rNS2DbtK/nOza8xBjhKSrvzvazta26jO6gjoC6T6qVgbRvjlO6Z73gqC1FA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(346002)(39860400002)(366004)(376002)(136003)(396003)(451199015)(83380400001)(86362001)(33656002)(82960400001)(38100700002)(38070700005)(122000001)(64756008)(66446008)(66556008)(41300700001)(8936002)(66476007)(316002)(4326008)(66946007)(76116006)(8676002)(52536014)(2906002)(55016003)(5660300002)(15650500001)(6506007)(53546011)(9686003)(26005)(107886003)(7696005)(186003)(71200400001)(54906003)(110136005)(478600001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5UilJ+6ITbsXKsOEyl7vAwncgjJeL3IRNxwX74xIKdH9rW2TVEPYe8EeX77d?= =?us-ascii?Q?+0k23gq7sTdnGpMSM9ipH18kx/vMPVMz6b6OcTPkl/vQrdhPGZBhHDNifEnR?= =?us-ascii?Q?6kTeyEozOHweNwN+xHmwJ1teqVed6LRz3YOYxA7gKKXzvjwF5aGTdbn8DkDo?= =?us-ascii?Q?ooBCrTtzT/o/AE1gbea6SckT/1oJtptGUWcOS8ZQdlxurcvTvALQSsVwhuLY?= =?us-ascii?Q?lWm3HF3px28sv8xvD1hn93qfN283A7kcwCNcSzh9nJ3CgkoHs0NR0kxiAF6D?= =?us-ascii?Q?zqHZYQ86fM1K50QLch5KpejVdUka7YyB1OPUidNnTlnWLXJmHGx8jrReX6Lw?= =?us-ascii?Q?T9HBgJHLN3zDgDd3DAqhZmrCmqTgi/C8spWX4fgBsUM7zcmfUmCaAo6PcE3S?= =?us-ascii?Q?fLDXFAESjGx6tov09afP9Eb1rIoOUFaOrLcY/TlOJBsWW3sBoddmhX2lWzex?= =?us-ascii?Q?rg2VgqsLu/G2V/UF9prlJfMwC1rb2/K1nEtjGDRH1+e1ejFJ4Bb+7++UapRl?= =?us-ascii?Q?O6Re7Ac6oXDepNzgIYq7hMOL2T9m9E5rAtHBzPYsDDaxYYFD9cU9AQiYTqLt?= =?us-ascii?Q?m4BBMgCNcR/evPX2YoP8Pvj8g43bCoex9M9O8YjK76XerGx7+tEP2mVpH2aC?= =?us-ascii?Q?Nctw/rsjuEFia48L/uKYzg2AgWMqoTyQkjljgSt4ZHODmWr3EjbpLpLFS0bN?= =?us-ascii?Q?kEAxEqobsQV731uMOyqJ9AML8l2J1I+LQBWsHDOlTFLGky8vC1AHaxAWT3Y2?= =?us-ascii?Q?piL5ZXxlbEKW5DP8IMwv9yXFQfwtyzdiPvW6/rYaRhXlte2BL/4grCRgHn8h?= =?us-ascii?Q?szW+eh5KweWOiKEEXC2EcMpqOaEGpXGJFquF5EjKPR4ewvTnuYIIVIUrKQE0?= =?us-ascii?Q?d9SJ0+3BYGCWA+rEGoPSeFiy8xZdVvcTD0ALXzjkg3Djd718ZrggMOz3aT0G?= =?us-ascii?Q?j+2e+qbiJBhkOq4unFaEO9knQ0Y7WmMj+oYkDjLCaTsdHchQyh78vUymjZTr?= =?us-ascii?Q?eDh7PKb+zuMG16RWtURzpGHSJiaAcI88TXMQrpndP2CGd3KzsKAQGtpZyLLr?= =?us-ascii?Q?tT+Geu2yN6YUUpgtO50aKexHA8Saltxd6E28Osapq3b6SrTy0frQyuVs/b2S?= =?us-ascii?Q?M3ERagA3LtjJtskKVKncJnwPi13LdJvFf8NDDOiVBdMxaLQI85tQI1kx2Bwo?= =?us-ascii?Q?Yl0s5oQrmFCHNZghwBi2NTyOdXa7JVLX/2JrOb+AcW6W+dIb9laWaClZNExg?= =?us-ascii?Q?If3Kjxf7SeLiOooJPS4/CY/oJU1XI1OxUPlXTzBzQZIQCP1tXrQlfyuO4DIe?= =?us-ascii?Q?qloOD+865Ps3XGYOusmZU9DEZG7Mp/jD7qpa2ZhJclV37njnj4O7AAleJZR1?= =?us-ascii?Q?lTOy6XZZHXKLyXvXvhy+/3MDhRcVQnBYzBp6nCKT1wjIz7RP0IZTKz06Ek7G?= =?us-ascii?Q?R/pXDsJVp1TLaGVVRyVOPucvdhQcQfP7h716usvUCe1QeUx697ysXG/D8MCj?= =?us-ascii?Q?oxhXek3AMXZnmAt8IkYYrLlyfF1eMhpOrAMzFWCyhZyhK6MMEE6mFZexqYVt?= =?us-ascii?Q?YsP2nac8Ns9rnWg67/y5EhGvr7YrA6CgyWRajoG7?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3e166938-2b0f-4223-8cca-08dac15eb7d8 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Nov 2022 07:56:18.1699 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: op67ap1nDdYAcAhPdzFaL3XwaO6iEHXhrIO4alJc4afLP4fOMl8Lx/E5+euYu60KULbIUqYtcte8yY+t9AMJfg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6448 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Pei, Andy > Sent: Tuesday, November 8, 2022 3:39 PM > To: Xia, Chenbo ; Taekyung Kim > ; dev@dpdk.org > Cc: stable@dpdk.org; maxime.coquelin@redhat.com; Wang, Xiao W > > Subject: RE: [PATCH v3] vdpa/ifc: fix update_datapath error handling >=20 > Hi >=20 > See my reply inline. >=20 > > -----Original Message----- > > From: Xia, Chenbo > > Sent: Tuesday, November 8, 2022 9:47 AM > > To: Taekyung Kim ; dev@dpdk.org > > Cc: stable@dpdk.org; maxime.coquelin@redhat.com; Wang, Xiao W > > > > Subject: RE: [PATCH v3] vdpa/ifc: fix update_datapath error handling > > > > > -----Original Message----- > > > From: Taekyung Kim > > > Sent: Monday, November 7, 2022 5:00 PM > > > To: dev@dpdk.org > > > Cc: stable@dpdk.org; maxime.coquelin@redhat.com; Xia, Chenbo > > > ; Wang, Xiao W ; > > > kim.tae.kyung@navercorp.com > > > Subject: [PATCH v3] vdpa/ifc: fix update_datapath error handling > > > > > > Stop and return the error code when update_datapath fails. > > > update_datapath prepares resources for the vdpa device. > > > The driver should not perform any further actions if update_datapath > > > returns an error. > > > > > > Fixes: a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Taekyung Kim > > > --- > > > v3: > > > * Fix coding style > > > > > > v2: > > > * Revert the prepared resources before returning an error > > > * Rebase to 22.11 rc2 > > > * Add fixes and cc for backport > > > > > > --- > > > drivers/vdpa/ifc/ifcvf_vdpa.c | 26 ++++++++++++++++++++++---- > > > 1 file changed, 22 insertions(+), 4 deletions(-) > > > > > > diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c > > > b/drivers/vdpa/ifc/ifcvf_vdpa.c index 8dfd49336e..0396d49122 100644 > > > --- a/drivers/vdpa/ifc/ifcvf_vdpa.c > > > +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c > > > @@ -1098,7 +1098,12 @@ ifcvf_dev_config(int vid) > > > internal =3D list->internal; > > > internal->vid =3D vid; > > > rte_atomic32_set(&internal->dev_attached, 1); > > > - update_datapath(internal); > > > + if (update_datapath(internal) < 0) { > > > + DRV_LOG(ERR, "failed to update datapath for vDPA device %s", > > > + vdev->device->name); > > > + rte_atomic32_set(&internal->dev_attached, 0); > > > + return -1; > > > + } > > > > > > hw =3D &internal->hw; > > > for (i =3D 0; i < hw->nr_vring; i++) { @@ -1146,7 +1151,12 @@ > > > ifcvf_dev_close(int vid) > > > internal->sw_fallback_running =3D false; > > > } else { > > > rte_atomic32_set(&internal->dev_attached, 0); > > > - update_datapath(internal); > > > + if (update_datapath(internal) < 0) { > > > + DRV_LOG(ERR, "failed to update datapath for vDPA > > > device %s", > > > + vdev->device->name); > > > + internal->configured =3D 0; > > > + return -1; > > > + } > > > } > > > > > > internal->configured =3D 0; > > > @@ -1752,7 +1762,14 @@ ifcvf_pci_probe(struct rte_pci_driver *pci_drv > > > __rte_unused, > > > } > > > > > > rte_atomic32_set(&internal->started, 1); > > > - update_datapath(internal); > > > + if (update_datapath(internal) < 0) { > > > + DRV_LOG(ERR, "failed to update datapath %s", pci_dev->name); > > > + rte_atomic32_set(&internal->started, 0); > > > + pthread_mutex_lock(&internal_list_lock); > > > + TAILQ_REMOVE(&internal_list, list, next); > > > + pthread_mutex_unlock(&internal_list_lock); > > > + goto error; > > > + } > > > >=20 > Is it necessary to unregister vdpa device? Good catch, yes it's needed. Kim, please add the unregistration. Thanks, Chenbo >=20 > > > rte_kvargs_free(kvlist); > > > return 0; > > > @@ -1781,7 +1798,8 @@ ifcvf_pci_remove(struct rte_pci_device *pci_dev= ) > > > > > > internal =3D list->internal; > > > rte_atomic32_set(&internal->started, 0); > > > - update_datapath(internal); > > > + if (update_datapath(internal) < 0) > > > + DRV_LOG(ERR, "failed to update datapath %s", pci_dev->name); > > > > > > rte_pci_unmap_device(internal->pdev); > > > rte_vfio_container_destroy(internal->vfio_container_fd); > > > -- > > > 2.34.1 > > > > Reviewed-by: Chenbo Xia