From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 34735A0542; Wed, 26 Oct 2022 11:10:02 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 54C3D40E28; Wed, 26 Oct 2022 11:10:01 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id D102140041 for ; Wed, 26 Oct 2022 11:09:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666775400; x=1698311400; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=EELOf2CarCygdljdSD1ROWdCtzh96VuX8BMtozkeNFY=; b=oJ1Yy3eZN37l2u/NlPYFMYJeXYlqtbYPonysjUwLMdbO8loxOVOpYoah 1QxANPKgAnfXfGSjNiikHJ6zONvtoauF0ByaTVGfFvE30n2/JqtRojM5l obqloHY8S0c5xq+PWuATbgETkFUzZul4neM0n7e9PUwgq+AMOBxmku7zS fO6OBh6XjPzAj0605wAOSx5OF/GHjAAxZ26zlWjVjDtB2Xl5FBAgcdd0f 5iVEa/AFbVJWaCgzXXTDYDOyVeScIAXMDRMJCJ41zeAThyX4eFjouNSAL 0HqtUdCQIWbkkeO6dRgXLC5n0u5yfoaKJpFDefrB+aiYwD/6a/B+5nF0b A==; X-IronPort-AV: E=McAfee;i="6500,9779,10511"; a="334515298" X-IronPort-AV: E=Sophos;i="5.95,214,1661842800"; d="scan'208";a="334515298" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2022 02:09:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10511"; a="806974164" X-IronPort-AV: E=Sophos;i="5.95,214,1661842800"; d="scan'208";a="806974164" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga005.jf.intel.com with ESMTP; 26 Oct 2022 02:09:58 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 26 Oct 2022 02:09:58 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 26 Oct 2022 02:09:58 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 26 Oct 2022 02:09:57 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XTzxa04bn5bBgP5PFMq5dsmjccCfXFMrL/GKE5Tz/IBFLcQ2BRcfP/Q3rX1TVliyzKrNXbZKOMqmZXpDhkrcvflQKcIXOuoVmWayiSFJmDHKUSjfPR3AxMB8JfUMIozb+Q4elHmVnpvh4LIEc13JlTHRp4Muh8326BHvm1Vz4kdPZIiPZa+ZWXI5AUnRSS7Hqtzb7D/NKkq3gWi87nOzFp/+No/6zzmsYo8JxRrBgVBPAlnTWlH96UcsXAyWSUX/GbNmYmr/FOiVUbt9YizjPKoitA+eI14uCRAB6g57hd1Xw/WoUUSb66QMwYG7+UtTM97LaMeBe1feI2wsTwwTOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+7SbhetlluOCgY/UOHvOW8CNBRGQjvsAT8DYQSDInH0=; b=nUjWwaJB9mTyCUaQdleIFylMRme0AqObVzM6HMR9DgKVcygdgzNO4YWSOkDeja3aiVuyscDe/xyFVOftlPlBV1xqw4NieD8MzBMXxOe+dcKvi/weG/UcuLqG3kIl9OCZ8uW6mtWJaYkZPwzRoldrjfM6fMPxf2Lss/4R+4WmthsCdNHq2RnTPKG4Lj/FgniOgDF6EAdBr8RvR5y7Xrr1jlTtX5QABY+dJn76npdv6CnHYtPtyanrdPzIFqMN9yb9Kj/22rB7/CTrMPhck49sD7j3UgahMKZQQViQBGUo62tPQ5xpwN2ddi9CDH2Mmdlc4TF+ywDpqZzNbZORLOROaw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by DM4PR11MB7183.namprd11.prod.outlook.com (2603:10b6:8:111::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Wed, 26 Oct 2022 09:09:54 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::1a91:6a56:1250:ef0e]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::1a91:6a56:1250:ef0e%7]) with mapi id 15.20.5746.023; Wed, 26 Oct 2022 09:09:54 +0000 From: "Xia, Chenbo" To: "Matz, Olivier" , "dev@dpdk.org" CC: Maxime Coquelin Subject: RE: [PATCH v2] net/virtio: add queue and port ID in some logs Thread-Topic: [PATCH v2] net/virtio: add queue and port ID in some logs Thread-Index: AQHY4f6dfnVSO4T3PkeqFVl7QkZ//a4gcVtA Date: Wed, 26 Oct 2022 09:09:54 +0000 Message-ID: References: <20220929122228.1170-1-olivier.matz@6wind.com> <20221017080037.28634-1-olivier.matz@6wind.com> In-Reply-To: <20221017080037.28634-1-olivier.matz@6wind.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB3504:EE_|DM4PR11MB7183:EE_ x-ms-office365-filtering-correlation-id: 47af9eac-e19a-4929-3e6e-08dab731d8c8 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mGLi5MUnbtMsESCxpmI47L2gJHwvrDuhY2lnslaRhGPX0f0rPQloYepjC966rcziHnyKvQSgQZPZtRaFXc0T18ELqOsgmvNyW4wwZT3M6VcKJzz85TkvyYQWrX4PsaB0fM5j7kg8NqsvnbBGS5n8B6ZQYXmO+XLunCfJUugvVZp4YocIyzYr3TI4+PMYnNHwfjSaa4LaL0Rd7mr+mLo/28p6i7RCJwOMcVFuo1Oek1wb7EEd4sT6eOM0HhQuoSKTivTjfMIizAr8G4SAQgTKCYzDOCXwdnQwefSSqb9JhLqhxp61Nxww7eC16oy+hANTqlPxwFIOnQFatpIbh9Z980cCltZ5R2BqMU5B9IBLGlJOATjrL7I3k/cGHBTzIruZFuidGcskRFItqha234Z6DCIYX0/d1KYccOwOle9BXyDRvcCmtXZWaT78b1xysE+Jx6uZPNm0CrFKXi6wum2RbaEVrWP+Dz/Gv2+zCNprmboClHd00kjrv0npb1+ZMjDI5t1vCkk4FoGvQqM/pMvuVQ/VskeoXIs67oA0f+19homZItvaKc9IVwq8kk1tC+oEfOZ6ZO9jrosmVKq3Jdki0lNUwonyu5Qp079il8xvtsI8fltMj7bnzbHu2q6frj8wHoc24VOC/GtL8Rihjikhhi/pc0bG/Y5Jlx5t9PdyBHZudQgTZSDELyWmfuT0bn/c+i635a+wdDx70x24FReuzD1Vj/u91e+qhrGog9Cci6leWeS8pWJmLzZ4MxX5zvTxT+9VYom5rg1fXTGNNw1ZfA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(366004)(39860400002)(396003)(136003)(376002)(346002)(451199015)(8676002)(110136005)(52536014)(8936002)(6506007)(66446008)(316002)(26005)(38100700002)(82960400001)(7696005)(64756008)(53546011)(41300700001)(86362001)(4326008)(55016003)(76116006)(478600001)(38070700005)(66946007)(71200400001)(33656002)(9686003)(83380400001)(122000001)(66556008)(5660300002)(186003)(2906002)(66476007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?HgeomGpajrXpVdvP2xWJ5MX3cytuyxNeyLA1Nm5m0Ss9FilI9mcoi9jrHGB1?= =?us-ascii?Q?ezTFzG01hirIkWgrH1aYqnra6JNAsC43RK7Ea8JkG7G0EVvBN6C8jfoGTsqW?= =?us-ascii?Q?ArqplYuVbGANjXv6dCVaBYDa7kOBEPcL/lfSP8PT4uLtYVMgnSyyrMbnvVde?= =?us-ascii?Q?E5p44U4ojzBhzqPXIe98KoJ6fRU2zYfORrqwevIr8XwuOH6+qUDp9MNnJ/PP?= =?us-ascii?Q?xtfGiv7CEUcQd0S5Gan8ymyMSDaJp/wRsgXQHh13JjT7eepqKaasELhxUw+d?= =?us-ascii?Q?MuhNH+PouFoj5VdQ6IjE5tEXeoFUz6903a9UdHyroGR16PlopBixiIUtMF6+?= =?us-ascii?Q?0n4lvKy7PutwN8Cm7G7xB5QXIIdiAdGYia681tfHdoNtG+/lFdr/hWaWA7Af?= =?us-ascii?Q?Z1hudMlGevC6KlcYIXFxbWGJQz06J+FEho3ghitQXynisV9uRi43kPPEcs2K?= =?us-ascii?Q?QvLEUFZNBHWXNdFEGlt6TjI8Lme2/TVyu96IpzJn0kYq2a7i4k8kc/Qy7dy/?= =?us-ascii?Q?Y04hiyr4l7ztksm7H/EDVjiMiie6SKCsYfphnO6SyndEr65kSOsHrZX46kMZ?= =?us-ascii?Q?27f+g9wbZxWP+AQn7/T3io80vz6NM5YUbybwOV0cIp+GUn5SrNxZO1kNTrOt?= =?us-ascii?Q?SWHYHreh/DGv51HW/5cjJ8jK5anVzfj05P/j/kUAylvAyTjUElQ0jGZKpoSJ?= =?us-ascii?Q?1qoK46brK+0UfwdSHmcUX56Xif6DWHndc0WDqDMfHoHfYqm54k+QhZ2pwjiS?= =?us-ascii?Q?jnc2HOpkmDfM6Q6y6rDYAYO7HWkT12X9AfLFMeAhGUE2xKQGJKem0ZPK8bHe?= =?us-ascii?Q?AgokCwyaAEP+68mnJPKKeNyWf8RgVT1sokq5QhWJ44QeyV57e5UsEVxLV2mE?= =?us-ascii?Q?ojgTAvSDE5kb1NiG7Etva1IziPbZ5MhpJA625+TvkYX1GkGMX3/LHsp+AN1z?= =?us-ascii?Q?U4u5jz7nxp/NHKEDb9NAX56KqCY5v8zL8dqGepiF+jpzNX4SQ3dGit1x0xC1?= =?us-ascii?Q?FS35UmGJVQDMO28OMhQksFg0P9u1r8dIXiQm1B3O7IORfhggHF5faIB+gMX3?= =?us-ascii?Q?fFKyoWzVN7qJWXdGRKcLU1UFiXX4SSM46vUHlJW00bPIFvm7zu1dS44c003l?= =?us-ascii?Q?Df8S91k9QzYjeo6qvSiMfIxUxQal8t3AcvpV0s2CviKCGdBir0qLQCP6zdPJ?= =?us-ascii?Q?9Zk4MoDo4f4x7fb1pirKDf4Zly79dJ+nrPhgm58Bp9MCeFqvazBUZP6dK8m5?= =?us-ascii?Q?vvOBkohCnTxYrZaETKKd3g5Ukn5E39m7+2R5AAn1kvG5AtBONEOhHTulq76f?= =?us-ascii?Q?RXEA1EaulFxzF8H2xB9nCJAwEMpida4sMpfOOlYzwwvh5mNTJlyDqaxKl1J0?= =?us-ascii?Q?Z8I1e7kPPSquLD9wqd0jSnTQEawKofh22qrKZUIYPZlES11UvW3p7EWUe1mP?= =?us-ascii?Q?ut5G7rnAI+4URLD9ktLAGcPsOgutrZ000IxrZxKmCt4o2AVA68fZIx5tR5t2?= =?us-ascii?Q?BP9NkRB5rxfplJWez/mijgThXGdkHG2GmEe0rb8hUfmEBzkh+dFLXdgMz/Nd?= =?us-ascii?Q?k/dDOjK7suae9oeigmkStof51tYGkAMTN6x7ACoJ?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 47af9eac-e19a-4929-3e6e-08dab731d8c8 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Oct 2022 09:09:54.4160 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: f9LSq6+Sheqk83voxcEtLvPfoaukDGhWZcc6qh1TKPr+eaxzpief7JJ+nXbYh96/gt/qJ1eej9/avuZwdWvnHA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB7183 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Olivier Matz > Sent: Monday, October 17, 2022 4:01 PM > To: dev@dpdk.org > Cc: Maxime Coquelin ; Xia, Chenbo > > Subject: [PATCH v2] net/virtio: add queue and port ID in some logs >=20 > Add the queue id and/or the port id in some logs, so it is easier to > understand what happens. >=20 > Signed-off-by: Olivier Matz > Reviewed-by: Maxime Coquelin > --- >=20 > v2 > * use %u instead of %d for unsigned types >=20 > drivers/net/virtio/virtio_ethdev.c | 6 ++++-- > drivers/net/virtio/virtio_rxtx.c | 3 ++- > 2 files changed, 6 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/net/virtio/virtio_ethdev.c > b/drivers/net/virtio/virtio_ethdev.c > index 574f671158..760ba4e368 100644 > --- a/drivers/net/virtio/virtio_ethdev.c > +++ b/drivers/net/virtio/virtio_ethdev.c > @@ -2814,7 +2814,8 @@ virtio_dev_start(struct rte_eth_dev *dev) > return -EINVAL; > } >=20 > - PMD_INIT_LOG(DEBUG, "nb_queues=3D%d", nb_queues); > + PMD_INIT_LOG(DEBUG, "nb_queues=3D%u (port=3D%u)", nb_queues, > + dev->data->port_id); >=20 > for (i =3D 0; i < dev->data->nb_rx_queues; i++) { > vq =3D virtnet_rxq_to_vq(dev->data->rx_queues[i]); > @@ -2828,7 +2829,8 @@ virtio_dev_start(struct rte_eth_dev *dev) > virtqueue_notify(vq); > } >=20 > - PMD_INIT_LOG(DEBUG, "Notified backend at initialization"); > + PMD_INIT_LOG(DEBUG, "Notified backend at initialization (port=3D%u)", > + dev->data->port_id); >=20 > for (i =3D 0; i < dev->data->nb_rx_queues; i++) { > vq =3D virtnet_rxq_to_vq(dev->data->rx_queues[i]); > diff --git a/drivers/net/virtio/virtio_rxtx.c > b/drivers/net/virtio/virtio_rxtx.c > index 4795893ec7..d9d40832e0 100644 > --- a/drivers/net/virtio/virtio_rxtx.c > +++ b/drivers/net/virtio/virtio_rxtx.c > @@ -793,7 +793,8 @@ virtio_dev_rx_queue_setup_finish(struct rte_eth_dev > *dev, uint16_t queue_idx) > vq_update_avail_idx(vq); > } >=20 > - PMD_INIT_LOG(DEBUG, "Allocated %d bufs", nbufs); > + PMD_INIT_LOG(DEBUG, "Allocated %d bufs (port=3D%u queue=3D%u)", nbufs, > + dev->data->port_id, queue_idx); >=20 > VIRTQUEUE_DUMP(vq); >=20 > -- > 2.30.2 Applied to next-virtio/main, thanks