From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 29FEEA00BE; Mon, 16 May 2022 14:57:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C3B8840A7D; Mon, 16 May 2022 14:57:11 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 8D4B940A7A for ; Mon, 16 May 2022 14:57:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652705830; x=1684241830; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Kgkdk3jtqXgs6tKUOk/YmLUeLXjEZqe/BHNyxThAItk=; b=bciKrZ218HlbsCM1Bj1mWmjzoB1EJE/+1AWCnuRGUGXA3CqTAQ3AqRbO /X/NW3IYh3MM0x7X5w9Kpw8VewaN3gkUEzRQyB0ztxo2Un5tmUqjQuGjX 1nhlpUi3GNR8WHy+gZb9r3woyxehErDu9CPI36zsRzdSQMtltV+dZLcWr //tL6naVujdJ0e+xBviSK8AWU8r7W1IcqRjef4ycUf0lblgSZc9qruUcO 2c+q9ZeQ850x8nr6fd8k9R7FdI/6FMlMQkzZiEE7+RUmDciXrnleX8bsw bfzOxaVzjMpQB3cjCCIUh5Ibz2idg2pdwvjCYmcrDfLJJ1xkCu4w8ItC3 g==; X-IronPort-AV: E=McAfee;i="6400,9594,10348"; a="270519657" X-IronPort-AV: E=Sophos;i="5.91,229,1647327600"; d="scan'208";a="270519657" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 May 2022 05:57:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,229,1647327600"; d="scan'208";a="596504832" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga008.jf.intel.com with ESMTP; 16 May 2022 05:57:08 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 16 May 2022 05:57:07 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Mon, 16 May 2022 05:57:07 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Mon, 16 May 2022 05:57:07 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hd+HoYSZ9oN1rq1ZWahrpLVZPvi0m66cF1VuqvsRSB9oo0nctE14AhBVR8tbRFBxCObmxm/BNEqZoFDFUMyjETRGxYIMCak6ZMh7DYgBLCujaa/x9YO7M5REyT8BDJP553MaJcle8Ru1B0ux+PReygW+wrTA0KbkRBS1j5JmOCiv8ndRdNgadFrrdc59RE08B/j2mroi9nGXxWx2Tqd9YFbBrFTJrHusyKKtngqwTfao0Klfan2WlMj/isXQuizHKYdinHmHQl+yl5Jv6TebSkP8Rg7KO8Nvg6mLUKHo12MZEUFN6BNej+ZHXsWPz09IC+5eJu1JvGKnTURvQmv4cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gnYUsAhFD0elddKYKVbAKiXh5i5lsISy6P6Sr14j5Uc=; b=i+5uKUPo8ptYLwIgnUc9VrvybQB2vRUaD8DqQOBSjm+0Yj7ne2jA/endXMuc/4kVE6QPISk6f/05iCv9oqYUrT60meLEa3FBmqftCpYkWjBrzfL5Gjj1kPprUSJ6Gu3GJOqOhjjs0OyaacNrcVvAoEwXyiuqov+7Gm/YQ/wmOayGlKu3mAVzq4Fg8eJHrPcP5tCqFFks2g0zTNyqYT4u1i2EZ4UrinDdMf/433/h6XV15P/dATbSDWohPNertGSD5SAZawus6QJEpm3yJiMt8wGOlPyZLEjXtwInJm9Wpt8CUuyM3zPe7E3i/ndAlLgKC8kKLx3YoEXiM8Uv8UVRQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by MN2PR11MB3727.namprd11.prod.outlook.com (2603:10b6:208:f0::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13; Mon, 16 May 2022 12:57:05 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::54e1:e802:17c8:93f]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::54e1:e802:17c8:93f%7]) with mapi id 15.20.5250.018; Mon, 16 May 2022 12:57:05 +0000 From: "Xia, Chenbo" To: "Wang, YuanX" , "maxime.coquelin@redhat.com" CC: "dev@dpdk.org" , "Hu, Jiayu" , "He, Xingguang" Subject: RE: [PATCH] examples/vhost: fix floating point exception when there is no VMDQ Thread-Topic: [PATCH] examples/vhost: fix floating point exception when there is no VMDQ Thread-Index: AQHYTYBEH85gOj3tQ0Cxqr7GazAnnq0hrTcQ Date: Mon, 16 May 2022 12:57:05 +0000 Message-ID: References: <20220411163451.572814-1-yuanx.wang@intel.com> In-Reply-To: <20220411163451.572814-1-yuanx.wang@intel.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.401.20 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f9b2d83b-49ed-45f8-9300-08da373b945b x-ms-traffictypediagnostic: MN2PR11MB3727:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 80o88rKXN7SF3KdAam+RnbFVFSvv4ulOet4pfhvj6Twh+/2dcridRrse2pf2+sobCuhLFP+BrMayBQ0vqh4qLxoi3CFfnLeYWb8W2TM/iMinMzF5dhMKjEFH/rO9mcXUcRAXHRE9pBOkbps3rXKJr3gUUDO4YnxjcAuNiu8uSZD2AYuWk0pfGgp/94yl9YyQa3t8WvHvPfpdImw9DSw8D9+obI3y0S8CSTx0e25e4nz+yJ0T8OlRPypTjkGip5rJBj7HHIwT+2aBNczW2V3FZ5QfSSq3kiYv1MsTwA0D4ZvmCJ9tU0te8XQwv45DVn8KI45awGCIXC63p1fYShTXvBGKF8+qW9DSrcD3nv+7gdE0/hAOILMMdOIdtnfquSB9098y/np10wS/wFeSj0/p/kbZIxOUgVXk5Bhhl9gUIVWWisAj7ZqIqtlgM3PqktU5/txsIn5MDKupg6nFHsezCaEfryUb3h0Bf/mI5AJ1q3CMRgMWNsUhKiSw+Y1HW1WdAnQ82zZ8JVF8d5oomA+PZIUeDEj1VaQjxJyhBpmjMzI20MGC+zIwrR5VzbnmiLejQPB8XUm7I8Xi2obWI/GErBaBqPMfhEksgS/0DIVD5uZIEezeZGWA36hSfuOguaBDNxFWcqbMbFaj4CLxLs4XaN3/Mh2uQ2A8Hg6y3mnHjRKDki/mmLvKcYkTuQMRfLiXZ6nu8DJzFTfAPg3+dcz8rQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(122000001)(83380400001)(54906003)(110136005)(107886003)(316002)(6506007)(9686003)(2906002)(71200400001)(52536014)(508600001)(8936002)(53546011)(66446008)(66556008)(86362001)(66476007)(66946007)(64756008)(8676002)(26005)(76116006)(4326008)(82960400001)(38070700005)(186003)(7696005)(38100700002)(33656002)(5660300002)(55016003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?quUGb9nTsFeI4XPRbeLzi7+YcefO3wXmhKqtuOhLmUr9c5KAn2z5Wtev3XYk?= =?us-ascii?Q?I/Ch3S5exxGlx6Nyuv5yJpYL3AqZ7PTE3+zsQrArJL2bKyrXe32CvCo4w+8a?= =?us-ascii?Q?jnft+hIjgtHQhVf+P673RZ9geyVQ96BgR0LFx8uSuYsQuZ5cXE4fCHBz/Vi4?= =?us-ascii?Q?ctPCqiO9+8J6H5wk5jWbGZVe7xJK79+S8IyetlbnyzniwyI75JR8cT9jMyhC?= =?us-ascii?Q?DCXfYeYmce1JphAIOIYbeuaeKnvBXwZ9DzKnAUbHZEBH1MRhCZoGAzuVSfX5?= =?us-ascii?Q?uUD5SVL8HXXmido78R/bKKoz9ifCwZW6OskNwIR6X1YqFsWGvDJ1lWQy3e2N?= =?us-ascii?Q?VWdYYouXGzu/KBHHLOuVVM3iFmWkfkxomoiJMG78TqequTJ2cfL2t2jGENSf?= =?us-ascii?Q?8lv0W31AAhALxeHWtD3VEqzhEev8XchGupvjbCGBOU+bVkW69oB++hUJPTwk?= =?us-ascii?Q?5t0JISyimqkvyIW+HOicckS9hhP1YEzFlizuoMxlNzYacNlYtMLlqjyMmTR5?= =?us-ascii?Q?+2Vylh6uvWemoQzDtDrzMN5BSXuGMMWExCB5h0zMeIbo50EtifHaMRTUgOIc?= =?us-ascii?Q?cYdI6TtJOo4GTWRY2ScXhrgFcMpWBhnGm6mTFTiDDM1t2DJirj0DRCWmkoVP?= =?us-ascii?Q?cM3b1yBLfjUnunBU82+dzNNrHtHcQBDlRofTXp+t9a7Vvfncqmo9YzZYaS2v?= =?us-ascii?Q?1741z2jBOrkHfNGjirmJMW1bGJ+f5TLWZ8HM798iCwKXAWccMYoScHTcLTv5?= =?us-ascii?Q?djSKwxMJPigvg5p8dyjfoLrEASLLvkhqIkysxw5agpa2FTMqJJgLz2z4ndad?= =?us-ascii?Q?i2Enr19Vp+m4hJua8rRaAj/1DPOqn3gPlpQ1PqyK6v8z+QxdNWj6tPw0cg0W?= =?us-ascii?Q?9U2s6sO4uRra/oZiNsyRoatlJR40v6IJsUa26M4L/EC4fjW7SZN72clc+4Ba?= =?us-ascii?Q?AcVi9wXc1ZmjKaQj5RRCnPBn2wqJGIIP3mYmiKlDBtE/Q8LBprRBaS4sQUb4?= =?us-ascii?Q?QLHeE3FhXqPwHnZXgCMN2fq831sWyzksK6NGMVokMfOpD4oVW9slt5WcgrGF?= =?us-ascii?Q?X3qAJQQL1Ug/NHJFHOmTlg8/vqF9tR0/23VttBle07QnN9JITpPkPIa53mpV?= =?us-ascii?Q?Cuf3wST9IGsy6VRVclk2BMsUxrBa9WMUKIHFfT1ymBFaCHn5LEjmKzgfLGvr?= =?us-ascii?Q?I784bouybLjRFhqj5mtZ7x7TvdBs3VSLQyJCwkcfKsg91OEJ2inCMdKzMAvP?= =?us-ascii?Q?z4d7dhXcvQ1bu9mLVNJz7VrdrZ8VnUxGxi9TuqJBfotE1ptq6/Ors4L+Xo3T?= =?us-ascii?Q?uKopX9zWLVVyqg+OuQAkyP7I7zYwur7puUob5+6gSosn5E65F7OLCD7S8twW?= =?us-ascii?Q?Neu8lhHBq7d+YhiyRXis6jRlOnQAsVptNGCqothef8+KDmVDuZFAeDcjI5xo?= =?us-ascii?Q?mTs4KkCuOE/r3B1jcb6N68fGtTkffiCK6RbyCbq0eUcXdqWzSqXkQWrqRk0R?= =?us-ascii?Q?LhOuwPC/PpqBXQ4ZD7O4uxzoeY8/nN6Qas0uQL9yR2PKjaV9GEWqMu9qiXUU?= =?us-ascii?Q?50o/T+c104EStYICrISmPs9q+KsR+KQzxxlnfzJ9Y+W9idyfXxh81gtM3ABk?= =?us-ascii?Q?xh4ezAeJZreEkJETmf/WHaAHgxbxx37qppuXby0FOH2KXSoU6cKrlT0vw7/v?= =?us-ascii?Q?R01MztHSdmAs2bdrs496yNIIWr6Wzfw0uR6JN6KhAG2B3QCNXTyjJc6Urcx8?= =?us-ascii?Q?1NawhFvSpA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f9b2d83b-49ed-45f8-9300-08da373b945b X-MS-Exchange-CrossTenant-originalarrivaltime: 16 May 2022 12:57:05.7817 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yz1daZqKmYgXFZ1gFCH94n95jhKcChdFvYZNI4DqdfOb7Ev6b+rEk42xIwiD3IcLpS4sKfZyOavYuxxv4+/D+A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3727 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Yuan, > -----Original Message----- > From: Wang, YuanX > Sent: Tuesday, April 12, 2022 12:35 AM > To: maxime.coquelin@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; Hu, Jiayu ; He, Xingguang > ; Wang, YuanX > Subject: [PATCH] examples/vhost: fix floating point exception when there > is no VMDQ Based on the error reported by devtools/check-git-log.sh Title better be: examples/vhost: fix floating point exception when no VMDq >=20 > If the VMDQ limits is 0, a divide-by-zero error occurs. > This patch replaces throwing a floating point exception with > a normal error message. Pls add fix and cc-stable tag. Thanks, Chenbo >=20 > Signed-off-by: Yuan Wang > --- > examples/vhost/main.c | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/examples/vhost/main.c b/examples/vhost/main.c > index d94fabb060..815ac1cd57 100644 > --- a/examples/vhost/main.c > +++ b/examples/vhost/main.c > @@ -400,6 +400,10 @@ port_init(uint16_t port) >=20 > return retval; > } > + if (dev_info.max_vmdq_pools =3D=3D 0) { > + RTE_LOG(ERR, VHOST_PORT, "Failed to get VMDQ info.\n"); > + return -1; > + } >=20 > rxconf =3D &dev_info.default_rxconf; > txconf =3D &dev_info.default_txconf; > -- > 2.25.1