From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8E42D42BCC; Mon, 29 May 2023 08:51:54 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 800504161A; Mon, 29 May 2023 08:51:54 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id EDAE44111C for ; Mon, 29 May 2023 08:51:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1685343113; x=1716879113; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=/0osDr7vuZCgLMSMxpGNnItzNdYNM5rswDP81CXw8MY=; b=oC3g2nB52zjnVyggGIS3ntmG4Ffj002n3HrIXLzK6fdfLAqwcaOysrp0 dP5mJCJaBiGRoRe6apox1o+rkzDnRIl/7/K7CId37W2dSBZeKbryPnNZa BGKSmMM+yQn1T334u/NU9AuSjTeI2FJ9zdqW4VJe9xS+o+K5CoYtw0TPj iZVA7EKnQyu2uuc0xl/0K9sXdgbpP9Ftqr6ej/8bO98NjHsMfHryFHv1D Z0nMuOpOjSPKOIQdEaHq/NG1eBQ4c796HN10K84Z8e1ybc0Bgmwy4fVGh D/MdUiMy8sLA+fYkDAdcSz0VRSH4aUQ+fRHu+/3Jg1F4DsRqMsqn1Huf3 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10724"; a="354648880" X-IronPort-AV: E=Sophos;i="6.00,200,1681196400"; d="scan'208";a="354648880" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 May 2023 23:51:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10724"; a="656384977" X-IronPort-AV: E=Sophos;i="6.00,200,1681196400"; d="scan'208";a="656384977" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga003.jf.intel.com with ESMTP; 28 May 2023 23:51:51 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Sun, 28 May 2023 23:51:50 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Sun, 28 May 2023 23:51:50 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Sun, 28 May 2023 23:51:50 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C8IeUQ/Qsd16ej4NOPq+Nw4P0XqedHXJi5J+D5vdbQ6kT4igWQ0Om8DklAA8LkSE30Y8yqlqaed7s/yDwH7U9WQK8oqLojO7/YdApOIaVdLPmjpBWlH1x/60iwFufzUSrkZKn+LCF3IR8WRa9ZW+6zb5M19ca7hzjsQmL85r1CMmI0S+Q6TVTrMGiCdLn7Bh4YGfjL4Twghg+SR1U7euRx/MpCan9AD0lleZ4piulc+vFwE4MZ5qgTUQmowGw3BsluUTMRZXEiU97lTY5Bf0HEDk1sS6vZ2/+Oe08TFNEtGCKdeteOfxCBYr0Qi7bRXHP9IR0GeoAGvaD6MANEYtAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qh74/9HcdrYduhnalmmfpzrMiyq/AD1rhxdU67a1iyw=; b=iCoZDEWu3NRggfpAFjnkprE8vxUxr/ZInBk2HaXTRZps8hmXrxV1TvUBknFBMCSgekbFmObmTOlnUjYi51myyB1gJieDC0zGObGGFQwxF3+S7xi+GWUBnEPXGGPnaSLHhMoTIpyfpukqNIo931xxwByGzTk092O4l7PL532/Z0nRMF1gHc2GoXwbcYQ6ddnfTHkiuekuvLiaFDrm75O9L1BV4Y8OdZrrCdI9IwGgeqM9X9a11WHZPtyCotJTEw356NTXxobuIZkoxgiWcSFi9dffRufKOzJQ00mO0+KIcOdCeRQwvbeIB3k9qXSfbUTP6z0FsUnX6yv7unWagxKDRQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by MW3PR11MB4602.namprd11.prod.outlook.com (2603:10b6:303:52::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.22; Mon, 29 May 2023 06:51:47 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::e427:f0a6:8472:d0f6]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::e427:f0a6:8472:d0f6%7]) with mapi id 15.20.6433.020; Mon, 29 May 2023 06:51:47 +0000 From: "Xia, Chenbo" To: Maxime Coquelin , "dev@dpdk.org" , "david.marchand@redhat.com" , "mkp@redhat.com" , "fbl@redhat.com" , "jasowang@redhat.com" , "Liang, Cunming" , "Xie, Yongji" , "echaudro@redhat.com" , "eperezma@redhat.com" , "amorenoz@redhat.com" , "lulu@redhat.com" Subject: RE: [PATCH v3 20/28] vhost: add VDUSE callback for IOTLB entry removal Thread-Topic: [PATCH v3 20/28] vhost: add VDUSE callback for IOTLB entry removal Thread-Index: AQHZjyXPTJCKX2tlpkOpkGEDSgoz0q9w1byw Date: Mon, 29 May 2023 06:51:47 +0000 Message-ID: References: <20230525162551.70359-1-maxime.coquelin@redhat.com> <20230525162551.70359-21-maxime.coquelin@redhat.com> In-Reply-To: <20230525162551.70359-21-maxime.coquelin@redhat.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB3504:EE_|MW3PR11MB4602:EE_ x-ms-office365-filtering-correlation-id: 4969a1db-2224-4ee3-e284-08db60112c3a x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: XRKxVyH3T031lB0GWOAEU7Pa9+s/V0/cWu/peR7+Kn39y0lSWn2JE1xnhpAfkh7R8Lv4XTytXTr3HAkzDiRxEuJ6IeCPEpdqhznkbigc5qRuhHEAe9c0T8Q407eMNvRVTbuaVwQcdIFM28n2dmiiHrvocYrKIqEeWqS1dhRhyCQp5PnhW6ALbKSi/KyYZvYYNteuW/CUnvVKt7P8SD1k59KQc1D+ixbRqGyosx1raO1x6rILCv0Hi5F06DKxAIDToARN2KQzKnk6SmYOApmMmUB/14xhGc5ipoF3zQ4pCtNMrsavVaO0wU6rJLVvSkqyE/7sMStyZhh72MYUJ2Fljx9zwZ+sZTXeRbT8TSnpFJzMqLTOCeT81xFopZXFoG8AqI598J6Ey+6Sn7wayY+MjWW4Ke2pYYNq7J5g8eLzbEhvPhyJjuiLreu2yTZXox0JAi644BAthSuwPzYzAkVXi9XtjMoP1XIbFMLxByPRNcQtOZb2kgWlLtjcZJyvsFE1RbOPHjniP7H+qGa3CBMGjTixLObnjdo+8J8h7Fjiskzdxg85WQzl9ewOtTB3XAFl/X080Mt/M5V28EdbL3BBUtF7kuFTUiVDmrF2GJWvOdRht8AgHhoFYFOzf+A794XAgaBTHOP3SgJ7z0USlGYtpA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(39860400002)(366004)(136003)(346002)(376002)(396003)(451199021)(71200400001)(478600001)(110136005)(5660300002)(8936002)(8676002)(52536014)(7416002)(2906002)(38070700005)(86362001)(33656002)(66946007)(66556008)(76116006)(66476007)(66446008)(64756008)(82960400001)(316002)(921005)(122000001)(55016003)(38100700002)(41300700001)(186003)(9686003)(53546011)(26005)(6506007)(7696005)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?fLTb4UFJilZ8JVphW81Gc9CrALsYqYeiO11HNf4wP+wfy8YMErsCrYah79b4?= =?us-ascii?Q?QfMV2Dxbm8AqzHQJaST5pJFu4XWx4tBCqorVPVhMBjO5flVWtrA/DOj1p6Pg?= =?us-ascii?Q?MZJa/WGXnsQLXDdj2v/Jx9q+OdpZ1u4dfOvn1WItFcYj7YU0FYIvegm7rl96?= =?us-ascii?Q?1bQfxPBCNraJjSUB+sqTIS7MQSMAwBa1ERwyszlFjVb8c3vJHp+KVxZsK8Ej?= =?us-ascii?Q?GJ6//GHMq8h1HEF4YRzGrYE334pMNJoesV4xcEJ1RLw4vX4oz+13fUFu/+21?= =?us-ascii?Q?o9+RndQYYIwAXlUXvyu4WPGUDWKrDjNgBPzInhfEVrKp4C33rpZKNGul5WVS?= =?us-ascii?Q?lw4Le8OolnbgGCG8zGxdEFpgm4y4ljdbran9DRC/da/RbBLcc6lyNDuvR59l?= =?us-ascii?Q?dOd5g5t3Hh0MugIgOK8w1q0mHgP1COQRvAIIZub2yiy8oI6/oQUqjB0vbpWf?= =?us-ascii?Q?XzZUxovBaPlnFLESW2vi4FRQbfN+aM7uNuchNWrVCRQewCQXBqw2+Y2q88Tn?= =?us-ascii?Q?TA18LVaOj6kkhUYPa7kzmJrw5i8Pk18pNR8Hy4Fl2QRbcFPtQ3Uf0qgrGZmM?= =?us-ascii?Q?LgF2K1rmxymAL9klV1ynawx6BRw8VwsYNodYlXT0uP/bQKybfilbYGKw1Lep?= =?us-ascii?Q?2qFQuNZL2+NETgRa75+Rv79BhJOEZX88qDJh6A2Wj50oPRzdtGRgRwwrBf7l?= =?us-ascii?Q?4BM3tmHtUFuw6BfPtXoFz2yQZgWzYpRhwT3rzg8SV4fU7v4TuJjVvvPgeJ3o?= =?us-ascii?Q?NBdbRjqB4ko2VRs8EZqgO9fpgBXjkxrJUbDRYf6yWLtP4euAULmlrh3DSpDC?= =?us-ascii?Q?/293LEB/99HGqKXcgPjq/1Ilyx06dXVI1vFrB6Epgk2PSNkl96UW8ydcMeSm?= =?us-ascii?Q?HPFqOWYZOVLko7p3ehBrsg6g9vBo+IKT1b5G8KK3lPkLwpvRjfqDtB+VdQ/k?= =?us-ascii?Q?LoN3V2iEK8paySA34zFRuBkMKAnhTTwrJspj9UG6uaIM7a+fBYBZNITIauZI?= =?us-ascii?Q?qqi1CUy/7r2vSFNdAHEb5YxN8KFAh1pZl+Tv4i4b41Cio0SkZYrBOqK19hhr?= =?us-ascii?Q?17v1BYdz40INen8PboyLQsr7R4vg0DHla/Kyd4mZ2xAiv972FeSQ/AlQzUH5?= =?us-ascii?Q?WKzaSUkj7lhstCo1KzFk+1oSP+arMuIEfyY8TZbZBZyXoX7okK8Rxk+/ZxaZ?= =?us-ascii?Q?xtcPvEmKkaeOgTMa4+wGG/GnWtyrib1PrVnOIwnyKYKnfALRIjGS/j5un7gz?= =?us-ascii?Q?ur3cI2qgUGRfnOpEXKjory73brnsDTZyc3ZKwfSyOK5PNlcn4UtPGRx0ffRv?= =?us-ascii?Q?OqFi04MGUHotYYojLw+I9I9MSnXuuq4D2J63FijEBino+WxNRmtVQu8OfCS2?= =?us-ascii?Q?rHZ/7bm8xq55lZv8soDLr4f6U+MRjkSlQhfXwdYfdPXElCJYGprrlp7ADM5q?= =?us-ascii?Q?Dh4Bw5WlxU0SijHR8TdPvg74HbQJeCw1Pk/fvAex4Wm0oncyXGi4JvEWuxf+?= =?us-ascii?Q?nawIFdawmdGkUMEnyFdMMtY6qPkBEimIbVfC70e0S57m+PL6sPyOFk1OGQMW?= =?us-ascii?Q?CaF29EWl+9jztuVVaV3hTmRbjzOoW5TXilFEGrs9?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4969a1db-2224-4ee3-e284-08db60112c3a X-MS-Exchange-CrossTenant-originalarrivaltime: 29 May 2023 06:51:47.5801 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BxYRjotVoqZEqCgf6tQYNJNmGAvGSTne09sdgy3rapRtHj2yPd++mIYgkmCA+I//hydBCgtuv+JN2hWkt0drzQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4602 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Maxime Coquelin > Sent: Friday, May 26, 2023 12:26 AM > To: dev@dpdk.org; Xia, Chenbo ; > david.marchand@redhat.com; mkp@redhat.com; fbl@redhat.com; > jasowang@redhat.com; Liang, Cunming ; Xie, Yongj= i > ; echaudro@redhat.com; eperezma@redhat.com; > amorenoz@redhat.com; lulu@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH v3 20/28] vhost: add VDUSE callback for IOTLB entry > removal >=20 > This patch implements the VDUSE callback for IOTLB entry > removal, where it unmaps the pages from the invalidated > IOTLB entry. >=20 > Signed-off-by: Maxime Coquelin > --- > lib/vhost/vduse.c | 7 +++++++ > 1 file changed, 7 insertions(+) >=20 > diff --git a/lib/vhost/vduse.c b/lib/vhost/vduse.c > index f72c7bf6ab..58c1b384a8 100644 > --- a/lib/vhost/vduse.c > +++ b/lib/vhost/vduse.c > @@ -42,6 +42,12 @@ > (1ULL << VIRTIO_F_IN_ORDER) | \ > (1ULL << VIRTIO_F_IOMMU_PLATFORM)) >=20 > +static void > +vduse_iotlb_remove_notify(uint64_t addr, uint64_t offset, uint64_t size) > +{ > + munmap((void *)(uintptr_t)addr, offset + size); > +} > + > static int > vduse_iotlb_miss(struct virtio_net *dev, uint64_t iova, uint8_t perm > __rte_unused) > { > @@ -99,6 +105,7 @@ vduse_iotlb_miss(struct virtio_net *dev, uint64_t iova= , > uint8_t perm __rte_unuse >=20 > static struct vhost_backend_ops vduse_backend_ops =3D { > .iotlb_miss =3D vduse_iotlb_miss, > + .iotlb_remove_notify =3D vduse_iotlb_remove_notify, > }; >=20 > int > -- > 2.40.1 Reviewed-by: Chenbo Xia =20