From: "Xia, Chenbo" <chenbo.xia@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>, "Ding, Xuan" <xuan.ding@intel.com>,
"Hu, Jiayu" <jiayu.hu@intel.com>,
"Jiang, Cheng1" <cheng1.jiang@intel.com>,
"Pai G, Sunil" <sunil.pai.g@intel.com>,
"david.marchand@redhat.com" <david.marchand@redhat.com>
Subject: RE: [PATCH v2] vhost: add runtime locking check in unsafe APIs
Date: Wed, 11 May 2022 13:58:37 +0000 [thread overview]
Message-ID: <SN6PR11MB3504AA63AB5E3DC6C8A05A109CC89@SN6PR11MB3504.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220511065837.1267895-1-maxime.coquelin@redhat.com>
> -----Original Message-----
> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> Sent: Wednesday, May 11, 2022 2:59 PM
> To: dev@dpdk.org; Xia, Chenbo <chenbo.xia@intel.com>; Ding, Xuan
> <xuan.ding@intel.com>; Hu, Jiayu <jiayu.hu@intel.com>; Jiang, Cheng1
> <cheng1.jiang@intel.com>; Pai G, Sunil <sunil.pai.g@intel.com>;
> david.marchand@redhat.com
> Cc: Maxime Coquelin <maxime.coquelin@redhat.com>
> Subject: [PATCH v2] vhost: add runtime locking check in unsafe APIs
>
> This patch adds runtime checks in unsafe Vhost async APIs,
> to ensure the access lock is taken.
>
> The detection won't work every time, as another thread
> could take the lock, but it would help to detect misuse
> of these unsafe API.
>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
> lib/vhost/vhost.c | 18 ++++++++++++++++++
> lib/vhost/virtio_net.c | 6 ++++++
> 2 files changed, 24 insertions(+)
>
> diff --git a/lib/vhost/vhost.c b/lib/vhost/vhost.c
> index df0bb9d043..39cbeb415c 100644
> --- a/lib/vhost/vhost.c
> +++ b/lib/vhost/vhost.c
> @@ -1732,6 +1732,12 @@ rte_vhost_async_channel_register_thread_unsafe(int
> vid, uint16_t queue_id)
> if (unlikely(vq == NULL || !dev->async_copy))
> return -1;
>
> + if (unlikely(!rte_spinlock_is_locked(&vq->access_lock))) {
> + VHOST_LOG_CONFIG(ERR, "(%s) %s() called without access lock
> taken.\n",
> + dev->ifname, __func__);
> + return -1;
> + }
> +
> return async_channel_register(vid, queue_id);
> }
>
> @@ -1796,6 +1802,12 @@
> rte_vhost_async_channel_unregister_thread_unsafe(int vid, uint16_t
> queue_id)
> if (vq == NULL)
> return -1;
>
> + if (unlikely(!rte_spinlock_is_locked(&vq->access_lock))) {
> + VHOST_LOG_CONFIG(ERR, "(%s) %s() called without access lock
> taken.\n",
> + dev->ifname, __func__);
> + return -1;
> + }
> +
> if (!vq->async)
> return 0;
>
> @@ -1925,6 +1937,12 @@ rte_vhost_async_get_inflight_thread_unsafe(int vid,
> uint16_t queue_id)
> if (vq == NULL)
> return ret;
>
> + if (unlikely(!rte_spinlock_is_locked(&vq->access_lock))) {
> + VHOST_LOG_CONFIG(ERR, "(%s) %s() called without access lock
> taken.\n",
> + dev->ifname, __func__);
> + return -1;
> + }
> +
> if (!vq->async)
> return ret;
>
> diff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c
> index 5f432b0d77..59163bc165 100644
> --- a/lib/vhost/virtio_net.c
> +++ b/lib/vhost/virtio_net.c
> @@ -2091,6 +2091,12 @@ rte_vhost_clear_queue_thread_unsafe(int vid,
> uint16_t queue_id,
>
> vq = dev->virtqueue[queue_id];
>
> + if (unlikely(!rte_spinlock_is_locked(&vq->access_lock))) {
> + VHOST_LOG_DATA(ERR, "(%s) %s() called without access lock
> taken.\n",
> + dev->ifname, __func__);
> + return -1;
> + }
> +
> if (unlikely(!vq->async)) {
> VHOST_LOG_DATA(ERR, "(%s) %s: async not registered for queue
> id %d.\n",
> dev->ifname, __func__, queue_id);
> --
> 2.35.1
Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>
next prev parent reply other threads:[~2022-05-11 13:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 6:58 Maxime Coquelin
2022-05-11 7:35 ` David Marchand
2022-05-11 7:49 ` Hu, Jiayu
2022-05-11 13:58 ` Xia, Chenbo [this message]
2022-05-17 13:23 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR11MB3504AA63AB5E3DC6C8A05A109CC89@SN6PR11MB3504.namprd11.prod.outlook.com \
--to=chenbo.xia@intel.com \
--cc=cheng1.jiang@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jiayu.hu@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=sunil.pai.g@intel.com \
--cc=xuan.ding@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).