From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7C940A00C2; Mon, 30 May 2022 04:52:38 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0FBEF40A89; Mon, 30 May 2022 04:52:38 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 98A2640A82; Mon, 30 May 2022 04:52:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653879157; x=1685415157; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=z9xCUY1W0bowYsVYsZJ2VWpIMgntbIG8de0/vCq2Adc=; b=UgvbvU4Ezm1s40EAlPGWL0JFq6P+wozoZHL9iPmZhOyD8Kos1YhxO9/V VfVVoZwabkCfmTYfaS9tXJ+uEPtAhRx+D3G+/qAwRDla0MDZlD98cuNAt 3JZ7lnytnSmQWdvcnPuHgT7OYpA13TJUdAnXEvmnN6Q8lCi6LuCobQqPx 8GqkEUENxu2bqtmSJx6wrffvgh75O1tUlknVDeCFj7JpGbNkxVJeY8Z1O Api82LQ5ElOR0y0u/tKb7dVz5kdPIJvnjqcp2q2fSw5R9oSpv+U71BD8b i6HC5BjG39I1+wWmg9OZvoOgKuFQ13HeLQ9rcLvtHlrYg0WU3BjmST6zo w==; X-IronPort-AV: E=McAfee;i="6400,9594,10362"; a="256937934" X-IronPort-AV: E=Sophos;i="5.91,261,1647327600"; d="scan'208";a="256937934" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 May 2022 19:52:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,261,1647327600"; d="scan'208";a="575731469" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga007.jf.intel.com with ESMTP; 29 May 2022 19:52:35 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Sun, 29 May 2022 19:52:35 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Sun, 29 May 2022 19:52:35 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Sun, 29 May 2022 19:52:34 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hZMOJBuUk1G4+ZLoIZVJbd6HSiaCegGw4OdpDVK+dTJr+P/H0Ce6z3mI5zkoyEpLplo7cijIis8o6GCpAk6+QuyBN3HjOm3tmZQgNLoHsLuH/uQYjTSCLLvbY9cE9qpPs4e9+9UvvKDh9w5PNWGaQZSYJB3XUm08JHZhOjjNi+6a5v1SUJbG/EJKdnBm6UT7yBXUHQuPcQizfGjLHO+sM0jakceMH9WB7vmeEY37RC51g9WB1R8k9xGmQW7sK8JkUVhEGc1DDa3eCv372rYjOvsTGXwAWoNnbrz44WnVq6Nkv4pNtepbRwnjYxUlxGZkgAJLx1QZoe8ITIW7KWGjmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U7e4pcjrGi5wN0z8EdeniG6pL59H/pnaSkUzKPI0Va8=; b=QIF0eZm+oh/xZVwDmAJpNpntzIxiE5oEPJS+qHHpVMLlO0Kjfo9QiriT+oozz5FN1QzhkOKLiLhPxyHTH4Z+3XkYVn1jrSPIFbqV4EAHx6Ip6VKEqkkebbg0sZmqwR2zvn0JePeNaYk2doRefnYSWuDdZ2LMU1Uv6T1oP5w+wMu9Ubkbc8Vu06gB9qf/0ziTKRfbx6CsInRGWxgTyu5/Ow+gbTollAXx9/yuZ8cQrt7ghquFQPtr2TU4xRLjNogqcUk8g0fWmClnNl5amV32HZlXLX1yH28xBBErFxmw/wERUcll2baICHRq5O+jvPtNjZXS+vnXCnfxyPP1NRzijw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by BYAPR11MB3734.namprd11.prod.outlook.com (2603:10b6:a03:fe::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Mon, 30 May 2022 02:52:33 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::d4ff:ac50:621a:60e7]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::d4ff:ac50:621a:60e7%7]) with mapi id 15.20.5293.013; Mon, 30 May 2022 02:52:32 +0000 From: "Xia, Chenbo" To: "Wang, YuanX" , "maxime.coquelin@redhat.com" CC: "dev@dpdk.org" , "Hu, Jiayu" , "He, Xingguang" , "stable@dpdk.org" Subject: RE: [PATCH v2] examples/vhost: fix floating point exception when no VMDq Thread-Topic: [PATCH v2] examples/vhost: fix floating point exception when no VMDq Thread-Index: AQHYanq2o1/kJBw7n0CW5h2hymTBOq02y5VQ Date: Mon, 30 May 2022 02:52:32 +0000 Message-ID: References: <20220411163451.572814-1-yuanx.wang@intel.com> <20220518133633.1634902-1-yuanx.wang@intel.com> In-Reply-To: <20220518133633.1634902-1-yuanx.wang@intel.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 40dd690a-dc2e-46dc-e50c-08da41e771d6 x-ms-traffictypediagnostic: BYAPR11MB3734:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Yw5bdJeK8QkqRFuM+Jhcf0onCzTrXrl3RULU0NfbMf5nBuG+OYCkhR+5uWoINaw/9pwX7MhNi0YfpRwFGnG1RjgxclGJYFVdNQZcQkjznZncbEj0xd2tMlm8SJaRp1aa9wFzIgGvjuxeJzcy99LgO09XxuCNLyp7XArq08o2ZrsiUOegmMsw5Ba83Y1JccWTvBge9Z0RCY4Fyt/OHLKXAlXgd9+ZbAmJVVGo4ZSFxNYqtqcNWaJ2hpKsXjUzc1PsKX34MDqO/TqbemE5UVb94do+hm8knM9U+dj6P72J1joFfXI6aqW0r+cxqz5tBNiaj/TWZRI+hW1Xq6uGChuDoem64vOHrOokDeEZc6y6ZJ27+8myyJLlcbKiNYebc+fnkNwfLeAvpXyOgCD9+D0A+80/8KrlwJG66llLWZdH1CQt/SS0xw3uHSqjo+cCaZAkr3sFA3KdkGf2aSZLlk49iHgHyQcTGSkcWB9yb9qoMiLQ85jAIF3835Y5JQIVEQfuDM3rYaDSSZc16fN50R82gCBKhaZhRBUr7gv/PAqlLa+QiV+lyS26NFpMgy8fRKPnLmzmg9FLkoMKw/hDK0Qarl0k2zvF1TG2rMq6xRhmzbaeZ3EFbEj7vcTLQaXFIHOWPBbhtNNM8jLG4lpKmLC+ipZZJmZ7eXtjolVtOET9jgPMxu0/Lc9dUBCZeCWcQQ6yBEu3fTxX9QXz2IEJTWs/Mw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(83380400001)(66446008)(64756008)(66476007)(4326008)(76116006)(122000001)(110136005)(52536014)(54906003)(66946007)(55016003)(71200400001)(82960400001)(186003)(8936002)(2906002)(38100700002)(66556008)(86362001)(9686003)(8676002)(53546011)(7696005)(38070700005)(26005)(508600001)(316002)(5660300002)(6506007)(33656002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?q7ggz16vUbKQBmvQY+1eu41vcbgVSZgUyYVzA46TF3IgDnPJ7XDBCDs0twSz?= =?us-ascii?Q?HwfewfdDXzaOQUP1jwIFQvIcr/m4dbTuFC4Ui85STzcbPxTxxEhxZO5S/XUF?= =?us-ascii?Q?QpYc1rfXeX8rRsKm3HkBDXSROIcVa9nJXJk16S6cFCm81IZigEB5vfaTAN9x?= =?us-ascii?Q?QSwte3f2JhENrgslVLLDYDwPwldweKviVG9kmtTTAm5rPqXXdO/pVVb3geqO?= =?us-ascii?Q?W29NNXL4jcO6hlzBn/XoMTKvkOWxdjvQd3mA8Ky9TnAd/njn/fiVpWtd2ISY?= =?us-ascii?Q?hRoHJ1QssQI6D7n5QVW1iufIE89Awm/U4S8fk+MnMyXmSVjjzCFKHJY2b6py?= =?us-ascii?Q?+Eo4CdCJVJaKZ+wRwhCM13H3jyrCjCRpsjlbd0Rbcjdr8PZM8CqJf2tlwY/u?= =?us-ascii?Q?PlGknCMcz3LMIwg4eYT/p07svRVCo8rAZwBzp+i5DFJyBxJ2NCpKDGf21XIN?= =?us-ascii?Q?fFbdafkFC27nrq2fqBp+CPlWvnEgYZgDaQg8f4mi8nhbz6OHXbUPuwqS1wx4?= =?us-ascii?Q?TPuODLiRSdybM+QrgAkgqBk73wwZO/HDBJLXe0lypgd92V8IgSO+x4SFsH8x?= =?us-ascii?Q?JOK3jRj12mAjbjxmDo4/QNWXhXt6jdZQHHfkm1PdRtjsgnEgcoNgIuFwMGOZ?= =?us-ascii?Q?tbyEu0qFVFmgHJUjKMhMhA5bofjKEi4nGxusK1/FsB0lDYcjEvMNmT/eYLC7?= =?us-ascii?Q?s9frKDmkTHVlnVEoprWCnHCm1bzhCgnW7KCcOreZZVk3GoQXjAyaZhDThqvl?= =?us-ascii?Q?sSSFQ+ew1ztUafv2LhLnAuqmKqA8fzkTni9SIkypdfxTSZ95ZkFdsdTlTe7J?= =?us-ascii?Q?cPErTeSswzRlwqOgDL084tJL+9mE2r3qvdsCHsW8h2XKGiLqSr7qFX8yzfdL?= =?us-ascii?Q?dAn2ePmvAqtsg9UXr1l+UYmBIzaLkE9A5wsjVWM5VVWgiJyKjME8Gul8R1Su?= =?us-ascii?Q?jBwapzZHE9GH2gjbexe4jMH20p6nLSvJPwaN0ItQy0PLz/jo7rF41OiRgO9V?= =?us-ascii?Q?K4OUhDWEkpqSkalfDBjtXgbDiSHXx74IlDyh96bHfKrsEnSn+Kzj0D+APGHD?= =?us-ascii?Q?OBzjEiPt6BGcg0Dd5j4nLq49SELmR6gQ7Bhf984WVnJDKjBjWq6zRSatcvYT?= =?us-ascii?Q?9pWAt91f5jVfRYQVQ14gCIjNBCp9T1HHNSZwppCBNSNsIhAH+6iJCG/p+g1f?= =?us-ascii?Q?I/LF/DYQUIrpx/SIiOQLq/fVQzbWMKZBdDrz+KkJJ6Xl5ofsTsbgi+aapN82?= =?us-ascii?Q?8GCm2hklSTYlND/gcXYv7d4YsEYpjD3w9vbTsVgs/LQ6WmSxuOO2OIlD5Jp/?= =?us-ascii?Q?jzlUM7pY4k1kUsZVFjqv/UpT/iHNwoOxZ+tHA9B0W/u4miLvLJMG2434riAa?= =?us-ascii?Q?xJdJ6I/MoZFYMB/5h1OJLAFpYFZHtIdzyKyop7rBnAYoAfIfDGmU25r7GuQ6?= =?us-ascii?Q?UA3vnkMW9OEH6+qJOtvJtiw9/6VEPKAfZnKgyfwQNBQRU9GV1JTXr0GY9qkr?= =?us-ascii?Q?LJoHiIuHls5I90KirX3D+ANXqIud5d9DOFqSPfY28j5+gjTAe8CWEQosbNUI?= =?us-ascii?Q?O9e3HrGMV8tKAYVYqlNZBaEOqn+XOq0V4E+HycnRqiXdRb395LqMXRV4H4j7?= =?us-ascii?Q?L15szjeE02rYM7bBxETUclpYf1qGuw0lhuOl4ntatoT/8FX5tm3B3VCOtxxq?= =?us-ascii?Q?bBd/4hZlvqYGb0QLS7BoalaoGGb8yg8HI1kFzni9Vhr/Z7LIOSeGfQOym3Ry?= =?us-ascii?Q?GDuz/UkuTw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 40dd690a-dc2e-46dc-e50c-08da41e771d6 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 May 2022 02:52:32.9349 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: s5tS3fkwkU5obf6iMjzgDweVAmNoHNwvwgyPqHrSVpDfRExvnQeAy5m+u1Wfnb6vL4VUsK6naMc8zeShI2t9dw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3734 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Wang, YuanX > Sent: Wednesday, May 18, 2022 9:37 PM > To: maxime.coquelin@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; Hu, Jiayu ; He, Xingguang > ; Wang, YuanX ; > stable@dpdk.org > Subject: [PATCH v2] examples/vhost: fix floating point exception when no > VMDq >=20 > If the VMDQ limits is 0, a divide-by-zero error occurs. > This patch replaces throwing a floating point exception with > a normal error message. >=20 > Fixes: d19533e86f ("examples/vhost: copy old vhost example") > Cc: stable@dpdk.org >=20 > Signed-off-by: Yuan Wang > --- > examples/vhost/main.c | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/examples/vhost/main.c b/examples/vhost/main.c > index c4d46de1c5..48d9f3802f 100644 > --- a/examples/vhost/main.c > +++ b/examples/vhost/main.c > @@ -400,6 +400,10 @@ port_init(uint16_t port) >=20 > return retval; > } > + if (dev_info.max_vmdq_pools =3D=3D 0) { > + RTE_LOG(ERR, VHOST_PORT, "Failed to get VMDQ info.\n"); > + return -1; > + } >=20 > rxconf =3D &dev_info.default_rxconf; > txconf =3D &dev_info.default_txconf; > -- > 2.25.1 Reviewed-by: Chenbo Xia