From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BCC6FA00C2; Thu, 3 Nov 2022 04:27:39 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4761540694; Thu, 3 Nov 2022 04:27:39 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 85F3A40693 for ; Thu, 3 Nov 2022 04:27:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667446056; x=1698982056; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=ywaSRINOVJSSUilxr9LmYjwPAWfCJj3JGOs/D+R29fY=; b=XgZqfdMUN45OSJMwUYq0hbEExR1VDe3Rh+0CudQYgJwju1R2nZ81fY8r 2/FgFrmZs9846TLhYBnjqwqgpGtG9ZHa+utrJUVEuSmdA2z4DqQ9qUR8x 439ZbZmEsD/b8NcRT5JvvUl6oyV1CjmRLaMGZT5/8bhvTW/6+LWFydKfa VMQq4+LCctfzDmPt38dj866AZq/ECQ4+/8ix6HEyONvg2+wNtEASyAtUt snq/qVBf4A/IRFVa5jJBS7vjtN7Uy5LYhgNwteb2RGFTp/oBpG1F6igtX V04R33pZsre2ip1fjJa28t3nS1H0lDkBdoYzXomkslOnueKP66I0i9Rao Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10519"; a="336265646" X-IronPort-AV: E=Sophos;i="5.95,235,1661842800"; d="scan'208";a="336265646" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2022 20:27:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10519"; a="740012390" X-IronPort-AV: E=Sophos;i="5.95,235,1661842800"; d="scan'208";a="740012390" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga002.fm.intel.com with ESMTP; 02 Nov 2022 20:27:34 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 2 Nov 2022 20:27:34 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 2 Nov 2022 20:27:33 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 2 Nov 2022 20:27:33 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.171) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 2 Nov 2022 20:27:33 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mn57HZ6AAli/QmQ1lR8WOBskqw+qfE/h2IPZ4tl4kOxJ5H7evtUeguoXzlHmssIzfMjrQhi5ONaP/9wLDp16gr1gbfSWjuaWkG29ayiAOtLIVTipvWhSmlAsePzGMi5s6rkLfTqpDmosMiU+NTh6Qh7wTAwf3sSBJ2UvxCB+gI46vReIV3uUC2KFEhI8K2d6ZKsoCTJqafdN4Oe4jjOU8BXNk3wTNx0EhAVTTUASGIde3wgdTg+ESPbJIWdDElgn8Aww4HPt9+PFxTZfPvEEE6vSlLuJ9vEZ+kNBi7BIy5E0pOMVt9wVvCXPHACoqfhNhxbnkAv8T8OgtFjTWi/YaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xgd+y5p7R1glGlp1BETsFAKbS/W1Y2oKG7la72sbFL8=; b=DDD84hYOH6b6Pifj08TYykpkTFrxiR2flIN28MySu9fWFNMtE7jkQr5oQldvlle1kr7x78qt+heUX8/kNw4UjNMI156YSYXGxeUHKwGBITpsH55qeQUTVdZUJtrdCcZWpQawoy1PBNJvCluiNM8MjICX2WffrMFXjKilVo0Q0JjZJUI/Un7TPZkNrpzH0cfBjWFL3Qe8PeG5S0pVnYOzOp11EzWuhTd2nDobBgTUACsv8lkgFn/1fITrHCjHdrS29n1TUNwJhxqIMiT/+ieuHhIvkSKK695/wCLGuWiPSptqELxnceYUtdtReBl8scWMi3o8Ic7Qgx05ojww6oqLug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by DM8PR11MB5637.namprd11.prod.outlook.com (2603:10b6:8:33::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Thu, 3 Nov 2022 03:27:29 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::3c6a:7a7c:129d:aecb]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::3c6a:7a7c:129d:aecb%4]) with mapi id 15.20.5791.022; Thu, 3 Nov 2022 03:27:29 +0000 From: "Xia, Chenbo" To: Hao Chen , "maxime.coquelin@redhat.com" CC: "dev@dpdk.org" , "houyl@yusur.tech" , "zy@yusur.tech" Subject: RE: [PATCH v2] vhost: enable CONFIG feature for vdpa Thread-Topic: [PATCH v2] vhost: enable CONFIG feature for vdpa Thread-Index: AQHY3Rz86TltLZe4iE2T5HygSkOVtK4sqtZg Date: Thu, 3 Nov 2022 03:27:29 +0000 Message-ID: References: <20221011025435.3769-1-chenh@yusur.tech> In-Reply-To: <20221011025435.3769-1-chenh@yusur.tech> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB3504:EE_|DM8PR11MB5637:EE_ x-ms-office365-filtering-correlation-id: b17999f5-6c4a-47b3-6b55-08dabd4b5627 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Sn0PI20mKUZG3sN2HdXcbeHgHzBn+azBX6MF/d0h2UvIUvzpn9//QsvgtBj35LRJZDDwDjpIhssjolkfWQdOujkrI7OZJk24ridwBKrKWu60eKcliyDHpnA3unyJpC/UV6PeDHvUeEaXbDh4exHevFsjaOMPFvCAixFaq49JJO3TRFt4IgJmvg0XDsUu8o6c4QnEOyiVyG+QPpEYsDq9zX+7fD+X4ejzP5DeIb8FF17ICfq98DuwYS+IzaqckADAdHHuQWS5mdDyD6lO9ACxonqXETGob34SwRHTx9gsZz1P7AHpqW3xUlOVtMC2SnYOJIhQrJ8dCAr1TC+QPmJ32oeSehhW7KxhEDtq1/ZgfJxxvekYKUAtnjC1omTDV0XUA+Bwi/U89j+5ow0XViTPlOcn36bNH3sBPiaYNmYSnCMd4vFHCeysNIDfazXHlO2/Oj00SSO5U2G2Bc9VS6dEdsd2keIgUGfrlJWJkaCg1vwHVz3N2sawsaOaBz39ZcJL7rwYk4BvqkTtVe52huz0YqPNMv6u+u8j/KgPOeeVdw1TOR4xG0aRdX56g3TnwMpGyF28dX1PlcsOMrggPgPHboG8opLN5nqNh/8yrmfOVyFCsGN6W/BpPDMCyGph842H3pU7xi68X8nT1rl1HL357W9FwC7tEcj7iATohtQX77oFa3l3VfjtGbg18N7s27gSPvX9Ru7Zh0Tx01iDQsLAWlIDFf69DbxM5C+pMS2aqx/mMHTCt9cfraKXz2oAGWbPyDzVFjyHEStK+KXilJBeZQEtkJs1biRL9p4LrmuUr/k= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(396003)(376002)(136003)(346002)(39860400002)(366004)(451199015)(52536014)(41300700001)(122000001)(38070700005)(82960400001)(64756008)(66446008)(66476007)(66556008)(66946007)(54906003)(8676002)(4326008)(76116006)(8936002)(316002)(5660300002)(86362001)(38100700002)(33656002)(966005)(71200400001)(478600001)(83380400001)(55016003)(53546011)(9686003)(26005)(6506007)(7696005)(186003)(2906002)(110136005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?fH4s/2sM7uC9xD9WedPh+YCuLNKWMflxJbTikUSfASiA2mpiouVS4Nqplpjc?= =?us-ascii?Q?2YwCKJ1RhIWv1hOoiOqiuwBGGr3MFsyZXgNP1rltaSMtH1ddXNoMSRNLa2Wd?= =?us-ascii?Q?CHpJv/6OR8QXuIhySwEAk8fnjNYmEY6/mD/JAkS1B9FVvk6E+LPZ3LTeZ8ho?= =?us-ascii?Q?mOnw6mxy8pCYVHhgmaSCYIbkGQ2BeJZe70PF0OLYfH7pTikKkTNqh3tl05N+?= =?us-ascii?Q?b/aj/qDwvGKBMH5OFava7fGuX7ZDoTxT5TLmEdgGInluP3ysHweYp5G9Hb4d?= =?us-ascii?Q?gXiqcbmP5AGK2gB1Nt7TlJmseQrofUcvH6cQ/u1XzY3I/goIIhgnmZEy7pj/?= =?us-ascii?Q?NGBUSBKdqvrbwD1+Bk9YHjdaEs8ztKhaw4Y4IqcczmIYnbtG895lK5CkHUg/?= =?us-ascii?Q?qSgwtBRoXWnGtYOzDJvqAylV4d+u73AxTqpXJrhko3pWCbkzJKGrXqoIszaN?= =?us-ascii?Q?H7JKNVcj3UkuB8sfTiAUR9Z4i3ilD6q7B+vHniAkXgah9a1VXYb/Wpe7Onu9?= =?us-ascii?Q?b03V8WhGJJgliZa5hJ+56cnBGpUA5lcT0/TMC182j21GiJlhMxOwkmlxD9Hm?= =?us-ascii?Q?dh4eGbkLO+sxg3Be1FTcOYc7Flj1Tg40+T4xSCMPgaxVfoliLRCF6P195Vmg?= =?us-ascii?Q?aM2KXnBZM2CUzP/p3gBYymYsByIyYMXuFa029NZ91vnHnQonvwTFKCflMW6Z?= =?us-ascii?Q?FUU8RCYiw0klGdQ5lNJwJPsUTjPZq/3rPAz2BD9WejyEdumDWNjwh8dOst2F?= =?us-ascii?Q?y8JBsgxz0czJOYoXHdX5MPL3UXkY2rjLXZFg3m6MTv7DAvVIzEais9+rgx7u?= =?us-ascii?Q?zybS3Zg5hJZBhGCQ1ZRzMemwQcLuTOavHXW8s8e6EWDqcCdjyVcaG/PTo3xi?= =?us-ascii?Q?Y10dZ1wnOcyPHxe8XS8gE2wf7CuF9IPCsLHTvLrX/TUb/AAPGG/TdP+KVSaa?= =?us-ascii?Q?Ij7wHbJa5zbuHAPHWzkkFNDRJI2hj+DtrKVQCs+kfTg/E9w/SVMk/eaFBsOc?= =?us-ascii?Q?NLSzAU3TFIJ3rqracc/12qOxbDfLmI+hNayV/+boylUEEYF9NUeu9uhnr0YB?= =?us-ascii?Q?U8m/pyJpMUQiSQSbN0O9gcquf3V5gbPeYrFuxr9YGfSrFcBhl54zgRTAUVCR?= =?us-ascii?Q?DneOfhhQb6vTVKN1n+aZjDgcShimiNhBEAvKj5iurjRnUkDQmP9O/50UPBn2?= =?us-ascii?Q?dJ+OGPNArCN41Ast3P/KiPzf3nwNIJ1m45x8sf0DAcoPxHSTrEMmYzVUSy1Q?= =?us-ascii?Q?xBaj81LFrv6gr13sa5ykOqDlMx1D8BmQGjyo2Pa6DZVZhi2mxfjebYp7RQMm?= =?us-ascii?Q?3totR0Iqvp9FoX4Cp/bAQ3IJtlCmAfMEdjwJTzv7Sgjj1DIFcj5jaSrMGo8m?= =?us-ascii?Q?8LkBcPfq51tcaDZu8YVqPL6bLOShS2Cuq2I/xD5jI73xWB8TRW6Y9vMKI1+G?= =?us-ascii?Q?6IIocBpIFzccirdBIxsP+qagcQwRmUYUGJy/xjsxrPecVnGEY9anW2Wefi2g?= =?us-ascii?Q?nbDrZ29P1aF6XMvxcNIYBLQPorYQc6nlztgrYM29u+Px1zwpRENIyhQAEmYY?= =?us-ascii?Q?dpb4VE4x+yG4c8LyPnQnwnKBQsoOcwzJuujEq+cM?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b17999f5-6c4a-47b3-6b55-08dabd4b5627 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Nov 2022 03:27:29.1654 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: b2a4AiCTvSmsmBE8oATca6VbXhvmtYdb2vt+1A/pYebheMptKPi9amvsnukLjbOBPD/lh1ndBTgtJ8QVwB095Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5637 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Hao Chen > Sent: Tuesday, October 11, 2022 10:55 AM > To: maxime.coquelin@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; houyl@yusur.tech; zy@yusur.tech > Subject: [PATCH v2] vhost: enable CONFIG feature for vdpa >=20 > Enable this feature, so that libvirt or qemu can call vdpa vendor > driver's ops '.get_config' through 'vhost_net_get_config' to get > the mac address of the vdpa hardware without manual configuration. >=20 > v1->v2: > Move VHOST_USER_PROTOCOL_F_CONFIG from VHOST_USER_PROTOCOL_FEATURES > to function 'rte_vhost_driver_get_protocol_features'. Don't add above version info to commit log. Refer to below link about where to add the info. =20 http://patchwork.dpdk.org/project/dpdk/patch/20221102111713.507-1-anoobj@ma= rvell.com/ >=20 > Signed-off-by: Hao Chen > --- > lib/vhost/socket.c | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/lib/vhost/socket.c b/lib/vhost/socket.c > index a8df2d484a..df8f26a5bd 100644 > --- a/lib/vhost/socket.c > +++ b/lib/vhost/socket.c > @@ -808,6 +808,10 @@ rte_vhost_driver_get_protocol_features(const char > *path, > *protocol_features =3D vsocket->protocol_features > & vdpa_protocol_features; >=20 > + /* Get the unique features of vdpa */ > + if (vdpa_protocol_features & (1ULL << VHOST_USER_PROTOCOL_F_CONFIG)) > + *protocol_features |=3D (1ULL << VHOST_USER_PROTOCOL_F_CONFIG); > + This makes think about what should 'vsocket->protocol_features' mean. If we do like above, for every new protocol feature that some vdpa device c= an support but built-in vhost-net can't support, such logic is needed. Maybe we should define something like base protocol features that vhost lib supports and some features for backend-specific. So for vdpa case, just do 'base_feature | vdpa_protocol_features'. In current VHOST_USER_PROTOCOL_FEATURES, some are general feature that vhos= t lib supports, but some seems not (like VHOST_USER_PROTOCOL_F_CRYPTO_SESSION). @Maxime, what do you think? Thanks, Chenbo > unlock_exit: > pthread_mutex_unlock(&vhost_user.mutex); > return ret; > -- > 2.34.1