From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7392F42BCC; Mon, 29 May 2023 08:33:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 64412427F2; Mon, 29 May 2023 08:33:16 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 9BDD94161A for ; Mon, 29 May 2023 08:33:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1685341994; x=1716877994; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=qnFo5P1CPBRtJ89Gio9QjKsmm0+TRhnfvqA+SgEJFzQ=; b=m3BzjAp8GS5LBK/WHWG1NcJJUXzEjDFpfrSylLGTA3eYnfmoxamx03+E V2jbb3VBBeHp6sX9qsMsEOZCuxNUmnnNMnu2RI4YrVZa5qngYADON1Lpc q+1kAlDfBdBRBZOhpkCp0Bv3RI5O0ev0hWdJJNO09GRX8Vvab8ADYt0jz WhA7+qemshdtLRszQiSUDwlwF+6swHrtQLq3SlOscuf+0N3otcu3mDxw1 dJkGyHRaY/UqlxVz8Pj9VaV6u1m3VISSfGupGtc5YpWwhyVOXqNaV0+Na nmx4DI1Id+6oFywRgerTnNc8Tx2647wcxzJH97MOjJ0SPRnVdQbOpyPi1 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10724"; a="382887643" X-IronPort-AV: E=Sophos;i="6.00,200,1681196400"; d="scan'208";a="382887643" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 May 2023 23:33:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10724"; a="880255072" X-IronPort-AV: E=Sophos;i="6.00,200,1681196400"; d="scan'208";a="880255072" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga005.jf.intel.com with ESMTP; 28 May 2023 23:33:11 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Sun, 28 May 2023 23:33:10 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Sun, 28 May 2023 23:33:09 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Sun, 28 May 2023 23:33:09 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.176) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Sun, 28 May 2023 23:33:09 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NU0Goon7g9pj/9MoMM6gMU8mv+DbMm/FDGv/4DnfQdbYTJCl/1UgaMLGUyYuX/WXk/RGnP/xhyhs3gt5uTKpvvwgDoWk3W4WenmjPV1JOQrVY47oXvNxhN687euFTRfBPsRL2mAwVJEfXnHqEFH3wTIyugpEb1BdHCfN+AMgHChqQxcFjIeGzUDHBwNybgZR4+xTA06+H5mfoNVcFyfx7EFEsYmcNwyuAQbPfkYEyKPjJ5acKu7uhVa2AA+ipkd4HVClA8n3nsXe03Yrxy+O4hP6NzDehpP8L2DxMngEBhCWpZz6KsAzqndcijlEqb1iw6tU1IpCLm8BZnzGi+PYww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JqQRFVj2sZHWfPlWcFUMgZxtgTEt1Po/HNYr25N90ho=; b=BLXHDlyKFrJpiYHuRxcr37WGlYjmFcFK81RbO+byEkSiVhS8eDLb0yoaQXzdALsuYFg33XG8yiLQqUTHwI44IKc0WGetLTSdLhhuzRDbvEr9rFxgs07UrNJW6xuW03+ctJu8yhKfXxxDmgXKk+EdFp8aWTmO6A3+klDWrOVARfu6o/9L5eEIasx3Xn+zm58dyf9tK/CWf5hnimUgn9l+c+lTLYEO55oWkg7AYOqibYD1Vft8uRev/AaTP4NGIsr9jGHmtWnzFYe1CDRDUOFuliJiwRAWkkR0d418yUmq9ZjPYU/tJiDQ8hwYFtQZfVKiGu2uL9NQU9qNg+1Xytv1WQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN6PR11MB3504.namprd11.prod.outlook.com (2603:10b6:805:d0::17) by SJ0PR11MB4816.namprd11.prod.outlook.com (2603:10b6:a03:2ad::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.22; Mon, 29 May 2023 06:33:06 +0000 Received: from SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::e427:f0a6:8472:d0f6]) by SN6PR11MB3504.namprd11.prod.outlook.com ([fe80::e427:f0a6:8472:d0f6%7]) with mapi id 15.20.6433.020; Mon, 29 May 2023 06:33:06 +0000 From: "Xia, Chenbo" To: Maxime Coquelin , "dev@dpdk.org" , "david.marchand@redhat.com" , "mkp@redhat.com" , "fbl@redhat.com" , "jasowang@redhat.com" , "Liang, Cunming" , "Xie, Yongji" , "echaudro@redhat.com" , "eperezma@redhat.com" , "amorenoz@redhat.com" , "lulu@redhat.com" Subject: RE: [PATCH v3 12/28] vhost: add IOTLB cache entry removal callback Thread-Topic: [PATCH v3 12/28] vhost: add IOTLB cache entry removal callback Thread-Index: AQHZjyW9DDotbq6gZEaa9HmOEbOZWa9w0HRQ Date: Mon, 29 May 2023 06:33:06 +0000 Message-ID: References: <20230525162551.70359-1-maxime.coquelin@redhat.com> <20230525162551.70359-13-maxime.coquelin@redhat.com> In-Reply-To: <20230525162551.70359-13-maxime.coquelin@redhat.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR11MB3504:EE_|SJ0PR11MB4816:EE_ x-ms-office365-filtering-correlation-id: cf73dee5-a192-4640-b157-08db600e8fce x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5+ujFNB5ydsOUzmLCSPgAJZGxnbkvIbFtgWIylizgGZs1tH3khhcuVvqVXAFyoVPy2C27Xx8AbqYEckWddNY+ab4oRNqGJFcwPgbCo7+C1gMbhbMT33u/yc7hScmKO3JRPr91iCjUUel6bxmaZCrJUZ0MP6x4mcq7XPWO3rXIiypRUQTHStL+ppFCu7UKSzMaoltAqw075aVoWol8JoO2jyvvp0oqvY45lQuCFZR/hEagZj32B+i1/yOT0SPqkQ6VVdmo9WolJnE2T+B5ZrqICrfcHiLfh0lyViI8pSBx+VySgDOPpvj7uT/nhBxl9WMC7LEPP9UIEBedL8aHW8Ri9CR/EKTt/9IhQclkB86K2q4h8E9XcX8pRFHgb43G3haVsx4bqHlboZre3lIH2Uk3IT8lLLACC1Cb8YspvNsv0fXh7vwSmvXVDbA+536+FDZiecG3c6mCNvJPgQDM9o6SyR2m0WCfzGx4lJ1NbJ9vCUUgCeivp2xPIDqO3fOWuycTKwdhr+P4A/c2RPVLzY+/CEnVb1lSkHhIQIyBPc9Fb5qw3SyuvE3uet11YShoyNFFeYviBSl3U07kmfzxYTEMDDphabc8tLicCa4H6MN9pbrWAfHaRTY4xtGSpDpk7CJY98WiB9YpnjGM+DNBvjaiA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3504.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(366004)(396003)(136003)(39860400002)(346002)(376002)(451199021)(26005)(7696005)(53546011)(9686003)(71200400001)(6506007)(2906002)(316002)(33656002)(186003)(55016003)(52536014)(5660300002)(41300700001)(7416002)(8676002)(8936002)(478600001)(921005)(82960400001)(122000001)(38100700002)(86362001)(110136005)(76116006)(66946007)(38070700005)(66476007)(66556008)(83380400001)(64756008)(66446008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?U/jstjBm6Eh43tD/EdIXqCwFc+zB+0Swvi883ia1ZFdOO4/sdnJbjFE7cDVT?= =?us-ascii?Q?m4/Kpd9zvZqtfGm+brg5M7OURFzkDMWEt7QFqmlGh/E6kM8TXEb9/5y/iNWP?= =?us-ascii?Q?0qIkd4xkMowm6Z/skH6H/HBSppJfyoXqbLOi4f2ZFXdmWYXnykJsCBYYhAGt?= =?us-ascii?Q?f6t8v7g2Qkopl3lmFUr9ET021Ns3B8oSFtrQH4o/yv6tflQA++yA5SLJV2yl?= =?us-ascii?Q?2CfIxhjPGlVGF1HKuYowFlFqlHzngkE+6tO5EryvVeeqsVRHv5Yo6vBV7Dey?= =?us-ascii?Q?fmAk1NiB1s2sGou2uUJRiPT4lQ98rpo55ubfBWncveSDF6SnM40/hMnavIOK?= =?us-ascii?Q?0e2OSKC9Pobl3XJ3uq4PeLdKMAGfph74XTq0QcailrCs0iBn1wv3IyDEN+rz?= =?us-ascii?Q?rimSiTBEpvLackgIoy+lNtL9LU0/Q0p2ANPnNlCgGU7kwGxU7di4rH5b+/ET?= =?us-ascii?Q?RwlqohtKzK3JZd8aNZtREIDj83WvzrJbgqNVzn6Gwljyvpslt3mkq6/XQvmk?= =?us-ascii?Q?htJz76Db719lHb9RQ6igUi7Lxn2PgVUj6SPnLdK98ej4MymD5MoIUuS2qUrx?= =?us-ascii?Q?+SBMm3H49ASw95lJZoylB3MrYa90n5v/TKV0Iof1ZQFLpLadFLE3oVxAQSJ3?= =?us-ascii?Q?8Iv14+Hmafj7Pp5u1cfWusxeEW0LYVo8YdZApB2+4r3Mw24cMJEhIParDkN5?= =?us-ascii?Q?r+CzRHPedD9uulmTlYt0K6iyX0oIu5WM6bv256spvr9CX5QvwaBoxdW5TRcR?= =?us-ascii?Q?bAhr6e+MkxfWacrELez+/IBZEXz5jXqMs6mH/v9liRziLJTt+gmXaZVT2Yz3?= =?us-ascii?Q?2TLHkxOD6Js7sivJUrtWslsvyN9J/IDeaUCFww/VLAJgSTfwTEb2Y6icE2bS?= =?us-ascii?Q?PUaPmdTXmi/fYYwau3RlO+qNVFqA8guShSoeNm8KtzC3PzBnov4D7C+PGA7p?= =?us-ascii?Q?86AEudVum0i/ZGHuLKQBXCgT8vry4seGxORQeKwCRZhH2z5R/HDJwr9zXA/s?= =?us-ascii?Q?J9FC2h/tOIcjw23GolyO7ygm/CsZjxAvQhl/ZPSjmKVNKrLZPHKosrF3iSHj?= =?us-ascii?Q?gzKO9rcIJSCBPxjTlkwRVj5h2PS5JG3YR4mNgobXPlvqcp35Jfd2E8b0ha/k?= =?us-ascii?Q?uva66X0COLbsMS94+x8ynR57njcu7iwWDapDtWqWC8mAxIxTlCI1GMUwPN60?= =?us-ascii?Q?s7vl6eKyymbUKUGQmSgz9fpt8NNmX7mcopFYP1/bU0d2PPBAjwskmrVkCLeu?= =?us-ascii?Q?QaAtvlkDVf+Kv96uOa67xVlcKOcSgmc3pwKfTcqlqQpqLo1PMh0cHABTRIye?= =?us-ascii?Q?XvuDYv0xa6NzcKy0GGZjDlEe7mUAQLixDnCB6+GLpyXS5F4+IOgYSWZgYCbI?= =?us-ascii?Q?dv1/nwnA7GkPNEYisxgFbO+T0JWQJMoetjeBfZheeVcYW9zSRz8p2ZSXaPv4?= =?us-ascii?Q?IRdtKKxX8nKOPUT3JYfEtuz1cAE5K87Q5+neT/DXgf/kndxx2/hs059uYz7h?= =?us-ascii?Q?lW3RRlJkt0ux6vsFrMIyIsHTnQb8rZMSK/HxQ+ligkuOa/DYFwe0xtQaSAQP?= =?us-ascii?Q?O78+2ZeC4hIpOMfQCfE+q8xSPJshr1GbMRyukN1x?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3504.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cf73dee5-a192-4640-b157-08db600e8fce X-MS-Exchange-CrossTenant-originalarrivaltime: 29 May 2023 06:33:06.1002 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: M8UNguMHKvwXeeAtLYWdam3z2zzMTbpTuGC7XzBjcM6v7IKzr9linm01ypndthKRt3Tv0O2jSR3TBJpk647gZQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4816 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Maxime Coquelin > Sent: Friday, May 26, 2023 12:26 AM > To: dev@dpdk.org; Xia, Chenbo ; > david.marchand@redhat.com; mkp@redhat.com; fbl@redhat.com; > jasowang@redhat.com; Liang, Cunming ; Xie, Yongj= i > ; echaudro@redhat.com; eperezma@redhat.com; > amorenoz@redhat.com; lulu@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH v3 12/28] vhost: add IOTLB cache entry removal callback >=20 > VDUSE will need to munmap() the IOTLB entry on removal > from the cache, as it performs mmap() before insertion. >=20 > This patch introduces a callback that VDUSE layer will > implement to achieve this. >=20 > Signed-off-by: Maxime Coquelin > --- > lib/vhost/iotlb.c | 12 ++++++++++++ > lib/vhost/vhost.h | 3 +++ > 2 files changed, 15 insertions(+) >=20 > diff --git a/lib/vhost/iotlb.c b/lib/vhost/iotlb.c > index a23008909f..6dca0ba7d0 100644 > --- a/lib/vhost/iotlb.c > +++ b/lib/vhost/iotlb.c > @@ -25,6 +25,15 @@ struct vhost_iotlb_entry { >=20 > #define IOTLB_CACHE_SIZE 2048 >=20 > +static void > +vhost_user_iotlb_remove_notify(struct virtio_net *dev, struct > vhost_iotlb_entry *entry) > +{ > + if (dev->backend_ops->iotlb_remove_notify =3D=3D NULL) > + return; > + > + dev->backend_ops->iotlb_remove_notify(entry->uaddr, entry->uoffset, > entry->size); > +} > + > static bool > vhost_user_iotlb_share_page(struct vhost_iotlb_entry *a, struct > vhost_iotlb_entry *b) > { > @@ -198,6 +207,7 @@ vhost_user_iotlb_cache_remove_all(struct virtio_net > *dev) > vhost_user_iotlb_set_dump(node); >=20 > TAILQ_REMOVE(&dev->iotlb_list, node, next); > + vhost_user_iotlb_remove_notify(dev, node); > vhost_user_iotlb_pool_put(dev, node); > } >=20 > @@ -223,6 +233,7 @@ vhost_user_iotlb_cache_random_evict(struct virtio_net > *dev) > vhost_user_iotlb_clear_dump(node, prev_node, next_node); >=20 > TAILQ_REMOVE(&dev->iotlb_list, node, next); > + vhost_user_iotlb_remove_notify(dev, node); > vhost_user_iotlb_pool_put(dev, node); > dev->iotlb_cache_nr--; > break; > @@ -314,6 +325,7 @@ vhost_user_iotlb_cache_remove(struct virtio_net *dev, > uint64_t iova, uint64_t si > vhost_user_iotlb_clear_dump(node, prev_node, next_node); >=20 > TAILQ_REMOVE(&dev->iotlb_list, node, next); > + vhost_user_iotlb_remove_notify(dev, node); > vhost_user_iotlb_pool_put(dev, node); > dev->iotlb_cache_nr--; > } else { > diff --git a/lib/vhost/vhost.h b/lib/vhost/vhost.h > index cc5c707205..f37e0b83b8 100644 > --- a/lib/vhost/vhost.h > +++ b/lib/vhost/vhost.h > @@ -89,10 +89,13 @@ > for (iter =3D val; iter < num; iter++) > #endif >=20 > +typedef void (*vhost_iotlb_remove_notify)(uint64_t addr, uint64_t off, > uint64_t size); > + > /** > * Structure that contains backend-specific ops. > */ > struct vhost_backend_ops { > + vhost_iotlb_remove_notify iotlb_remove_notify; > }; >=20 > /** > -- > 2.40.1 Reviewed-by: Chenbo Xia =20