From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BAB5CA0C4B; Tue, 9 Nov 2021 10:35:58 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5430B40E03; Tue, 9 Nov 2021 10:35:58 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2083.outbound.protection.outlook.com [40.107.223.83]) by mails.dpdk.org (Postfix) with ESMTP id 27A6F4068B for ; Tue, 9 Nov 2021 10:35:56 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RQ7Hs8Nvsg6F9/y/Nm9Itv1I+xGZbgzHPxv+cJIhNDRQqL/b9X79iWM7pS/S4VIbL1yv0Rqs1UmBgznCmcsZgBYkei6ntR4Hjopz9N4ZLvAJcjEJ56aafc0tqOS8Nq7HgfagbMMeAe8vAGAw8BgJYns+KBSTgxtc7UPN/RTNNjYaFKUWpxUtZnIhKF/ftIcNnXrRxFnl30GdgMP9e20FZD3+QB+Apbmy8xiu3oiSzFN0rNoUiRsaVUJF8QCPfLmfKF8Kw2NA9+YsciJJSPRPRJK3vUtGaKZ+ysyjSS+LVw4eIID4WcMLFiLmGqSU4dKRShrnth6HwoSOjSFturjnpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w6mLCiNwUSodx9jy3rZwhzllxbSz8Uazlpe58UAjM9Y=; b=IAOp6bl3DcLEgyI+mlINYx32S9Wu8GUmUGqpHwn1Hfzq75nap8EpJSsHTy5mvUrOgHnNVYVLGy1xu2+O0vrPBO0nGKp1yTNgs7fueDavKY6V1r/CVFoCqtnxJu9h79KsiBxZUN1czvbCoR4b21GKjyXuewbliSGe/Uxf2LCPPjDXupmDZk3s9B4HhDXkvkGvVeaXUwjL5HmeXlV5rwCNI05ozCsGPCoTDqCn5+PXjxuy78ItV1NxE1v6/gaCylrkX2O85iGuLZVV0EKU48r2N8C+oA8KXKwchUMK0YsEnW5sBNd3rGVy/VgL09u7E+vs0lrXgrkLrjcTram+7hHISw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w6mLCiNwUSodx9jy3rZwhzllxbSz8Uazlpe58UAjM9Y=; b=WXXuIBlW62gd6e+qVR/pfjvzwB7FAoPWRR4vEIXr1uH4gd1MciSgRNtb8ISUPUsj3k2pQOhREvVhnjCrh02/smE0m33wQZBvbtLrUNJd8Q5pX7OejCzrd2k+t7fRW9ZJUkhQZsMXm/Dbd4t/T3HESlN/CJAs3iXvi2JPIKHcjPO0Z8Th9EZ/dO8dyOFT0iIKL+654pKgo0fuXuOI79cMbfVvhQd7bx0SEC6LxiKMrdaL0CYSmWINRTPdS79CDI+RTrVbHAH6zoCSclaFtdHn3n/FFLC6rNv4zBuzvyz4qALKgSwcNNwpxv8fXNP1A3g3GSEIXXgsjPcfCRYdFNXqMA== Received: from SN6PR12MB2639.namprd12.prod.outlook.com (2603:10b6:805:75::25) by SN6PR12MB4669.namprd12.prod.outlook.com (2603:10b6:805:7::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11; Tue, 9 Nov 2021 09:35:54 +0000 Received: from SN6PR12MB2639.namprd12.prod.outlook.com ([fe80::c515:6248:cd3d:1094]) by SN6PR12MB2639.namprd12.prod.outlook.com ([fe80::c515:6248:cd3d:1094%7]) with mapi id 15.20.4669.016; Tue, 9 Nov 2021 09:35:53 +0000 From: Gregory Etelson To: NBU-Contact-Thomas Monjalon CC: "Burakov, Anatoly" , "dev@dpdk.org" , Matan Azrad , Raslan Darawsheh , Dmitry Kozlyuk Thread-Topic: [dpdk-dev] [PATCH] examples/multi_process: fix RX packets distribution Thread-Index: AQHXyk8JsjIn7aZOIUmIGAqzqKs04Kvoe/GAgAAGE/CAAAxLgIARq9IAgACYBLCAABCjAIAAIoQw Date: Tue, 9 Nov 2021 09:35:53 +0000 Message-ID: References: <20211026095037.17557-1-getelson@nvidia.com> <1880770.nP2jOJxqqx@thomas> <2000101.8nMyBBQigM@thomas> In-Reply-To: <2000101.8nMyBBQigM@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ad657984-e12a-4729-ca2f-08d9a364534f x-ms-traffictypediagnostic: SN6PR12MB4669: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GWZgMz7PyVSnllVqFOoYp7/X6XIhJDdUbJWqHt5ezysBQrCdOpwv15ZPLFz5ILv4oGZZh24YfxaOJGmXqRf6gAyMw6Pod9jUrTO+79CplEUUMy77jrhmPdpe3YIb1/FuiaRFzazvadM574O90926sgb5fjpFEI2H2eghvn2qgDAE4fxO/hEgsmz1v8/QltIwSPvOz4pK0Yo1XGIV/SGqqjN6HrOrSdwG6jrGgyAlwODNoo97KbmYKpnSnE+9/lCAyts3bhwMKboRLd6e6N9tqDE2cq6pYaYOU9Fpo5Qs2SryTT9OJgUBNlJYPPgIHe5UBqWFW5aeh4TCfyvGbKblxYyLmIWW47GussBIkHXzu/GXTB2fr3n90EgHXzoZ93kXyAszViU96jh7Bx5ELp6O4GSWuIQwIykhJU4b8WMHnajZffqul/eWx/MwSr4TXpvczk2Mv6xXzCPFStPwzmWqoWkC+XsgrS/tG0/ISXVQTJGe1UHUflyUQOm2VYCoOr84J5jnx6MD62o6GRt9vcvhCFNWbduIrb7uXC7ADp3YRi2l8441pzsjItLVZud9ZBO35FQsP3TbilmgnjCrtqabSuAV0d44BXA+FGV2/8M6M/Qbk11n0+aAVla+uEj29JRGqroBw1gH2RZ+fh5m+/kn4W0ym0Dj3nBCaLoXhf+UOUlxxQyIzFtkwZCwo+4FIyHnEkgMkq6RUlgVRqgifehgYg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR12MB2639.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(64756008)(107886003)(54906003)(4326008)(38070700005)(8936002)(66476007)(5660300002)(2906002)(7696005)(66946007)(6506007)(66446008)(186003)(26005)(76116006)(52536014)(53546011)(33656002)(66556008)(9686003)(122000001)(4744005)(508600001)(6916009)(71200400001)(55016002)(83380400001)(316002)(38100700002)(8676002)(86362001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?cVkAyRapVc152JtppGBrYzQSos/O/hVEtzBqHllCRMp0SwymiuNL/y+nDQLk?= =?us-ascii?Q?BCz1JbL5NkaaM+M3r0VPNMmXRX8cW7Pp0uJqJphqDTUzQFZtud+0aYuFKE7q?= =?us-ascii?Q?HwpuXolwNI3nRwwVjg+Pzj8EFhjA4vj3/tGAdYg9ammj0MT2pTe0hwTsRt/3?= =?us-ascii?Q?NmsaW1hsu8ZRvEGnsKq1xJdkD9dQIWcXlR/07LmGxkC/rOSc9t1OhKq+g+Ca?= =?us-ascii?Q?4plo6qMwsllXDygz4QEllcHOB1vVdkiM75EywgLkU+2mAWSLlSuigVHMXBAc?= =?us-ascii?Q?mDD8ithcgR6ADvBwkp0IZsyneLjgXpzFnbZBeyW5x27fr0TqLwNfxkz8kRWz?= =?us-ascii?Q?WBiuzWD/5W+8L6Ph4op8rn+QrDwsxp3dIhvAKS3iftuaDLNg0AUgNqve41ov?= =?us-ascii?Q?hB8Nl0w5XZFhwz5Y+Xvh9giZUpG+sGWdojfcEKtCe3B2NfHsTSvBnr/JP3QI?= =?us-ascii?Q?BBPZd6RxZQ1Gr45GZAsG/kTkjx51WVm+XrUdMR2/WO4emXe14Rpd8gG0wvun?= =?us-ascii?Q?H4k6Dg6O63qwOBm3pcsILN+Ctzgk2fRZYWfssPE2sRkYLcEASkBa7t85KlK6?= =?us-ascii?Q?228Wl5GHt69AJrIY6Qe1W8p2yrZoGufQHcfSgD4gk0ezvuFcj06/0ww+qkjY?= =?us-ascii?Q?gLCW0zPI90QI/n3qBimvb0lHu9nZ1SIlbxl+FOHaqBP/WqxqU3affcOEySHh?= =?us-ascii?Q?d5ruRixf2IkgWYwSS2RROTCxCHVHdFOushmvoAxNkkpR5HoW0MSLqZcj7wrJ?= =?us-ascii?Q?2vLahpykl0MTGlOAID4PQKh1/aOhPmxz45NhBRWm8UunA6MS8/WiqqSnQLnU?= =?us-ascii?Q?emDGIa925ZO1LYqUChZvR9zCwIhV8BCDyMCYzcB4RLkqu/VStIb6gR+BY+KE?= =?us-ascii?Q?7qxVNMfRdAUn524MzeynQ4qPrRdZ7ut0AWL7qMQeoSVS4Xuy63BON4SHCDai?= =?us-ascii?Q?AdJxynim1u29Pq64G2dWrOPXhOHOc5cvgrzZjP1+2Hz8LLzWyqmHn1GX9IkV?= =?us-ascii?Q?WgwUidRkwpIACFWqvIOI0XTu3aG3PnICbFjr2baj+k6ud1n8XwevTTD/cNJK?= =?us-ascii?Q?Jr1X+PoaWuVibkyw0YJHjPS72mS8OWtS1I6Q4QOZZZ01XozdjyhGvb3GyKVW?= =?us-ascii?Q?QymLSwe94v6ChcH3UwufVmJoc1YlshGVPH2neg5p6yYs+a5DnwrUwNzA/fin?= =?us-ascii?Q?wfu37HMvmQXyg7RePfp6XWnisIyJp+vbaLjxa49ogzQ+yvGpdJja7/osq1+3?= =?us-ascii?Q?ukWNp2bwOjkQYw59O4rbrJ329DcAutBVIUSese1Eg3MSQr8YB8Jfj+atYNdG?= =?us-ascii?Q?G4e2qAhP4TrwiQy9T0QO7X464PguDw/FaVgrLcbFd4fh9GDXO2IfDvcF0N2W?= =?us-ascii?Q?TdcbSA91jOe/t6Ovt4zkabjIpffw6WyT71Egtru2Mf5RpCFalNWDFf+NOyNN?= =?us-ascii?Q?HLgZYCJ+Trv71FTblg4acBoahJU+bqC29JrELqCs9VaXBo8FwvbvaEnKfrZu?= =?us-ascii?Q?2K0qP6UnSToHKpUpNlzU/+PPzkCRg/ZwW7n+GYqIvdkJDnj5vjIIt6CSyw+l?= =?us-ascii?Q?EfvPez/ycbMSIyWFlwaZlHk8uT8bUIMVUEyzcv/G7lbSqzM2A/uW3C43JLla?= =?us-ascii?Q?XXbJz3+S5Yfdwtg6aSN0m3Q=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2639.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ad657984-e12a-4729-ca2f-08d9a364534f X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Nov 2021 09:35:53.8452 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WmqVbup8Tf/AaxN1VSatGNgbFIK0pk9yaq0ZX01+ssOdb+tnlYD7FWn/BrAx3cfpw+kI5Sjrz5FUKDMlFh9uFA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR12MB4669 Subject: Re: [dpdk-dev] [PATCH] examples/multi_process: fix RX packets distribution X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello Thomas, > > > 28/10/2021 17:35, Burakov, Anatoly: > > > > On 28-Oct-21 4:14 PM, Gregory Etelson > wrote: > > > > >>> - uint8_t client =3D 0; > > > > >>> + static uint8_t client =3D 0; > > > > > > > > Acked-by: Anatoly Burakov > > > > > > > > > checkpatch has a message for you: > > > ERROR:INITIALISED_STATIC: do not initialise > > > statics to 0 > > > > > > > Turning the `client` variable to static ensured > that the next time > > the function will be called it will proceed > iterating clients instead of > > starting a loop from the beginning - that's the > main idea of that patch. > > The variable must be initialized to 0 because > the application model > > requires at least a single client with index 0. > > ANSI C allows static variables initialization to > any valid value. > > Do you know why the checkpatch utility denied > such initialization ? >=20 > ANSI C makes static variables iniatilized to 0 by > default. >=20 I'll post updated patch Regards, Gregory