From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9035E45B68; Fri, 18 Oct 2024 11:26:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7F5EC40279; Fri, 18 Oct 2024 11:26:16 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) by mails.dpdk.org (Postfix) with ESMTP id F21594025F for ; Fri, 18 Oct 2024 11:26:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1729243575; x=1760779575; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=BCwieLgUrw368oM/omJHxALsiYXscBlyXe6a9zfgBtI=; b=lSr6c3zsBlOLID4otD3HuxEJHFfchLoxtSqjayaQ63QmsjJA/xVmrwe3 svzOaTvyNkrNJEZtLC0KBMfh7aLgbtIAm8esrKueq4uSg8+rnaRgciM/g 2YG3y3PEKvPvdgaZHMg6eHR++WHv1MfBS/2TSvjgKxrasLoYu7SFxg/Us O8NLpb0su0bFfYtuxq3EGLH2oJUvzgxwe/e7RYbfDe9GE0AUgFjNhxlmC sGlzcv/4C0j5QDXK+/r5GxVi+fSi2Ikkw4RxSOv0Am7vdV2RfIIZAE2VG 3Qkx9ui9Nu/A5SxlE2btnPT+JBfVeQui5Zwx8QDOFVe3Qz38l6/g2g3Li A==; X-CSE-ConnectionGUID: aUq44gIgRtCdnlQU9pEq1w== X-CSE-MsgGUID: /uE3pYVASWSueUy86HRrKw== X-IronPort-AV: E=McAfee;i="6700,10204,11222"; a="28871124" X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208,217";a="28871124" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2024 02:26:14 -0700 X-CSE-ConnectionGUID: 24i9MDK8RcG+HL6rB2wVmA== X-CSE-MsgGUID: wcxMRe9jTJ6yXZ41rvwaCA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,213,1725346800"; d="scan'208,217";a="83454555" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmviesa004.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 18 Oct 2024 02:26:14 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 18 Oct 2024 02:26:13 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 18 Oct 2024 02:26:13 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 18 Oct 2024 02:26:13 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xUe0xgwVqH1xDcCnMHqahVBqBJElb9rYUKXHHn1i1eH8X6I6IL4yuryitxGVT8hGaELahn9NFrYuv0JSwJtMxWz/TMIzLnuMz0IvRjJkJghJt++9AzUdldbMKEttz4+lszcyZ2OIFpNfDuFZR0LXl1c7NAi7CEP2EILJGmEK7vMxqSmMKYAaBAF9DrkdhFsnh3oSDy81BGIc9MwVkBXSd3T/k+415eTrmMgc7ZuCfivcFqScVqd+xOppoRSkC+YOl2/OusCjLOn9CsniWYspfZmW1IyryOQCXqnGoJqNQ6EePbx5pNkS76gkP2+QqgCgN27yFAeu7DrJLWCtO/zIjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lM9S2HzyBAvd0LdldzyXEz98F0O+CMdK3Z1k3llovPk=; b=kKh4oCBxDsetWn5pZX/VjMnIdKdVFnp+D5iiRgDkyVVnT9iFS2/XXajBzYdleRqdkGqa5LuKUc5WqcqqgoGqNmz4BuVMuhBKaNE6CCEE1IFmTYAuikWUth/51Rk3100fePRacJexfu/k19XhTjvJCPpGp+xfNBUPw0y4QvQpw9mia/Jb4coPSpMNaObSeo6IdeQ87mPv9KhvSMb1DvrtOAjwh9BhDpwXNJlzHSRQIeZS3XuFZbiqfAOuLDmeiq/sSzMXezMYfFKUP+yibqAnNRoBX1Hljq1FOOUcZeTZQ4VS82xQxZd9kqzAgWZRUOgvEOtlx5hLom9G58J75s1Zkw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN7PR11MB6725.namprd11.prod.outlook.com (2603:10b6:806:267::18) by MW4PR11MB7104.namprd11.prod.outlook.com (2603:10b6:303:22e::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8069.18; Fri, 18 Oct 2024 09:26:05 +0000 Received: from SN7PR11MB6725.namprd11.prod.outlook.com ([fe80::da01:fd51:d6ef:551]) by SN7PR11MB6725.namprd11.prod.outlook.com ([fe80::da01:fd51:d6ef:551%4]) with mapi id 15.20.8048.029; Fri, 18 Oct 2024 09:26:05 +0000 From: "Meade, Niall" To: Thomas Monjalon CC: "dev@dpdk.org" , Stephen Hemminger , "Wang, Yipeng1" , "Gobriel, Sameh" , "Richardson, Bruce" , "Medvedkin, Vladimir" Subject: Re: [PATCH v4] hash: separate creation parameters checks Thread-Topic: [PATCH v4] hash: separate creation parameters checks Thread-Index: AQHbIKbvgJUw6t/8a0Sw1LbcaGeJaLKMMLaAgAALgLg= Date: Fri, 18 Oct 2024 09:26:05 +0000 Message-ID: References: <20240726145443.1058676-1-niall.meade@intel.com> <20241017151131.2499153-1-thomas@monjalon.net> <3605354.som1txNFv6@thomas> In-Reply-To: <3605354.som1txNFv6@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN7PR11MB6725:EE_|MW4PR11MB7104:EE_ x-ms-office365-filtering-correlation-id: 00922594-06a7-4f18-48b2-08dcef56e42d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|1800799024|366016|376014|38070700018|8096899003; x-microsoft-antispam-message-info: =?iso-8859-1?Q?kouGKUV8Q9ZdWWs/zasPkfJVI/tpZ/CJFqhShqRsZ7xdPG5mLshkXyd37N?= =?iso-8859-1?Q?47QT0ttzWMllVuA8+HaWzg9M17iyTyxyAAn+M9iuuNRMgqN24ZBGpWdoeO?= =?iso-8859-1?Q?FcW9EmdcCNbuUFJiieF+3hdzR5+61v5fXOyWJg0k5sFrtYt9oKzWIhTBI3?= =?iso-8859-1?Q?3iJKIOczlEj6LDLWi7n9c+pmxq5isS8soxAE3gtuYTUmkGLo3x2aSbiEWT?= =?iso-8859-1?Q?cTHWarNOzn4u5Lruxz/18Ox5DxNeGIXPIor1V5caezEyep6maCqTOfapPI?= =?iso-8859-1?Q?pwemA2O/HmbRAFIfuQ8JDraSReGlEK+036xWzrmiOhJrCllI7TPt77cS1f?= =?iso-8859-1?Q?3D37z1mfGC1NFig9sc1duI9vm6I06UKeeJWFWoZoI7ZgDUhW3ZY4sVRv+O?= =?iso-8859-1?Q?aZUauWhYrAvFACkXubt0HS6s/rke2yIniCqmff4YKA3GW+RJ7QM5v6rUts?= =?iso-8859-1?Q?eAwmLaI0lLLUHM95A8NQAssGCBypzvJylpJZVj04axJ6CY2u66B3+sPJ60?= =?iso-8859-1?Q?jyHK8pp4M6chqEvEO5LSiYXonx4Pqi7H5ZkRO3c8a12PTPwM4C3vdOpeqI?= =?iso-8859-1?Q?WbzEV7FjydmR93R4n9GVVVLWFvglskX52W4AgyKi1Cnx6HCJ2RMRYiQGsL?= =?iso-8859-1?Q?nAPlRsioCTfsvTaQfsb1gjCvI/7O9j68RqzbHzEO+e+pdYLwblWw0KKXYy?= =?iso-8859-1?Q?zSFWNuBEVk6EAkOqaoNgX5SEKwB1EL8bdPMITyVnsfBBSrQBS9inuYILNd?= =?iso-8859-1?Q?C9gdrCZFmQPheUT91xJpqcAQTBL8ys3525qlSTUMoTSP2heA+/DLBKv6Q1?= =?iso-8859-1?Q?4C1taAd2qKCBzCvNzo6dY6sTEepyt09x6TkrX5mW7vdMRq6BfKYR3ZPW4I?= =?iso-8859-1?Q?nbeeqjfP1ZqfXIJoOaedY7V2DpJ/gmsNNN57SwRCuKwCCZwPy+XnDEnBFU?= =?iso-8859-1?Q?o/j0Otcwgb7rCfvZ6oarGkZ1TpEgqOsBK4/g5KV8CCC5gecpMCDAFb/TdC?= =?iso-8859-1?Q?K10mW/TnwPs7OWwb560NhaTrgFomEwd2aYj3GqxijYZV/Q5OjwHrOR3Iqa?= =?iso-8859-1?Q?KVjKnYbO8fUTckukFSaKmSU3QFOtENP9UrE8O3tYIivtYAGZjvVsnUsvfB?= =?iso-8859-1?Q?CseuuVdrWEHqL+BBlBGcxlB//Cp4AEmDpG5k9KzCFWM70d/nptD0+k2+Ey?= =?iso-8859-1?Q?EnsJbFsjXM565zJUmN/zIql7NrKbCd2PXiBQERgnpgrwk2/l+feGK4Cuxx?= =?iso-8859-1?Q?RVwjcr24gXKXO7kTEnLZQphFjz32ppWzjQw8AByIBRVA0+bHQJyKFgbz4v?= =?iso-8859-1?Q?AmsS7UMN6WiLZMVKc6GUFETczpSAjZwJ9XxEbyLxAIlyF3DAUS+CpEL8jT?= =?iso-8859-1?Q?0iwpoXckQfhPOzU04cx66nwmlWs/UDIxK4dp+LIoVFDBipnWkULVQ=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN7PR11MB6725.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014)(38070700018)(8096899003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?yxy/VkkoSTOkcxj0nAhfyZfjeYEyTyyb/ixfkxAj4eZu40B5Taozb3xZyg?= =?iso-8859-1?Q?Bh12gqtzIfoeEvcM4g3RiXfv6PWcxFOOkMqykdfw4uKy/8lO/RMdpqs/N/?= =?iso-8859-1?Q?fhV/AtCLosel/HWXsdkGw+X+52SzlwrITnorzKn50yxqdS9TzLdJYHLWKW?= =?iso-8859-1?Q?y8TtqoznTTEYaZIqLjiSb2yO/76QtSrp2CYMN8S4amc2blL52oHmPiB81/?= =?iso-8859-1?Q?ELhHW91AvbrqmDuX33QhJH09ssjAeWTJRllI5ji/yZqHPpV4qReWFOpQ6g?= =?iso-8859-1?Q?RZ8Yuv7zc2gHCLu4mG/nOOX88htXr40BgwF2iI92xRW/b1GuZ9m486lvik?= =?iso-8859-1?Q?EC2PpgWlF/dKytVOQDrglR7PvJMOzD9KM9LV+wgy9HED8PhB5V3cW9woYs?= =?iso-8859-1?Q?6BjepW1q1Sy5jTNiMwiM87QEiz/UeTo/Dv0HS6UtfsEFLzp0UWcw2LT46P?= =?iso-8859-1?Q?ebH/536oMLDVJPe9UN2DSG8urdq5kxuNNSbMzHB9neN4KwNdw0EE29QGvr?= =?iso-8859-1?Q?ulj2NML59DyURn34dGrSrlIk/YTnE7Yxxyi2DBxpYnODCmrxcFJGplMgkS?= =?iso-8859-1?Q?MVP/jqjbJXLYrQ/PKx63Sf75VoxwjDDgbqWDWQXg0gUnxqBpUkCjujQIHr?= =?iso-8859-1?Q?CEDwtsYbSLjTL//SM2FIA/UTKUA9gmgGa6GuDtJItbHH7MkFspjj3Hm6UI?= =?iso-8859-1?Q?Ift6Zh2304/1gbkZrSFpf9n5L9EhQV19UiuPgNwBjDZgbtmb1XbtEisM1z?= =?iso-8859-1?Q?hLQEIghkBW3hSEbdloq9vJR7cZQjNDrn3aosNvmePKuomx72mk57kD0Mz5?= =?iso-8859-1?Q?bX8oEDp6ZF96kySgNGMeWDXcKyKykEgBD/yRIdguxAnU8sd195OR3pRqvi?= =?iso-8859-1?Q?PskmGnemcuTsccbvuKlj3KS+OisraFvXDOnZTiugPJ6OwTCwD5LTktzbOo?= =?iso-8859-1?Q?ho+9g6X8r0PBiv06YdK3RMrFGKSL1PKh+If7DouaF+S/8TDfpCxlQBsRkg?= =?iso-8859-1?Q?DVpf+31QyA+U2KomnqZ6uiY/3v6HdIT3bbQXnzO5eB7D7Z7IQ9vc3j3zP5?= =?iso-8859-1?Q?mWGC8tI4xJLsZMlblre2RGpNqKLx7EmgVY2Xs4gwhHV1xMff4P5a8+jwYA?= =?iso-8859-1?Q?lq3djA4FUuW1Tf0pm7DRRMEjq0Vg+JTM/upbxQ2lmB4as/xrSJGlLBCdbo?= =?iso-8859-1?Q?ZGOnMWld1MtquBDQrXPlcjnW0s2ZkZQJITYCIIoMUs4CHlLyrry1CEda0W?= =?iso-8859-1?Q?jVMBDUQyBwmHuAMYyrUUHJ0cvAHs4eqWJUMFt0gsLipeel2pOoUX43rpBD?= =?iso-8859-1?Q?EWYj7gWIJbsH+oNRskasrMDhMVqn5sgANwk2JUEUL80BQx8/+3nortPROW?= =?iso-8859-1?Q?DXUDnHabky54KfMe56H4ALV6p/CV3ouunKFb5/r/x7rLHJLxHSJ7Sw28VA?= =?iso-8859-1?Q?HLZ1VN2jViiurju0mStu3z8nmGlU+/89Y0A9hMeO9Tx5GTAVYeTeUSa01l?= =?iso-8859-1?Q?Fd3YY7C76+mOtpV4QLBP/Hs0psXR24IMubkkRpOqA8qnj7a174JAdn10EI?= =?iso-8859-1?Q?/93nXEHf1SlIKjEr2+CR/LbhtJhtHK4iXOz2YDwrLRh04vTdps6d1T0f7U?= =?iso-8859-1?Q?9aBLhWemhtKULYeNFITuDp+/MlUWg+Ht0W?= Content-Type: multipart/alternative; boundary="_000_SN7PR11MB6725430F9C01422D03C92F82EF402SN7PR11MB6725namp_" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB6725.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 00922594-06a7-4f18-48b2-08dcef56e42d X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Oct 2024 09:26:05.3745 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xDABMTSZGwkEtePXmPW57MXgCO+QufI8hB/IA5cQ69kGOckEwn5fcYKse7xI3oM1vR2naPGE6t9MKwW8/URjaw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB7104 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --_000_SN7PR11MB6725430F9C01422D03C92F82EF402SN7PR11MB6725namp_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable >17/10/2024 17:10, Thomas Monjalon: >> From: Niall Meade >> >> Separate name, entries and key_len parameter checks in rte_hash_create()= . >> Also make the error messages more informative/verbose >> to help with debugging. >> >> Signed-off-by: Niall Meade >> Acked-by: Stephen Hemminger >> --- >> v4: formatting details >> sent for triggering a new CI run > >The community CI lab is not in a good shape today >but I take the risk applying this patch. Thanks Thomas --_000_SN7PR11MB6725430F9C01422D03C92F82EF402SN7PR11MB6725namp_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable
>17/10/2024 17:10, Thomas Monjalon:
>> From: Niall Meade <niall.meade@intel.com>
>>
>> Separate name, entries and key_len parameter checks in rte_hash_cr= eate().
>> Also make the error messages more informative/verbose
>> to help with debugging.
>>
>> Signed-off-by: Niall Meade <niall.meade@intel.com>
>> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
>> ---
>> v4: formatting details
>>     sent for triggering a new CI run
>
>The community CI lab is not in a good shape today
>but I take the risk applying this patch.
Thanks Thomas



--_000_SN7PR11MB6725430F9C01422D03C92F82EF402SN7PR11MB6725namp_--