From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9FDA043B9B; Fri, 23 Feb 2024 08:18:39 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 749C9402ED; Fri, 23 Feb 2024 08:18:39 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by mails.dpdk.org (Postfix) with ESMTP id 1F6C4402CB for ; Fri, 23 Feb 2024 08:18:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708672718; x=1740208718; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=p+/7hMbdMQtDRv5PrtjkoAYqqcDz4P9/c+3QlMYGGNQ=; b=CePF4iWWT9JuIKFg79/ks9ZDvPsoZSMncpiESwHUBcqLSgA42Gmepvcx KtIuM9YdI3uvinocw42eCNKpMJpzDVeyh5r5FmaaW+uAnWQv+nCMcytB4 1kH9aPCVWBzeXr5MJgd15LmZ0vUO6ckV7PJ7Zv3y4zNJvrgoCWWMEiC3N aax6mKL/SwLwHQJy05naaGWrJrUnClyePt9/1cxfyFYyphZ+yybWQ+np9 eYApmWQV4caxKpoMbDbKwd2xjV4hyqQrON7Tej+LcVRnQv/oPiXS0ob8Y un+IbriAihgqHCDy8cCM5fdh0VxEU8Z3Jv7f2zJh90EJ0t1SHrpr8KzJq A==; X-IronPort-AV: E=McAfee;i="6600,9927,10992"; a="20411809" X-IronPort-AV: E=Sophos;i="6.06,179,1705392000"; d="scan'208";a="20411809" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2024 23:18:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,179,1705392000"; d="scan'208";a="6023131" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmviesa006.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 22 Feb 2024 23:18:36 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 22 Feb 2024 23:18:35 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 22 Feb 2024 23:18:35 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 22 Feb 2024 23:18:35 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 22 Feb 2024 23:18:34 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HmA7T/IkXhUkjKZa8IbbZ80jKREU7oDJKR1nVhoquiYH145B6BbcX3l4H4qz3DyKO7S3ySHMtKEp+QQwgsbHF+t513FLTNRRH+0+z34/PbrOkxJlS+9z1OmmcBWQaTzv8GjxH47pJSFFKcijVgKqyUV9ZIx+2UBJSKJZ9CdTUH+Fib2NG3jyWdW7YqUXzQKZ6q0Z1HYWXvo36OGuXRWCwAELdGCcK90UheImGm3dn/v7J9i/QWuIRyeWqSWCcd7dezcyipSjSpsrAw0GGCyZOv+0/i3jRXRdSK6Lr6Gz9/5t79yJceJnR4CUHwEicJrgeKFKB45GYETTrYdXVPjHIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wsfHjq2qQ75nbavAgr+zrON5IZDyE3bPBYJQh6/O7Qk=; b=kqqv/wU/DEBfLyCd1mDBDEKtp2n5YBzkoM/sNCoB8wdNRxQWm51dE2uQ/Rerusat1M5x0j4RGXLNOG3loCXK82QdpIehUq7THzpzrtvjMctndSEKNEGM7ueEx+xMnl3f9F0zm1F18dsde+EeMtTJukDds5MhKDFsc5BNnIypEzh3d6rT2p7aKcSG3oZqEGBF93bvbRp9dDs0lj+vPvPNaf0vY2fC9WGgKqxSFQJbwvN6xotnsjzMA6Bpq++DaCA1k8brKbJldNpUeHh2VcNVfUdvnF4Kxhj08LSoZIZGqhFcaNFxxvys5Vs2CStezYrtP65UEvu22FCm0YY9zst50w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN7PR11MB6775.namprd11.prod.outlook.com (2603:10b6:806:264::21) by CO1PR11MB4994.namprd11.prod.outlook.com (2603:10b6:303:91::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.10; Fri, 23 Feb 2024 07:18:32 +0000 Received: from SN7PR11MB6775.namprd11.prod.outlook.com ([fe80::b4eb:a93a:9a5:b692]) by SN7PR11MB6775.namprd11.prod.outlook.com ([fe80::b4eb:a93a:9a5:b692%4]) with mapi id 15.20.7316.018; Fri, 23 Feb 2024 07:18:32 +0000 From: "Yan, Zhirun" To: "pbhagavatula@marvell.com" , "jerinj@marvell.com" , "ndabilpuram@marvell.com" , "kirankumark@marvell.com" , Ruifeng Wang , "Richardson, Bruce" , Konstantin Ananyev CC: "dev@dpdk.org" Subject: RE: [24.11 PATCH v3 4/5] node: add error stats for ip4 lookup node Thread-Topic: [24.11 PATCH v3 4/5] node: add error stats for ip4 lookup node Thread-Index: AQHaZYoO4XPPxlVRWUySiZcmD0tQArEXgkSQ Date: Fri, 23 Feb 2024 07:18:32 +0000 Message-ID: References: <20240222053639.15057-1-pbhagavatula@marvell.com> <20240222122342.16375-1-pbhagavatula@marvell.com> <20240222122342.16375-4-pbhagavatula@marvell.com> In-Reply-To: <20240222122342.16375-4-pbhagavatula@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN7PR11MB6775:EE_|CO1PR11MB4994:EE_ x-ms-office365-filtering-correlation-id: 90ca01a6-0e9f-4c19-b8e3-08dc343fa476 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0nReOB8hiactOzYbZsegD+ZPC6SW9oGYvB3ScN9ALeCWdIN7B6eAxMKk9a4wbvi+nypSAn3y4AWa1JQufrM7i2xO7LewdaNwyzFy4mW3JM4J/BJk2L/+B2XtCuhxTjz1FiP2qpQFdmiJKeRaZBbHjFKZYZdYqMhP0pJfEQK1oVk2nAxOBMpLHlGx/vFv3yhmGC+CkjCnMmJQnnLvCnercEwhdvrjC5+KUxzS8MIx8JUsucQD3q8NJ5AjmxitRtCVuqHDVg2UyuanBlUX7o/9wuFVmkHhHBBMPb7StYGrJJmB5TSlxn/Uzt8FejrCYbvGGCs4W2vPKQab8Oeg1sjPu3MRkmzkIY/aUVyXr5UV9H1Syhw0YOFeosytw07au3942zBifJrhK/V/k4G3qEuf84Wxs+w8ELwzFLZr5oAtOXA6aj2AOS94nMASjKAHDszCEAer1TTMQ2bDBzwmhd2UYVmfKlBVR1HH4iE/hyCDc2BWn31vLFOkQm3yMj019E1WpBMsfDqjYVzQL10ninpqlWzIrhHfH2lSwXvCPW4+RvSTwovTPtXMuOrWK4b5l5cXdmpVn5ecdgB6aS3vllrZ3tLGlusOZIdfAsbdXC6D4ifI6v50JPd20fzkdyMngkG2 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN7PR11MB6775.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?klpGnM6FzTq2xAFLZ6Met6QZET+cHIlOmZF1+3Em/9yvtx+Hx24I2wW6cH1A?= =?us-ascii?Q?TX0BNUuj/t2G3zDL8sS7cHCYlURrIG0oEQ1nPzZiZ45rYv1yvibZFHtalu0Y?= =?us-ascii?Q?mzOQI9PJZupY79qACb4yark1SVZLPHq9hPJgFzJ5IN2vhqCB68vyLBSPX9pi?= =?us-ascii?Q?7UWIi2o6zeL39FJeQbKztk88IOXJEgIccNMixE09YpAGSmMM924MShFtiKKp?= =?us-ascii?Q?g54tSzVNi4UIRWWADXb3U4cQJQtk8lGL5mGLcANlnZ3TZGLK0b3dmkjiyhmt?= =?us-ascii?Q?QBeqpd35NV5TdaoUVmVGC89MajIhzW5OUL/2KSuWAaS4NHdmkLiplqAi3QSE?= =?us-ascii?Q?70eHvR3Tr1RLxe9clR8VlZaKefatPI7lOj/ThUDaO+J+/B5oWCyJC0qHwQGX?= =?us-ascii?Q?LQjvCtJ+YqUMlet8m5KTVeoU8JCiL9Q1NIn4neu5tjQsWUG3hFg5GERX2g5X?= =?us-ascii?Q?iGhetSKLPYmXoDHUp/wJ4HE8H99WzBn+HHyLPKtZ86HLmsCd7ygtjupp/3Ia?= =?us-ascii?Q?jz+UH7x0vK6sX5xWxChW2vVhDuOJ5nbAnZEsNvDMK7b17XVkUs+kordUHrLs?= =?us-ascii?Q?UzSEavwToT1ntQgHOxp/PjgQHNAbiM0pvCBFa2yD2rus1z1Sz6LZRo2sXYKY?= =?us-ascii?Q?esZbxX8l8dd3qR5nvE5HhY1hg7RZUkszQsFYOFRq5XE0hMoXAd1WGSt5tYZ3?= =?us-ascii?Q?oAaTDFKXfhAHSYBxqvTw8RejIVkRB/WVSIJm1nfxwowtgwNta7bnMnasD14T?= =?us-ascii?Q?9Hxr0uAuQh02GDLRcQzmL/Razuls5gFBumA02OpPpeoF3O/sXZDCN8ZJ5fmq?= =?us-ascii?Q?hcSSqF+5p89SBIM+IzmImUjYrt9/rsFo0HHVgFWpx7M39eQC20qSF7nzUytp?= =?us-ascii?Q?fBl2jApV6W09cedn7iX6NSl7rGmrcDr58ZysMlezAX23v42tw/3nA4iuhpNr?= =?us-ascii?Q?ZWeAa7MCdmoC/wKWfhihFzuUNLgoi5iVx8pL4c2IIWU36SZHa4HuNNVWTVj5?= =?us-ascii?Q?9DnoifBSlw16r99oFbygS97LxNkESujYVt7PY1r1HpdGucF1wsHcaeO3z618?= =?us-ascii?Q?xgIS439fvvVutJE+jfaatgfkoGQSkftswffKgjr29gyvQ5Vc6LXav7Pd8Z3D?= =?us-ascii?Q?YKqKWDJ599Vcs3A62RsAYhqpa5Tm/WNavSozPVfyvNxmCEgPlPIiqDqV0Mgn?= =?us-ascii?Q?hBh+Nd5mFhheW8YejopTghqFWOJMdMy88AbA7xmh2OWHmbHH9sVY/WnkBQBT?= =?us-ascii?Q?Qp29h5gUUb4HocdOHlhLEQjqOlv81/TYH01aywV4kArqKHmeXx4VCsiD8NTB?= =?us-ascii?Q?KSGCaU0981LPhk1XhwX2I1oiMNEWXWjgzI0QlZFGX7D1mDJiO7PGd6u526J5?= =?us-ascii?Q?x7AyjTbbxBVOJU9A6A/xFLHh5UGPq7CgASporc5szLKS3EAOCHlSQ9Z5CcuW?= =?us-ascii?Q?+NodRY36C6XXjy4v2Q79DOVYrCxofR9jv/Y13fkHF2NfC50ON1gLPw5dPisW?= =?us-ascii?Q?OGB9vyhflhDP0Rd95MSM59MGKR68dJVnLARXF8THKNne4O8A+xzaUjU++/HL?= =?us-ascii?Q?KGm5emd4XztQAMBy63SJCpBVq/RCebWY6awXbOuT?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB6775.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 90ca01a6-0e9f-4c19-b8e3-08dc343fa476 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Feb 2024 07:18:32.6144 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ycjMx/otXaYKZi6y1RIiqmXOWNTxHBxXE/ODfY7h/xaAekKJjAMcZpapLL6oHLwx9Ecubwks30Sf9ukdrFWK8A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4994 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: pbhagavatula@marvell.com > Sent: Thursday, February 22, 2024 8:24 PM > To: jerinj@marvell.com; ndabilpuram@marvell.com; kirankumark@marvell.com; > Yan, Zhirun ; Pavan Nikhilesh > ; Ruifeng Wang ; > Richardson, Bruce ; Konstantin Ananyev > > Cc: dev@dpdk.org > Subject: [24.11 PATCH v3 4/5] node: add error stats for ip4 lookup node >=20 > From: Pavan Nikhilesh >=20 > Add error counters for ip4 LPM lookup failures in ip4_lookup node. >=20 > Signed-off-by: Pavan Nikhilesh > --- > lib/node/ip4_lookup.c | 9 +++++++++ > lib/node/ip4_lookup_neon.h | 5 +++++ > lib/node/ip4_lookup_sse.h | 6 ++++++ > lib/node/node_private.h | 8 ++++++++ > 4 files changed, 28 insertions(+) >=20 > diff --git a/lib/node/ip4_lookup.c b/lib/node/ip4_lookup.c index > 18955971f6..5a7921db75 100644 > --- a/lib/node/ip4_lookup.c > +++ b/lib/node/ip4_lookup.c > @@ -86,6 +86,7 @@ ip4_lookup_node_process_scalar(struct rte_graph *graph, > struct rte_node *node, > rc =3D rte_lpm_lookup(lpm, rte_be_to_cpu_32(ipv4_hdr- > >dst_addr), > &next_hop); > next_hop =3D (rc =3D=3D 0) ? next_hop : drop_nh; > + NODE_INCREMENT_ERROR_ID(node, 0, (rc !=3D 0), 1); >=20 > node_mbuf_priv1(mbuf, dyn)->nh =3D (uint16_t)next_hop; > next_hop =3D next_hop >> 16; > @@ -219,11 +220,19 @@ ip4_lookup_node_init(const struct rte_graph *graph, > struct rte_node *node) > return 0; > } >=20 > +static struct rte_node_errors ip4_lookup_errors =3D { > + .nb_errors =3D 1, > + .err_desc =3D { > + [0] =3D "ip4_lookup_error", Here, if one node has a list of err_desc, should we add a table for countin= g? like:=20 err_type count=20 type_a 1 type_b 2 type_c 3 or we can report the total number of failed pkts for one node only.