From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F29CA42D40; Sun, 25 Jun 2023 04:19:47 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6146240EDC; Sun, 25 Jun 2023 04:19:47 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id E83D340A7F for ; Sun, 25 Jun 2023 04:19:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687659586; x=1719195586; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=SJsu3tuDGaSeLBJmNjfIdER9IT+O05LkRL8lu/FfMKQ=; b=kp1f8SZGhraOw3K2ABlriY+89e+173V5Q5MXRExZr4c/cq+pZGnfPw7B Qn3CSdHyppE7Ej0QyoqjSknWoAVFTmBIdnnl1KZI9D30y55OL45oRR6Vo vi6naMcGGxPSZ9kIQfiDN8yWfhy4ZuJu3Ke7Tsdy70EJPVy5bJL+RUbFm +tzV4mryr/PS5j/Hyd+1xZMy0d7ib9j7ekwYFXWHUXu8E8jZFOiHPC9iA 7kCwZ06rZ8V5xgS/2+gg5FVj3N/osVmlymKNMiXoo8gYoQRpUBBgGmvOQ satgE1+Y9CSHUrAUs104Y6WuE4Vbnof8hWP7TdoVOf+qIdsOZCXlUVt2n g==; X-IronPort-AV: E=McAfee;i="6600,9927,10751"; a="350779040" X-IronPort-AV: E=Sophos;i="6.01,156,1684825200"; d="scan'208";a="350779040" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jun 2023 19:19:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10751"; a="828800861" X-IronPort-AV: E=Sophos;i="6.01,156,1684825200"; d="scan'208";a="828800861" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga002.fm.intel.com with ESMTP; 24 Jun 2023 19:19:44 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Sat, 24 Jun 2023 19:19:44 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Sat, 24 Jun 2023 19:19:44 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.105) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Sat, 24 Jun 2023 19:19:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CbAbvPsgq/X2S99efetSPTGYvk2PeUYsb/XW/QYNc5apgOpfoQk9Z1nEpoTjTSF9vVc+M/JWbC/ya0mV6dJo46MfKr3vFfRUlSIss/5YUmt1CtAs6qN83tDtc3sG/0cigVbnhyYGZLKa8UZaG1S3+nhZoGJY/QhJT9HSe8LT/azjbfe6tAlV91U/XnqYmpMF5rKyuoBQUZHX20jepd3dXsZjhYt73Dej9Q3XbSs6aQyvDVDoRyyWCGRa50WyANKaKtau74TLe2My/QdMp7+xVJpQ1B22Twcn8+XHRFCbsV+EtePirTyYWL6LC+Fd3MKk0AsF052rCoLaIsAWuXDHDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lzQWMKQYY7jnR5k/GAFo4yB8XT4qOewoKGL1s/lgouw=; b=iaOMPfrJjzonepSBYaktLDZuW2pBR/m5T8/BKbRQwbg8o05OhgcDUinwK+HF22CiyShMTcNRhc6YOR9sZ5MHlYpuZpkgFp5xOOc/krADZxtrwHkYVsyhOkLdRQAg3mvdKx435CFMscvpIPG5ypwfGBjz3+nKPekghv7yJQnstU+9kWbTObx/y48KVeqDH+KrwQPLBTZjw1VQXWIldJoXqDXcDWJFtFaWKmMaPbhVUeU1vD/I0TrzqoIvMorGPys7UGhVuimfToTkrTUtw1Xy13ongCgyeEJd/TYJQdiyQR2k2e3rXSrwtgaVIxWPmDgYeErX4sMnJjaT1ubgF6ft+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN7PR11MB6775.namprd11.prod.outlook.com (2603:10b6:806:264::21) by MW4PR11MB7104.namprd11.prod.outlook.com (2603:10b6:303:22b::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.23; Sun, 25 Jun 2023 02:19:42 +0000 Received: from SN7PR11MB6775.namprd11.prod.outlook.com ([fe80::a458:ed7a:643b:5aa2]) by SN7PR11MB6775.namprd11.prod.outlook.com ([fe80::a458:ed7a:643b:5aa2%7]) with mapi id 15.20.6477.016; Sun, 25 Jun 2023 02:19:41 +0000 From: "Yan, Zhirun" To: "Zeng, ZhichaoX" , "dev@dpdk.org" CC: "Zhang, Qi Z" , "Yang, Qiming" Subject: RE: [PATCH] net/ice: revert mark action in switch filter Thread-Topic: [PATCH] net/ice: revert mark action in switch filter Thread-Index: AQHZpCO/1t+j8smaTUyLbklydePcTq+axWuQ Date: Sun, 25 Jun 2023 02:19:41 +0000 Message-ID: References: <20230621094125.3071251-1-zhichaox.zeng@intel.com> In-Reply-To: <20230621094125.3071251-1-zhichaox.zeng@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN7PR11MB6775:EE_|MW4PR11MB7104:EE_ x-ms-office365-filtering-correlation-id: db3e3031-3d1c-4698-0204-08db7522a22f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: V897SR1Oga27FRc7rGsQ1a1Dr5IE2qWffuJpFYrzBiV9doK6GADkfQ/H8xtltek2NzgkPvajSuMt3d9xC6xbtHn7lM9RGWCVzuf/9Ghr/BLAVcJAXSwVnGpXpwR9ekrFSlEWU+RVpgPX5kk97OEQx2XNB0S+pYaXjUuvmrr3LqPVZk6CG4zbuzC5yhI2zHrAu2YlEQLVRYqwvcvAhIIsY245buTY1Ef9Y3clBwRD6Q0w5aeDaFX90xGV4pcvxSNNo+7jZmD6fZFDQgfXsZ5AfNGYVbXgSndvfkm2T/UjK37Ke7aRABLzex5J+/wc+g648AFkzOXsRp/HokS8vdz3VwmljY5hk/dhUgWZurHd+x3Y7kr3cauwA8Ma8JsSFm1/mNFznOFi9tRdqzPeunx+Px2vE8kUfz7Ug4YfPQMxRpBSTFOC5zvqL6LxSADLMTHXwKmA+lv/WIn6CgrKJyPXa+sK4UICjWVVnId0WfWa+UgtnbfH+3xWhin3oTgcwNnamGU4xBnDmvIPCFwOaTsl5tCD89qRT12o5ka+eRiEpcSUrDwkyOVAbqTw7cNTpt/L6fasbFQiR0FkPTSx8945e+hFY2d0tb4GfyotPiOm0DAyXDgsdMQtgkOppobk9mM5 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN7PR11MB6775.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(136003)(366004)(396003)(39860400002)(346002)(376002)(451199021)(8936002)(8676002)(55016003)(64756008)(66446008)(66476007)(66556008)(4326008)(66946007)(76116006)(41300700001)(316002)(53546011)(6506007)(9686003)(26005)(186003)(107886003)(478600001)(110136005)(54906003)(71200400001)(7696005)(2906002)(52536014)(5660300002)(38070700005)(82960400001)(38100700002)(122000001)(33656002)(86362001)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?C9IkH+jqgsMTO6QhETLRacwMqal4OOPJaeFVYSUvhzVk0LpBV5kkxS5wY9Q1?= =?us-ascii?Q?1C5ymET6e5ag/pKl9hgei1p/nLZx1jcVb2+PQhvxunsNs5I/IBeSJET6b+eq?= =?us-ascii?Q?EI+oTRlIrP902OhLyRkPteD8Zua9n2ZyNctF5mJE10AXzy0Qpb0/3VxsvmOq?= =?us-ascii?Q?XtGaKGoRRnJmjtIBGsNKTFVUt8HsLWENXsN2HdDbtaAGo5CyKWbzKnBPT8xU?= =?us-ascii?Q?FWJindskYMbs5tKTEj4jPmwR9n1zUYIEOwN2fqmo/FW8O9tFxwozAxxDt08W?= =?us-ascii?Q?vkeAglXyTPf9WjRQBO4UNqLv2fRt2394XvWUl/yQZijdnlAAnzQcAX3+ouTk?= =?us-ascii?Q?mP1eda1ybh7lWnolgbMCUQUy28fToC7AnQJmscTHUgCXJtMdsI/ASXBcY+ZU?= =?us-ascii?Q?2FCELMlYruhntn0WvKdsV7CVXjo3CRhHiSSx9zbQUg9BwzYqbXfjzowsnGxu?= =?us-ascii?Q?HGff2CVRJRcnKG79TvvaVOgLDvuOEBVzxKr7yqilb3XYFmxP40k+LGhMecAn?= =?us-ascii?Q?twpQHzdN54LpWqvQh8qqsGsF1PFW4gadHNRd0QKxTKjd0kfm0qsqmNM+hLxK?= =?us-ascii?Q?+gA4s+fxLo9VJMqsizgEBo3OLTrefdjtSfPnA5goGXAZfMKa5FZeLXwFjgAa?= =?us-ascii?Q?JtNBCP2c1ugppNAdKs5Dw/FcXZnWTJWTA/sfZ2wRK10yQSsaDxnwzOXm2K0g?= =?us-ascii?Q?du6KHQ9o6urLtQVWxg9Eu3INfbpfl4ktpONv7AjncW2aEHhpBw17SLDr3Q1P?= =?us-ascii?Q?1PVGjLNCXSvZzYJkO4K6HTi1nrKTiO8lfPLQOT7dPaon1uB5zHV6/Re6C3Py?= =?us-ascii?Q?awpKgHzArz8KYsxZAmVQocm7n9iDZ1nNoL/4tmzwFWl6GlMWc0ylqS1OH21Q?= =?us-ascii?Q?1KHAoaWHX8q8NACIbp7vHJ2W9eHPTHON/2xysICLMomkdXHzF2AN+tmUXBMR?= =?us-ascii?Q?xPwwPss224Xix+iJoAsZJvfdnmkQD5fNu41kds5If15kOvFGgLePePb1nvVs?= =?us-ascii?Q?FcPmcRhxFljDGQH1qMPR0BC4L+Rax42BINo3BtyKejx8IDIPPiWcnI7V0n7t?= =?us-ascii?Q?1EKv30MtduiTqORia0YguFlfwvXq5iHZsWAKMOruDhbmgekR20vRE9X1ZJPv?= =?us-ascii?Q?QUQ6gSq6Qo4quVaYyCPOdstIFVgOeQQLD64NEsflHWEMTyKgzfpUlQ9CGrAw?= =?us-ascii?Q?9Td/VEhiEwGSdVg3B7vdVxTilP/OxCTzAWf4lzm83S4c15DZzaw8OS8SwA8x?= =?us-ascii?Q?nR4YbMl0kyUs9DQMWbKcQVK0t6NWi3w7HQL+2H4KxwAt2K7QDXnlUqe5kwuT?= =?us-ascii?Q?xJWDr/73pgOabiJYpoD98JlcFcPI2oyGnw7SqkhMoHfuReqamo5UJz2FTgxD?= =?us-ascii?Q?Ev6jrNyQCwdXz/cxJ6sDP49MZxwECfiFVB2qnJnxS4ayxSnXgKNvv657GtYI?= =?us-ascii?Q?tUiL1cpKigDBpVajm3qonnWEeM+eG4psS+F8yLfMCUIBT8CPK4Z3EMQPWt4s?= =?us-ascii?Q?u1jJNRN6sdiN699a/AWfFP4kpfMM4WoDhaBYFPPutbbmdH3gUv/o9xgS53zh?= =?us-ascii?Q?e4uR4qJ6rlqFURzJtZqwJ+s0wjTF0lov81U7Js3f?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB6775.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: db3e3031-3d1c-4698-0204-08db7522a22f X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jun 2023 02:19:41.3105 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gOOnUlTxDXJp2Y+z2aa8BIBYruf2JzavH8GihC8BkkJjahWzuSimDIPT13ULconLvVBkmENFEU0q8GWOnqSIfQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB7104 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Zeng, ZhichaoX > Sent: Wednesday, June 21, 2023 5:41 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Zeng, ZhichaoX > ; Yang, Qiming ; Yan, > Zhirun > Subject: [PATCH] net/ice: revert mark action in switch filter >=20 > This implementation has some problem, the function did not work properly, > and it broke the mark action in FDir filter, so revert this commit. >=20 Hi Zhichao, Actually, I think it is better to describe a functional impact in commit me= ssage. It could make it easier to understand the issue. It could be: Revert this part to disable mark action in switch and recover the mark acti= on hit in FDIR by default. For current impl, switch filter missed the consumption part of = mark id for app. And switch filter capture the rules first rather than FDIR which makes FDIR= rules lost.=20 Does it sound OK to you? > Fixes: e24f43f2c824 ("net/ice: support flow mark action in switch") > Signed-off-by: Zhichao Zeng > --- > drivers/net/ice/ice_switch_filter.c | 9 --------- > 1 file changed, 9 deletions(-) >=20 > diff --git a/drivers/net/ice/ice_switch_filter.c > b/drivers/net/ice/ice_switch_filter.c > index 1ff4b1afda..110d8895fe 100644 > --- a/drivers/net/ice/ice_switch_filter.c > +++ b/drivers/net/ice/ice_switch_filter.c > @@ -1715,7 +1715,6 @@ ice_switch_parse_action(struct ice_pf *pf, > struct rte_eth_dev_data *dev_data =3D pf->adapter->pf.dev_data; > const struct rte_flow_action_queue *act_q; > const struct rte_flow_action_rss *act_qgrop; > - const struct rte_flow_action_mark *act_mark; > uint16_t base_queue, i; > const struct rte_flow_action *action; > enum rte_flow_action_type action_type; @@ -1768,13 +1767,6 @@ > ice_switch_parse_action(struct ice_pf *pf, > ICE_DROP_PACKET; > break; >=20 > - case RTE_FLOW_ACTION_TYPE_MARK: > - act_mark =3D action->conf; > - rule_info->sw_act.fltr_act =3D > - ICE_SET_MARK; > - rule_info->sw_act.markid =3D act_mark->id; > - break; > - > case RTE_FLOW_ACTION_TYPE_VOID: > break; >=20 > @@ -1830,7 +1822,6 @@ ice_switch_check_action(const struct > rte_flow_action *actions, > case RTE_FLOW_ACTION_TYPE_RSS: > case RTE_FLOW_ACTION_TYPE_QUEUE: > case RTE_FLOW_ACTION_TYPE_DROP: > - case RTE_FLOW_ACTION_TYPE_MARK: > case RTE_FLOW_ACTION_TYPE_REPRESENTED_PORT: > case RTE_FLOW_ACTION_TYPE_PORT_REPRESENTOR: > actions_num++; > -- > 2.34.1