From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8C98243B9B; Fri, 23 Feb 2024 08:13:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 58E91402ED; Fri, 23 Feb 2024 08:13:47 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by mails.dpdk.org (Postfix) with ESMTP id DD3DA402CB for ; Fri, 23 Feb 2024 08:13:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708672426; x=1740208426; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=4yAsu7Z1A4HMXn7fVKUHKXmJvhT+Ybom25iHko7DUhM=; b=VySBYmaXssCj8hjT5Fk4k6mrIQCRV6mmbrF//hrxeuO+RInp2BP1QH7R X7OuugMP9tMo5dvMEkZeindZRrax2PmnyLmYXxYP5hOqKd2MPkx39Qf4r E5JRyWPfUUdYx9DHLT58jHVdyCaa7Vlm28Mm/MJ5vh7LsUw6PLpTLDLOd mtsdiKAgco4FjbDG07HYrG2/VO98fWCcjR4EM5D5jfirHid1mmvAA41Ld peyztlHOHSuogDxl1UCbH6JUDGchw+YsAWtDhlX35mWPRlgZXsXDet82r 02eRLNZZHMbxUwxVWev+pMxznZH3ctJMfXYA13pAHyJzbz/8Eh2lyywDE Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10992"; a="28404800" X-IronPort-AV: E=Sophos;i="6.06,179,1705392000"; d="scan'208";a="28404800" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2024 23:13:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,179,1705392000"; d="scan'208";a="6226173" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orviesa006.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 22 Feb 2024 23:13:26 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 22 Feb 2024 23:13:25 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 22 Feb 2024 23:13:25 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 22 Feb 2024 23:13:25 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 22 Feb 2024 23:13:25 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KrNtsVDaCSaQBkzJdz5+ECP10S+Qv35VLeNiYJ3TIGGnXwdRwvYeE8JHQLWCrQhswPXkulIRp03JHlxI9XAWJMUzuApDiguZBe+3skUPf+O+Zq+SWUUoJv8JFUN/FKm4CQPFNkYufdWXNXr6rIqJtz4jXpTqkbVxhtEq3JlKdHdfMwl9HXOkeTSjsCEH0jWU7N6eUL7m/x8PN9D10aKCnpae8gWD82FAPq7IUAe796LT2q+fNdjQJxPk5BHmJ1G4vsTaZ6mgnqEuCS7KHmsQDAarnt+MIVYBhW6uz9gpAx5flJNZrDukHsx3X9NyZHBIDzpUuC/9YCR7Kc79m2o4Bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0eDF9V8iE2x6v6i/+3GuMA1fz8W7DDRBPBIJDM5/OFk=; b=n0dwIyPG1+dTBJShWkGk3FTHkrflIys5FWQfWgV2z8Y+8Ii1pnh9B+hfpE9A5jz93JY3zZj6/Ha2D9BpWZ48yKGobFJz491Mw+UJaNkxpgKQan5uDejS6rZqmRZN1JahA7xMdRKi6hf9eArxeKyJ+qqgeqsDEI1Z9cSL5rhpAF8/lS7xPSBk3Nd3laMIMjURWUscxXOu3oQtAqyFxFVLP6vCIwZ4nt2KNXHFctbBBqCH1csrAkO+PlzhHyacdfxEUqP2vcUnXyZMltr4zApUFI7dV+WjdMSLRltqxjxHfYtAcPklZ4/0feT58G9oxxUzQffhLNC09r6QDywdzTEvtA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN7PR11MB6775.namprd11.prod.outlook.com (2603:10b6:806:264::21) by CO1PR11MB4994.namprd11.prod.outlook.com (2603:10b6:303:91::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.10; Fri, 23 Feb 2024 07:13:23 +0000 Received: from SN7PR11MB6775.namprd11.prod.outlook.com ([fe80::b4eb:a93a:9a5:b692]) by SN7PR11MB6775.namprd11.prod.outlook.com ([fe80::b4eb:a93a:9a5:b692%4]) with mapi id 15.20.7316.018; Fri, 23 Feb 2024 07:13:23 +0000 From: "Yan, Zhirun" To: "pbhagavatula@marvell.com" , "jerinj@marvell.com" , "ndabilpuram@marvell.com" , "kirankumark@marvell.com" CC: "dev@dpdk.org" Subject: RE: [24.11 PATCH v3 1/5] graph: add support for node specific errors Thread-Topic: [24.11 PATCH v3 1/5] graph: add support for node specific errors Thread-Index: AQHaZYoTJH9Wd25Ec0COp5eZWs6ccLEXf1JQ Date: Fri, 23 Feb 2024 07:13:23 +0000 Message-ID: References: <20240222053639.15057-1-pbhagavatula@marvell.com> <20240222122342.16375-1-pbhagavatula@marvell.com> In-Reply-To: <20240222122342.16375-1-pbhagavatula@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN7PR11MB6775:EE_|CO1PR11MB4994:EE_ x-ms-office365-filtering-correlation-id: 36524a42-8be2-429b-93b2-08dc343eec4c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SqErfUYJ1RLV3T7iISu3Sd2rI67OKJqcdq65LK0U/reGTzJRl19WTn1PMAmXmDv6E9+qtfxvZN7iwTOzgLPbz8NUqckepXCqx5ML+UOxcWqTVNqTYmsFPa9ARV8IYPOA2pSn4BEPMXa4z1tSh2Q9JHxaBWmmvsyvE8G1y6A7lGUz2BGIfDZoNnmOXlMASDWjnsu6NAxGnzq2AP8/RWz/+3Aneh/PTPKva6nMtLLEucsw2MHQwsJSTrAZFNQsxU5wHbN93FpaIvPFgw+WvW37Pz0kpMqTq16Q63iHTQ+bmBPgt4E7ShDwIO4L0hyDFgS22dYY1mRoJTfgCabHnlxQtz7cBzzN+f5kvHe4N8eqO4fTnUz9ucmnoWzaQHMYK6LXEvGAHSb4D7Zja4fXf0giO4XHHy80xRwLZ7AS+3Eyk8mk0GSCO+58/w5biWFPTAMjVbSJddmoLq2ivYGfINXIAipjgEQe0eROIAfchBbwq2gYM32dXq2QdUVSl/MS4Wdg6QumvN8XHkTqa/AI8j6KlL6BdZIf/O+/I2KD8fdPFSvPBVk1IgHQhzE2SbnPngSAgsqguDsAXcpdg0K1j72r2wSny60BjE2fgsL1cfXC5UOItXlG7RW2tez5rZlGLRu2 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN7PR11MB6775.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?4GBzR/g/ANEXceBVV0dfPjIt7GSwkKLMCC/pIQJKlrAWf41MgBqjYGT+DkVN?= =?us-ascii?Q?hU17+QsFU698G3KidkAPicZAKLmv/jwv0ODxifV9KhyDIYJkgPMe2ToYyT8N?= =?us-ascii?Q?pquRbnyDLAVGsDaSkjFH1sL3h1En+yvm9yWYAtPxk7Ze2oTnl1Sl1JyI5fH+?= =?us-ascii?Q?QF0i2WDqPuxtVkoFQKBBUQlGOHELN39tHwJ/T8UIXqhEHM2M99gkfbJiD8K3?= =?us-ascii?Q?wCZDxB5Y3Cymdt1cYmXzfdDDQJHg2IOM+GRbJf7S9aI1ujn37lbShurMi+/w?= =?us-ascii?Q?J/vu2cPMLgeKDg791ydIEHxOUGW+7+xsDbCnbEpPItuBi5RQqNHtASgMjdDx?= =?us-ascii?Q?JMSF2t7dobrVOq7NWagbvINoNe7CPo0yntDh2DrqyZ0ZC+Xu8x19WJTUm0EO?= =?us-ascii?Q?CpuKCo8XEkZoxRLq0ZJZsH8mrVAj8tBIeXpG1HJEYuDzfWCFYifLtDyLUwR2?= =?us-ascii?Q?jZ/+cjoF8Z85od2KDweA7Y223TtF9wc5LuqWbua0WRIfyppKRGpK4J9cX/lx?= =?us-ascii?Q?PpFVzh+xVdchiO9w7Nte8D0I4wo1nnnB6zmP2CiiP+bENgzCEFisyyjm6vz/?= =?us-ascii?Q?e2eJVCYvHjK+sVAiJy0xqRuPqiiaK8R5CNRLMw7lOWpvCrxpJz/n4D7wMu8f?= =?us-ascii?Q?qNQXlVJoIHIA6dShkO8hNsBstV8mS/KRHaf2qOHCoibZ1K8m9RRyKUW2Vfyv?= =?us-ascii?Q?LIgivcIxGcoe2hESbYYo6zAyNxUBbKpUz3zBrU5himqw9596eo8j894g5NKz?= =?us-ascii?Q?dICw/Y1t3CvYd7BgxespyZWVefXqcuI0GrXxGlYCMPDI0bvvKkBXsaJcfges?= =?us-ascii?Q?oNrwPTpbPVZinKW/zmoh0EQ1o2E9DqIQG0QBdO6Xr/aVYF1gDeVOPL59E/mk?= =?us-ascii?Q?xEsThl9NYLub5G41R+n3dJ6sDdbVl3yI4ojUNJUS3j8eC/F6EM694MRCUU3e?= =?us-ascii?Q?GjU4GToDJe8fUjLfTdEcGqaQBuEQg55srbTi40yX8dHvMC4FlOKZ+48r61zW?= =?us-ascii?Q?Ss1HzlMBCVDgUltBEGQmXoF8Ybg5qero5a9xuhvWQxJ75SKVrKOmCx6fok8e?= =?us-ascii?Q?2Y2gtfVSEMCTQWp6TGkDuzk9T5kbITx+yscdybBtbAJddZ1cTJtppNorFOKb?= =?us-ascii?Q?naMSW39doigqaWpSzNTjPdj/V+lOqS2Sr8hVSj+4lln+EhlRz1DHIzurqzZh?= =?us-ascii?Q?C/p+paHo9vMKPp52H2qaZntcDVRxQlk7C5wM/ZVFhdJde5QuySOa/3Yk84YM?= =?us-ascii?Q?wKBaKlScvKwdczj+xO9/wt55xkm2zCzn77dS6IZgVHPq1Uy3dWfp+R2ykBNy?= =?us-ascii?Q?SJ2OlkltH5P3KRnAFs5tmAR/wKuzd4KNJUeMCCHPMJdI73T0nFM2bLhvS6g3?= =?us-ascii?Q?slyPrNtaL8SiF2MoRnAWs7UPzKk9cqp8xXa2RpUlfnldDAcM78bKuK22QiKs?= =?us-ascii?Q?NWVlj3BeWLY5uB6K0lg6i6NJCP8UiZmSlKQfGnQ69k0pGmxmSwEcPaNV6PjC?= =?us-ascii?Q?Ai4SpfMf0Uo2xLlhxWxKzoLUL+iMo3IMaFEAdxrMoAqYmsvbW9fvv8Og0bZY?= =?us-ascii?Q?2jQRy8kGsapECWTuIhCVF4D6EP/rsJVUl3s/b7DC?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB6775.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 36524a42-8be2-429b-93b2-08dc343eec4c X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Feb 2024 07:13:23.6591 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hEJhB5oO/s7m0RXNs7/7aCHGRjKlLqSj8aTKC2uP4zSTXuWMqBTYDnjZhSrEgs6/H/nqI67SS67LNxc5TK40ZQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4994 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: pbhagavatula@marvell.com > Sent: Thursday, February 22, 2024 8:24 PM > To: jerinj@marvell.com; ndabilpuram@marvell.com; kirankumark@marvell.com; > Yan, Zhirun > Cc: dev@dpdk.org; Pavan Nikhilesh > Subject: [24.11 PATCH v3 1/5] graph: add support for node specific errors >=20 > From: Pavan Nikhilesh >=20 > Add ability for Nodes to advertise error counters > during registration. >=20 > Signed-off-by: Pavan Nikhilesh > --- > v2 Changes: > - Fix compilation. > v3 Changes: > - Resend as 1/5 didn't make it through. >=20 > doc/guides/prog_guide/graph_lib.rst | 22 +- > .../prog_guide/img/anatomy_of_a_node.svg | 329 +++++-- > .../prog_guide/img/graph_mem_layout.svg | 921 +++++++++++++----- > lib/graph/graph_private.h | 1 + > lib/graph/node.c | 37 +- > lib/graph/rte_graph.h | 7 + > 6 files changed, 1016 insertions(+), 301 deletions(-) >=20 > diff --git a/doc/guides/prog_guide/graph_lib.rst > b/doc/guides/prog_guide/graph_lib.rst > index ad09bdfe26..018900caea 100644 > --- a/doc/guides/prog_guide/graph_lib.rst > +++ b/doc/guides/prog_guide/graph_lib.rst > @@ -21,6 +21,7 @@ Features of the Graph library are: > - Nodes as plugins. > - Support for out of tree nodes. > - Inbuilt nodes for packet processing. > +- Node specific error counts. > - Multi-process support. > - Low overhead graph walk and node enqueue. > - Low overhead statistics collection infrastructure. > @@ -124,6 +125,18 @@ Source nodes are static nodes created using > ``RTE_NODE_REGISTER`` by passing > While performing the graph walk, the ``process()`` function of all the s= ource > nodes will be called first. So that these nodes can be used as input nod= es for a > graph. >=20 > +nb_errors: > +^^^^^^^^^^ > + > +The number of errors that this node can report. The ``err_desc[]`` store= s the > error > +descriptions which will later be propagated to stats. > + > +err_desc[]: > +^^^^^^^^^^^ > + > +The dynamic array to store the error descriptions that will be reported = by this > +node. If there are no more detail infos reported by node, why not reuse the node-= >name directly. > + > Node creation and registration > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > * Node implementer creates the node by implementing ops and attributes o= f > @@ -141,13 +154,13 @@ Link the Nodes to create the graph topology > Topology after linking the nodes >=20 > Once nodes are available to the program, Application or node public API > -functions can links them together to create a complex packet processing = graph. > +functions can link them together to create a complex packet processing g= raph. >=20 > There are multiple different types of strategies to link the nodes. >=20 > Method (a): > ^^^^^^^^^^^ > -Provide the ``next_nodes[]`` at the node registration time. See ``struc= t > rte_node_register::nb_edges``. > +Provide the ``next_nodes[]`` at the node registration time. See ``struct > rte_node_register::nb_edges``. No need to change this line.