From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B4B7043B9B; Fri, 23 Feb 2024 08:15:19 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A0732402ED; Fri, 23 Feb 2024 08:15:19 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by mails.dpdk.org (Postfix) with ESMTP id 20E48402CB for ; Fri, 23 Feb 2024 08:15:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708672517; x=1740208517; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=oljskCAyH403gHD2ASyleBOLYu0q+YFpNYTOSstIpZM=; b=IV8sc0Y9IT/HFcdcPLSWUxiukjxdQ9PkT/YWBTmE8EIoOxpoK14+XE3+ cHPiDPUkTLdHzF4XOMFlIpmqfoRupKdghi94JsV9JmezsnyrALx/d3Dy1 Ej2lW4HdITwi5Q4XoxdtQIVeBnK63WFbjAL+9UkI9T6ll5GIeS9XZYVqZ 88W4qXKXNr2jIJJ6zjUNhac77e8ZkjS0ySbYXFI0jwMK12sUpuNhkA7ed sRfzNVBD+ErR1YjYSUGziF43JDxgOqLi0kUz1FbhXlH2kOXTGmRgTnLp4 U5xFz44r8OnpaIfVbV6ff1ddshaDs0x62sKerTCzzdCApqm1AW/ORowcm A==; X-IronPort-AV: E=McAfee;i="6600,9927,10992"; a="5916495" X-IronPort-AV: E=Sophos;i="6.06,179,1705392000"; d="scan'208";a="5916495" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2024 23:15:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,179,1705392000"; d="scan'208";a="6195335" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa007.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 22 Feb 2024 23:15:15 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 22 Feb 2024 23:15:14 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 22 Feb 2024 23:15:14 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 22 Feb 2024 23:15:14 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WVdkj4dJeBHTQEQoiuMWmpM3UrN/zLN4QjufgVNktBEwas7ZqcFRtBV0m1HiIeZAe+aHM5URJKSkupEtEgnLBJHhq3NMjghnDZdRhn0q9qHEQ+Bi4CvNVBYX1xGtjapNt8q9Qyfjo/plM0t8dTfmjBlbiyAxDFVQIU8MX6+ubnk7xC5LHe1RJC8tF3jDttE4gSc4lYdny+3XWMzaGZlSb6PVf+aFhsLXU4DeUKol0yeQ03dV3WAdpbqdA2lNtx0Z6e8KuH1P6RDzO6RJV4mgaXfWoogEY6aWi/8i+/xYo+qC5NfyUNoIlaOgAkY1fWI7UyISqSFiD3dQI0utrHpv9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2Kypt1t30QJUgZpKywUioLXkkyutrWAuqzGHSUakcOo=; b=IRorM/FuvG43DZLx+ssNUqcGXNIXkmrsYpC+MQSHvXEvep1cWhQzBhEyB/NPhbakCJIPPPIkt+Vq45x0eOGecHVMTQdHw5fS5kHIY33EMm8/LyFlxEjt2Bx+gOeAKHsqBAx37bBC97hRiwQj8+2os4uCuF7GMDezcFJw/wmeR5Hs4s01Sg7CdY5AEY7f+cA8m7uc2AwNocIlD6x+G0BxpDhE7qNzuPLkg+R+ihX6A+7/48rcZ1LmhRPGso0MV+1ygDpmhKGDwYgSdwl4NFooy9AU60OR5b1yC3g9TTE3NE87W68j3cR2eSR6HOFgV+YEoHlxuOjvPKpUA3kmR1j3RQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN7PR11MB6775.namprd11.prod.outlook.com (2603:10b6:806:264::21) by CO1PR11MB4994.namprd11.prod.outlook.com (2603:10b6:303:91::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.10; Fri, 23 Feb 2024 07:15:06 +0000 Received: from SN7PR11MB6775.namprd11.prod.outlook.com ([fe80::b4eb:a93a:9a5:b692]) by SN7PR11MB6775.namprd11.prod.outlook.com ([fe80::b4eb:a93a:9a5:b692%4]) with mapi id 15.20.7316.018; Fri, 23 Feb 2024 07:15:06 +0000 From: "Yan, Zhirun" To: "pbhagavatula@marvell.com" , "jerinj@marvell.com" , "ndabilpuram@marvell.com" , "kirankumark@marvell.com" CC: "dev@dpdk.org" Subject: RE: [24.11 PATCH v3 2/5] graph: add node fastpath error counters Thread-Topic: [24.11 PATCH v3 2/5] graph: add node fastpath error counters Thread-Index: AQHaZYoLM3OEpU5In0SQlFxLQg0klLEXhKJg Date: Fri, 23 Feb 2024 07:15:06 +0000 Message-ID: References: <20240222053639.15057-1-pbhagavatula@marvell.com> <20240222122342.16375-1-pbhagavatula@marvell.com> <20240222122342.16375-2-pbhagavatula@marvell.com> In-Reply-To: <20240222122342.16375-2-pbhagavatula@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN7PR11MB6775:EE_|CO1PR11MB4994:EE_ x-ms-office365-filtering-correlation-id: 18d299f7-2d16-4426-2afa-08dc343f2971 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ncGUSM8kZ6g+7mRd07iFJJvV1J4E/jGC1PtY6LkrVCMI3Y1Ha08yA92PN2VzimVW5Om3A2gq1w1bFOjQ7NTFnoDj50H2jd09qD7kAS53hM+rmD4iyIwJrJjQZI9LsICuiyQcV79mZVvjQOdu+TMe55ceABDr0SGOQt47nr+CjfkoESCjoaqe8uoSjSlZ+L9c4elF30y2j2cjaEaMnvgmOREpKlviPf40ZcQPaANOtKsDrwZTsLWZI/R6oZXgXzOM+XqVoO6XHSFrLcgTqPHke2rNJ07Nqhm7leDkhSH3EM+oWKR9LXCT+FRJ2kDHTD+Zys+kImlrwHZQE/fUHqq7wCqIBmOyfmFpRkVNNGeR8BafCH1cWhuthtbO9kVVHehPEeo2JHrsTnnmjrXpfQUFYOmGNMRessn9ERYXI6yN+6yCcjaBmOnd3MaFI9WzCFwd6GHeY38SI03pYR30LtzTWwcsLKKk9XPMFtW5AfRL9D8s41tnrCjN/RLwBMTj9F63yYLTP/pxIMQZ9/+jYinXa9jUBPNdlkWbVvas7e7x36HyyD1ON9sHdBd0SwuRQpHzkkwwgOUjf5CGUqUdzjEFBwrH9mE7HwW9jCIj+1t69hvnrZkuE9OPDAm+9Qv8PIpR x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN7PR11MB6775.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?hH8S/7laPQY3q4E+aRzItVaVxg4Kou/ac1B113taZgQQbAl0iRG3Pwy2fD9/?= =?us-ascii?Q?HyTAfVBQZe3LyEdtMHIF4jHBiIVk+JSOvy0CjlMJ98l4j0rmQGw+NuAuUOGa?= =?us-ascii?Q?RCIuLSHO1iZqnN0qiU/TTn9Yshj7Dwd4hfJ/OP4v2ONPyLnvfxQAy/PeDTzr?= =?us-ascii?Q?l4iK+gZlDE76ycAFtu3LqqaqsDnAO2R59Cxn+uXVafTnoB6/e2ExJMCVgixZ?= =?us-ascii?Q?RLm8HY2zkII0VAItqRYn6hPXiRwcCDIHjCCJxA9LtA3hWGTULeYmDKkfFyVk?= =?us-ascii?Q?0uxVDNxr0LUOstMvWMZlkuSG9aLF3P3uMwrOraMPpeFh8qa4uzMay9biWkpl?= =?us-ascii?Q?xl5S1uxzTRpLm10io84YCugfzdehl2boq80mtpaK+IAPiktwCAUVJuCUAbS4?= =?us-ascii?Q?taevqDnE2cJ3iLKPY8xcYUvj45OIAWmLCgAcFkw9Hd6l4ho9moOIvFdU/pv2?= =?us-ascii?Q?rCNHBdfFtmCWBQLX+1kdnnhLDjuYfEBheYkxgBHqJUwvjwpSw6wo3Q48w2Kh?= =?us-ascii?Q?rHa333CIVeWhzkTjzxlVlyPTgxjtuEVdeW/DkzN/pE1838yhUMmlcPrhWliP?= =?us-ascii?Q?g1ZSe/VSb9jV7CRng1nvt+8LUSo+RM1FW3lhrWyOkhPhupoHJsU9vCuM9Xip?= =?us-ascii?Q?apOcoR1BY/cHVscoTOK6VNt7wXKCaNU4fqPTvYVl1tI/hWlC9SKtKP3eojVC?= =?us-ascii?Q?Zndvxe6iHLqb6mIpzaOly13lCeFHV/5BQLiMhPGH3btBnnvoXjWCmEchYOST?= =?us-ascii?Q?DfksI/K7Efw4RIq3VkNe/LXQqrG4wVtayZdvSbocvLufMpXwQTlT3u/V8b+k?= =?us-ascii?Q?YXc1adNjIvbVRmC/TruanBikwytQWc50fgCmLM1lD9+1LedEM68x41qUhZ6x?= =?us-ascii?Q?0DhiHqp7ib/NjrLI7VMsXW+sphCZaIIQqSG0/TSZ6t8KKYfRnOJc3Fmc6SQM?= =?us-ascii?Q?C4iLPNR0urbo2qYLt14RwG8HaGf5TUG2tMYco/Dhhz/N0BcnOXM1nLMu/QI0?= =?us-ascii?Q?KJUw+niUlkv3LFzYhE3wyWkUlmiYNqT9OTDnlMYjSLZ+PTFt1vaGrIslqopd?= =?us-ascii?Q?b3bcY/Q35AFOdZKgWfraJ3l5EhsvECTpxTqcmYbU8NfLc51rKsrIvqIoDSf2?= =?us-ascii?Q?XXxBeDI6mT/CxIc9FXvhMhY81LOhuIXDu+Q+G4CspKBR5vQiuUbWhk1A/Bw/?= =?us-ascii?Q?fOiOrt3K7TXj1naopgAGFKi4qKrBgAymUZkcGGRY9u41ZnkxWYqATxgCOKPT?= =?us-ascii?Q?uMthz39OoDNZ2G6z6Ik7Cv0ooeVm+DKiSWHQwedrruhMLIp01ugraW+PVKpb?= =?us-ascii?Q?MDIowH55v8zQjypQtshTw1RbNx8Pniv3jTQePrAS8yBM8WNG83HGpXRiWk+y?= =?us-ascii?Q?yHqlXEtomZLATNVomTtkgvVKEx53zFBeHg9iMJWgnJDfEAGwCquzN7wGDu4B?= =?us-ascii?Q?+L3Wi03SoOy/n26xonox+JKGkd3VbX7N3T9TVRLowLOMQXraJr/eXNU38Ckf?= =?us-ascii?Q?cBMxvYsj4rlS6Gho7PoLCQiQr313UM+l+f6zwlXVGNuHrlqofIOo4ymErQLq?= =?us-ascii?Q?ms93gzET1TuxzDrN4ZXPVpE1DyhVwul2Pb7POUqG?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB6775.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 18d299f7-2d16-4426-2afa-08dc343f2971 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Feb 2024 07:15:06.2338 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: B5xtJkc28Wq0PR3/nutYZ/Be2KmI4xapWwroER8HER38+MjsdwePVy6ay6Sexg5U26Jclj0fpjOPz0uV74K2pw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4994 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: pbhagavatula@marvell.com > Sent: Thursday, February 22, 2024 8:24 PM > To: jerinj@marvell.com; ndabilpuram@marvell.com; kirankumark@marvell.com; > Yan, Zhirun > Cc: dev@dpdk.org; Pavan Nikhilesh > Subject: [24.11 PATCH v3 2/5] graph: add node fastpath error counters >=20 > From: Pavan Nikhilesh >=20 > Add node fastpath error counters advertised during node registration. >=20 > Signed-off-by: Pavan Nikhilesh > --- > lib/graph/graph_populate.c | 22 +++++++++++++++++++--- > lib/graph/graph_private.h | 2 ++ > lib/graph/rte_graph_worker_common.h | 1 + > 3 files changed, 22 insertions(+), 3 deletions(-) >=20 > diff --git a/lib/graph/graph_populate.c b/lib/graph/graph_populate.c inde= x > ed596a7711..924f5a3034 100644 > --- a/lib/graph/graph_populate.c > +++ b/lib/graph/graph_populate.c > @@ -39,6 +39,15 @@ graph_fp_mem_calc_size(struct graph *graph) > /* Pointer to next nodes(edges) */ > sz +=3D sizeof(struct rte_node *) * graph_node->node->nb_edges; > } > + sz =3D RTE_ALIGN(sz, RTE_CACHE_LINE_SIZE); > + graph->errors_start =3D sz; > + /* For 0..N node objects with error counters */ > + STAILQ_FOREACH (graph_node, &graph->node_list, next) { > + if (graph_node->node->errs =3D=3D NULL) > + continue; > + sz =3D RTE_ALIGN(sz, RTE_CACHE_LINE_SIZE); > + sz +=3D sizeof(uint64_t) * graph_node->node->errs->nb_errors; > + } >=20 > graph->mem_sz =3D sz; > return sz; > @@ -64,6 +73,7 @@ graph_header_popluate(struct graph *_graph) static voi= d > graph_nodes_populate(struct graph *_graph) { > + rte_graph_off_t err_off =3D _graph->errors_start; > rte_graph_off_t off =3D _graph->nodes_start; > struct rte_graph *graph =3D _graph->graph; > struct graph_node *graph_node; > @@ -99,6 +109,12 @@ graph_nodes_populate(struct graph *_graph) > ->adjacency_list[count] > ->node->name[0]; >=20 > + if (graph_node->node->errs !=3D NULL) { > + node->err_off =3D err_off - off; > + err_off +=3D sizeof(uint64_t) * graph_node->node->errs- > >nb_errors; > + err_off =3D RTE_ALIGN(err_off, RTE_CACHE_LINE_SIZE); > + } > + > off +=3D sizeof(struct rte_node *) * nb_edges; > off =3D RTE_ALIGN(off, RTE_CACHE_LINE_SIZE); > node->next =3D off; > @@ -158,7 +174,7 @@ graph_node_nexts_populate(struct graph *_graph) } >=20 > static int > -graph_src_nodes_populate(struct graph *_graph) > +graph_src_nodes_offset_populate(struct graph *_graph) > { > struct rte_graph *graph =3D _graph->graph; > struct graph_node *graph_node; > @@ -193,7 +209,7 @@ graph_fp_mem_populate(struct graph *graph) > graph_pcap_init(graph); > graph_nodes_populate(graph); > rc =3D graph_node_nexts_populate(graph); > - rc |=3D graph_src_nodes_populate(graph); > + rc |=3D graph_src_nodes_offset_populate(graph); >=20 > return rc; > } > @@ -228,7 +244,7 @@ graph_nodes_mem_destroy(struct rte_graph *graph) > if (graph =3D=3D NULL) > return; >=20 > - rte_graph_foreach_node(count, off, graph, node) > + rte_graph_foreach_node (count, off, graph, node) No need to add space here.