From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0C68B43D0E; Thu, 21 Mar 2024 06:34:08 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C63B34028B; Thu, 21 Mar 2024 06:34:07 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) by mails.dpdk.org (Postfix) with ESMTP id 6C0F440265; Thu, 21 Mar 2024 06:34:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1710999246; x=1742535246; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=sMI0MxtFUkkuHAHX0KupetHdRb56LrBOyBR9xe0+MOc=; b=jZVNCgy2d6S+PKY7hXsb7hrZS+SXRHkEB7vDoboXBI4OQGdjmtx5vEUp 1JIw3Lxj9hmZe1md7W1NJc7CXfKoRs4viC1+AAS686w0aQxmDaC9YRiPM jNvRBTuo7gW1BTKxvOk0VnkX5hVrg9xRxQL40k7vYHlzHnkZvKvZ/f0jY Neamd+3L4oMlnaji0nuVTHxLZHoZQqqjw0KPdme9O9EGDbGYDULu3WmiJ 4PJk+csxZvI1G4ovv2oZNNEe7d076f2HhywXscSkQR+PKjQrE8hshJTaP LBWr429w8AmAUEkBORMAUFBXGgo2UfG58REDpzDqex+mNEL3eAE8qXtaF g==; X-IronPort-AV: E=McAfee;i="6600,9927,11019"; a="5819362" X-IronPort-AV: E=Sophos;i="6.07,142,1708416000"; d="scan'208";a="5819362" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Mar 2024 22:34:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,142,1708416000"; d="scan'208";a="19109346" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa005.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 20 Mar 2024 22:34:04 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 20 Mar 2024 22:34:03 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 20 Mar 2024 22:34:03 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 20 Mar 2024 22:34:03 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 20 Mar 2024 22:34:02 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nzn21f5J0mJXzEztx5C7ODyH+E/nb20mP724mut0ylPmncCDmDZGbVPo+0k8AtS4RNqY7xYekFy0QCZTOclwF4xECO5Ac47h6+6FIL91PD7SbjeTVqYMrN+FAvcMlqCDt6UYD/ojX74qsk/hbiS6+sjt31Z0+2M8LrhNjyYBeydEAdckz80PAYPjtvbnRP2X1rTMfmkOXnpqirwKK9//kxw6CVDhDcer16JXwYCuzT3guIXUw1+mx3NiEkvC7uIjVPbdr2BWT8LGTvPu8PHCHGzO9A4+bwr6oQrUWQ+5wM+1Zo2emyFKl1zluVBffzzfaB02iBzcGUERO7x4Huk9Cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oM8CycpL/8uzYq5E3Clc5SnlnNk0d8aoyFltHIJXrl4=; b=b/nnvDo4dhdf0Ife2AFG4qHvtzi0mYkbwvZaLBTTERDGICYPU9xbC1QZxkVGabAWtXqpnDMV9nzXqfjOhPd4FTuEYifX1NOcJPXgSZP8Hjq8fMXn6jug09n9auCm/k+UoCt5WCJEUO6BC9lKzB4ilj83Dc36WmeIxiiNZ+Z39JLdVJFAwL0wguTTZdt9r74jGGpaF+wkvLAbxH90PJrQXA1Ajl0HePz2+O/GDHUh94bbzd3z8YqN+truEzgzIWtF74PJAB+g1MacY1b+lLc7Rm+zngnSaIvdvTPukW1pwkEsa5LdanOPkAkpefZdOAoHATo63V8hHfJPDRA4L2xTqA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN7PR11MB6775.namprd11.prod.outlook.com (2603:10b6:806:264::21) by CY8PR11MB7847.namprd11.prod.outlook.com (2603:10b6:930:7c::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.12; Thu, 21 Mar 2024 05:34:01 +0000 Received: from SN7PR11MB6775.namprd11.prod.outlook.com ([fe80::802b:12f4:f230:a430]) by SN7PR11MB6775.namprd11.prod.outlook.com ([fe80::802b:12f4:f230:a430%6]) with mapi id 15.20.7409.010; Thu, 21 Mar 2024 05:34:00 +0000 From: "Yan, Zhirun" To: "Wu, Jingjing" , "dev@dpdk.org" CC: "jerinj@marvell.com" , "pbhagavatula@marvell.com" , "stable@dpdk.org" Subject: RE: [PATCH] graph: fix head move when graph walk in mcore dispatch Thread-Topic: [PATCH] graph: fix head move when graph walk in mcore dispatch Thread-Index: AQHaecXhBCsfELcr0kOLVZV3+3zA97E/94GQgAAzvQCAACJAkIABQa6AgAAcnRA= Date: Thu, 21 Mar 2024 05:34:00 +0000 Message-ID: References: <20240319141454.3275543-1-jingjing.wu@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN7PR11MB6775:EE_|CY8PR11MB7847:EE_ x-ms-office365-filtering-correlation-id: 385b20cc-b976-4944-80ca-08dc49688314 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: v/b3Ttb51Zyz/rHSN1KicCTsvQOgf3vYFqSr3b95rz8BtuFN7JHHxqWk8+DdTJPR1izH9P2wG49N9JqTYObJYN4LAFo2sUaHv59ko5h5HGDqzLwbZ8mtC/xHfAP0w/aplr3+I2jxaB2jliLnJ27gQZNoQSOKf5VA6EMBELXGtEy7OF4FquuBWdo9JYSSQEeDJyWhDw8t7rVIKn7WOANiZRFHEo/ron9IaEdNOwdZMYocMZPBjn8HuEoZ8Py0srhNVODQh+unOiNLBIvYjNAwLcoqDeglwELMnGOIYuGA43c8kskXf72qUGTVGxPwZjK6sVs9q8y9EhDSBdaHH+AsYavY1xmcAUXg6fJ7wdN/cTcTz2w6cTuWNrSRRCwWcsfolK+BVd8JhS/RXc4UouPMMXpbFc/EdD/6sawXiMVDTtRzXdwgGYzxRV8STQ62VbIfsQo4JSgUlpBF9Hj0hPl73jfh8/r+HwYzfWkJdYk2AQVfPATSdum8W2q3Y0qWgohZ7h1BT5QNScnaZtH0MLydrmdZuZzAsAgMQHs87+zyIsgTg7Qb/NKs+o5EAYdi+pAHhhLYPz77VInyHk6bDNvYiQ8nIqf4f2MCHPe3DEvBZ7ZKJxIMKyNO0trQSGvW6fNj8bka0SgKVV/AOUhOHMhNiTgoscL8Os5o37Zi8yi6LtWoXLp9EOzar4GxrtRpw5mZlVh3Duc3h8ENsflUQ2HygosSWT0+v+eNMId3Ant6Mos= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN7PR11MB6775.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(376005)(366007)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?UrlJAE5rA+UzPNwIQhI3DFsYaqk5r2Eb+NPoZtBP+ZfLDIQF4N6TE2VwtDDw?= =?us-ascii?Q?0pWdiGmP7EbnjHz7MMRqTOFOyDwX29G1cYXYkkiXAhiOykI3Z8LWBoOR5xzx?= =?us-ascii?Q?NyzeOw1jJ6aiCoL+6rYAZSX60XNwK3FQf+ckpKEebF2o9P5iEq5nq/EiyXMu?= =?us-ascii?Q?3lrQXEXmj3wcp/7Ncbo0vMpieXJil5YkNXz3DFFzECPHJSXSmTn/7AApbPAc?= =?us-ascii?Q?lf65/aqLzj+2HUKTg/ufhJ1+Dhr7SoW3NwHBEg5IRl3gCxPOq3MGzKRnCTcd?= =?us-ascii?Q?H2ECuw8ti3Rm9O75gaw9LGniyH834U5ddz2MX7rdYIxB7EUBFLLsYzpyx1nS?= =?us-ascii?Q?/KAf8yaySAKEGMmQMbOWY9TVBK4aDfAmwVyewZnwnBB0VZh9VEZhJe+RyqUt?= =?us-ascii?Q?SFBGN1Pew/bPbfRt4pkHYiN2nJptXT1dpxW7g1IQ4+ZTGXkDKLSneU0v6EvP?= =?us-ascii?Q?Al19aEEXpUAG31XjKS2ZRh0XAsrnO80QMoX3R2XJN4rCeEjmByBgnmcrGA99?= =?us-ascii?Q?84Ck/TPvFQYJOo0IizZYsK7g75Rx4qagsjiTk88pHtfY6wwf1kcpVmkOKVAm?= =?us-ascii?Q?ADgHfPwpFL7CYhPSutNeWLX8jGpDUDvJLQuNeMhv7/2mJoQPhllDRXIp5sOT?= =?us-ascii?Q?ttrFbX1a8EyD2TK4hJeUrpV2CwdYPP+lxQiW+h0tYJaZK3WReYPRsrnOM9C5?= =?us-ascii?Q?lAB5ZmYx+MDwT0BzOI8bOCVx5kNeg1F8A4pviS77lnKag6gsSHecIJpCyNn3?= =?us-ascii?Q?zb2/6FrJbbeL0G2QDpRwBqzsD56HzdfywU+l5MT7MU94gKX8rwHPaK933ybk?= =?us-ascii?Q?E0I5Z/AYyNXXMTlYQdnTwdKjaxYmuI5e0A3RW9otsUxlZceTbCxlojpZqj1k?= =?us-ascii?Q?pJZfSKzgbQCFLH/d/Gw6FmyOiCdWcNOLDqvNy94j00G/I6QYFlvkDQlCjda6?= =?us-ascii?Q?T+W91jiUX4hSVBbFF4kaVmi4dRjqN26rdoqjAniWuVl/J0WSYPYv+N9BH6Cr?= =?us-ascii?Q?D62ZQtZU6HF15hDauUTgJP9osRmLiq1XVziXuQ+xBJEgT2D7TuPMItSqO83M?= =?us-ascii?Q?z4BDRDqO/AotPk0UbFVxpJ/T5g2W+8KkE4uzOQyMEhr4SYn+jz5t+omjC5oT?= =?us-ascii?Q?Bc9KC3/ETcaymdoeumXF/V1Q47lGpKq1/OoRdn/6igG5TBMe2GVtOJyNJHlV?= =?us-ascii?Q?158O/4ELxAUvaX4EnLVkbc4Xi6O/5Cli5QA/0ismDAFSTXRp0HgpDWz2wR72?= =?us-ascii?Q?yOgIfjpXy+H8jo8YlQsjovAjcz/UJqlaWg6mkP6eYbF1b+/gdkt8r/T38R2h?= =?us-ascii?Q?WfJKf0AHEk2qMkfhaXgS31vKFvHUWgBlgg+3+YDExiNIlPk6NxzaKo7umccW?= =?us-ascii?Q?9NwjmJNpo+XmyA3R705+Ou4+qffIXTdhWWQzWYSUXTZMfFrEEci7sLxe5mzq?= =?us-ascii?Q?oLqWIfwdIGvqp7AeR3mNKMJP/WLSB6O7+4Y+yPSgTA1auCIOD4yQLPwS+Q+9?= =?us-ascii?Q?b6DX0C9p2uvKKXZ8IO4IC8vuBsrBzJf2BrTGqCfa1C6Y/t5A7IT3NsUdUDhZ?= =?us-ascii?Q?ashYk3ffqg+KPA6r1xJSJc7fVrbJYtJ2M2ulYxAr?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB6775.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 385b20cc-b976-4944-80ca-08dc49688314 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Mar 2024 05:34:00.4328 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 02cXkT7QvJ2iE1N43HygCxqdGb2UdUGgUfjW75ucmAjZpAR3xu88J4lh48opNd3+fRUfj3zAP6eNuHr+XmO1Xw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7847 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Wu, Jingjing > Sent: Thursday, March 21, 2024 11:39 AM > To: Yan, Zhirun ; dev@dpdk.org > Cc: jerinj@marvell.com; pbhagavatula@marvell.com; stable@dpdk.org > Subject: RE: [PATCH] graph: fix head move when graph walk in mcore dispat= ch >=20 >=20 >=20 > > -----Original Message----- > > From: Yan, Zhirun > > Sent: Wednesday, March 20, 2024 4:43 PM > > To: Wu, Jingjing ; dev@dpdk.org > > Cc: jerinj@marvell.com; pbhagavatula@marvell.com; stable@dpdk.org > > Subject: RE: [PATCH] graph: fix head move when graph walk in mcore > > dispatch > > > > > > > > > -----Original Message----- > > > From: Wu, Jingjing > > > Sent: Wednesday, March 20, 2024 2:25 PM > > > To: Yan, Zhirun ; dev@dpdk.org > > > Cc: jerinj@marvell.com; pbhagavatula@marvell.com; stable@dpdk.org > > > Subject: RE: [PATCH] graph: fix head move when graph walk in mcore > > dispatch > > > > > > > > > > > /* skip the src nodes which not bind with current worker */ > > > > > if ((int32_t)head < 0 && node->dispatch.lcore_id !=3D graph- > > > > > >dispatch.lcore_id) > > > > > continue; > > > > > - > > > > > + head++; > > > > If current src node not bind with current core, It will go into inf= inite loop. > > > > This line would have no chance to run. > > > > > > Seems reasonable, it might be OK to change "head<0" to "head <1" the > > condition > > > check? > > > > No. "head<0" means it is src node. > > All src node would put before head =3D 0. "Head<1" is confused. > > You could find the details of graph reel under rte_graph_walk_rtc() in > > lib/graph/rte_graph_model_rtc.h > > > > I guess if there are some src node missed, it may be caused by wrong > > config, for example, the missed src node not pin to a lcore. > > Use rte_graph_model_mcore_dispatch_node_lcore_affinity_set() to pin > > the src node first. >=20 > I don't think it is confusing because head++ happens before head < 0 chec= k. I agree to change it to "head < 1" > Yes, it happens when lcore affinity is not set. > For example, we have two source nodes, both of them have no lcore affinit= y > setting. > By current code, the second node will also be executed which is not as ex= pected. >=20 > Thanks > Jingjing