From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 241B343D68; Thu, 28 Mar 2024 09:32:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C6CD2402CE; Thu, 28 Mar 2024 09:32:42 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by mails.dpdk.org (Postfix) with ESMTP id 0AFF7402AC for ; Thu, 28 Mar 2024 09:32:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1711614761; x=1743150761; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=VuUqiN1QKJ3IoD8G8R1ovnNNO5CMSyZi5zkPG9KoRVA=; b=ZCWx7aS29cTlsQ1ZycA+jvz/N90HTmSJ9xFZOEJzr3fRVb3myJ1STcCb NghY1Syjzgpv7hX1/vucuoIClihzDJQoKsNoteWe5aLVabmtNXuPYYwZO DbcDNGa6ns+yrqvbD0K0TC31pZVMt3k0WpJZN7ULsWg8kNQAznqDBFQ1Y 47oyiAd4ZxvL0RPehlt6i//VSq457oHLchuHxPiBsMnXEBk7uGhEOVbpP aRHs7R3TjKNp62uaPemy6QJS5KaJsGtxlyv+Z/SBnIrx2H7ikwaG56b98 6LpN/we8yadpEPDm0s8Q7tYGcXwEgJtFarGq9g1Du6irTW3M94QY1Vv+F w==; X-CSE-ConnectionGUID: e0eDuDeYTn6NXLN1v4Jihg== X-CSE-MsgGUID: U9fPqIUgQMKGvfr20d8l4w== X-IronPort-AV: E=McAfee;i="6600,9927,11026"; a="17482825" X-IronPort-AV: E=Sophos;i="6.07,161,1708416000"; d="scan'208";a="17482825" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Mar 2024 01:32:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,161,1708416000"; d="scan'208";a="16607295" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmviesa009.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 28 Mar 2024 01:32:40 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 28 Mar 2024 01:32:39 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 28 Mar 2024 01:32:39 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 28 Mar 2024 01:32:39 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qmxc5CzAIGgQPHpje02+McMMGCNupXr/Id2yXLZt3E4EHKlkNBmugLewzXdtWdHaWucjfPW3r0Kg4oXfd20lmO3zNFvQqntsLZQRE6EPzWJA51I+kQriFv/nNKAKLPK1v6BO/TKCChHWxC2S1xkgjN72j3/CQ4Yun8GfoLM6hrry2FyqmabAjBv3yWt/edEFoMq3JVAAYP/2my4dvAcVDzDO8vtlQrWbVjothoe2uscXlhlT7VERrXyPeUdTdTjTu4ElTMGJOwVYb7UGllYqhRram/CcnuSJhGtoweH+rIcfKCA6ZOvHgPzYQ95o+hO+2GNHzOp3r6n9ceEjFsZy4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r8EFh4UDKksZRJCdoK+pXDyeUEa0mzamffl89+Wi93k=; b=jRvMuj1QyiH+MesyWQJvUpAJHP+U6LPihb07hjo7HPjLB5JZ+xY9dkSNTLbSxCHDAWHHKuKvPXZZfDkBUhZr0z8wirrzFmIz5pAXKcT0zbCuVx93VljFrYpf3ExJ5+UeQr9KZR09UlAmLgurDA0zHlnm5jSk30mpqtycQgDqkgYWki0LeLc2GeNE3HRcb8GHpk6t/dCw4gNsmkSVl9Ft3yEBEX0rgFxtkJyfu1KOjv73pLW1jiBRcHJsuZ7+wTYPc5JQkIwimVpQXyA1XjUR/ggOLnxNcWiDBqcCvrDldbN37kOjuP3y0anAlpBaFD/3INET1nbV+nBpOuDnoPf5dg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN7PR11MB6775.namprd11.prod.outlook.com (2603:10b6:806:264::21) by IA1PR11MB6171.namprd11.prod.outlook.com (2603:10b6:208:3e9::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.31; Thu, 28 Mar 2024 08:32:37 +0000 Received: from SN7PR11MB6775.namprd11.prod.outlook.com ([fe80::802b:12f4:f230:a430]) by SN7PR11MB6775.namprd11.prod.outlook.com ([fe80::802b:12f4:f230:a430%6]) with mapi id 15.20.7409.028; Thu, 28 Mar 2024 08:32:37 +0000 From: "Yan, Zhirun" To: "Wu, Jingjing" , "dev@dpdk.org" CC: "jerinj@marvell.com" , "pbhagavatula@marvell.com" Subject: RE: [PATCH v2] graph: fix head move when graph walk in mcore dispatch Thread-Topic: [PATCH v2] graph: fix head move when graph walk in mcore dispatch Thread-Index: AQHafC42bnOMaAnTj0uHGZ1FLQhEWLFM28jA Date: Thu, 28 Mar 2024 08:32:37 +0000 Message-ID: References: <20240319141454.3275543-1-jingjing.wu@intel.com> <20240322154637.1346239-1-jingjing.wu@intel.com> In-Reply-To: <20240322154637.1346239-1-jingjing.wu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN7PR11MB6775:EE_|IA1PR11MB6171:EE_ x-ms-office365-filtering-correlation-id: 7d4de287-d08d-4a0a-af1e-08dc4f019fea x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1FLnwS3iHk5VCGSyW7LDBn8WB4KX/d4f9dPcmOcqFnKR1xo9vQM/2FSrWz0NdoLEyNbS3IMs2Si3nplok1SHeG4rm/02/Qe6cqUqHBuAWxib9/5imQfrdEmRThTyx3tMnXTs53gbZCPAr0PxBZZin9UVgsqkyJehW7Fjtl786XFAbIgYE+DvfrIchjjvdVih1hlpGMwoap5it6kcHAPVJvBH4sIic5Tk793Z/oSOsRKq25y+tgk/WVHfeTuTQAcDBvmWkbwUejiuqseh/FSWVb+a5kbYBUWG9hqUh9mV6B4fsMcgXIt3BnEHBE/R3XTFQPkw2SdNzNe4bKk1tgx/Fw21hznzKKJj6Dage1PQw0s7bT0pLEVW4I9krC4ClOY3Cf6i/w3+MwoGj5NDWa9xr7GEYC2E178K0CSdiapNqvsB0FVaPbC+h4vbPhGCc8vcIj26JgZBE0/BVXJ40LknqnMiaNeaFjnVdhZqaf19xaUHqMP/LuDCuEQ/2xzT2Kam7Mc6q9dCcYji9pVmOusqxBL2EDHtQ+JJ8DMWNJMsck8uTCDkc5hVzf516RkFuaiQ/4djFPyXVXRadxP9TCaTFpYfQm0ACVUhkX/esbNIEXb+lpRwmjs6ORZZ7g4byreLwuppWOXJHLNJ2EBIJ8gjVlDRdp0pUpS6j8RKReY91zf1JZpAH1mqdFDgNkDa8wAmp4TgVMtJr0Ot2/QJ/pHDHg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN7PR11MB6775.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(366007)(376005)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?BxTQrxNeB6u+yCOFDFlrzliVwVp3GlTJ6O94eJjegIDn1ydqJFb4VA6e5m2j?= =?us-ascii?Q?ifmPeL1DPqnuTtcW66ZkMflGaDykgk7R1/c3deMTMYWWcYSrqyts3PTnBrfp?= =?us-ascii?Q?fkvbJI3inpiNZSI/j33MW9kyonGdq97gtGbhzIxOIOu/Gely5iHAXt/AWUds?= =?us-ascii?Q?1coJRzhBL8cva3ssokMY5i168Uhn0pBUUqisGQbQVTPoywlzWsvAo4Uu0Qnj?= =?us-ascii?Q?+3aySv9VansM6nHqT6GtBlBkp3ll/466LnqhPZ5Rbi+t54SL8B8RBzfSH42V?= =?us-ascii?Q?askRCyPM1WuapkIcLN333x0Bc/rn/wNzeQ+ASByz6lRHX1TAlXxWbg5VKxI6?= =?us-ascii?Q?W3IJXQ6kdrgCe8ju+WDthyrfXKxS6wVQMR+/OuC6IR6P5km9Zs9QyaXqbb44?= =?us-ascii?Q?hOPoeKqjWfFN6J5a1+EZshl2dZJqvZirXsK2kUoQPOutJVXFFxqa/Gz9iMjr?= =?us-ascii?Q?F/lsr0xx6nhISgSHH3X8AJoczkEv/+ATAu04lDEnRFxFs0CI7exw+5YgmOrH?= =?us-ascii?Q?g22DsJN9k9sBdGPZZ2sEzgMiuJWz8pENE+DbUOEj3BhBONUbPluybrmkMSmF?= =?us-ascii?Q?cP79LyGSnqwWIaKEpwie/bLO0CsU7opfAWOaHkxJ4m5vTqbM/1xqRTiFp8Ge?= =?us-ascii?Q?CbWFNevq/lzNCwPU9gc74793RpGxRnh0ojsp7+5fVYx2WEMTZgLnaEyKy4ck?= =?us-ascii?Q?wZX0mDzG87o/5ZMCedqrWDhOC7TkvcqvSoiqoD8pBSbunmX8LM7rHLq2d//o?= =?us-ascii?Q?Vusf3NcXiC6njxfxEmushH0YuPOvT5bTKc/r55bFSKzB14e3p5SXM7BqLH52?= =?us-ascii?Q?pgPrdLwiCrYhBcK4kJ75Vo4ITqHbVUjh4mf09qyui3xLcyheXAe8YfgUHiyT?= =?us-ascii?Q?8qlRkRjND8d59Bxufg62dGv/JB5YhfIT2JpNAWRb0wNnDPBBmIc+VFCDk5MS?= =?us-ascii?Q?YUZVpQCIZFM85ANkyCYAUvGvuy8vlIpIfZepHFGQ7Bi/nIqXwLP3Z8rr/5P4?= =?us-ascii?Q?wY63cJhLHJGjKc8ciFAak/DdwEU4bwsnvi3pZhKWtx5PzTNRz3yuZuPFi9Ja?= =?us-ascii?Q?brmaJ1Cl58btzVA0LQWAhudP2ugvgH1dggZgDFuSXSSTxCDnLY/gx1M/+ujT?= =?us-ascii?Q?o5Ag5IABQkWq9K+HOD1pvpF9o2VJ3lsQ5waUruOSkYOCDLXiEfHTEO87ld05?= =?us-ascii?Q?k3XpArPEryC9h62/VIYS4KlClexib8TXch320zuPOStIyWXbabaZW+a+FWKm?= =?us-ascii?Q?EnDvp8sn3ehGYAS8UYVeZKwz06sqjjpuPLl3hPAxodL7fdhcOoBTAhA7ZcUP?= =?us-ascii?Q?/CVFRK0gg01C0SzstGkZApfDFiuUZshZuTYF+5L0q3NgXjUUQbBXahyrGJCF?= =?us-ascii?Q?6Vqy+iT/Sf2mbIhT5xaTGaLjOmizNmOcqjJdVg6NxEUzwpHvnEKoK+5bd48b?= =?us-ascii?Q?AXUtScCAdW+eE46QcU2IunffV/GnXftg8SdybOTJD7Cxu2cS79TxgQiXSnEr?= =?us-ascii?Q?w0Q3KZMTWmhQv9gHuu4qiyColSdj/05QKR0tJkN/7DoY7tBZQxZossf3Fl7k?= =?us-ascii?Q?LHlmT1ttEngIE/2/NnxeF1PMCL8p0W9jHop1r5+i?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB6775.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7d4de287-d08d-4a0a-af1e-08dc4f019fea X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Mar 2024 08:32:37.5921 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VELxtVk1hzLBM090R3fQiFRqdEDGcEYlDwUht8FRLbKJccPms93WZhXlYUOS1EaEtPtFPNaabSVOi3/kJitwtQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6171 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Wu, Jingjing > Sent: Friday, March 22, 2024 11:47 PM > To: dev@dpdk.org > Cc: Wu, Jingjing ; jerinj@marvell.com; > pbhagavatula@marvell.com; Yan, Zhirun > Subject: [PATCH v2] graph: fix head move when graph walk in mcore dispatc= h >=20 > Head move happens before the core id check, which will cause the last sou= rce > node be executed even core id is not correct. This patch changes head che= ck to > less than 1 instead of 0 to fix this issue. >=20 > Fixes: 35dfd9b9fd85 ("graph: introduce graph walk by cross-core dispatch"= ) >=20 > Signed-off-by: Jingjing Wu > --- > lib/graph/rte_graph_model_mcore_dispatch.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/lib/graph/rte_graph_model_mcore_dispatch.h > b/lib/graph/rte_graph_model_mcore_dispatch.h > index 75ec388cad..1cc75b7ac4 100644 > --- a/lib/graph/rte_graph_model_mcore_dispatch.h > +++ b/lib/graph/rte_graph_model_mcore_dispatch.h > @@ -100,9 +100,8 @@ rte_graph_walk_mcore_dispatch(struct rte_graph > *graph) > node =3D (struct rte_node *)RTE_PTR_ADD(graph, > cir_start[(int32_t)head++]); >=20 > /* skip the src nodes which not bind with current worker */ > - if ((int32_t)head < 0 && node->dispatch.lcore_id !=3D graph- > >dispatch.lcore_id) > + if ((int32_t)head < 1 && node->dispatch.lcore_id !=3D > +graph->dispatch.lcore_id) > continue; > - No need for this line. > /* Schedule the node until all task/objs are done */ > if (node->dispatch.lcore_id !=3D RTE_MAX_LCORE && > graph->dispatch.lcore_id !=3D node->dispatch.lcore_id && > -- > 2.34.1 With small change, Acked-by: Zhirun Yan