From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A4F0F43CFA; Wed, 20 Mar 2024 04:33:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 452FB40298; Wed, 20 Mar 2024 04:33:23 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by mails.dpdk.org (Postfix) with ESMTP id 206D140271; Wed, 20 Mar 2024 04:33:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1710905601; x=1742441601; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=9rfWPf7Sd+yUuSgEZ+5gZm/Ntr0Y2tsGQtrzdltGF5o=; b=l/odFDigLr6H1c2c9BWpZRgbUVlA2kg6X2DhsT7FSYMHxPDqN+3laqnq Gi6TyoNdAMN4ZdSlDZQ3vBPlNQXS3lo1XZpPCndcUo0uWq51l/MRGQsBc uJzBQoXiIoGiZ2Gwd+09bqbC2xkiPyyDd2jWruJf5sisEbJarhoEilgFm XNR8SH+I8Vh/cdhdFRsFQFwwSGkvNA+ULPUqEhhq/VW25C7JtryIRhuz+ jOGgiKExny4Vf+eca7l3520xQ8NvwaxERadOToETCmbl6PTrMmST/P4HE toAPJm6qxA9hPJH2uDaCTwdcecmfhe75jhV68ycelqr8/iMtIw+WMPksp w==; X-IronPort-AV: E=McAfee;i="6600,9927,11018"; a="23271524" X-IronPort-AV: E=Sophos;i="6.07,138,1708416000"; d="scan'208";a="23271524" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Mar 2024 20:33:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,138,1708416000"; d="scan'208";a="14674759" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orviesa008.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 19 Mar 2024 20:33:15 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 19 Mar 2024 20:33:14 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 19 Mar 2024 20:33:14 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 19 Mar 2024 20:33:14 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 19 Mar 2024 20:33:14 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GmHq2LI1sxsNMsxX/Tg1CCNppfLg4ewqoy2Mv9LuDIdanKqPXBvE43qkfkvAnwbtU92n7G+xFJy2HG1c+YHJzos+qeeLSfr4HwIP65FV1JPg86eXgjgp+bdDxuhzY1dCrPiVda908cA500qRPUUvxCcisGUXcsBk4nFcD54Os2M6vY8d9ZHH4Dx2pvW3XiqyhReFDdqF+HRg5ENRyB79Ny6rQouHiSwopc7FHrfKGH1OvK1R8avVv0qq6y0CFucMSESRco8JoPw6w1epyx29U7DzHhz8FeWeRxWfUoQJuXZGW8MEUKFbKwVz8MD/foCQO4yAiP5ATrw0/xnaNHbJDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PDjj3SvtDYCd7XQQJFxTOr2+B4EbKVmHLuE407wqn9o=; b=azNeF2hjqU6kHmHD4drc+SJo5wSQMNfXMisjSJ9lPbO4W/bX+PXZULeobowStlIkaclCJLrlbzQA67w0wqfgPmSgFnQGYgoKTCYKu18sfK2cwnXQfTxEU+LKEgf14vITaUiWIGDK3ah1DEN7aJcrKeaYRrngkdqQzJhfJzV6suT4KowM4te1eUk1FWvPmKYJLXo7GOreI9zrMapr8pUC816zm/inWP7+ZLFc2Mv3UE+f0WCvAvCRsPCZmQ7aiXByPYxw7vrwSGWg544z4XgQ4CACKtFRINxmnjSPOsCI99OyhQ+NMfZMjFgo4RkmUKW9EbEqy/diacBY3UCTXB8RwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN7PR11MB6775.namprd11.prod.outlook.com (2603:10b6:806:264::21) by SJ0PR11MB5940.namprd11.prod.outlook.com (2603:10b6:a03:42f::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.11; Wed, 20 Mar 2024 03:33:12 +0000 Received: from SN7PR11MB6775.namprd11.prod.outlook.com ([fe80::802b:12f4:f230:a430]) by SN7PR11MB6775.namprd11.prod.outlook.com ([fe80::802b:12f4:f230:a430%6]) with mapi id 15.20.7409.010; Wed, 20 Mar 2024 03:33:12 +0000 From: "Yan, Zhirun" To: "Wu, Jingjing" , "dev@dpdk.org" CC: "jerinj@marvell.com" , "pbhagavatula@marvell.com" , "stable@dpdk.org" Subject: RE: [PATCH] graph: fix head move when graph walk in mcore dispatch Thread-Topic: [PATCH] graph: fix head move when graph walk in mcore dispatch Thread-Index: AQHaecXhBCsfELcr0kOLVZV3+3zA97E/94GQ Date: Wed, 20 Mar 2024 03:33:12 +0000 Message-ID: References: <20240319141454.3275543-1-jingjing.wu@intel.com> In-Reply-To: <20240319141454.3275543-1-jingjing.wu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN7PR11MB6775:EE_|SJ0PR11MB5940:EE_ x-ms-office365-filtering-correlation-id: e8c3760a-0f52-4770-4750-08dc488e78b1 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0B+rxyilC6K06xT8Xte3q5RylP2tR9bt4YbNBob81uGaeeAWCbaTeAaM0sVoHu7FIQ/EqWFszkA0Qs5tBYraxOE7WFy5V7kF4sTJGDx9OuylyZE0JbITHtPovIhs7H5c0aR/JU5xfAWY2hkhPu5PzzJLXHMn9xU5CdydHbR/tZtotlw+A0cMd7s/oCc/acRzflzlZ7m7MnR3TX+FfGJHCznoUtTjMX7xbQR0CMuE+0AS5ajbNekmPhpRCLg2n6Qs6x6HDolj4MZP5Tm204whVJcZhqFFsgPN65D4WeDXOVH8HzyXqwtamcprH9fVn5ADOt29KsDSvECDj3pI9rpSDUnooga66mpR3x+3cpo8IaH4gVB897FB1RJvG9VL7GKSvC9Gsq/dD8YIw6UVRxdXvgQ0zzqtcUxcMJQ45qmo63gixa0yipJ0VOlRuAD5kpNwu3B7MdjfQCMO6c3CyGfytOJ2QHuWp7uv3nZKdnzgQ5OsV5qHMyLAgLT//eOP0Q1cKbW+R4argnXxEhFLnX76UFD9hrkhJVZhTSR72GZiomnSKR0428axDlbiCdRFIv+x5HAIULr6U9LxYJsE679alw7LLtzVyCLTfJRRt/O861DSI77vlZYwsw8yQzNYAZdob6PQMyqOQ7qf4+Vs3Fp8c8mwiQh6qzemoYmqBsU74fCpCWDoLcrHM5r0lhYYfZL8aDBydCkr+xcBiimlfhupyq/jG1py3LT4PlrzehN8UR8= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN7PR11MB6775.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(366007)(376005)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?mGkhNrQo+v5rP7LvniTlCbqd/wBpGM8MJACIhQnXunZ47O1IAViFwpCoK4Ru?= =?us-ascii?Q?4NxNX5dxvVGUROOPEVysFQx2bQjfWwFznYllpxKCuGpx4dWIghj9cv8YbREE?= =?us-ascii?Q?mi1/K1g43jugk6AsQscZQcpAUst0zZcjH+5NGXUhr8tkrscHlB2d7EkAvZMZ?= =?us-ascii?Q?U9gEBbU1HQnQzWF0U6rsc3lz9P2QX8Gy3eBlzyxpFdQfEwxJWRAuXOA6ScYj?= =?us-ascii?Q?vwlwioz+jxqJyFRqAJNzxab3IUYpW0rmKQRHkkjA5GHw7PB623bbJJVwsZZN?= =?us-ascii?Q?7brnPfkFS54MnrkJY+Zzw6jOR8yjMMwWJDEubEjfbYrjDnkMaDqyMHfUh0cG?= =?us-ascii?Q?+Jl9Stbeo556a8AEknf3oqUCNw1xs42V33rk8xFt0JJDQ8ftRYrl0ytZmAK4?= =?us-ascii?Q?vjDPM1WmQvuXy0P4SCorbnEMkSRtPN2tf6c35e1B8klqR1iTNQzYZeDpQ/Sr?= =?us-ascii?Q?fYBirxMXmQ59iMpMBVwV35WwKHKPWaHtKJcFlrJXxC69NjHcaz8T0awU6RNL?= =?us-ascii?Q?Z8E6n1ZG99lrWBLEjAVwms3W6OWs3v2gIB6O868qW+PksjTHeAH9xrjWkI8Z?= =?us-ascii?Q?Je27XDyq4WKahFIXwRsU3ol7BB3VoZVMzvz7uE1alnjY2R2BhuJLs2R3xRO3?= =?us-ascii?Q?L8qrDIYPs0jEC2494v72ePIVNqoBhNnCgViFcSY8qf8VZUJZ+OkBz25y/Enh?= =?us-ascii?Q?TQYLeUOIRzqEEWd/WFIZmaJKMgYHVrx5DbWIYNfCHsOFAxVkpTSQd021HiSW?= =?us-ascii?Q?P8oC7c9GHL3s1SAIZdJTbcVJgBcABgmUsrXw9QXatxBspOuZp8t/IBOUFIx/?= =?us-ascii?Q?7eIeAxT2d3/WlmQZBV3Z7dYWn2lNcCOKIfEOQ4hi21X3B3XV9VKwEsXNEXl4?= =?us-ascii?Q?idX9d6r9HE6qsy0NJt++Goc+bumh4ZEP/WZjTGUtfHrp3wzjIKgTUuzHP5Kx?= =?us-ascii?Q?GLXB4sJ7quN5X7Oa81aovB9knSg0rIISyZT6vl8g6KZ+zg0pnMHYkN6uIqsI?= =?us-ascii?Q?kha45U375bnzUX6CJHGh1tkkoKjrm5hLVHPDiSj4Hfv4YARjgs1YRCdQHt6B?= =?us-ascii?Q?N44YmVXvJ7YAKH7Eh3O8MQiRi6h0MN1ahE6u5ZsdIRr3zN3sxHlGFSbQwpKG?= =?us-ascii?Q?5MFwnN567/eYlRWZUGxOdNxaRRAOycHlffYos4lzaSsLG2DV9rQEuw/QhVpA?= =?us-ascii?Q?prBaQLc7E721dWKZIVYtVwo3oMShiXVgcMz4yPFYjt9JTLHA+ktEOj2GM5fQ?= =?us-ascii?Q?37DHOQLVgEoOgzF7P6Trd1rfR8Sdc9ot49Uhp3JIuqZtZ/MmjfKOlr5MGe+P?= =?us-ascii?Q?jgY+jbTVO4rrv72mg9dkuyWsHknCIrfk0DnMUgC6zaMeiKT/vDBRRGPhpmBX?= =?us-ascii?Q?qtwUIJcT6gXnL6Q8UyoG7RE4dhfQ6nLhnzfpINEnBhTT9zt73fOgPBR7MOqR?= =?us-ascii?Q?JcvtD+qtEkDyW8cmF5CStNbhUkoIopC1f535RDGj3rf8IpqgeaDkBTYxpUjU?= =?us-ascii?Q?vUV5Xoofi9unrNoPT76sJ+wO5dAG/RJzEY/SszJo45VKkW01eMPX9V+rLlwH?= =?us-ascii?Q?lWz3+j7pCcGhEQXZB7r2aeJYYZxAAFQ1Mb4nX692?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB6775.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e8c3760a-0f52-4770-4750-08dc488e78b1 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Mar 2024 03:33:12.6915 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lHAv8DQn4rvaDqTWTbmcHORsTBky8MBfBJCadt/pZ/oCJRd9u/tNU2/Azp9cqqnUujPtGAwHrj8GQxZJnCqLYQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5940 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Wu, Jingjing > Sent: Tuesday, March 19, 2024 10:15 PM > To: dev@dpdk.org > Cc: Wu, Jingjing ; jerinj@marvell.com; > pbhagavatula@marvell.com; Yan, Zhirun ; > stable@dpdk.org > Subject: [PATCH] graph: fix head move when graph walk in mcore dispatch >=20 > Head move should happen after the core id check, otherwise source node wi= ll be > missed. >=20 > Fixes: 35dfd9b9fd85 ("graph: introduce graph walk by cross-core dispatch"= ) > Cc: stable@dpdk.org >=20 > Signed-off-by: Jingjing Wu > --- > lib/graph/rte_graph_model_mcore_dispatch.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/lib/graph/rte_graph_model_mcore_dispatch.h > b/lib/graph/rte_graph_model_mcore_dispatch.h > index 75ec388cad..b96469296e 100644 > --- a/lib/graph/rte_graph_model_mcore_dispatch.h > +++ b/lib/graph/rte_graph_model_mcore_dispatch.h > @@ -97,12 +97,12 @@ rte_graph_walk_mcore_dispatch(struct rte_graph > *graph) > __rte_graph_mcore_dispatch_sched_wq_process(graph); >=20 > while (likely(head !=3D graph->tail)) { > - node =3D (struct rte_node *)RTE_PTR_ADD(graph, > cir_start[(int32_t)head++]); > + node =3D (struct rte_node *)RTE_PTR_ADD(graph, > +cir_start[(int32_t)head]); >=20 > /* skip the src nodes which not bind with current worker */ > if ((int32_t)head < 0 && node->dispatch.lcore_id !=3D graph- > >dispatch.lcore_id) > continue; > - > + head++; If current src node not bind with current core, It will go into infinite lo= op. This line would have no chance to run. > /* Schedule the node until all task/objs are done */ > if (node->dispatch.lcore_id !=3D RTE_MAX_LCORE && > graph->dispatch.lcore_id !=3D node->dispatch.lcore_id && > -- > 2.34.1