From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4229943CEE; Wed, 20 Mar 2024 09:43:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F06F9402A2; Wed, 20 Mar 2024 09:42:59 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by mails.dpdk.org (Postfix) with ESMTP id 1637640298; Wed, 20 Mar 2024 09:42:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1710924179; x=1742460179; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=qYN3/xELM/Eo1HT5x+T7DN4jvc1daJIpIYPVq1wMafw=; b=keu6OF4ti4OEYiaqe9VklVn+VFoNLp/oz0ax5XRNWtGTUzyEV/LhFWbA 01Si9WHMRD4oz5yXwB9zuO8r2r+M/lhMzD/swP5cukfSQLllYmrrGLZrH QhFOxGrQc4jqmanhJXJNkDPxk3mwiN4nFHwqCgzpxQfpvAFxAUFOIVGOG g8MLfBwjOCFUFDyxqf+4oelXxpgE6f2bJoOMS4OL6H/4dxhS6/hnIwRqX Pr2P5L97xW5PMVZtglBSH4QQTlO6VbV06+ux+xbUPi/ApBca1kxLIftRY cFiBMRD4vQIIApAAsMFOfX7SIWF0k8J963pPNfOLXkQ263XStwcq2oK2u g==; X-IronPort-AV: E=McAfee;i="6600,9927,11018"; a="5714481" X-IronPort-AV: E=Sophos;i="6.07,139,1708416000"; d="scan'208";a="5714481" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Mar 2024 01:42:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,139,1708416000"; d="scan'208";a="13979397" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmviesa010.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 20 Mar 2024 01:42:56 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 20 Mar 2024 01:42:55 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 20 Mar 2024 01:42:54 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 20 Mar 2024 01:42:54 -0700 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 20 Mar 2024 01:42:54 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j4W5x1TNtJCiFld/1El/hEdOjSV8y+77R50we9i8MEW1kl0j7B55AvAsc0PQ7jKWEHBqwkrCcWK/LzswP4eGlmqN8Wbr3vCh6OHVuOsIn9meUrz1c1A/boQXbKWFIbxsTquuMuFyBAg2yEFrH8QVf5weaZJMS3Er/+Rmc6kgh5gbg08yqhJc7HixibignRcVlcuq/zlkVwC7SGsxdWEpD8aF2Wv+I745u3ZKr8x55RzCxPqOCxBonMdCnyQF48wIf6SgqGkoFbku9OxzhekxdrUtAtpmWsS2fJvrliZ1hQhEQsfsuZpbCiN+raJtB+WZ5Oz7pdn8iODpUI2TOn1ubg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wyJkmKkO4UB9BmdvmRTNCwlFdT/DSl7DTVEmWuIpz48=; b=F91zHJquH0cIJxKWZcBnUlDLgNM2QOjgt3NH65jZwd+RAI4TpiHZuT7jmjaqx4N0XBbwr+ukOrlJMLzsWZ15K0IxFJHkyOMcLB93j8dAtX0U4ILPEEQ5IOhjsGDoFIBi6VgfRR+AuB8iYauF28ypc0Rk6SuvcFY6tGxdvTrn8JY4OlBJFvQYa5WGy/cuVWt7XCq4yUAxaK5ooBqbxDL3dCZiEjJEiIysNMBouZGTa4M48IA0IUyi5+9HGlaGKD2+JuE3u+CO739Lz5246I+U42UQTrURbkuPXm4M/qjhZTbazVbeGReClnBRD+8nX2tlWn48KXFa1DvOmfC17E4McA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN7PR11MB6775.namprd11.prod.outlook.com (2603:10b6:806:264::21) by PH0PR11MB5927.namprd11.prod.outlook.com (2603:10b6:510:14e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.17; Wed, 20 Mar 2024 08:42:53 +0000 Received: from SN7PR11MB6775.namprd11.prod.outlook.com ([fe80::802b:12f4:f230:a430]) by SN7PR11MB6775.namprd11.prod.outlook.com ([fe80::802b:12f4:f230:a430%6]) with mapi id 15.20.7409.010; Wed, 20 Mar 2024 08:42:52 +0000 From: "Yan, Zhirun" To: "Wu, Jingjing" , "dev@dpdk.org" CC: "jerinj@marvell.com" , "pbhagavatula@marvell.com" , "stable@dpdk.org" Subject: RE: [PATCH] graph: fix head move when graph walk in mcore dispatch Thread-Topic: [PATCH] graph: fix head move when graph walk in mcore dispatch Thread-Index: AQHaecXhBCsfELcr0kOLVZV3+3zA97E/94GQgAAzvQCAACJAkA== Date: Wed, 20 Mar 2024 08:42:52 +0000 Message-ID: References: <20240319141454.3275543-1-jingjing.wu@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN7PR11MB6775:EE_|PH0PR11MB5927:EE_ x-ms-office365-filtering-correlation-id: 7e360b11-1cf7-4245-5e73-08dc48b9bb39 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fGD5Wl4ACI4LvQZtFpX3wFearpnmDzXJr4CX04vMYA8JGhU/uMt28LbxDqG0RY/m6NXrsJFOLI5LhgIVQ0g0A2qTmX4XbEvJ1nA1oCPRkZH++IcOimkhfjUim/OYRxbR055bKrEbSqPVbYZzMCfGmonLOVP9YcaiUrGkRVY2AACRJ7brHKtpfID8VWlYj0qdKvALwOB8y9Ho84qPk9fQ/2YN23SE4Mp0Yn3UNiR8LL6lW3qoyHfK0xAmFWFKRAHcxqGILMdC8v2joDWLXtv5a2QTvH/0gfVzvnHnls2o26daRAsv7ndGo6LWneADdCD6tMkMMq7/2ZeAEmnawTMC/MDp6NbvGvB86JAS2Dbp+y1MbzfSaeYvBYZPpuliobcMvOTFdTpMoj9oNMcYFF4asDYa3N2VudOS2xPRCFIXL4mh6EoO1O+TxxRQK4u1snKKyjgfdc7eG3/nkJ1Qqs2RF2PS3fOjv27wREpxk+8Fkj4BIBkkmBOVSdYhlVa5KkemiOsxIwk7ah/paZJfJvJrftTukvUSPkC+S3x3RiRjbsyYltauc9VrOSSiPZO+WzhHd4lRVDB733d3zJy7NAEtwkiMla34sF4kIFeYBuISNFSE48QcmaOj3+zzyYonpDrU40NQvqtfbeVcUTRBTEtlhtaThGBe0CVnCY9A8JgMxy9q80NYw7JM/7oJz8wKL16hPIo0IKy5ex+PNa0lH/3mHLJC4Z4xzJz6PUDBniKce7M= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN7PR11MB6775.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(366007)(376005)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?I0IAR10gzB4xH7DJZxxqQVpd2ARlM5yqmyk98naA0qxbOskvrR0xnVTM5DvV?= =?us-ascii?Q?QwmlWyvRgKPdU6RFiNQWIk6m6plPbriycR1j2Pz1kMf7A5YheJzsxZ1AFd6I?= =?us-ascii?Q?7m/lArzqmsAOaa2xRxX1R7xMWv2gmmq/E08D6WFSUIGToiVJSFuvN9Kt0Toy?= =?us-ascii?Q?c9KU6UOZV0a/Xztv+Se1iYzMZ2F9NSAlkNnMVzuQ/oRLd2mvsJ4YfxT4oIk3?= =?us-ascii?Q?Tavfaq4+RDy8CbuUAZS9a+uuaZ23FnDBAMLnoG5yxqyR6mtCy/dS31VqfL9V?= =?us-ascii?Q?prBehU2HU11JAyWu611Kp77J3iR2XvbZ9S73e56BFwdb+E8F6gz8Kms9wx75?= =?us-ascii?Q?xKNXxJl+YkfTSrR/gwmpAlACbbB/7zvYP9N6KeEAQqf2KDkbouSBTF/X7k2v?= =?us-ascii?Q?sT6LjzO0E6xiIYiU/WoO79ZGbH4W0DiTxHv3Z8CLUyyh+cTsxEndUphCHGbs?= =?us-ascii?Q?4n+WLl/SXIsnT4Wl8kkz9Cu+B2tea2oWvdtRGMN5f+FAssqHXKO65HPN7nzT?= =?us-ascii?Q?4Sv9zXymgMfKlAQxMsLAzd9lE4awvN+Z6wDk19sjyaoJNi2ONs1CtmH3pmoB?= =?us-ascii?Q?wlkubqW6McHTx5ePfQdSWUUH+jxjPLej8sb/NJ2HMciPmoPfMbJNZ0oeSiUd?= =?us-ascii?Q?7hgJUWMWS6xu2lVtzz3K/5YQ1ZMsnwaGl+IYwwZU+psH9KGgkzqLfQ6zwJKl?= =?us-ascii?Q?EZ2zsGXa3EoT0KbuILjcWjgJBj0gcL79l7SgfpVxRH0l5kZNBUeUkKNZX8vL?= =?us-ascii?Q?yW1zaly1s2+20dAKKMTpGLCUMdPP2V32zdvdB6adUPhCIjMSf9GZvykp7d0D?= =?us-ascii?Q?JvsrZvT54ioFOouAEkGtmX5xlpH8WWNGyfI/M/G68IpvnSX6Fe0koPFZ+4K9?= =?us-ascii?Q?mvBvF710C/glY455igB1gK5Bzy+QmC/IYaDGkG1rIvS19Mfk1GZGLgjfp+Ru?= =?us-ascii?Q?Yn5Q2LqSNhjQScZKFnJFComSe/TJ0uuwGhzi0JwohAeq0e0xCumkUtC5TmlT?= =?us-ascii?Q?NbGFOm0p6qshr+5YJf+43S/1ggKOsVX6R5GaIi0AGpLPmmZ33Ruyy7wGzgGN?= =?us-ascii?Q?amOM2k6HS4FMEufjNRR0wY9l5IZr67Mg1q3UAF4J2jZWQuPPVajCrt5CG7es?= =?us-ascii?Q?qP5IjvJzcNHZcJCq6KnSsV/6YZa5C6V2GSZUXLldVwNvtW6PA+Cok1iVLtG5?= =?us-ascii?Q?iTCuIH38kpuL6RiK1Diw+2DL45WeOu9FK4oJbYAj9gYGPuNV1hceVzrTdR+3?= =?us-ascii?Q?xG3phckeGoBFJKrlY53iXaD/ZSr5O2lgFbATsnM1RkVQ5RB5D/VXDG6XVAPr?= =?us-ascii?Q?Ddr1PPMHK5IIYTy5eEM6MMilBFnuSkNDrX3JNYSEs+fbLROYNxw7geKNbrb0?= =?us-ascii?Q?A64BsWW8QKOMcfMeCbrhIrCp5meRVFWFjec5Xs5g0czMQkjoxKUmbZstfxbz?= =?us-ascii?Q?1RexSDBuMHi/32CPbA55O8m+bAUpICSjri0JfnwGFL2MbxH9EYDWsfoQx09P?= =?us-ascii?Q?OEjEFNxn6h1Mwy4rd1k2GpEsqcz0pYSMMAqoQN8DXxWMshRnXjELitCPAsXd?= =?us-ascii?Q?p229cX1T/zFDLjrGcrvBiB/AjNXxOGAxQp0h5/Xr?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB6775.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7e360b11-1cf7-4245-5e73-08dc48b9bb39 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Mar 2024 08:42:52.6624 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FWgWwok8R5GhgTgwoPXLYTDYh60fBXIQIcF/WrLk3E1vLJhC3x+pz4PY6v2fj/9Y90wvHBm2czwCiDcvOyAjbg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5927 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Wu, Jingjing > Sent: Wednesday, March 20, 2024 2:25 PM > To: Yan, Zhirun ; dev@dpdk.org > Cc: jerinj@marvell.com; pbhagavatula@marvell.com; stable@dpdk.org > Subject: RE: [PATCH] graph: fix head move when graph walk in mcore dispat= ch >=20 >=20 > > > /* skip the src nodes which not bind with current worker */ > > > if ((int32_t)head < 0 && node->dispatch.lcore_id !=3D graph- > > > >dispatch.lcore_id) > > > continue; > > > - > > > + head++; > > If current src node not bind with current core, It will go into infinit= e loop. > > This line would have no chance to run. >=20 > Seems reasonable, it might be OK to change "head<0" to "head <1" the cond= ition > check? No. "head<0" means it is src node.=20 All src node would put before head =3D 0. "Head<1" is confused. You could find the details of graph reel under rte_graph_walk_rtc() in lib/= graph/rte_graph_model_rtc.h I guess if there are some src node missed, it may be caused by wrong config= , for example, the missed src node not pin to a lcore. Use rte_graph_model_mcore_dispatch_node_lcore_affinity_set() to pin the src= node first.