From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B07AE42CF6; Mon, 19 Jun 2023 08:17:18 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3F6B8410D7; Mon, 19 Jun 2023 08:17:18 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id A398D410D3 for ; Mon, 19 Jun 2023 08:17:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687155436; x=1718691436; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=nqeQp06qqmPmdwXOTvef6a//T4PtaKqwEE0ZfzjetXY=; b=aLGJZjFveD70tu6XrNUFMV1z1TzcXF+9kvF5nDlDadSwCBADXQozMz74 Iophl6Bc4XqJvyagU+HNG5XcGdTgeGB8yOrPjUVm7qTevdlgJgJ6JczJU iqfchYP8rmKFUtxDukF3XhtYkirTFYu3z0yysJRcY4bRkNM68x1nJvBeb f9uKB1mKOUVKH73YCsFKl9wczACb0XFku44KZ6iyOq7SqixjXrnsrroyF W6XOh9J89eEfWB3fQKgTVkZi81XMVx8Gnh5czb9C/A2HSB7RQ7ZO7sOsr So6zKoQ7X9NR9i7cdQh9O1qD87++7WRPzA6RuG6c8vk2uaakoofqPiOLZ w==; X-IronPort-AV: E=McAfee;i="6600,9927,10745"; a="362089207" X-IronPort-AV: E=Sophos;i="6.00,254,1681196400"; d="scan'208";a="362089207" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jun 2023 23:17:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10745"; a="858099407" X-IronPort-AV: E=Sophos;i="6.00,254,1681196400"; d="scan'208";a="858099407" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga001.fm.intel.com with ESMTP; 18 Jun 2023 23:17:14 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Sun, 18 Jun 2023 23:17:13 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Sun, 18 Jun 2023 23:17:13 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.174) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Sun, 18 Jun 2023 23:17:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EXgGqo1HjJfaG1Q6h+R3TUy9jLY5XeJ3RUIcZ3lmMydfBRtccY4kcc54bgmF9MetaUeoCX7eWgmF3lhQZe/a9qqzXWFHUPU4nOctxkh8+XEiJWXsJ87dNIt8aGL8/fY8RUSbV6YGZlss6fRVaY4yfc6m+Xr5JlakmBAEjVQFnPitmDps56S1bg6TeokBJEC1ifBK+qAuuCjDw0zV0XVvTFS9+WGmZmd2jwxXMU5X7xoxB9id9NFVj+F0mf4BSq9SWoypQS7UEZbQM3NVEEsz0lLIQC5ewTzVeH6lpjNuv7oV4uEmq3r5SNMomjO8LMepL+2FM1qNG1HpAWpsb2ITJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0/P26LpAMfw5mawpYeoR4Q2lvBj8/7f4yHJjQty8vbw=; b=Y/U72s6CiNFp6qyc4215mMMQUPoEbIneK8zZf9IhUcnrjSEk0YpO/z3od+sXvladcivCKimsvwuE16qQP6L9pTZfgylDK5GsrrCiigilkRR8i4pUzT31niyuOWiUHtB5LyZzO5/F48WbodnKzv5kONVXTSEk/5EaDCLn1dKmtChNbB16IuefA3ttlpn8Gcb6ygCljoqYWnNIOhFrYYeZWuIhpj2apXdeyFQbaUnN5+5C8QhBgyUn2qoirh9jg9kHZzSvRGO8wl3ChXDbJHmN2AT1TE+6zHN1o3iGCAVkgPk0DiJK217NcSp3lQOoT/WHfJc49zw3KaHlp4p3bXJDjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN7PR11MB7019.namprd11.prod.outlook.com (2603:10b6:806:2ae::22) by DS0PR11MB7192.namprd11.prod.outlook.com (2603:10b6:8:13a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.35; Mon, 19 Jun 2023 06:17:10 +0000 Received: from SN7PR11MB7019.namprd11.prod.outlook.com ([fe80::2d39:426d:f529:6088]) by SN7PR11MB7019.namprd11.prod.outlook.com ([fe80::2d39:426d:f529:6088%4]) with mapi id 15.20.6500.036; Mon, 19 Jun 2023 06:17:10 +0000 From: "Jiang, Cheng1" To: Anoob Joseph CC: "dev@dpdk.org" , "Hu, Jiayu" , "Ding, Xuan" , "thomas@monjalon.net" , "Richardson, Bruce" , "mb@smartsharesystems.com" , "Xia, Chenbo" , "Amit Prakash Shukla" , "Ma, WenwuX" , "Wang, YuanX" , "He, Xingguang" Subject: RE: [EXT] [PATCH v6] app/dma-perf: introduce dma-perf application Thread-Topic: [EXT] [PATCH v6] app/dma-perf: introduce dma-perf application Thread-Index: AQHZnbUBtaI3/jfMaEW1JJ15Pu3zk6+LVxgAgAAWYWCAACJpgIAAUDhQgAAl9gCAALJX8IAARL0AgAAjGnCAABPJgIAAEfkAgABGx1CAAoQacIABkKQAgAAKJzA= Date: Mon, 19 Jun 2023 06:17:09 +0000 Message-ID: References: <20230420072215.19069-1-cheng1.jiang@intel.com> <20230613043140.18101-1-cheng1.jiang@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN7PR11MB7019:EE_|DS0PR11MB7192:EE_ x-ms-office365-filtering-correlation-id: 216df996-ae15-4c5e-bc25-08db708cd08b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cZ3FfjcPVBL/Ygkg9lLEhi5JaDbmjEhTEBTpSd/mVOrnJGm+t9XTAR2m5vGikfQHSePq393VlNWh08zMuezKzqgVrj+4kVItRoSHFfsjfCUMhyL6UpdOkxtqzWuC09Z/tMAJnn0AvkFvB+GDXuoX1RbNlaL+D5m/TTCE9gHNvP7Wn5HvRx8ygTkdndHSwpQOwlXjiTm9VwkWRmdDf+fW0088G3XxOpNcmouHnM/w+w9ARZYhIm2saes/+Ldh31/5H/D/5vP0VmFscBsbsdWHRMmvarABbwqn0z4CkSHiawbUsjQH4oq2LAYFArv2NhI4zGKp+hU708ylZuDdHP35Z6I2AoBp3KUNf4DjABCZplA/Z8jdr9yeP+8xjB+PcBpg8/2jUBUIhwpqxGd/vPjZH7s/6U0J3rR2hpPRt8hqEHzpjeIMlP+nbDjZmBPnbBvyou+3aKDO2ls65hxieo6XGGO33Efk+5vBulaSA4LsxfOfojtJJAsMWbtAI6GKCs9z8PGK28Bd4/izLByUiWivgwAg2hCeEdbFmYp3pbUplInzL3UR9CL4Q9mS6IrBm+4KAFvxZ72vAw/pMJ1MdkvJGQa5ztyO1dQbeTbNim6uAcM= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN7PR11MB7019.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(376002)(346002)(396003)(136003)(366004)(39860400002)(451199021)(71200400001)(38070700005)(478600001)(107886003)(53546011)(6506007)(7696005)(5660300002)(52536014)(86362001)(2906002)(33656002)(55016003)(54906003)(8936002)(8676002)(41300700001)(66556008)(66476007)(6916009)(64756008)(66946007)(76116006)(66446008)(316002)(38100700002)(122000001)(83380400001)(82960400001)(4326008)(9686003)(186003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3bqOytER31eIJfn7e6Sv57KBmzGpAifPe3VvSfQqUfUS3FRW3gNq2z0nNprG?= =?us-ascii?Q?+X3suQwOgYr2+m4R6IRzg9WFbPcHVSXCX+ujGMyosYUsb6QN7b9I9E3bU+Zz?= =?us-ascii?Q?S8cSoSy2oyHx27CEnjzwWukHnbDvIPPvGYn9DPZ5YEjylaNLPoEeiw4Kn9jH?= =?us-ascii?Q?e8/9HWEbRUw3EY9RvMoL+XWUbqe9hdsfZ4tz/sFlvE6sAQm32MJHr5wZudFs?= =?us-ascii?Q?4DWQn+HkI6DwTpb3fE9b5G99Kj/tMso0yM3oupYva5jbbAELlZqL+KOtrckx?= =?us-ascii?Q?7jUpKAtIGkyZMuEm7C0bRGbH+bngfFF00F/eBMVh7Nwv0Ij/j79ZaFvNWkGv?= =?us-ascii?Q?NCg7Nz43pGpv7Vkmxwxo9xw/26otgOe/9iHkb5q832RgehNyijpCUhhXQ/oW?= =?us-ascii?Q?6itvI/pWFFjFrvEFFkvxpiUlY0yFq4TP6TAWTBlT/8LHdUTIONz3DFIppa0m?= =?us-ascii?Q?6g96QRVKSnDKMpj4a2zfP0om6occ2x8Muhe3OmfgmYTNtslk2sfzGoJ/UDyX?= =?us-ascii?Q?aa2dc/21OnswvaegeKWr0DYIXkPuLVoelZOXLcMrje/CDTUIEgjIJSTJzRWf?= =?us-ascii?Q?l00ouCXWY4R+Kwy/wow1h+WAVeRCTGsM77cdS7EFTsExJVHJqJE3M3+oANmU?= =?us-ascii?Q?HcQqNuhZ42t6c0L41jX5OQGPNe9v7Ucjt1NCUQTl4oR9EJENTHH+bvQl6xkG?= =?us-ascii?Q?ItMaRUXN0NPewc7wZ8LiuvltypuTz09txQHLsbayB9Cs8PFm8gTmxgxZc+Qb?= =?us-ascii?Q?3VSZ3FBf0Hr5C24WWNbL1ofZGen412irsOL4LyQ6LiIs1Gn/2tmqshet4tlc?= =?us-ascii?Q?65NIHIUtM8Wq3MXz/0FWbqK1ac817Nw592RMVaCxs4krg4lWdwI9fK/WxLuN?= =?us-ascii?Q?bBgHHi+PpHGJETTokvt9thq+SP3Av6cbbxfn62QHolf4NL0r1CEMJCrKcd83?= =?us-ascii?Q?Oz9wkRWNu4ekTaPtHqP96AVipRTh9IC2NnFutgHeBLrwTaMJGLSpZTwntKOa?= =?us-ascii?Q?C5fhU7JiBtHK9Kde8OexXNSXNMRr+yhsQEutOqnzLkjAoDYpXqMk91PIebtn?= =?us-ascii?Q?rZJcpJ89SZZpWA6ASYE1GGY4Yu1gMJBPpb6Gi46jqLP0NLuYmNUsxMtvn8fC?= =?us-ascii?Q?Adj0dGObPaEJ9i7JqUzr2Z/A3eeAeRAHMJ0gBlRjOeBtjUVAWsIqIwtMmUBP?= =?us-ascii?Q?72zmLKDA0yDYfegIQt2N8oUnd2wkDQxgnZ+nJ7iw6y3PsbmR9/saGKUrW51I?= =?us-ascii?Q?ImsHTIr2xPux3WbTVuNBCqmx6d3APOvURjr9Oc5BhJinDqJe/6Sluo9FMGar?= =?us-ascii?Q?w93S7nLhDAo9wJpeo/BugW2Dzs2/1hCSTW2/ZgRJMYLMSvw4OnJCn1E9URiN?= =?us-ascii?Q?5UzSx8D7lBEuUiCgW6KSqW1ab6aqUgrIbrRXFeEhq4a0b49B9Qo+8zPxdm0J?= =?us-ascii?Q?gvLQbIf0NrkHEWRPOhYry9Iq1C/uhGet2+PIRYSNJwFDJFSvu0KNUhFSi26i?= =?us-ascii?Q?GvkrPpJUpCgr8wz8VamVS6CcGtuHSt+JZuOFIYmkn+UQLoa7j9I/bQVXZSg9?= =?us-ascii?Q?ZE+bQdGawaaD3nP1pvQ=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB7019.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 216df996-ae15-4c5e-bc25-08db708cd08b X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jun 2023 06:17:09.9031 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Nf++rRHA59s5vU9guER7mK+oZ5NXccHEngVPnKRTc65xF4ek9p6+C2BRZ2XezVQIoxFlTTrR98JIs9YbjghrLQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7192 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Anoob, Replies are inline. Thanks, Cheng > -----Original Message----- > From: Anoob Joseph > Sent: Monday, June 19, 2023 1:26 PM > To: Jiang, Cheng1 > Cc: dev@dpdk.org; Hu, Jiayu ; Ding, Xuan > ; thomas@monjalon.net; Richardson, Bruce > ; mb@smartsharesystems.com; Xia, Chenbo > ; Amit Prakash Shukla > ; Ma, WenwuX ; > Wang, YuanX ; He, Xingguang > > Subject: RE: [EXT] [PATCH v6] app/dma-perf: introduce dma-perf applicatio= n >=20 > Hi Cheng, >=20 > Please see inline. >=20 > Thanks, > Anoob >=20 > > -----Original Message----- > > From: Jiang, Cheng1 > > Sent: Sunday, June 18, 2023 11:05 AM > > To: Anoob Joseph > > Cc: dev@dpdk.org; Hu, Jiayu ; Ding, Xuan > > ; thomas@monjalon.net; Richardson, Bruce > > ; mb@smartsharesystems.com; Xia, Chenbo > > ; Amit Prakash Shukla > > ; Ma, WenwuX ; > Wang, > > YuanX ; He, Xingguang > > Subject: RE: [EXT] [PATCH v6] app/dma-perf: introduce dma-perf > > application > > > > Hi Anoob, > > > > I've looked into the memory footprint issue, and I didn't find any. > > So could you please help to share the config file you are using? Maybe > > it can help me to accelerate the debug process. >=20 > [Anoob] We had to increase the hugepages to get the test running. > Otherwise simple memory allocations were failing. Some of structs have > redundant fields which can be easily addressed. >=20 > For example please check below members in struct lcore_params, 1. > scenario_id 2. lcore_id 3. dma_name 4. worker_id 5. test_secs >=20 > Also, some of the parameters in the above struct is const for a thread (l= ike > buf_size, kick_batch etc). So I was thinking may be it is better to split > lcore_params into two portions and have only the dynamic part as volatile= . > But that is something we can take up later. I leave that to your judgemen= t. >=20 [Cheng] OK, I'll take a look and try to make some improvements. Thanks for = your advice. > > > > Thanks a lot, > > Cheng > > > > > -----Original Message----- > > > From: Jiang, Cheng1 > > > Sent: Friday, June 16, 2023 11:16 PM > > > To: Anoob Joseph > > > Cc: dev@dpdk.org; Hu, Jiayu ; Ding, Xuan > > > ; thomas@monjalon.net; Richardson, Bruce > > > ; mb@smartsharesystems.com; Xia, > Chenbo > > > ; Amit Prakash Shukla > > > ; Ma, WenwuX ; > > Wang, > > > YuanX ; He, Xingguang > > > > > Subject: RE: [EXT] [PATCH v6] app/dma-perf: introduce dma-perf > > > application > > > > > > Hi Anoob, > > > > > > Replies are inline. > > > > > > Thanks, > > > Cheng > > > > > > > -----Original Message----- > > > > From: Anoob Joseph > > > > Sent: Friday, June 16, 2023 6:53 PM > > > > To: Jiang, Cheng1 > > > > Cc: dev@dpdk.org; Hu, Jiayu ; Ding, Xuan > > > > ; thomas@monjalon.net; Richardson, Bruce > > > > ; mb@smartsharesystems.com; Xia, > > Chenbo > > > > ; Amit Prakash Shukla > > > > ; Ma, WenwuX ; > > > Wang, > > > > YuanX ; He, Xingguang > > > > > > Subject: RE: [EXT] [PATCH v6] app/dma-perf: introduce dma-perf > > > > application > > > > > > > > Hi Cheng, > > > > > > > > I think there is a bug in EAL parsing. Please check the below diff > > > > and see if we should do something similar. > > > > > > > > diff --git a/app/test-dma-perf/main.c b/app/test-dma-perf/main.c > > > > index > > > > d65655b87b..7fcaa5acf6 100644 > > > > --- a/app/test-dma-perf/main.c > > > > +++ b/app/test-dma-perf/main.c > > > > @@ -432,7 +432,7 @@ append_eal_args(int argc, char **argv, const > > > > char *eal_args, char **new_argv) > > > > i++; > > > > continue; > > > > } > > > > - strlcpy(new_argv[new_argc], argv[i], > > sizeof(new_argv[new_argc])); > > > > + strlcpy(new_argv[new_argc], argv[i], > > > > + MAX_EAL_PARAM_LEN); > > > > new_argc++; > > > > } > > > > > > > > Thanks, > > > > Anoob > > > > > > [Cheng] yes there is an issue in it. And I have the same fix. I'll > > > submit it later, thanks. > > > > > > > > > > > > -----Original Message----- > > > > > From: Anoob Joseph > > > > > Sent: Friday, June 16, 2023 3:19 PM > > > > > To: Jiang, Cheng1 > > > > > Cc: dev@dpdk.org; Hu, Jiayu ; Ding, Xuan > > > > > ; thomas@monjalon.net; Richardson, Bruce > > > > > ; mb@smartsharesystems.com; Xia, > > > Chenbo > > > > > ; Amit Prakash Shukla > > > > > ; Ma, WenwuX > > ; > > > > Wang, > > > > > YuanX ; He, Xingguang > > > > > > > > Subject: RE: [EXT] [PATCH v6] app/dma-perf: introduce dma-perf > > > > > application > > > > > > > > > > Hi Cheng, > > > > > > > > > > > [Cheng] sure, no problem. Feel free to contact me if you have > > > > > > any more questions. > > > > > > > > > > No further comments from my side. Can you submit next version? > > > > > > [Cheng] Glad to know. Yes, the next version is almost ready, I'll > > > submit it this weekend. > > > > > > > > > > > > > Top level, I think you may need to add a doc file for the new app= . > > > > > > [Cheng] sure, I was thinking about this, and I'll add a doc for this,= thanks. > > > > > > > > > > > > > Few issues that we are also checking in our end, 1. The app is > > > > > having significant memory footprint. Need to see where we can > > improve. > > > > > 2. EAL args passing doesn't seem to be working. Are you able to > > > > > enable specific devices by making using of '-a' arg? > > > > > > [Cheng] I'll take a look at the significant memory footprint issue > > > later, > > thanks. > > > As for the eal args process, yes there is an issue, Dengdui's > > > comments also mentioned it, and I have fixed it in the v7 patch. > > > > > > > > > > > > > Thanks, > > > > > Anoob