From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D6C6E42CD6; Fri, 16 Jun 2023 17:15:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6988D40E0F; Fri, 16 Jun 2023 17:15:37 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 4C51640DDB for ; Fri, 16 Jun 2023 17:15:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686928535; x=1718464535; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=NkUEw4M2au+uNv7S3fPhel1+PM3LJKuPcVtc93RL38A=; b=ZPwlHQQ4voWT6OgBuM148v4iF3tS41EoaCUwZDC9gB9PIjPyns/Dv1Fa Qw9REREecFLjLLMkyjesZX5YAH01M4QxJOvpYtrBvKnoXBJAYrpiGbcqq 3iBNgJld0U5u0De3lG9KSpTyC5Qg+1iAJ9T2haXIGXRKHCOUvvMjyYIgy rE58hN2fjPFPggvLhGBorb1/l3QOTwrHv8keKXEx9Ctr8aP4f5SE2xz5T pkN8HO9G5CNp8cSl7x0AWj/owq+ymh4ydlPKD0V2hFI9vJrNrNYoxQFeP VmmkF5YyGyVrRfn6Z22j3Gx4gBghcBuqv+cbpS5q5uVs9cVBBfQnK3qI7 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10742"; a="343972914" X-IronPort-AV: E=Sophos;i="6.00,247,1681196400"; d="scan'208";a="343972914" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jun 2023 08:15:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10742"; a="690278758" X-IronPort-AV: E=Sophos;i="6.00,247,1681196400"; d="scan'208";a="690278758" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga006.jf.intel.com with ESMTP; 16 Jun 2023 08:15:33 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Fri, 16 Jun 2023 08:15:33 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Fri, 16 Jun 2023 08:15:33 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Fri, 16 Jun 2023 08:15:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kdNHZEo37heeoJMx5ncT0nN/qz/94KCYEm7L1x2KZr6sH4CzzmP8bYzI8eZakAzkeit+pr6yUbVzbhGx/255OdPEcp7tuEMkLUU76jPWrwkvgOTC1Y+Ozo0D+ROwKfmFF4m07onc0wHgm9Schi92QsQQg8nVDRaQGrJA/sp2GjZtHL40fA2GaOjN0G0B71G9iTtVlSJmFauXrFYoVdkL04d07bG0rBsSjjjXpYWGKiNdzkKi/HBTwVsKVQ3ns1mdTFkg+V3+vWWM+97BTfq4KnXpu7rAnnUlNN7LNyNqzFP345O8ZYpa0AqfpWLcbW+lIIjw25VHXPxOq4WNu6I0ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hodIO41Na/bhkIvBi7GNeSkHHaNak2GihpOBxBB7KYU=; b=nltpgdPULnvINRBsXRv9TiW98bz+WIXoNeq0Z3JPaOEanzSzS+Pz1pkYkiuXI5u/BxLbtiyCxyNBbrdizrNlhBm4URFlu0Cu6OVOEZFK039RoTrlKSX+Hx40RYpvGND0UL5gPwMoyyuj/vBdsbdgiq1GCViN1P26Lk4c08HiyRqFKl06vnUCZT3EYoSpvBE4MnmmyHD9zYaapq67oN1nUzWrHyTY/IR4WSAdxOyBXgF6Lc6CXaMbWYTDdPR+883Ox2K7AuaFg/H9Q+peXolLBEZijBoo9HZq9MeWRpzSlL43rOPbZT7PpBD/0VBS8Y70hDIQYorPpIOKcbVxrRt5xQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN7PR11MB7019.namprd11.prod.outlook.com (2603:10b6:806:2ae::22) by SA1PR11MB5924.namprd11.prod.outlook.com (2603:10b6:806:23b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.29; Fri, 16 Jun 2023 15:15:31 +0000 Received: from SN7PR11MB7019.namprd11.prod.outlook.com ([fe80::2d39:426d:f529:6088]) by SN7PR11MB7019.namprd11.prod.outlook.com ([fe80::2d39:426d:f529:6088%4]) with mapi id 15.20.6477.037; Fri, 16 Jun 2023 15:15:31 +0000 From: "Jiang, Cheng1" To: Anoob Joseph CC: "dev@dpdk.org" , "Hu, Jiayu" , "Ding, Xuan" , "thomas@monjalon.net" , "Richardson, Bruce" , "mb@smartsharesystems.com" , "Xia, Chenbo" , "Amit Prakash Shukla" , "Ma, WenwuX" , "Wang, YuanX" , "He, Xingguang" Subject: RE: [EXT] [PATCH v6] app/dma-perf: introduce dma-perf application Thread-Topic: [EXT] [PATCH v6] app/dma-perf: introduce dma-perf application Thread-Index: AQHZnbUBtaI3/jfMaEW1JJ15Pu3zk6+LVxgAgAAWYWCAACJpgIAAUDhQgAAl9gCAALJX8IAARL0AgAAjGnCAABPJgIAAEfkAgABGx1A= Date: Fri, 16 Jun 2023 15:15:30 +0000 Message-ID: References: <20230420072215.19069-1-cheng1.jiang@intel.com> <20230613043140.18101-1-cheng1.jiang@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN7PR11MB7019:EE_|SA1PR11MB5924:EE_ x-ms-office365-filtering-correlation-id: 0a521f88-f1b2-4265-79c0-08db6e7c8639 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: m3hI1a9nU8Jq4/eKEDrZXj73JsB9Cnld9n5rW83qDUNjdKq1zIitoaQEJ6Jxd8z6J3YMQNn4CTHYLrjp2gks7XNKPhT5WMCpjRD+mNOBpQKRq9V9MCgZC9ch04VSzaE/5gsRNyw7252zQvL6ZQJYss7X0yJOg86M8OaEL6nH3NMGjmhHRnDbwp6eJj2weCUm/QGWh4iDw0NzWNGtl6EKc8PRYxZQ6Zlodg+P6TyAR4KS4eJthjp2LNW2PFSjK6S6uu46LIhtq5+8NG1xwIEmURsDPn3AoAcwJr+Rm+Lw7xvkLpw9MNwfeJazGffDqUb4F4h7pLBxc+Yexe0Wi/Or+F3n29KZvojAUSInGf1lfmNZ3e5hGnHUxue0b2oxhoY1+bp2gDZW3Pvfq2RyrYyvUuF5xa/G+jYxI7gUtkmB13CyhyTcd5jZ064O4qwjS8ezIfCuDqEEjhfoXzhdMKif+AVL0imsRwJvCzGOYzFhg/5hufUDa+0/Df9QFZg4lJElpmdIcDcbzis+403DvOvuuPm6+ux5PnwOiBX06RpKSFBGAH2CDK54/g7bzqoHF/zLQs6r0HpVSiOoPSifzfgEXjdKgKQhLL72XkEq7XIRFDdZOplWeqPecte6jzwo6VZo x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN7PR11MB7019.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(376002)(366004)(346002)(136003)(39860400002)(396003)(451199021)(478600001)(107886003)(55016003)(86362001)(38070700005)(7696005)(71200400001)(316002)(41300700001)(122000001)(38100700002)(83380400001)(66556008)(76116006)(66946007)(66476007)(4326008)(6916009)(64756008)(66446008)(5660300002)(8676002)(8936002)(52536014)(33656002)(82960400001)(2906002)(53546011)(186003)(54906003)(9686003)(26005)(6506007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?mdD525mxN6+hbZb3QdityOBnYMGYXPfqZNicEBjJEdV/C0KS81PIxCOVkgNu?= =?us-ascii?Q?pR01OIdP2x8jkw/zc/3fh5WAJIMS69qIUCQutgYQCC2pAsiMHrbuSTGnWr/P?= =?us-ascii?Q?F70Voi516+t4We+SSvqqOl1BseZcvD/ziCuxuIniFVZP3SIGr0uhTTlICJHI?= =?us-ascii?Q?XTkcsuNE56yOrOb4WxGKe4LKjfAwFg+LtHDeFntr3o5YayygUeASSAe5XgRr?= =?us-ascii?Q?WClWHur84j6FV9lSjPRJ01/aTShEs+24A9ERKeZeZVB79DuXv6jxq1DYe/Z+?= =?us-ascii?Q?sX1DV2xt4BkusIL33DukfT8bqgWcUrFNOhmz3JFgO/+YqDOqLZEvCesKbsqC?= =?us-ascii?Q?Jdq8xux+r4o+G63VkTp7iMQNmGJzICneuc9g/BxeycV3HEzQaBGMOc62TkU4?= =?us-ascii?Q?r7RJe5WfyK/8eeppsw0Zg8S8o/XwkKS4w+XSFHKSGzE/m8cseeZaO9/As6kY?= =?us-ascii?Q?qBc/ZglUyBiD0chiYXfXFl8TYZIS95HgzUb+4O2tyHQWJJB4OwJYxpn1UXF/?= =?us-ascii?Q?VvlrN/eLd1V9rfmvrf4Rq1KqdH3J943tb1os8gPgle1xLvehpvMmdhYplJPU?= =?us-ascii?Q?TpFRwOEbKHjV+IQAk7LMKU41IBYBBmXjRtD3wArWpHve2/zV0k1jGNdjHJ4X?= =?us-ascii?Q?jPT65Y0XInO32wfx/sKis/UnnuVeUPimtNQ54csZg57UrHlhpIZxi9+mjVkn?= =?us-ascii?Q?Vml1vYGJhtQveBOknj0AUg4MCisccfj2ePl2zYoOq1Yr9nuoFxy0qHxs7Fvg?= =?us-ascii?Q?AD/VpU1Kn1aDN1xkPDQX755tZDBuOG8X8uUkXHIeuPdP5J52B/g3l/+Q3t3q?= =?us-ascii?Q?2oUQyvrJezbzYXDr41sjmTuSXbLqAXOeNxlLPUFnp4+esHf7EfLyJKtE2tUH?= =?us-ascii?Q?GsnaTf7A0ioQoNasOkqgGEhld7BzBCpzVA66n0kg7T87d/pAcf/n+uQt3JT0?= =?us-ascii?Q?y9c5l2hnajDHb4mczdZ8y+xHdFWcIcO0Aq5gtkbCAiNtmDucdaU+PlXwyGz9?= =?us-ascii?Q?77Wudy7Q30+t5tjlx3LJtx02sey9zAMDh3fbdj6REX4jgsxLE/y7XBp6SA1d?= =?us-ascii?Q?Ym9KJTpGhQ4ggnldkBL2/JkaXt0Aer0Q6ugYv78EizdBq6UG/GMdY5iKxfr+?= =?us-ascii?Q?cklJ7nz17ovxdrOz/F311TCDciCtwN3HyD/IWEWC4dfedeSLCT3ki2aG8MF8?= =?us-ascii?Q?gIP56PEKht3H72k/dtWNYyvaqiYKvjcdkH2zIlElEqGLYXqFN18JMiajuC1T?= =?us-ascii?Q?kkPMFWryyswBaM74ZfUzRw0zBUU3qrzAv7WYe/0uhcjGC4CXUY5xSgfIQ8SW?= =?us-ascii?Q?c3VoK2AeZUzCqp++sCuAz6/kptUtUnHgLdmLhXODvWEZbX3CZ0hW6yCgyNZc?= =?us-ascii?Q?Xl1AeYXkyK0pVruk9EA4L/JQ3PFpf9JHty6N1tAsXapI8yu4zb+B4chcL2Qt?= =?us-ascii?Q?QLLdDe3mRNtwF5I++C7Kp1J/Cl4F8DaRJ8wbw4z9uP0q2pE3GoUCEX/ZiaPX?= =?us-ascii?Q?6oRDHeImAl6c0hRTJu38hDsx6L8B0n/Jo+XoykkDww9EicNtP6TPckxVrQ0Q?= =?us-ascii?Q?GCAC9xUR1x7yRyy2K19GOdSqLyqFDU+h+cgZgrlY?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB7019.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0a521f88-f1b2-4265-79c0-08db6e7c8639 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jun 2023 15:15:30.9521 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: u/loiM4mSU6buJZn6X06hcYE+FFPcecRpZsViFQqat36IcutHa9syuEgoGwM/5h70KL+8tQih12R7m4HflhKqQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB5924 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Anoob, Replies are inline. Thanks, Cheng > -----Original Message----- > From: Anoob Joseph > Sent: Friday, June 16, 2023 6:53 PM > To: Jiang, Cheng1 > Cc: dev@dpdk.org; Hu, Jiayu ; Ding, Xuan > ; thomas@monjalon.net; Richardson, Bruce > ; mb@smartsharesystems.com; Xia, Chenbo > ; Amit Prakash Shukla > ; Ma, WenwuX ; > Wang, YuanX ; He, Xingguang > > Subject: RE: [EXT] [PATCH v6] app/dma-perf: introduce dma-perf applicatio= n >=20 > Hi Cheng, >=20 > I think there is a bug in EAL parsing. Please check the below diff and se= e if we > should do something similar. >=20 > diff --git a/app/test-dma-perf/main.c b/app/test-dma-perf/main.c index > d65655b87b..7fcaa5acf6 100644 > --- a/app/test-dma-perf/main.c > +++ b/app/test-dma-perf/main.c > @@ -432,7 +432,7 @@ append_eal_args(int argc, char **argv, const char > *eal_args, char **new_argv) > i++; > continue; > } > - strlcpy(new_argv[new_argc], argv[i], sizeof(new_argv[new_= argc])); > + strlcpy(new_argv[new_argc], argv[i], MAX_EAL_PARAM_LEN); > new_argc++; > } >=20 > Thanks, > Anoob [Cheng] yes there is an issue in it. And I have the same fix. I'll submit i= t later, thanks. >=20 > > -----Original Message----- > > From: Anoob Joseph > > Sent: Friday, June 16, 2023 3:19 PM > > To: Jiang, Cheng1 > > Cc: dev@dpdk.org; Hu, Jiayu ; Ding, Xuan > > ; thomas@monjalon.net; Richardson, Bruce > > ; mb@smartsharesystems.com; Xia, Chenbo > > ; Amit Prakash Shukla > > ; Ma, WenwuX ; > Wang, > > YuanX ; He, Xingguang > > Subject: RE: [EXT] [PATCH v6] app/dma-perf: introduce dma-perf > > application > > > > Hi Cheng, > > > > > [Cheng] sure, no problem. Feel free to contact me if you have any > > > more questions. > > > > No further comments from my side. Can you submit next version? [Cheng] Glad to know. Yes, the next version is almost ready, I'll submit it= this weekend. > > > > Top level, I think you may need to add a doc file for the new app. [Cheng] sure, I was thinking about this, and I'll add a doc for this, thank= s. > > > > Few issues that we are also checking in our end, 1. The app is having > > significant memory footprint. Need to see where we can improve. > > 2. EAL args passing doesn't seem to be working. Are you able to enable > > specific devices by making using of '-a' arg? [Cheng] I'll take a look at the significant memory footprint issue later, t= hanks. As for the eal args process, yes there is an issue, Dengdui's commen= ts also mentioned it, and I have fixed it in the v7 patch. > > > > Thanks, > > Anoob