From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CE13343781; Mon, 25 Dec 2023 03:48:49 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 57A34402C6; Mon, 25 Dec 2023 03:48:49 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id A757440297 for ; Mon, 25 Dec 2023 03:48:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1703472526; x=1735008526; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=kkeLIp8zpVpgQ8XhalCPl0d30U0AAS/cFDV07ZAxv1s=; b=elKpnQJ1vOZaH7S6F3zAKY0XnrtO+ttczmMVHYZPHzB7Ka3vVGW4VSum uJ72nPuW8KR8CRCVH5I0HPqFY/lff0Djy5SdFgzjOhSzbXgU++0mE3Auy 0pD+LIf+2rBsC8kPNBQaQP0TCIIbHvrwRsqnkOjSeywO95cPKYXKaaG2I Oj1iZ6VUODZHuRD6dT1wC0Flin6A5vIG347phtDi2vsuPEGv8RHg5kpS+ pSmgzSk9G8Bh5r+sfKFLk4P9EiBeCEqsvrMqi0UcQJ+x0oX4iSf3pQcQg Muva8eeyYXcFdgpE2yviTmHw3YT603/AitSOB+tHp88rhXUez6bpBNP6N g==; X-IronPort-AV: E=McAfee;i="6600,9927,10934"; a="376403655" X-IronPort-AV: E=Sophos;i="6.04,302,1695711600"; d="scan'208";a="376403655" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Dec 2023 18:48:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10934"; a="848116772" X-IronPort-AV: E=Sophos;i="6.04,302,1695711600"; d="scan'208";a="848116772" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga004.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 24 Dec 2023 18:48:45 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sun, 24 Dec 2023 18:48:44 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sun, 24 Dec 2023 18:48:44 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Sun, 24 Dec 2023 18:48:44 -0800 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.41) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Sun, 24 Dec 2023 18:48:44 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ceco5UnI5axkA+Ia+L9jU0qXlGpuYP8vNII4UcinRNoTfUyJzBEGhSqvIH9gmko6TmQOevfmh+DYFERmvCM6Vr9hk9kLkNkUtklDEPl9AtXKSZpEXzQSyjag258nBXLCXicmjN3URhJcvgoK3l1tCy3nDBsRAv8xh1MPnSuMkSRX6S449x/eybNYoNCMHVdW0CbGLjWW6gwvAEN1XMnR4Dty7nazRNKuzjSAt2Dv1b4wmpOTB0SRumZSTss3f3a3XtdrkrTucxABqSFSHNsjPPpfFqTgt75pZTSzqRuy5/f12HcMtFfGZbM+ltTD9HGAFORP3X8NrmFfjEMidwSlBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k1UnFETrJ/oR9LthS3LzB8WkittfpIMhQYt8mAhqtjU=; b=RNvSy6zC+dW8zw7oRM7kUuIPjjXXioTFrxPxypc4uoaUvBFAn3KA2DjI3oSnlteQzoUpVhnh5l+nzGZGJ0XuYLTDDxiQ9jybXjbhvzMm2oWT0Vc2NXCjlJW0zF+eoVYmXzW0kDibVcsFXlOl7dnQBaiaujI8g4tChJHOXGAtxWlALeupLAjYrAneyJIpzsj1ulqqJSeYVljq6NRP+sYRM0HAOpopkvIV4R0nlD1tUk3MgSNp/CKIxmfiRinqkrCcs09eRrVI8kDwWAxX9qb2xLL5qtXUW/kcVD45kn2EhBRrb1LWeEvEd9Hue54W94Q4n6hGmTdThjrsokXanBgwvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN7PR11MB7139.namprd11.prod.outlook.com (2603:10b6:806:2a2::14) by IA1PR11MB6122.namprd11.prod.outlook.com (2603:10b6:208:3ee::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.26; Mon, 25 Dec 2023 02:48:41 +0000 Received: from SN7PR11MB7139.namprd11.prod.outlook.com ([fe80::5216:6b58:10e7:9875]) by SN7PR11MB7139.namprd11.prod.outlook.com ([fe80::5216:6b58:10e7:9875%7]) with mapi id 15.20.7113.026; Mon, 25 Dec 2023 02:48:41 +0000 From: "Ye, MingjinX" To: "Zhang, Qi Z" , "dev@dpdk.org" CC: "Yang, Qiming" , "Wu, Jingjing" , "Xing, Beilei" Subject: RE: [PATCH v2] net/iavf: add diagnostic support in TX path Thread-Topic: [PATCH v2] net/iavf: add diagnostic support in TX path Thread-Index: AQHaNMYqoACLJXZ3ok61we2aJX2ZpbC1LPKAgAQIJfA= Date: Mon, 25 Dec 2023 02:48:41 +0000 Message-ID: References: <20231221101202.2815069-1-mingjinx.ye@intel.com> <20231222104458.3663930-1-mingjinx.ye@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN7PR11MB7139:EE_|IA1PR11MB6122:EE_ x-ms-office365-filtering-correlation-id: 3ff3f397-3683-4d07-a176-08dc04f40103 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: HCMwHGlza3/3++AfqID921iwxJoBTcfRDLvfuERo2cPGhhe7O1Q5sRK3URVRvOOAK+G+3zPYTx4AK5uEFH5lQHOygw5bhnnGetZShFue4buCOAw1Z2Mcfl7jJVfsNnhQr9Ry3dj0sH6UuRYKjhYh4HjyzYwzLCto81ioALMzgxCysOjVrhrDWhxjJ3aO+pOZFs8gkYXfGnbPuf/sUuLTp2Jvu7zCgC8hJSHoGKL6EqMKYVlL1Pi/FgoQj3IeDTHDhl5ANthVpb2BdBnF2kKo/jmhkFuOpRlC882c79gp3u+WseLfbKeCoirhzhP/W8XXn1WFxzsl/vQfo3n86coTsi+bL7qlZs1ipUt6LWyWmu2cMNdBeDj7HqSxcUg8DiiL6F4p5OLs/OC2YkQIUkO1WEneqaPs0WwBd4nK+Axpv9ANMwzGOlm8sdsN2yyo031Ivgfyb3wRl+T7WybHE7DdjGVYUq7984D+uzk5M62W5bAd8/s6pYy1jj7tgghjqpRNacBX8GPRCZaB84ENwslmKtOEb8u1p8SJJh8BGPBlSSk5QMrpjra4ehZDi1Iyd7+vLDl3V5GTKpkp4e6Cxl/FBbTEQGHPfgWlJmkpmiJF6he6geQtwSXBeG9LiE8/Ioi2 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN7PR11MB7139.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(136003)(366004)(376002)(39860400002)(396003)(230922051799003)(186009)(64100799003)(451199024)(1800799012)(33656002)(82960400001)(38100700002)(122000001)(41300700001)(83380400001)(38070700009)(55016003)(76116006)(66946007)(66556008)(66476007)(66446008)(64756008)(52536014)(316002)(110136005)(54906003)(4326008)(8936002)(8676002)(107886003)(2906002)(5660300002)(86362001)(9686003)(53546011)(7696005)(26005)(71200400001)(6506007)(478600001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-2022-jp?B?YW1RM2ROa1loYTh4V0l5dWczNkl2VFpwK1Q0NVZiV0dzcVhRaWppNlRS?= =?iso-2022-jp?B?WnVZT1RBVVRoL3lNVUowSFBmQXViTk9HdGVXTEkwRGFRR0pUK0FoZ082?= =?iso-2022-jp?B?VGtwVTdhQ0hzQUN6Z0s5b0xVNndRNXlnWVVQdjdCQkFsazRzK3dsMEFt?= =?iso-2022-jp?B?dHdjbE1QTmNLNzBDeTFGR1VGNUN0Z056TVNhblh1RnNRbVJhclNvaGFE?= =?iso-2022-jp?B?MEJaVGZObnVGaUlFcTNPYXBXRmpaMFdxUUM3ZnB1eWhFTGFGQ1gwMFgw?= =?iso-2022-jp?B?Z1NhU3pWQ0Zna2s3cURaWm9HQURMRFA4SFRPbDF3ZC9sZDJsZlNMWTNE?= =?iso-2022-jp?B?S0VUWmozQ0RDK0gvVE9WaGJNMkV5amdsZWlPOGlIN216Z0NjREE5ZUpH?= =?iso-2022-jp?B?STJUajV4M2UxWFVqdFhUWWdndzk4UENTSm5GdXlBT281YlVxZXhkTFdL?= =?iso-2022-jp?B?MlZrUlNoOVJhU0xjcDNlUTNFUHorSXJKS3pxNDByOHptemlLK0YwWnAv?= =?iso-2022-jp?B?NzlrY2w5VHhiUVVGR1pXeXh2Y0dhQk4yY2k5MU41M25uZHVYSFBqdWJV?= =?iso-2022-jp?B?V0kzM2QrRUtWdklPTThFdGhsZGYzWitDRjRBQmVxblpYSE9LV3F6NWFy?= =?iso-2022-jp?B?M0xOU2dMempSbWJmcEx4eUVOUE55OTNpK1ZPVDFvRFp4djBUVnhtU3My?= =?iso-2022-jp?B?V1Zyc3hOTElKWmJ2L280OEtqN3dkUU9QNGxtcDR2NEpOSzNKSlFYNnZ1?= =?iso-2022-jp?B?c0t2NzdSMmtqVklxck50dGcvRUdqZjhPTDdockJZYzlVbGlOWktWdlIr?= =?iso-2022-jp?B?cWpvTzZiZWViTitTNk5zODZ1aEZFZVNVQmlEUmkyS1ZmQmpwcXBDQnZH?= =?iso-2022-jp?B?bUxnU2wzUTVsR2VOblZ5YmFNdGxvbFFtY1ErK0ZUek5oUWdhS29JUlNm?= =?iso-2022-jp?B?bzIxaDk3cmpFZlZONjFBRFExb3NhNDRIUlNvVFppbWZrQTBmL29ISFc1?= =?iso-2022-jp?B?V2pKdUVHUmlBL1JwakVPa2lERmtkTDM0MWZibnNSV1dHMnRzbVY3bFhG?= =?iso-2022-jp?B?ZkNwRkpDZlRjVUk3NGEzWkQ5NHVvOGRvU0dTbHNwemxjbGNXNTF2RzBw?= =?iso-2022-jp?B?R2pyNUIyK3dlRjdLWjJPWE5yd29WZUdvOUtzZ2d2V2hPK1lLYlQyK1BL?= =?iso-2022-jp?B?Wkw5QktNdXJXZUh5Ymd2cDB4SE8vQXNYSnA3MUJFR1cycjNVNXRnSjJk?= =?iso-2022-jp?B?aWhLUmN5cUs5b0NKUitKaW5TVEJFN005R2VtS2ZjNmZ5S3lKY3hlNUhR?= =?iso-2022-jp?B?S3AwWmpaeWF5V2tYN2V0WGMrTk1iOVNJOW9aZmxUSHBOblpBNWR3UndX?= =?iso-2022-jp?B?U2FrdnVEQ1JqR24xWnRVd1RVZVpNQkRHTGVMZlppQVVCU1FVM3E4NGZ4?= =?iso-2022-jp?B?b2QxRW1LZU1STzE2UnBSTFVpMG1VTy93c3RmcTJPdzkyaVlodzBURVJW?= =?iso-2022-jp?B?QW91WFFGVTJkbUhLa25OZ3dldGxqR01TMFF5eXAwYk9xZlBHZVVyeGFj?= =?iso-2022-jp?B?dDF2RHhsa09RMXhqTkYzR1F5REtPeFB1MnhSaGpMMUxaVGZTMERCMFVv?= =?iso-2022-jp?B?SUZFUUNRRFFmMjBsdk9yU01VZytTMTNvaG83cTd1SkExNUhHNHd6WDda?= =?iso-2022-jp?B?MWFyNkVkOVE1WlA2RjU2TXh0WXZDblhURGFnYjlyeDZjdmJpeTBMMkN6?= =?iso-2022-jp?B?dEMxNy9rSTZhZTdFWGYrQTYwZlMxNHNwZUVaeWp1MmpYbzJDYlZxR3lF?= =?iso-2022-jp?B?eVMrQnNxMTNLQzRSa0k2MmRDWWxmR0taV2xQb0J1cUwwTTNoaHFWTC9v?= =?iso-2022-jp?B?cDVSQ1Z2SzRldDRjeWFxMVBOVlV4RGFIT0ZyL2dwekpHSUtaZnV3SWxm?= =?iso-2022-jp?B?N0ZCbC9EcHIrbjhKZVB2VGh3bW82bXZqTytmQnRkVFgyZUkyYmhEdlEw?= =?iso-2022-jp?B?TVhiSDVjSCtJaHc1czRvZGgzY3puOU40bFFQTTFLK0FoWlpjaVNvU0Fl?= =?iso-2022-jp?B?QnYwVnVTREFIbmR0N0xKR0V5OFJWWXk4M3RZbzRJQ3dqZkNxZ0RQZTI4?= =?iso-2022-jp?B?VXFoTTkyUWQ1ejN6UzA3c1lnWWtiL2tFTkhkUVhhZ2kvZERmbXY3RlBh?= =?iso-2022-jp?B?QW9QUlEyb0J6UzIyVWhYdStySE1uclQyRTYvS0Z1WVFZcjNEMDYvYklK?= =?iso-2022-jp?B?Tm82UDF2OE9FelJnc3UwRTgwdWhPaW5SNjZVYSt0amh4ZHdsZi80QTVI?= =?iso-2022-jp?B?QWprKw==?= Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB7139.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3ff3f397-3683-4d07-a176-08dc04f40103 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Dec 2023 02:48:41.4818 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GJSINQKPtQpFaCT2NhtdeuGV4Ot5Zx2NV2/hZlUT12BrCWoSmeN/Cj3ZDizxKQHsSjFUAewZl8eh/H9SKUUcyg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6122 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Zhang, Qi Z > Sent: 2023=1B$BG/=1B(B12=1B$B7n=1B(B22=1B$BF|=1B(B 19:38 > To: Ye, MingjinX ; dev@dpdk.org > Cc: Yang, Qiming ; Ye, MingjinX > ; Wu, Jingjing ; Xing, Beil= ei > > Subject: RE: [PATCH v2] net/iavf: add diagnostic support in TX path >=20 >=20 >=20 > > -----Original Message----- > > From: Mingjin Ye > > Sent: Friday, December 22, 2023 6:45 PM > > To: dev@dpdk.org > > Cc: Yang, Qiming ; Ye, MingjinX > > ; Wu, Jingjing ; Xing, > > Beilei > > Subject: [PATCH v2] net/iavf: add diagnostic support in TX path > > > > The only way to enable diagnostics for TX paths is to modify the > > application source code. Making it difficult to diagnose faults. > > > > In this patch, the devarg option "mbuf_check" is introduced and the > > parameters are configured to enable the corresponding diagnostics. > > > > supported cases: mbuf, size, segment, offload, strict. > > 1. mbuf: check for corrupted mbuf. > > 2. size: check min/max packet length according to hw spec. > > 3. segment: check number of mbuf segments not exceed hw limitation. > > 4. offload: check any unsupported offload flag. > > 5. strict: check protocol headers. > > > > parameter format: mbuf_check=3D[mbuf,,] > > eg: dpdk-testpmd -a 0000:81:01.0,mbuf_check=3D[mbuf,size] -- -i > > > > Signed-off-by: Mingjin Ye > > --- > > v2: Remove call chain. >=20 > ... >=20 > > > > +static struct iavf_pkt_burst iavf_rxtx_pkt_burst[RTE_MAX_ETHPORTS]; >=20 > Global array is not necessary, I assume we can get adapter with rxq->vsi- > >adapter. Multi-process support to solve the problems caused by ASLR.=20 >=20 > > + > > static inline void > > iavf_rxd_to_pkt_fields_by_comms_ovs(__rte_unused struct > iavf_rx_queue > > *rxq, > > struct rte_mbuf *mb, > > @@ -3394,34 +3396,34 @@ check_mbuf_len(struct offload_info *info, > > struct rte_mbuf *m) { > > if (m->ol_flags & RTE_MBUF_F_TX_TUNNEL_MASK) { > > if (info->outer_l2_len !=3D m->outer_l2_len) { > > - PMD_TX_LOG(ERR, "outer_l2_len error in mbuf. > > Original " > > - "length: %hu, calculated length: %u", m- > > >outer_l2_len, > > + PMD_DRV_LOG(ERR, "outer_l2_len error in mbuf. > > Original " > > + "length: %d, calculated length: %u", m- > > >outer_l2_len, > > info->outer_l2_len); > > return -1; > > } > > if (info->outer_l3_len !=3D m->outer_l3_len) { > > - PMD_TX_LOG(ERR, "outer_l3_len error in mbuf. > > Original " > > - "length: %hu,calculated length: %u", m- > > >outer_l3_len, > > + PMD_DRV_LOG(ERR, "outer_l3_len error in mbuf. > > Original " > > + "length: %d,calculated length: %u", m->outer_l3_len, > > info->outer_l3_len); > > return -1; > > } > > } > > > > if (info->l2_len !=3D m->l2_len) { > > - PMD_TX_LOG(ERR, "l2_len error in mbuf. Original " > > - "length: %hu, calculated length: %u", m->l2_len, > > + PMD_DRV_LOG(ERR, "l2_len error in mbuf. Original " > > + "length: %d, calculated length: %u", m->l2_len, > > info->l2_len); > > return -1; >=20 > Can you explain why need to change all the log type here?=20 PMD_TX_LOG requires the RTE_ETHDEV_DEBUG_TX macro to be configured and reco= mpiled to output the log.=20 Modifying PMD_DRV_LOG allows for quick debugging of operations without modi= fying or compiling code. > basically the > diagnose check is for Tx only , we don't need to touch existing Rx > implementation. it could be a separate patch if you think something need= to > be refactor. Restore RX Change. >=20