From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B3B3843676; Tue, 5 Dec 2023 11:32:57 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3692A402C8; Tue, 5 Dec 2023 11:32:57 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 50DD740275 for ; Tue, 5 Dec 2023 11:32:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701772375; x=1733308375; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=tc3z5VvqNsFFoi0XUSSprLab3xIqyx1ztswNy9W4Wu4=; b=TiVGA3hhznZLdEFsAFEtanxNbMo4/niDXTRFBkH1LQcTE42vzL+esoLZ ox219wpC3+S6vqSBmKn6zsJ04gxSPjg/lSVH5xi6oV0LLCfM8M+1iciDS CRxJowbk+nPqlTF0FLLJY41DxU6GRLYG3yAe7WoljMBiNdjjwzN8eyAhR vl9KQS6XtELUQkoikFGQEG/yrAcEEt/4G3u3aJipEF6y2X7XOzIvo9GR4 8N/6K+PtpjGk6g2kK96yFAu+9G4NlQMSMt29+NQQlGtiEBlVi2XK2Y1mb YxEek4F6shjqeCUfaYicaql6aqlsO9J+x+PhtbgJkd3XgIgK/+AZF55/S Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10914"; a="396670570" X-IronPort-AV: E=Sophos;i="6.04,251,1695711600"; d="scan'208";a="396670570" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Dec 2023 02:32:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10914"; a="747180458" X-IronPort-AV: E=Sophos;i="6.04,251,1695711600"; d="scan'208";a="747180458" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga006.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 05 Dec 2023 02:32:54 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 5 Dec 2023 02:32:53 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 5 Dec 2023 02:32:53 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 5 Dec 2023 02:32:53 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 5 Dec 2023 02:32:53 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QjPE2yPy+/GJnqWQqa/rClbFgyiVDiIAAxDygb//RFX/kTwQV4pf3Cl5cxeKoGM/l9I03m0QDFbfZQWAx7f+nnSkuHCOazCrWWATxucxgHtEpDlmzRouGC63x0+/qGnS+E3/GtIxQKE/9DdlJyMUP+YGOcARC9SDc0ULsSt8r64ryC2MIIhRvdTQ0ji+if/ilSjm9zkJiGAM/dKtkovJEcMQx5qkp8jQd/nNEThGrNcp7C5pAiraSyR/uH7vRpRmO4LP1ODUDA5jzobxb57sOizpqsgGPOiQPQItLnanVn/YsFvah72rKQeGBXQsDdRbE+YyiCnkvdm1FmokIg92XQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lLSjDE5raQ25N71yI322OKAVDKxpSAFo9/hPaSiDK2w=; b=EoC7NdHvsCFpFcWAwoEjlUePP5lzblubRXWuxaMvTDBbccFfKf755BIiC5zwDoG5uO5Rf5wk14Ynr/SkA6FaUbFMZodedosJf14eoAAElypXKmZQLkWm62dicNCH6OVklUD0YaRZLGvZj8ViyfAEvLk6eDBDzqb/v/+3vsLHbkUog2JmPM95EjGq9NIMc6FBDxmZUi2XBFuhTxOjv3fTdwwcAqowq8FEQQMkh1Ks0XbhD1R6f/Av55JTXld4mwJ+q4b2M93YcXZQ1HOo+m0YfHjc6Dmuw/BKweFQpyvYS9oDK78ow35VN22EqTh8aimxT5CTpna5YHwEVSKUNrnw/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN7PR11MB7139.namprd11.prod.outlook.com (2603:10b6:806:2a2::14) by DM4PR11MB5344.namprd11.prod.outlook.com (2603:10b6:5:393::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.34; Tue, 5 Dec 2023 10:32:51 +0000 Received: from SN7PR11MB7139.namprd11.prod.outlook.com ([fe80::5216:6b58:10e7:9875]) by SN7PR11MB7139.namprd11.prod.outlook.com ([fe80::5216:6b58:10e7:9875%7]) with mapi id 15.20.7025.022; Tue, 5 Dec 2023 10:32:51 +0000 From: "Ye, MingjinX" To: "Burakov, Anatoly" CC: "dev@dpdk.org" , "Daly, Lee" , "Yang, Qiming" , "Xu, HailinX" , "Su, Simei" , "Cui, KaixinX" Subject: RE: [PATCH] bus/vdev: fix devargs memory leak Thread-Topic: [PATCH] bus/vdev: fix devargs memory leak Thread-Index: AQHZ3KbeijggetUpAkiI6S6QGkb9G7AW99OAgASxV0CAYx7CUIAcFonQ Date: Tue, 5 Dec 2023 10:32:51 +0000 Message-ID: References: <20230901072409.741847-1-mingjinx.ye@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN7PR11MB7139:EE_|DM4PR11MB5344:EE_ x-ms-office365-filtering-correlation-id: 55de133c-152e-4d2c-1aa2-08dbf57d88b8 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: B9z5pnjchinfjH930BgQBqebKN2wH8RuKw/OX+EbEMK1hW4u3sngcgHrj/zQ77BXxZKCYh/BWoyaS/afg9MhEShlkvKo9EG1ZUtkPMe7VfBu7mN0Ma9NXtV8Ayy0sd2yBOz6XJV48IJ6/znPPfBRNgMYg8wHvKV0weittgW2U87ULeP6fD5YA3lWnaEGonawyugqkoXO5h6iZijh5tNMMllYg93D7q/pYELLdJlhrgMql8ts3y/EosXHQslX48lb0zOR/ll+8OvaOzFlJisq4Rzr6FlD5DWnFrTY4gfdxkMfvee8nTZjx60xamq3OirGZw+W7J42GvlQeZ3+8vN/RXhZO9Q1DT/RNXIVJ0404ITiZINpo+fXgU2xmSRmT2CQqFbjrWrlVQDDmXSHgCaDJoEInvHhwd/68idxKh8H4ZUktzURCkW7qo5t9UoHYt4F9fK6/ioT/J3RZvVf8Mj3Rd/T+g1BXT/54AFyLw4n9jmVaIElX50pf617tOjHQ/dZgE4olKA1KbT2Po5OuHu1GfqwQ42Gu6uSha82vz3yKhOK2GV4OAY2ahIfc2HfeVLELVvaFv2T4k5sAKczJrXHxjKGbkmQW0wjYoHAo1JjvO2giGS/tVBwtWVlO8hw5JE5 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN7PR11MB7139.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(39860400002)(346002)(376002)(396003)(366004)(230922051799003)(186009)(64100799003)(1800799012)(451199024)(2906002)(33656002)(316002)(66446008)(66556008)(6636002)(54906003)(64756008)(66476007)(38070700009)(76116006)(86362001)(66946007)(8676002)(52536014)(55016003)(41300700001)(4326008)(6862004)(8936002)(5660300002)(38100700002)(122000001)(82960400001)(83380400001)(478600001)(26005)(71200400001)(7696005)(107886003)(9686003)(53546011)(6506007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-2022-jp?B?UW0vbkJxSjNqNmJtUlRXa05BdUR1cTRkdG9LMFFjcE9qUkMwbXRyRFB6?= =?iso-2022-jp?B?Y01KdXhYajF1eFppdUdObkdFTSs2eTFJSlpIMVk3NkNSUW1SVEpNaEVI?= =?iso-2022-jp?B?RmpxZWh6YWMybFJ0ZWluVUdiYSswSkR5bkpXMkV6SXVGbUh0bktnbTY0?= =?iso-2022-jp?B?VXMyeENRKzBOVWY1b3V6WERoUHhoamphR09GYTNCR3NOU2xhc3ZmMFlF?= =?iso-2022-jp?B?b09DdEkxQ1BtblhuWlZjUnVQdWpzVEFDdWFuY1lwbXZWM0JMdEwwdlha?= =?iso-2022-jp?B?NWZuMVlTVlkwLzRMc2FkR1dtT2dWOFpKL1RHekxtZ05ucHBJcTNLN0Z1?= =?iso-2022-jp?B?ZkRXYllpQzVoZTBScnpGbWpjNEdCYmoxZ2doQVpBN3Y0Rmhia2NrS2Uw?= =?iso-2022-jp?B?R21hY2J5aVkrUFFBLzNmWVZCcVNSOXlJM2FpVVJ1RTcvM3hLcnl5bm1t?= =?iso-2022-jp?B?TE0yUXZqS0k2QVQ2c1g5V0IwcHdPVFZNMm1jZnkwWWkwQmowTS9lTWNZ?= =?iso-2022-jp?B?YUVlNjFVak5TNEpTRlZNTXNOL3NWZVFFaTNWbFo3K2QxdzMyV3hsVUtr?= =?iso-2022-jp?B?Mm4ybVFiL0x4SnlZSUJkU1lDNW5KcXJ6azJjR042NTV2cWszdWpwN200?= =?iso-2022-jp?B?WSthbGVSL09iUVd6M1cvc2tXSE5UMXcyTFN6TDA1NXFJSklrQmJVYmlw?= =?iso-2022-jp?B?L1kzVHRpeDhseVRIU1FtdVdGUzhpRUJiOXNzY0EvcmtrZERzODNIaHlz?= =?iso-2022-jp?B?bHdQVWhEMGZWM2hMWXhpS0tUdUlRNUtONFRLZllDVlJTaUtabjlJUjhp?= =?iso-2022-jp?B?ZWZ1MkN5NFFyVmJqbEJUU011dkR5YTVJNzU4WkpKcUZBZVViUWN4b2JP?= =?iso-2022-jp?B?c2E2OGRsbmxOUndiYk5tdUtRYk94WURMSWRoR0NlaGljdlFWaG1EaFJU?= =?iso-2022-jp?B?Nnl6U2VmK0h1aG8raUpDWEtod1owa1BOWTdHOXRidi9FS1U2Wno2TExl?= =?iso-2022-jp?B?Mlc5SmUrVFNlUHRDYXBaK1RpbTV4UVQ1MHNDc2U0dVFDSFIxVzVSM21s?= =?iso-2022-jp?B?RC82Z0kwSmdSS3YyQWozbnpDTjQrSVNBR2I2eDd6ZkwvMmtMelc5QUta?= =?iso-2022-jp?B?enNVeUNtZU1DYnE0djRrQUxTREJEZHJmQWsrNHAxOWxmRlBOS3NpTURx?= =?iso-2022-jp?B?elVVc2ovVTQwZmR2dEJKdEtFWjdIeWtBVkdKVXNObmZJcDBjd2ZKdDl6?= =?iso-2022-jp?B?QkFaWGYxcHN1RklaOUxlNXFHRU90QXlEakNRb2tNK0RGem9CT1Q2VVlm?= =?iso-2022-jp?B?b3VQRWQrVk11OTNqSlFDYkg4bmQxcHg4MGppTE9Cd0JveXVJb2hQWTdx?= =?iso-2022-jp?B?bjljUWovd1VhZUs1UGhHRXNoWWdQQnVCakNkam1TNDlKMTFpclNycTJF?= =?iso-2022-jp?B?cHdrSGNtbURWYkVnT0VlTWt4TmhObmwxTDFEVnJteEtIdnRSSHBocXBX?= =?iso-2022-jp?B?Ym5VbHpTcmk1ZnB4aW9LaGRhaTBoYzVjRVh1UjlSRlZ5SStraGhJZ1Ji?= =?iso-2022-jp?B?MzhDRGdmU3BSdVY4eTVsTlpHbjBKNDBMZEFhdnFMem1ZQkFEajlzZ2FM?= =?iso-2022-jp?B?cFJlbzNYenh4a1FGZXdxVWh4ei9KUEk5ZXFYVFpRRDlUbFliWUcycUdj?= =?iso-2022-jp?B?b0wvbEI0SXhFZnNZSUlKZU9xbGs2a0tmOFBFb0FKaVVSUnJpbm90L0kz?= =?iso-2022-jp?B?WEF2ZGVSa3ljdmNWK1l5OFdjQjluUmNXellVWkJCOGVYTVI5UlFMK1pZ?= =?iso-2022-jp?B?a1hMWFJZY2lKZm9GdGtYU3lQUGtaQ1pDYlQvUWhWcVRYZUZTcUVudDBp?= =?iso-2022-jp?B?bG1lS21Vek5tYnBjdnB3cVFPcDhjc2kvMXYrZ1BEUjRBc3dDSEVEL1V3?= =?iso-2022-jp?B?TmxyTm43YkV1UXRCOGFWUXczbFpzUVZSdGgxWG5tZDNtU3NTTVNtak5P?= =?iso-2022-jp?B?RDJNUnBEcnJza3VaTzFuV0Jwd0JLdE5kT3VNaVU5Y0VxRlBQNDkyM1Ez?= =?iso-2022-jp?B?SUhCR2tzSVlyS1JPSnpWTUg4RVFpVkpCRHRvamdyQ00wNFJGa2RYUlNL?= =?iso-2022-jp?B?ZVoxTms5ZzRvRUJJU2V4SHFyREhJbWtZVDNNdUdmRWlTa1FjMlZjOXlk?= =?iso-2022-jp?B?eFFHQjZqYlgxT1loRHcySEg0VGdiRmNWM0ZWeGMwQ3c0QnQvdG1iRDRt?= =?iso-2022-jp?B?SEZxU0xFUHJPbngzQUNBdzV0SEdud0l1cDBGSDFFZk9aVE04TGdUSHY1?= =?iso-2022-jp?B?ZWk3Qw==?= Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB7139.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 55de133c-152e-4d2c-1aa2-08dbf57d88b8 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Dec 2023 10:32:51.6029 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: f9Cpenyuz36DtylwY4vM0kmpLZhe5ALU+n+uCL55PGfLWZNk0apx3B1rXqSjIKIIA2KAbNnE/ByZ9AIEwdN5vw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5344 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Burakov, The patch has been sent for your review for quite some time. Can you please= help to take a look and give some feedback? Your prompt response will be = appreciated a lot and very helpful for our next step moving forward. -Mingjin > -----Original Message----- > From: Ye, MingjinX > Sent: 2023=1B$BG/=1B(B11=1B$B7n=1B(B17=1B$BF|=1B(B 18:29 > To: Ye, MingjinX ; Burakov, Anatoly > ; dev@dpdk.org > Cc: Yang, Qiming ; Zhou, YidingX > ; stable@dpdk.org; Ling, WeiX > > Subject: RE: [PATCH] bus/vdev: fix devargs memory leak >=20 > Hi Burakov, >=20 > can you please take a look at this patch. >=20 > Thanks, > Mingjin >=20 > > > -----Original Message----- > > > From: Ling, WeiX > > > Sent: Tuesday, September 12, 2023 5:08 PM > > > To: Ye, MingjinX ; dev@dpdk.org > > > Cc: Yang, Qiming ; Zhou, YidingX > > > ; Ye, MingjinX ; > > > stable@dpdk.org; Burakov, Anatoly > > > Subject: RE: [PATCH] bus/vdev: fix devargs memory leak > > > > > > > -----Original Message----- > > > > From: Mingjin Ye > > > > Sent: Friday, September 1, 2023 3:24 PM > > > > To: dev@dpdk.org > > > > Cc: Yang, Qiming ; Zhou, YidingX > > > > ; Ye, MingjinX ; > > > > stable@dpdk.org; Burakov, Anatoly > > > > Subject: [PATCH] bus/vdev: fix devargs memory leak > > > > > > > > When a device is created by a secondary process, an empty devargs > > > > is temporarily generated and bound to it. This causes the device > > > > to not be associated with the correct devargs, and the empty > > > > devargs are not released when the resource is freed. > > > > > > > > This patch fixes the issue by matching the devargs when inserting > > > > a device in secondary process. > > > > > > > > Fixes: dda987315ca2 ("vdev: make virtual bus use its device > > > > struct") > > > > Fixes: a16040453968 ("eal: extract vdev infra") > > > > Cc: stable@dpdk.org > > > > > > > > Signed-off-by: Mingjin Ye > > > > --- > > > > > > Tested-by: Wei Ling